<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175426</bug_id>
          
          <creation_ts>2017-08-10 06:59:51 -0700</creation_ts>
          <short_desc>REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie</short_desc>
          <delta_ts>2017-08-10 12:31:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>164205</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>annulen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cfleizach</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mario</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1337401</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 06:59:51 -0700</bug_when>
    <thetext>Since r220515: &lt;http://trac.webkit.org/changeset/220515&gt; the Debian bot (Jessie) is failing to build with this error:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/4385/steps/compile-webkit/logs/stdio

On Debian Jessie there is no libgeoclue-2 or libgeoclue-2-dev packages.

However there is a geoclue-2 package that provides the DBus interfaces and a pkg-config file:


# dpkg -L geoclue-2.0
/.
/usr
/usr/lib
/usr/lib/pkgconfig
/usr/lib/pkgconfig/geoclue-2.0.pc
/usr/lib/geoclue-2.0
/usr/lib/geoclue-2.0/geoclue
/usr/lib/geoclue-2.0/demos
/usr/lib/geoclue-2.0/demos/where-am-i
/usr/share
/usr/share/doc
/usr/share/doc/geoclue-2.0
/usr/share/doc/geoclue-2.0/changelog.Debian.gz
/usr/share/doc/geoclue-2.0/copyright
/usr/share/polkit-1
/usr/share/polkit-1/rules.d
/usr/share/polkit-1/rules.d/geoclue-2.0.rules
/usr/share/dbus-1
/usr/share/dbus-1/system-services
/usr/share/dbus-1/system-services/org.freedesktop.GeoClue2.service
/usr/share/dbus-1/interfaces
/usr/share/dbus-1/interfaces/org.freedesktop.GeoClue2.Agent.xml
/usr/share/dbus-1/interfaces/org.freedesktop.GeoClue2.xml
/usr/share/applications
/usr/share/applications/geoclue-where-am-i.desktop
/var
/var/lib
/var/lib/geoclue
/var/lib/polkit-1
/var/lib/polkit-1/localauthority
/var/lib/polkit-1/localauthority/10-vendor.d
/var/lib/polkit-1/localauthority/10-vendor.d/geoclue-2.0.pkla
/lib
/lib/systemd
/lib/systemd/system
/lib/systemd/system/geoclue.service
/etc
/etc/geoclue
/etc/geoclue/geoclue.conf
/etc/dbus-1
/etc/dbus-1/system.d
/etc/dbus-1/system.d/org.freedesktop.GeoClue2.conf
/etc/dbus-1/system.d/org.freedesktop.GeoClue2.Agent.conf


# apt-cache policy geoclue-2.0
geoclue-2.0:
  Installed: 2.1.10-2
  Candidate: 2.1.10-2
  Version table:
 *** 2.1.10-2 0
        500 http://ftp.fr.debian.org/debian/ jessie/main amd64 Packages
        100 /var/lib/dpkg/status


# cat /usr/lib/pkgconfig/geoclue-2.0.pc
prefix=/usr
exec_prefix=${prefix}
datarootdir=${prefix}/share
datadir=${datarootdir}

dbus_interface=${datadir}/dbus-1/interfaces/org.freedesktop.GeoClue2.xml
agent_dbus_interface=${datadir}/dbus-1/interfaces/org.freedesktop.GeoClue2.Agent.xml

Name: Geoclue
Description: The Geoinformation Service
Version: 2.1.10


This seems enough to build with ENABLE_GEOLOCATION, as I tested to build WebKit there with this patch http://sprunge.us/MPea and it built fine</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337403</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 07:10:18 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #0)
&gt; On Debian Jessie there is no libgeoclue-2 or libgeoclue-2-dev packages.
&gt; 
&gt; However there is a geoclue-2 package that provides the DBus interfaces and a
&gt; pkg-config file:

That seems like a packaging bug, since the pkg-config file should be in a -dev package. But where it is should not harm anything.

&gt; This seems enough to build with ENABLE_GEOLOCATION, as I tested to build
&gt; WebKit there with this patch http://sprunge.us/MPea and it built fine

The problem is the FindGeoclue2 find module seems to be broken. If the pkg-config file is installed (I presume it is?), then the find module needs to set GEOCLUE2_FOUND=1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337404</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 07:12:59 -0700</bug_when>
    <thetext>I found another issue with a different find module on Tuesday. FindWebP failed to find libwebp on my test system and printed an error, but I guess it must have set WEBP_FOUND=1 or something because the build proceeded even though it was REQUIRED. I don&apos;t understand or trust these find modules. There is a pkg-config module for CMake, which works by trusting pkg-config like all the other packages on your computer do, and is way simpler. We could delete our find modules and use that instead. Konstantin has some reason for not wanting to do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337405</commentid>
    <comment_count>3</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-08-10 07:32:20 -0700</bug_when>
    <thetext>WEBP_FOUND is properly set by the module here. However, REQUIRED doesn&apos;t result in fatal error</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337407</commentid>
    <comment_count>4</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-08-10 07:38:27 -0700</bug_when>
    <thetext>OTOH, having FATAL_ERROR in find_package() is not really user friendly: you need to run cmake over and over to find out all missing dependencies. FeatureSummary lists all missing dependencies at the end.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337408</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 07:38:49 -0700</bug_when>
    <thetext>We don&apos;t seem to be using any geoclue header, right?
&gt; &gt; This seems enough to build with ENABLE_GEOLOCATION, as I tested to build
&gt; &gt; WebKit there with this patch http://sprunge.us/MPea and it built fine
&gt; 
&gt; The problem is the FindGeoclue2 find module seems to be broken. If the
&gt; pkg-config file is installed (I presume it is?), then the find module needs
&gt; to set GEOCLUE2_FOUND=1.

The issue is with the name it tries to find.

It does: pkg_check_modules(GEOCLUE2 libgeoclue-2.0)

It should do: pkg_check_modules(GEOCLUE2 geoclue-2.0)


Because Jessie has a geoclue-2.0.pc file but not a libgeoclue-2.0.pc file.

This later one comes with the package libgeoclue-2-dev that is not available on Jessie.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337409</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 07:45:33 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #5) 
&gt; The issue is with the name it tries to find.
&gt; 
&gt; It does: pkg_check_modules(GEOCLUE2 libgeoclue-2.0)
&gt; 
&gt; It should do: pkg_check_modules(GEOCLUE2 geoclue-2.0)

I&apos;m not sure.

$ pkg-config --cflags --libs geoclue-2.0

$ pkg-config --cflags --libs libgeoclue-2.0
-I/usr/include/libgeoclue-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gio-unix-2.0/ -pthread -lgeoclue-2 -lgio-2.0 -lgobject-2.0 -lglib-2.0

So if we do not link to libgeoclue AND we don&apos;t need any of its headers, it&apos;s OK. I guess if you say the build succeeds, then that must be the case.

So we must be able to remove our use of GEOCLUE2_CFLAGS and GEOCLUE2_LIBS then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337410</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 07:46:59 -0700</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #4)
&gt; OTOH, having FATAL_ERROR in find_package() is not really user friendly: you
&gt; need to run cmake over and over to find out all missing dependencies.
&gt; FeatureSummary lists all missing dependencies at the end.

We should consider switching to that.

Are you saying that REQUIRED by *design* does not result in a fatal error, rather than some bug? Our options parsing has been broken for this entire time? If so, maybe it&apos;s time to make use of FeatureSummary like you suggest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337411</commentid>
    <comment_count>8</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 07:51:56 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #6)
&gt; (In reply to Carlos Alberto Lopez Perez from comment #5) 
&gt; &gt; The issue is with the name it tries to find.
&gt; &gt; 
&gt; &gt; It does: pkg_check_modules(GEOCLUE2 libgeoclue-2.0)
&gt; &gt; 
&gt; &gt; It should do: pkg_check_modules(GEOCLUE2 geoclue-2.0)
&gt; 
&gt; I&apos;m not sure.
&gt; 
&gt; $ pkg-config --cflags --libs geoclue-2.0
&gt; 
&gt; $ pkg-config --cflags --libs libgeoclue-2.0
&gt; -I/usr/include/libgeoclue-2.0 -I/usr/include/glib-2.0
&gt; -I/usr/lib64/glib-2.0/include -I/usr/include/gio-unix-2.0/ -pthread
&gt; -lgeoclue-2 -lgio-2.0 -lgobject-2.0 -lglib-2.0
&gt; 
&gt; So if we do not link to libgeoclue AND we don&apos;t need any of its headers,
&gt; it&apos;s OK. I guess if you say the build succeeds, then that must be the case.
&gt; 
&gt; So we must be able to remove our use of GEOCLUE2_CFLAGS and GEOCLUE2_LIBS
&gt; then.

I did some greps and I don&apos;t see where we are including the libgeoclue headers.
Why we require it? Maybe this is a run-time dependency rather than a build one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337412</commentid>
    <comment_count>9</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-08-10 07:54:37 -0700</bug_when>
    <thetext>How is the Geoclue2Interface.h generation handled if ENABLE_GEOLOCATION is true, but no geoclue package is installed?
https://trac.webkit.org/browser/trunk/Source/WebCore/PlatformGTK.cmake#L183</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337413</commentid>
    <comment_count>10</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-08-10 07:57:39 -0700</bug_when>
    <thetext>&gt;Are you saying that REQUIRED by *design* does not result in a fatal error, rather than some bug? 

No, by design it should result in fatal error. However, I&apos;ve found why it doesn&apos;t happen for WebP and GeoClue: package names are case-sensitive, so WebP != WEBP, and WEBP_FOUND being false is ignored because cmake looks for WebP_FOUND. We either need to rename FindWebP.cmake to FindWEBP.cmake and use find_package(WEBP), or use &quot;WebP&quot; spelling consistently. Same for other packages with mixed case names.

As for FeatureSummary, I&apos;ve added it to Qt port because of user request, it provides nice summary about what packages (required and optional) were found and which were not, and allows to add hints to user what is the purpose of these dependencies (so that user can know e.g. that disabling Geolocation is a way to get rid of GeoClue). See cmake documentation for more details. It can also replace our home-grown &quot;Enabled features&quot; list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337417</commentid>
    <comment_count>11</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 08:09:30 -0700</bug_when>
    <thetext>(In reply to Konstantin Tokarev from comment #10)
&gt; &gt;Are you saying that REQUIRED by *design* does not result in a fatal error, rather than some bug? 
&gt; 
&gt; No, by design it should result in fatal error. However, I&apos;ve found why it
&gt; doesn&apos;t happen for WebP and GeoClue: package names are case-sensitive, so
&gt; WebP != WEBP, and WEBP_FOUND being false is ignored because cmake looks for
&gt; WebP_FOUND. We either need to rename FindWebP.cmake to FindWEBP.cmake and
&gt; use find_package(WEBP), or use &quot;WebP&quot; spelling consistently. Same for other
&gt; packages with mixed case names.

Wow.

Just wow. Anyway, this is a separate bug report now. Bug #175427.

&gt; As for FeatureSummary, I&apos;ve added it to Qt port because of user request, it
&gt; provides nice summary about what packages (required and optional) were found
&gt; and which were not, and allows to add hints to user what is the purpose of
&gt; these dependencies (so that user can know e.g. that disabling Geolocation is
&gt; a way to get rid of GeoClue). See cmake documentation for more details. It
&gt; can also replace our home-grown &quot;Enabled features&quot; list.

OK, we should definitely consider doing that in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337418</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 08:10:27 -0700</bug_when>
    <thetext>(In reply to Zan Dobersek from comment #9)
&gt; How is the Geoclue2Interface.h generation handled if ENABLE_GEOLOCATION is
&gt; true, but no geoclue package is installed?
&gt; https://trac.webkit.org/browser/trunk/Source/WebCore/PlatformGTK.cmake#L183

That should be a fatal error, because it is supposed to be REQUIRED. There should be no way to get that far in an ENABLE_GEOLOCATION build without geoclue2 installed. Bug #175427.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337426</commentid>
    <comment_count>13</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 08:27:15 -0700</bug_when>
    <thetext>(In reply to Zan Dobersek from comment #9)
&gt; How is the Geoclue2Interface.h generation handled if ENABLE_GEOLOCATION is
&gt; true, but no geoclue package is installed?
&gt; https://trac.webkit.org/browser/trunk/Source/WebCore/PlatformGTK.cmake#L183

This needs geoclue-2.0 pkg-config file not libgeoclue-2.0 one.

Therefore FindGeoclue2 is looking for the wrong pkg-config file.

This is on Debian Jessie:

$ pkg-config --variable dbus_interface geoclue-2.0
/usr/share/dbus-1/interfaces/org.freedesktop.GeoClue2.xml


It works fine</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337431</commentid>
    <comment_count>14</comment_count>
      <attachid>317807</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 08:37:08 -0700</bug_when>
    <thetext>Created attachment 317807
Patch

Tested on Jessie. Works OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337434</commentid>
    <comment_count>15</comment_count>
      <attachid>317808</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 08:40:33 -0700</bug_when>
    <thetext>Created attachment 317808
Patch

Remove libgeoclue-2-dev from install-dependencies</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337455</commentid>
    <comment_count>16</comment_count>
      <attachid>317808</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-10 09:33:34 -0700</bug_when>
    <thetext>Comment on attachment 317808
Patch

Clearing flags on attachment: 317808

Committed r220529: &lt;http://trac.webkit.org/changeset/220529&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337456</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-10 09:33:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337471</commentid>
    <comment_count>18</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 10:06:28 -0700</bug_when>
    <thetext>Also need to stop using the CFLAGS/LIBS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337472</commentid>
    <comment_count>19</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 10:11:56 -0700</bug_when>
    <thetext>Reopening to attach patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337473</commentid>
    <comment_count>20</comment_count>
      <attachid>317818</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 10:12:04 -0700</bug_when>
    <thetext>Created attachment 317818
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337475</commentid>
    <comment_count>21</comment_count>
      <attachid>317819</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 10:14:01 -0700</bug_when>
    <thetext>Created attachment 317819
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337481</commentid>
    <comment_count>22</comment_count>
      <attachid>317819</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-10 10:29:39 -0700</bug_when>
    <thetext>Comment on attachment 317819
Patch

You are missing one ${GEOCLUE_INCLUDE_DIRS} at Source/WebKit/PlatformGTK.cmake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337485</commentid>
    <comment_count>23</comment_count>
      <attachid>317820</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 10:37:45 -0700</bug_when>
    <thetext>Created attachment 317820
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337514</commentid>
    <comment_count>24</comment_count>
      <attachid>317820</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-10 11:27:08 -0700</bug_when>
    <thetext>Comment on attachment 317820
Patch

Rejecting attachment 317820 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 317820, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -&gt; origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 220532 = 769b5779384cb6500775be0340814fcc6aa84b24
r220533 = 5693a3b3a327bdb93e96d79539b30bb309a1bd07
r220534 = eb6e66c7224b0f60cdc20f1ac591c1fbf36f9326
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/4290924</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1337544</commentid>
    <comment_count>25</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-10 12:31:57 -0700</bug_when>
    <thetext>Committed r220540: &lt;http://trac.webkit.org/changeset/220540&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317807</attachid>
            <date>2017-08-10 08:37:08 -0700</date>
            <delta_ts>2017-08-10 08:40:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175426-20170810173707.patch</filename>
            <type>text/plain</type>
            <size>1189</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEdlb0NsdWUyLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFrZQppbmRleCBm
ZDZjNmNmNjgzMzBlYjdlM2I0NWJhZDc4NmEyYWMwMjY0MjRiY2U0Li4zMTQzYjQ0OTM2NzZlYmI2
YjZlYzZiMmViZWUwOGVmOTQ5NzNlN2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEdl
b0NsdWUyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UKQEAgLTMx
LDcgKzMxLDcgQEAKICMgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu
CiAKIGZpbmRfcGFja2FnZShQa2dDb25maWcpCi1wa2dfY2hlY2tfbW9kdWxlcyhHRU9DTFVFMiBs
aWJnZW9jbHVlLTIuMCkKK3BrZ19jaGVja19tb2R1bGVzKEdFT0NMVUUyIGdlb2NsdWUtMi4wKQog
CiBzZXQoVkVSU0lPTl9PSyBGQUxTRSkKIGlmIChHRU9DTFVFMl9WRVJTSU9OKQpkaWZmIC0tZ2l0
IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGI4Nzc0N2M3ZDkzNDkyZTAzMjRkZGFhMDQ2
OTE3YTIyOGY1M2MyNjcuLjk5MmQyNGRhMzljMzNjY2JiMjc5NDgwZGU5OGFkZDY5ZDEzYmI4OWMg
MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor
MjAxNy0wOC0xMCAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNv
bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjA1MTUpIFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRo
IEVOQUJMRV9HRU9MT0NBVElPTiBmYWlscyBvbiBEZWJpYW4gSmVzc2llCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU0MjYKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIHBrZy1jb25maWcgZmls
ZSBuYW1lLgorICAgICAgICBXZSByZWFsbHkgcmVxdWlyZSBnZW9jbHVlLTIuMCBhbmQgbm90IGxp
Ymdlb2NsdWUtMi4wLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFr
ZToKKwogMjAxNy0wOC0wOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j
b20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIHN1cHBvcnQgZm9yIGdlb2NsdWUxCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317808</attachid>
            <date>2017-08-10 08:40:33 -0700</date>
            <delta_ts>2017-08-10 10:12:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175426-20170810174032.patch</filename>
            <type>text/plain</type>
            <size>2376</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEdlb0NsdWUyLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFrZQppbmRleCBm
ZDZjNmNmNjgzMzBlYjdlM2I0NWJhZDc4NmEyYWMwMjY0MjRiY2U0Li4zMTQzYjQ0OTM2NzZlYmI2
YjZlYzZiMmViZWUwOGVmOTQ5NzNlN2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEdl
b0NsdWUyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UKQEAgLTMx
LDcgKzMxLDcgQEAKICMgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu
CiAKIGZpbmRfcGFja2FnZShQa2dDb25maWcpCi1wa2dfY2hlY2tfbW9kdWxlcyhHRU9DTFVFMiBs
aWJnZW9jbHVlLTIuMCkKK3BrZ19jaGVja19tb2R1bGVzKEdFT0NMVUUyIGdlb2NsdWUtMi4wKQog
CiBzZXQoVkVSU0lPTl9PSyBGQUxTRSkKIGlmIChHRU9DTFVFMl9WRVJTSU9OKQpkaWZmIC0tZ2l0
IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDVlOWU2YjQ5ZTYwOTU4
Yjg4N2UyNzU4YWQzYjE3ODFkZDNjZmMwYjkuLjBiMWQ2YWMxMTllNmFiMGM2OWNmMzk1ZWEwNDEx
OGRiYTk5OTM0NjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wOC0xMCAgQ2FybG9zIEFsYmVydG8gTG9wZXog
UGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjA1MTUp
IFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRoIEVOQUJMRV9HRU9MT0NBVElPTiBmYWlscyBvbiBEZWJp
YW4gSmVzc2llCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzU0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczogbGliZ2VvY2x1ZS1kZXYgcGFja2FnZXMgbm90
IHJlYWxseSBuZWVkZWQgb24gRGViaWFuL1VidW50dS4KKwogMjAxNy0wOC0xMCAgTXMyZ2VyICA8
TXMyZ2VyQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWRkIE1zMmdlciBhcyBjb250cmlidXRvci4K
ZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2d0ay9p
bnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCA3MWFiNDcwNjhkZWIzODc4MjdhYzFhMmZiNjMxNzBm
NTM0MTJjMDRmLi5lOTM5YjY3YmExM2VkOTBjNTM2YWYyZTcxYzljNWZmMjI2ODg2N2QzIDEwMDc1
NQotLS0gYS9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZ3RrL2lu
c3RhbGwtZGVwZW5kZW5jaWVzCkBAIC0xMDksNyArMTA5LDYgQEAgZnVuY3Rpb24gaW5zdGFsbERl
cGVuZGVuY2llc1dpdGhBcHQgewogICAgICAgICBsaWJmYWFkLWRldiBcCiAgICAgICAgIGxpYmZm
aS1kZXYgXAogICAgICAgICAkKGFwdElmRWxzZSBsaWJnY3J5cHQyMC1kZXYgbGliZ2NyeXB0MTEt
ZGV2KSBcCi0gICAgICAgICQoYXB0SWZFbHNlIGxpYmdlb2NsdWUtMi1kZXYgbGliZ2VvY2x1ZS1k
ZXYpIFwKICAgICAgICAgbGliZ2lyZXBvc2l0b3J5MS4wLWRldiBcCiAgICAgICAgIGxpYmdsMS1t
ZXNhLWRldiBcCiAgICAgICAgIGxpYmdsMS1tZXNhLWdseCBcCmRpZmYgLS1naXQgYS9DaGFuZ2VM
b2cgYi9DaGFuZ2VMb2cKaW5kZXggYjg3NzQ3YzdkOTM0OTJlMDMyNGRkYWEwNDY5MTdhMjI4ZjUz
YzI2Ny4uOTkyZDI0ZGEzOWMzM2NjYmIyNzk0ODBkZTk4YWRkNjlkMTNiYjg5YyAxMDA2NDQKLS0t
IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTEw
ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAg
ICAgIFJFR1JFU1NJT04ocjIyMDUxNSkgW0dUS11bQ01ha2VdIEJ1aWxkIHdpdGggRU5BQkxFX0dF
T0xPQ0FUSU9OIGZhaWxzIG9uIERlYmlhbiBKZXNzaWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgcGtnLWNvbmZpZyBmaWxlIG5hbWUuCisg
ICAgICAgIFdlIHJlYWxseSByZXF1aXJlIGdlb2NsdWUtMi4wIGFuZCBub3QgbGliZ2VvY2x1ZS0y
LjAuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdlb0NsdWUyLmNtYWtlOgorCiAyMDE3
LTA4LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAg
ICAgICBbR1RLXSBSZW1vdmUgc3VwcG9ydCBmb3IgZ2VvY2x1ZTEK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317818</attachid>
            <date>2017-08-10 10:12:04 -0700</date>
            <delta_ts>2017-08-10 10:13:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175426-20170810121204.patch</filename>
            <type>text/plain</type>
            <size>1687</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTNlN2M5MjIxODI5MzM3
NTk3ZmIzOWY2NmNiNGYyNmM5YTRjNmU2Ni4uMTA1ZTgxOWI5NGY5YmJmNzUwYTQyZGViMTVhNTdh
ZThhNGQ0YzBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA4LTEwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBSRUdSRVNT
SU9OKHIyMjA1MTUpIFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRoIEVOQUJMRV9HRU9MT0NBVElPTiBm
YWlscyBvbiBEZWJpYW4gSmVzc2llCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNzU0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBBbHNvIHN0b3AgdXNpbmcgR0VPQ0xVRV9MSUJSQVJJRVMgYW5kIEdFT0NM
VUVfSU5DTFVERV9ESVJTLCBzaW5jZSB0aGV5IGFyZSBlbXB0eS4gQXBwYXJlbnRseQorICAgICAg
ICB3ZSBoYXZlIG5vdCBhY3R1YWxseSBiZWVuIHVzaW5nIHRoZSBjbGllbnQgbGlicmFyeSBhdCBh
bGwgdGhpcyB3aG9sZSB0aW1lLCBvbmx5IHRoZSBELUJ1cworICAgICAgICBpbnRlcmZhY2UuCisK
KyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKworMjAxNy0wOC0xMCAgTWljaGFlbCBDYXRh
bnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9H
QU1FUEFEX0RFUFJFQ0FURUQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE3NTM2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdU
Sy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDMwODMyM2Rk
NjI5MGI3NDVjMmNjMjlmYTg4MjFjM2UyOTRmYmI5ZGQuLmMwYWM2MDU5MGY3NzgzN2VmMDg4M2U3
ODhhMmYxNDQ0MGZhODcyMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RL
LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0yMDIsNyAr
MjAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAgICAke0FUS19MSUJSQVJJ
RVN9CiAgICAgJHtDQUlST19MSUJSQVJJRVN9CiAgICAgJHtFTkNIQU5UX0xJQlJBUklFU30KLSAg
ICAke0dFT0NMVUVfTElCUkFSSUVTfQogICAgICR7R0xJQl9HSU9fTElCUkFSSUVTfQogICAgICR7
R0xJQl9HTU9EVUxFX0xJQlJBUklFU30KICAgICAke0dMSUJfR09CSkVDVF9MSUJSQVJJRVN9CkBA
IC0yMjksNyArMjI4LDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TWVNURU1fSU5DTFVERV9ESVJF
Q1RPUklFUwogICAgICR7QVRLX0lOQ0xVREVfRElSU30KICAgICAke0NBSVJPX0lOQ0xVREVfRElS
U30KICAgICAke0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotICAgICR7R0VPQ0xVRV9JTkNMVURFX0RJ
UlN9CiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAgICAgJHtHTElCX0lOQ0xVREVfRElS
U30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317819</attachid>
            <date>2017-08-10 10:14:01 -0700</date>
            <delta_ts>2017-08-10 10:37:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175426-20170810121400.patch</filename>
            <type>text/plain</type>
            <size>2889</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTNlN2M5MjIxODI5MzM3
NTk3ZmIzOWY2NmNiNGYyNmM5YTRjNmU2Ni4uMTA1ZTgxOWI5NGY5YmJmNzUwYTQyZGViMTVhNTdh
ZThhNGQ0YzBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA4LTEwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBSRUdSRVNT
SU9OKHIyMjA1MTUpIFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRoIEVOQUJMRV9HRU9MT0NBVElPTiBm
YWlscyBvbiBEZWJpYW4gSmVzc2llCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNzU0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBBbHNvIHN0b3AgdXNpbmcgR0VPQ0xVRV9MSUJSQVJJRVMgYW5kIEdFT0NM
VUVfSU5DTFVERV9ESVJTLCBzaW5jZSB0aGV5IGFyZSBlbXB0eS4gQXBwYXJlbnRseQorICAgICAg
ICB3ZSBoYXZlIG5vdCBhY3R1YWxseSBiZWVuIHVzaW5nIHRoZSBjbGllbnQgbGlicmFyeSBhdCBh
bGwgdGhpcyB3aG9sZSB0aW1lLCBvbmx5IHRoZSBELUJ1cworICAgICAgICBpbnRlcmZhY2UuCisK
KyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKworMjAxNy0wOC0xMCAgTWljaGFlbCBDYXRh
bnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9H
QU1FUEFEX0RFUFJFQ0FURUQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE3NTM2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdU
Sy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDMwODMyM2Rk
NjI5MGI3NDVjMmNjMjlmYTg4MjFjM2UyOTRmYmI5ZGQuLmMwYWM2MDU5MGY3NzgzN2VmMDg4M2U3
ODhhMmYxNDQ0MGZhODcyMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RL
LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0yMDIsNyAr
MjAyLDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAgICAke0FUS19MSUJSQVJJ
RVN9CiAgICAgJHtDQUlST19MSUJSQVJJRVN9CiAgICAgJHtFTkNIQU5UX0xJQlJBUklFU30KLSAg
ICAke0dFT0NMVUVfTElCUkFSSUVTfQogICAgICR7R0xJQl9HSU9fTElCUkFSSUVTfQogICAgICR7
R0xJQl9HTU9EVUxFX0xJQlJBUklFU30KICAgICAke0dMSUJfR09CSkVDVF9MSUJSQVJJRVN9CkBA
IC0yMjksNyArMjI4LDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TWVNURU1fSU5DTFVERV9ESVJF
Q1RPUklFUwogICAgICR7QVRLX0lOQ0xVREVfRElSU30KICAgICAke0NBSVJPX0lOQ0xVREVfRElS
U30KICAgICAke0VOQ0hBTlRfSU5DTFVERV9ESVJTfQotICAgICR7R0VPQ0xVRV9JTkNMVURFX0RJ
UlN9CiAgICAgJHtHSU9fVU5JWF9JTkNMVURFX0RJUlN9CiAgICAgJHtHTElCX0lOQ0xVREVfRElS
U30KICAgICAke0xJQlNFQ1JFVF9JTkNMVURFX0RJUlN9CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h
a2UvRmluZEdlb0NsdWUyLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFrZQpp
bmRleCAzMTQzYjQ0OTM2NzZlYmI2YjZlYzZiMmViZWUwOGVmOTQ5NzNlN2E4Li44YmI2MmNiNDdi
ZmMxN2Y1ODNhYjlkMmE3MTlhMjcyYjYwYTA5ZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv
RmluZEdlb0NsdWUyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UK
QEAgLTIsOCArMiw2IEBACiAjIE9uY2UgZG9uZSwgdGhpcyB3aWxsIGRlZmluZQogIwogIyAgR0VP
Q0xVRTJfRk9VTkQgLSBzeXN0ZW0gaGFzIEdlb0NsdWUgMi4KLSMgIEdFT0NMVUUyX0lOQ0xVREVf
RElSUyAtIHRoZSBHZW9DbHVlIDIuIGluY2x1ZGUgZGlyZWN0b3JpZXMKLSMgIEdFT0NMVUUyX0xJ
QlJBUklFUyAtIGxpbmsgdGhlc2UgdG8gdXNlIEdlb0NsdWUgMi4KICMKICMgQ29weXJpZ2h0IChD
KSAyMDEyIFJhcGhhZWwgS3VibyBkYSBDb3N0YSA8cmFrdWNvQHdlYmtpdC5vcmc+CiAjIENvcHly
aWdodCAoQykgMjAxMywgMjAxNCBJZ2FsaWEgUy5MLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIv
Q2hhbmdlTG9nCmluZGV4IDgxZjJhMTU5NzAxMTQ4MzY2YzFhZGRiZTcyMDI0NDJmMTc3MWExNjIu
Ljc0Njk4NmIyZTA3MTVmOGU1YTYzNWNhY2QxODUyZmYzZWJkOTk4YjAgMTAwNjQ0Ci0tLSBhL0No
YW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wOC0xMCAgTWlj
aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUkVHUkVT
U0lPTihyMjIwNTE1KSBbR1RLXVtDTWFrZV0gQnVpbGQgd2l0aCBFTkFCTEVfR0VPTE9DQVRJT04g
ZmFpbHMgb24gRGViaWFuIEplc3NpZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTc1NDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdlb0NsdWUyLmNtYWtlOgorCisyMDE3
LTA4LTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAg
ICAgICBSZW1vdmUgRU5BQkxFX0dBTUVQQURfREVQUkVDQVRFRAogICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MzYxCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317820</attachid>
            <date>2017-08-10 10:37:45 -0700</date>
            <delta_ts>2017-08-10 11:27:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175426-20170810123745.patch</filename>
            <type>text/plain</type>
            <size>4109</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTNlN2M5MjIxODI5MzM3
NTk3ZmIzOWY2NmNiNGYyNmM5YTRjNmU2Ni4uMTA1ZTgxOWI5NGY5YmJmNzUwYTQyZGViMTVhNTdh
ZThhNGQ0YzBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA4LTEwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBSRUdSRVNT
SU9OKHIyMjA1MTUpIFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRoIEVOQUJMRV9HRU9MT0NBVElPTiBm
YWlscyBvbiBEZWJpYW4gSmVzc2llCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNzU0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBBbHNvIHN0b3AgdXNpbmcgR0VPQ0xVRV9MSUJSQVJJRVMgYW5kIEdFT0NM
VUVfSU5DTFVERV9ESVJTLCBzaW5jZSB0aGV5IGFyZSBlbXB0eS4gQXBwYXJlbnRseQorICAgICAg
ICB3ZSBoYXZlIG5vdCBhY3R1YWxseSBiZWVuIHVzaW5nIHRoZSBjbGllbnQgbGlicmFyeSBhdCBh
bGwgdGhpcyB3aG9sZSB0aW1lLCBvbmx5IHRoZSBELUJ1cworICAgICAgICBpbnRlcmZhY2UuCisK
KyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKworMjAxNy0wOC0xMCAgTWljaGFlbCBDYXRh
bnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9H
QU1FUEFEX0RFUFJFQ0FURUQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE3NTM2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi
L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzZDczZWIxN2VlMTE1ZGIyNTNlNjA4NDBj
YmRhZDQ1NTM1N2JkMjQuLjE0MDA5NjUwODc1OGE4YTRkYjdjMGFjMzk5Mjk3Y2Y0Y2U0ZTU5ODkg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv
Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTctMDgtMTAgIE1pY2hhZWwgQ2F0YW56YXJv
ICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04ocjIyMDUxNSkg
W0dUS11bQ01ha2VdIEJ1aWxkIHdpdGggRU5BQkxFX0dFT0xPQ0FUSU9OIGZhaWxzIG9uIERlYmlh
biBKZXNzaWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE3NTQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogUGxhdGZvcm1HVEsuY21ha2U6CisKKzIwMTctMDgtMTAgIE1pY2hhZWwgQ2F0YW56YXJvICA8
bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfR0FNRVBBRF9E
RVBSRUNBVEVECiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzUzNjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2Ug
Yi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAzMDgzMjNkZDYyOTBiNzQ1
YzJjYzI5ZmE4ODIxYzNlMjk0ZmJiOWRkLi5jMGFjNjA1OTBmNzc4MzdlZjA4ODNlNzg4YTJmMTQ0
NDBmYTg3MjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMjAyLDcgKzIwMiw2IEBA
IGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtBVEtfTElCUkFSSUVTfQogICAg
ICR7Q0FJUk9fTElCUkFSSUVTfQogICAgICR7RU5DSEFOVF9MSUJSQVJJRVN9Ci0gICAgJHtHRU9D
TFVFX0xJQlJBUklFU30KICAgICAke0dMSUJfR0lPX0xJQlJBUklFU30KICAgICAke0dMSUJfR01P
RFVMRV9MSUJSQVJJRVN9CiAgICAgJHtHTElCX0dPQkpFQ1RfTElCUkFSSUVTfQpAQCAtMjI5LDcg
KzIyOCw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMK
ICAgICAke0FUS19JTkNMVURFX0RJUlN9CiAgICAgJHtDQUlST19JTkNMVURFX0RJUlN9CiAgICAg
JHtFTkNIQU5UX0lOQ0xVREVfRElSU30KLSAgICAke0dFT0NMVUVfSU5DTFVERV9ESVJTfQogICAg
ICR7R0lPX1VOSVhfSU5DTFVERV9ESVJTfQogICAgICR7R0xJQl9JTkNMVURFX0RJUlN9CiAgICAg
JHtMSUJTRUNSRVRfSU5DTFVERV9ESVJTfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0
Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggODVm
OTFhMGI0N2NjNzMzMDFmOWQ4ZjE1MzhiYjdlNzM3YWY4NjlhNS4uM2YzZGU2MDkyZWE4NGFmNDRm
ODUwMzljNDc1ZDA0ODEyMDZjOTBjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9y
bUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCkBAIC04MDks
NyArODA5LDYgQEAgbGlzdChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCiBsaXN0
KEFQUEVORCBXZWJLaXQyX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtDQUlST19J
TkNMVURFX0RJUlN9CiAgICAgJHtFTkNIQU5UX0lOQ0xVREVfRElSU30KLSAgICAke0dFT0NMVUVf
SU5DTFVERV9ESVJTfQogICAgICR7R1NUUkVBTUVSX0lOQ0xVREVfRElSU30KICAgICAke0dTVFJF
QU1FUl9QQlVUSUxTX0lOQ0xVREVfRElSU30KICAgICAke0hBUkZCVVpaX0lOQ0xVREVfRElSU30K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UgYi9Tb3VyY2UvY21h
a2UvRmluZEdlb0NsdWUyLmNtYWtlCmluZGV4IDMxNDNiNDQ5MzY3NmViYjZiNmVjNmIyZWJlZTA4
ZWY5NDk3M2U3YTguLjhiYjYyY2I0N2JmYzE3ZjU4M2FiOWQyYTcxOWEyNzJiNjBhMDllNGQgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UKKysrIGIvU291cmNlL2Nt
YWtlL0ZpbmRHZW9DbHVlMi5jbWFrZQpAQCAtMiw4ICsyLDYgQEAKICMgT25jZSBkb25lLCB0aGlz
IHdpbGwgZGVmaW5lCiAjCiAjICBHRU9DTFVFMl9GT1VORCAtIHN5c3RlbSBoYXMgR2VvQ2x1ZSAy
LgotIyAgR0VPQ0xVRTJfSU5DTFVERV9ESVJTIC0gdGhlIEdlb0NsdWUgMi4gaW5jbHVkZSBkaXJl
Y3RvcmllcwotIyAgR0VPQ0xVRTJfTElCUkFSSUVTIC0gbGluayB0aGVzZSB0byB1c2UgR2VvQ2x1
ZSAyLgogIwogIyBDb3B5cmlnaHQgKEMpIDIwMTIgUmFwaGFlbCBLdWJvIGRhIENvc3RhIDxyYWt1
Y29Ad2Via2l0Lm9yZz4KICMgQ29weXJpZ2h0IChDKSAyMDEzLCAyMDE0IElnYWxpYSBTLkwuCmRp
ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggODFmMmExNTk3MDExNDgzNjZj
MWFkZGJlNzIwMjQ0MmYxNzcxYTE2Mi4uNzQ2OTg2YjJlMDcxNWY4ZTVhNjM1Y2FjZDE4NTJmZjNl
YmQ5OThiMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsx
LDE0IEBACiAyMDE3LTA4LTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlh
LmNvbT4KIAorICAgICAgICBSRUdSRVNTSU9OKHIyMjA1MTUpIFtHVEtdW0NNYWtlXSBCdWlsZCB3
aXRoIEVOQUJMRV9HRU9MT0NBVElPTiBmYWlscyBvbiBEZWJpYW4gSmVzc2llCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU0MjYKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5k
R2VvQ2x1ZTIuY21ha2U6CisKKzIwMTctMDgtMTAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu
emFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfR0FNRVBBRF9ERVBSRUNB
VEVECiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUz
NjEKIAo=
</data>
<flag name="review"
          id="338321"
          type_id="1"
          status="+"
          setter="clopez"
    />
    <flag name="commit-queue"
          id="338322"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>