175414 2017-08-09 18:55:27 -0700 Resource Load Statistics: Increase grandfathering time to 7 days 2017-08-10 18:47:07 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue sam webkit-bug-importer wilander oldest_to_newest 1337272 0 wilander 2017-08-09 18:55:27 -0700 We should increase grandfathering time to 3 days to allow ample time to capture user interaction. 1337273 1 webkit-bug-importer 2017-08-09 18:56:02 -0700 <rdar://problem/33818046> 1337274 2 317773 wilander 2017-08-09 18:57:02 -0700 Created attachment 317773 Patch 1337287 3 317773 wilander 2017-08-09 19:51:39 -0700 Comment on attachment 317773 Patch Thanks, Brent! 1337294 4 317773 commit-queue 2017-08-09 20:21:08 -0700 Comment on attachment 317773 Patch Clearing flags on attachment: 317773 Committed r220505: <http://trac.webkit.org/changeset/220505> 1337295 5 commit-queue 2017-08-09 20:21:09 -0700 All reviewed patches have been landed. Closing bug. 1337484 6 bfulgham 2017-08-10 10:36:42 -0700 Reopening because we think this should be three days of uptime, not three calendar days. 1337486 7 bfulgham 2017-08-10 10:38:15 -0700 We should change the grandfathering code to operate based on uptime. I think this just means modifying WebResourceLoadStatisticsStore::topPrivatelyControlledDomainsToRemoveWebsiteDataFor to use this as the test: bool shouldCheckForGrandfathering = m_operatingDates.size() > 3; 1337538 8 bfulgham 2017-08-10 12:20:24 -0700 Never mind. Let's track other changes as a refinement. Re-closing. 1337689 9 wilander 2017-08-10 16:34:33 -0700 We're bumping this to seven days. Reopening. 1337693 10 317880 wilander 2017-08-10 16:39:43 -0700 Created attachment 317880 Patch 1337727 11 317880 bfulgham 2017-08-10 17:08:27 -0700 Comment on attachment 317880 Patch r=me 1337742 12 sam 2017-08-10 17:16:47 -0700 Please be aware that changes to the WebKit directory need approval from a WebKit owner. To that end, how is this change being tested? Can an automated test be written? 1337746 13 bfulgham 2017-08-10 17:25:37 -0700 (In reply to Sam Weinig from comment #12) > To that end, how is this change being tested? Can an automated test be > written? Existing tests cover this logic. Because of the lengths of time involved, they run with override timeouts that aren't affected by this change to a constant. If you want to track detailed testing in Safari, please follow the associated Radar. 1337768 14 317880 wilander 2017-08-10 18:16:35 -0700 Comment on attachment 317880 Patch Thanks, Brent! 1337777 15 317880 commit-queue 2017-08-10 18:47:06 -0700 Comment on attachment 317880 Patch Clearing flags on attachment: 317880 Committed r220571: <http://trac.webkit.org/changeset/220571> 1337778 16 commit-queue 2017-08-10 18:47:07 -0700 All reviewed patches have been landed. Closing bug. 317773 2017-08-09 18:57:02 -0700 2017-08-10 16:39:42 -0700 Patch bug-175414-20170809185701.patch text/plain 1399 wilander SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjA1MDEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTA5ICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlz dGljczogSW5jcmVhc2UgZ3JhbmRmYXRoZXJpbmcgdGltZSB0byAzIGRheXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTQxNAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzM4MTgwNDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3Jl Lmg6CisKIDIwMTctMDgtMDkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFBhcnQgMyBvZjogUmVuYW1lIERhdGFiYXNlUHJvY2VzcyB0byBTdG9yYWdlUHJvY2VzcwpJ bmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0 b3JlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1N0b3JlLmgJKHJldmlzaW9uIDIyMDQxMykKKysrIFNvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5oCSh3b3JraW5nIGNvcHkp CkBAIC0xNjQsNyArMTY0LDcgQEAgcHJpdmF0ZToKICAgICAgICAgc3RkOjpvcHRpb25hbDxTZWNv bmRzPiB0aW1lVG9MaXZlVXNlckludGVyYWN0aW9uOwogICAgICAgICBTZWNvbmRzIHRpbWVUb0xp dmVDb29raWVQYXJ0aXRpb25GcmVlIHsgMjRfaCB9OwogICAgICAgICBTZWNvbmRzIG1pbmltdW1U aW1lQmV0d2VlbkRhdGFSZWNvcmRzUmVtb3ZhbCB7IDFfaCB9OwotICAgICAgICBTZWNvbmRzIGdy YW5kZmF0aGVyaW5nVGltZSB7IDFfaCB9OworICAgICAgICBTZWNvbmRzIGdyYW5kZmF0aGVyaW5n VGltZSB7IDcyX2ggfTsKICAgICAgICAgYm9vbCBzaG91bGROb3RpZnlQYWdlc1doZW5EYXRhUmVj b3Jkc1dlcmVTY2FubmVkIHsgZmFsc2UgfTsKICAgICAgICAgYm9vbCBzaG91bGRDbGFzc2lmeVJl c291cmNlc0JlZm9yZURhdGFSZWNvcmRzUmVtb3ZhbCB7IHRydWUgfTsKICAgICAgICAgYm9vbCBz aG91bGRTdWJtaXRUZWxlbWV0cnkgeyB0cnVlIH07Cg== 317880 2017-08-10 16:39:43 -0700 2017-08-10 18:47:06 -0700 Patch bug-175414-20170810163942.patch text/plain 1402 wilander SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjA1NjEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTEwICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlz dGljczogSW5jcmVhc2UgZ3JhbmRmYXRoZXJpbmcgdGltZSB0byA3IGRheXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTQxNAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzM4MTgwNDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3Jl Lmg6CisKIDIwMTctMDgtMTAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIEFwcGx5IHRoZSBVTkxJS0VMWSBtYWNybyB0byBzb21lIHVubGlrZWx5IHRoaW5ncy4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9h ZFN0YXRpc3RpY3NTdG9yZS5oCShyZXZpc2lvbiAyMjA1NDEpCisrKyBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuaAkod29ya2luZyBjb3B5KQpA QCAtMTY0LDcgKzE2NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIHN0ZDo6b3B0aW9uYWw8U2Vjb25k cz4gdGltZVRvTGl2ZVVzZXJJbnRlcmFjdGlvbjsKICAgICAgICAgU2Vjb25kcyB0aW1lVG9MaXZl Q29va2llUGFydGl0aW9uRnJlZSB7IDI0X2ggfTsKICAgICAgICAgU2Vjb25kcyBtaW5pbXVtVGlt ZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwgeyAxX2ggfTsKLSAgICAgICAgU2Vjb25kcyBncmFu ZGZhdGhlcmluZ1RpbWUgeyA3Ml9oIH07CisgICAgICAgIFNlY29uZHMgZ3JhbmRmYXRoZXJpbmdU aW1lIHsgMjRfaCAqIDcgfTsKICAgICAgICAgYm9vbCBzaG91bGROb3RpZnlQYWdlc1doZW5EYXRh UmVjb3Jkc1dlcmVTY2FubmVkIHsgZmFsc2UgfTsKICAgICAgICAgYm9vbCBzaG91bGRDbGFzc2lm eVJlc291cmNlc0JlZm9yZURhdGFSZWNvcmRzUmVtb3ZhbCB7IHRydWUgfTsKICAgICAgICAgYm9v bCBzaG91bGRTdWJtaXRUZWxlbWV0cnkgeyB0cnVlIH07Cg==