<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175377</bug_id>
          
          <creation_ts>2017-08-09 05:14:06 -0700</creation_ts>
          <short_desc>[WPE] Use the device scale factor value in WebPageCreationParameters</short_desc>
          <delta_ts>2017-10-16 01:09:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1336927</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-08-09 05:14:06 -0700</bug_when>
    <thetext>[WPE] Use the device scale factor value in WebPageCreationParameters</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336928</commentid>
    <comment_count>1</comment_count>
      <attachid>317695</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-08-09 05:24:09 -0700</bug_when>
    <thetext>Created attachment 317695
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1344701</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-09-01 17:54:20 -0700</bug_when>
    <thetext>I know it&apos;s only one line, but you need an owner for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1344757</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-02 00:31:56 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #2)
&gt; I know it&apos;s only one line, but you need an owner for this.

The file is specific to the GTK+ and WPE ports, despite its location.

r221344, being most recent change here, didn&apos;t require an owner.
https://trac.webkit.org/changeset/221344/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1344813</commentid>
    <comment_count>4</comment_count>
      <attachid>317695</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-09-02 10:19:48 -0700</bug_when>
    <thetext>Comment on attachment 317695
Patch

I didn&apos;t realize it was our file. OK then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1345162</commentid>
    <comment_count>5</comment_count>
      <attachid>317695</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-03 23:03:03 -0700</bug_when>
    <thetext>Comment on attachment 317695
Patch

Clearing flags on attachment: 317695

Committed r221571: &lt;http://trac.webkit.org/changeset/221571&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1345163</commentid>
    <comment_count>6</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-03 23:03:07 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1353753</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-09-27 12:59:32 -0700</bug_when>
    <thetext>&lt;rdar://problem/34694437&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1360700</commentid>
    <comment_count>8</comment_count>
      <attachid>317695</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-10-16 01:09:31 -0700</bug_when>
    <thetext>Comment on attachment 317695
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317695&amp;action=review

&gt; Source/WebKit/ChangeLog:15
&gt; +        which enters accelerated mode unconditionally and as such doesn&apos;t
&gt; +        wait for the backing store update that would provide that value
&gt; +        otherwise.

This value is not provided by backing store update, it&apos;s set from the parameters in the WebPage constructor, just a few lines below the drawing area creation. Are you sure we need to set this twice? If we need to set it earlier we can just move the lines right after the drawing area creation.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317695</attachid>
            <date>2017-08-09 05:24:09 -0700</date>
            <delta_ts>2017-09-03 23:03:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175377-20170809142408.patch</filename>
            <type>text/plain</type>
            <size>1768</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhN2FjNjM0ZDMwNTdmMzlh
MTVkYzAxZDk3ZTJlNzQ3MTk1N2RkMjUuLjViZTA1NTMwYThlODRlNTU4NmU3NGZkMjJlZDkyNzVl
NDE0YWVhZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMDgtMDkgIFphbiBEb2Jl
cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIFVzZSB0aGUgZGV2
aWNlIHNjYWxlIGZhY3RvciB2YWx1ZSBpbiBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUzNzcKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv
V2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QWNj
ZWxlcmF0ZWREcmF3aW5nQXJlYTo6QWNjZWxlcmF0ZWREcmF3aW5nQXJlYSk6CisgICAgICAgIFdl
YlBhZ2VDcmVhdGlvblBhcmFtZXRlcnM6OmRldmljZVNjYWxlRmFjdG9yIHZhbHVlIHNob3VsZCBi
ZSB1c2VkCisgICAgICAgIHRvIHNldCB0aGUgZGV2aWNlIHNjYWxlIGZhY3RvciBvbiB0aGUgZ2l2
ZW4gV2ViUGFnZSBvYmplY3QuIFRoaXMKKyAgICAgICAgZW5hYmxlcyBjb3JyZWN0bHkgbGV2ZXJh
Z2luZyB0aGUgc2NhbGUgZmFjdG9yIGZvciB0aGUgV1BFIHBvcnQKKyAgICAgICAgd2hpY2ggZW50
ZXJzIGFjY2VsZXJhdGVkIG1vZGUgdW5jb25kaXRpb25hbGx5IGFuZCBhcyBzdWNoIGRvZXNuJ3QK
KyAgICAgICAgd2FpdCBmb3IgdGhlIGJhY2tpbmcgc3RvcmUgdXBkYXRlIHRoYXQgd291bGQgcHJv
dmlkZSB0aGF0IHZhbHVlCisgICAgICAgIG90aGVyd2lzZS4KKwogMjAxNy0wOC0wOCAgV2Vuc29u
IEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy
b2xsaW5nIG91dCByMjIwMzkzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz
L1dlYlBhZ2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcAppbmRleCA4ZTgzMWNlYjg3
ODgzZGQwZjMyMjQ3ZDg1OTIwOGM2Y2E2OWFlYTQ0Li4xODBjMDgwMDg5MDI5NTRmOGQ4ZmE0ODc1
YmQwODU2N2EwNDc3OGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi
UGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVhLmNwcApAQCAtNjMsNiArNjMsOCBA
QCBBY2NlbGVyYXRlZERyYXdpbmdBcmVhOjpBY2NlbGVyYXRlZERyYXdpbmdBcmVhKFdlYlBhZ2Um
IHdlYlBhZ2UsIGNvbnN0IFdlYlBhZ2VDcgogI2VuZGlmCiAgICAgaWYgKCFtX3dlYlBhZ2UuaXNW
aXNpYmxlKCkpCiAgICAgICAgIHN1c3BlbmRQYWludGluZygpOworCisgICAgbV93ZWJQYWdlLmNv
cmVQYWdlKCktPnNldERldmljZVNjYWxlRmFjdG9yKHBhcmFtZXRlcnMuZGV2aWNlU2NhbGVGYWN0
b3IpOwogfQogCiB2b2lkIEFjY2VsZXJhdGVkRHJhd2luZ0FyZWE6OnNldE5lZWRzRGlzcGxheSgp
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>