<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175351</bug_id>
          
          <creation_ts>2017-08-08 15:56:20 -0700</creation_ts>
          <short_desc>REGRESSION (r220393): LayoutTest editing/selection/move-by-word-visually-multi-space.html is timing out</short_desc>
          <delta_ts>2017-11-15 13:11:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=175116</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>ap</cc>
    
    <cc>jlewis3</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1336711</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-08-08 15:56:20 -0700</bug_when>
    <thetext>LayoutTest editing/selection/move-by-word-visually-multi-space.html is timing out

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/3187

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=editing%2Fselection%2Fmove-by-word-visually-multi-space.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336713</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-08-08 16:00:09 -0700</bug_when>
    <thetext>This started with https://trac.webkit.org/changeset/220393/webkit

Looking at the flakiness dashboard, the test went from passing to a consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra Debug WK2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336827</commentid>
    <comment_count>2</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-08-08 19:17:31 -0700</bug_when>
    <thetext>(In reply to Ryan Haddad from comment #1)
&gt; This started with https://trac.webkit.org/changeset/220393/webkit
&gt; 
&gt; Looking at the flakiness dashboard, the test went from passing to a
&gt; consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
&gt; Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
&gt; Debug WK2.

This test passes consistently for me on High Sierra, with a debug build. Will try using Sierra...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336857</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-08-08 22:07:06 -0700</bug_when>
    <thetext>I suggest rolling back until this can be fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336867</commentid>
    <comment_count>4</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-08-08 22:31:25 -0700</bug_when>
    <thetext>(In reply to Wenson Hsieh from comment #2)
&gt; (In reply to Ryan Haddad from comment #1)
&gt; &gt; This started with https://trac.webkit.org/changeset/220393/webkit
&gt; &gt; 
&gt; &gt; Looking at the flakiness dashboard, the test went from passing to a
&gt; &gt; consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
&gt; &gt; Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
&gt; &gt; Debug WK2.
&gt; 
&gt; This test passes consistently for me on High Sierra, with a debug build.
&gt; Will try using Sierra...

...actually, this might be timing out now because the test is just taking longer than it did before. Time profiling instrumentation shows that WebPage::editorState is taking longer than it did previously, due to EditingStyle::styleAtSelectionStart being more expensive in this test case than Editor::styleForSelectionStart.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336868</commentid>
    <comment_count>5</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-08-08 22:32:14 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #3)
&gt; I suggest rolling back until this can be fixed.

I think that&apos;s a good call. I&apos;ll roll it out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336870</commentid>
    <comment_count>6</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-08-08 22:41:51 -0700</bug_when>
    <thetext>(In reply to Wenson Hsieh from comment #5)
&gt; (In reply to Alexey Proskuryakov from comment #3)
&gt; &gt; I suggest rolling back until this can be fixed.
&gt; 
&gt; I think that&apos;s a good call. I&apos;ll roll it out.

Rolled out in &lt;http://trac.webkit.org/changeset/220443&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372398</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-15 13:11:43 -0800</bug_when>
    <thetext>&lt;rdar://problem/35568969&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>