175329 2017-08-08 09:46:50 -0700 REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure 2019-01-15 17:10:15 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=175143 https://bugs.webkit.org/show_bug.cgi?id=130653 https://bugs.webkit.org/show_bug.cgi?id=175909 InRadar P2 Normal --- 1 ryanhaddad darin ap darin jer.noble jlewis3 jonlee kling koivisto webkit-bug-importer wenson_hsieh oldest_to_newest 1336510 0 ryanhaddad 2017-08-08 09:46:50 -0700 API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure FAIL VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame /Volumes/Data/slave/sierra-debug/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:57 Value of: hasVideoForControlsManager Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2870 1336533 1 ap 2017-08-08 10:40:35 -0700 HAs something changed, or have we simply been not noticing this for so long? 1336536 2 ryanhaddad 2017-08-08 10:42:43 -0700 (In reply to Alexey Proskuryakov from comment #1) > HAs something changed, or have we simply been not noticing this for so long? This seems to be a recent regression, perhaps sharing the same root cause as https://bugs.webkit.org/show_bug.cgi?id=175143 I am trying to reproduce both failures locally and identify a regression point. 1337558 3 ryanhaddad 2017-08-10 13:17:22 -0700 This regressed with https://trac.webkit.org/changeset/220052/webkit 1338415 4 ryanhaddad 2017-08-14 11:33:02 -0700 Skipped this flaky test in https://trac.webkit.org/changeset/220711/webkit 1338690 5 darin 2017-08-15 09:16:38 -0700 Jer, can you perhaps help me figure out why this is failing? I would like to fix it and re-enable the test. 1345068 6 319811 darin 2017-09-03 15:31:17 -0700 Created attachment 319811 Patch 1345150 7 darin 2017-09-03 22:24:30 -0700 Passing all EWS now. Ready for someone to review. 1345179 8 319811 wenson_hsieh 2017-09-04 00:34:10 -0700 Comment on attachment 319811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319811&action=review > Tools/ChangeLog:9 > + video controls to appear. With changes to how loading occurrs, it can now Nit - occurrs => occurs > Tools/ChangeLog:13 > + changing the tests to wait one more run loop should get rid of the flakiness. In the longer term, I think it makes more sense for some of these tests to expect media controls to show up eventually, instead of expecting them after a "playing" message sent after a 0-delay timer in the web process. As you noted, there isn't a guarantee of how many run loop cycles it would take for the web process to be in a state where it wants to show media controls, nor should there be, since touch bar presence for media elements isn't web/API exposed. 1345222 9 darin 2017-09-04 09:27:41 -0700 Committed r221589: <http://trac.webkit.org/changeset/221589> 1353662 10 webkit-bug-importer 2017-09-27 12:48:20 -0700 <rdar://problem/34694057> 319811 2017-09-03 15:31:17 -0700 2019-01-15 17:10:15 -0800 Patch bug-175329-20170903153117.patch text/plain 6655 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGQ3ZWFiZjdhZmJhOTgwZDU4NDQ3ODc2MWRkZTVhNGUy MWYzOTQwNy4uZDE0NDllZTlhNjJiMTVkMjhmYjRlMmE2ZWMwYjRlYzU3YzRiZTEyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE3LTA5LTAzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMjIwMDUyKTogW1NpZXJyYV0gQVBJIHRlc3QgVmlkZW9Db250cm9sc01h bmFnZXIuVmlkZW9Db250cm9sc01hbmFnZXJGdWxsU2l6ZVZpZGVvSW5XaWRlTWFpbkZyYW1lIGlz IGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc1MzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlc2UgdGVzdHMgcmVseSBvbiB1c2luZyBzZXRUaW1lb3V0IHRvIHdhaXQgYSBy dW4gbG9vcCBpdGVyYXRpb24gZm9yIHRoZQorICAgICAgICB2aWRlbyBjb250cm9scyB0byBhcHBl YXIuIFdpdGggY2hhbmdlcyB0byBob3cgbG9hZGluZyBvY2N1cnJzLCBpdCBjYW4gbm93CisgICAg ICAgIHRha2UgdHdvIHJ1biBsb29wIGl0ZXJhdGlvbnMuIFRoZSBjb25jZXB0IGhlcmUgaXMgaW5o ZXJlbnRseSBhIGJpdCBmbGFreQorICAgICAgICBhbmQgcmFjeSAtLSBlbmQgdXNlcnMgd2lsbCBu b3QgYmUgYWJsZSB0byB0ZWxsIGhvdyBtYW55IHJ1biBsb29wIGN5Y2xlcyBpdAorICAgICAgICB0 YWtlcyBmb3IgY29udHJvbHMgdG8gY29tZSB1cCwgYW5kIHdlYnNpdGVzIGNhbid0IHRlbGwgZWl0 aGVyIC0tIGJ1dCBmb3Igbm93CisgICAgICAgIGNoYW5naW5nIHRoZSB0ZXN0cyB0byB3YWl0IG9u ZSBtb3JlIHJ1biBsb29wIHNob3VsZCBnZXQgcmlkIG9mIHRoZSBmbGFraW5lc3MuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1ZpZGVvQ29udHJvbHNNYW5hZ2Vy Lm1tOiBSZS1lbmFibGUgdGVzdC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvZnVsbC1zaXplLWF1dG9wbGF5aW5nLXZpZGVvLXdpdGgtYXVkaW8uaHRtbDogQWRk IGEKKyAgICAgICAgc2Vjb25kIHNldFRpbWVvdXQgYW5kIGEgY29tbWVudC4KKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL3NraW5ueS1hdXRvcGxheWluZy12aWRlby13 aXRoLWF1ZGlvLmh0bWw6IERpdHRvLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2Evd2lkZS1hdXRvcGxheWluZy12aWRlby13aXRoLWF1ZGlvLmh0bWw6IERpdHRvLgor CiAyMDE3LTA5LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg SGF2ZSBnZXRGaWxlTWV0YWRhdGEoKSByZXR1cm4gYSBzdGQ6Om9wdGlvbmFsPEZpbGVNZXRhZGF0 YT4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVmlk ZW9Db250cm9sc01hbmFnZXIubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL1ZpZGVvQ29udHJvbHNNYW5hZ2VyLm1tCmluZGV4IGQyOGNiZWM2ZDU5ODBhNzQxNjI1N2Zl YTA5N2JjZjBiN2EyZmFjZDQuLmM2ZGMwMDkwMzY2ZWVhMmFmYTlmOWI5OWVmNGI4NjI1YzcwYWVi YjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVmlk ZW9Db250cm9sc01hbmFnZXIubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9WaWRlb0NvbnRyb2xzTWFuYWdlci5tbQpAQCAtNDMyLDggKzQzMiw3IEBAIFRFU1Qo VmlkZW9Db250cm9sc01hbmFnZXIsIFZpZGVvQ29udHJvbHNNYW5hZ2VyTG9uZ1NraW5ueVZpZGVv SW5XaWRlTWFpbkZyYW1lKQogICAgIFt3ZWJWaWV3IGV4cGVjdENvbnRyb2xzTWFuYWdlcjpOTyBh ZnRlclJlY2VpdmluZ01lc3NhZ2U6QCJwbGF5aW5nIl07CiB9CiAKLS8vIEZJWE1FOiBSZS1lbmFi bGUgdGhpcyB0ZXN0IG9uY2UgPHdlYmtpdC5vcmcvYi8xNzUzMjk+IGlzIHJlc29sdmVkLgotVEVT VChWaWRlb0NvbnRyb2xzTWFuYWdlciwgRElTQUJMRURfVmlkZW9Db250cm9sc01hbmFnZXJXaWRl TWVkaXVtU2l6ZWRWaWRlb0luV2lkZU1haW5GcmFtZSkKK1RFU1QoVmlkZW9Db250cm9sc01hbmFn ZXIsIFZpZGVvQ29udHJvbHNNYW5hZ2VyV2lkZU1lZGl1bVNpemVkVmlkZW9JbldpZGVNYWluRnJh bWUpCiB7CiAgICAgUmV0YWluUHRyPFZpZGVvQ29udHJvbHNNYW5hZ2VyVGVzdFdlYlZpZXcqPiB3 ZWJWaWV3ID0gc2V0VXBXZWJWaWV3Rm9yVGVzdGluZ1ZpZGVvQ29udHJvbHNNYW5hZ2VyKE5TTWFr ZVJlY3QoMCwgMCwgMTYwMCwgODAwKSk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvZnVsbC1zaXplLWF1dG9wbGF5aW5nLXZpZGVvLXdpdGgtYXVk aW8uaHRtbCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvZnVsbC1zaXpl LWF1dG9wbGF5aW5nLXZpZGVvLXdpdGgtYXVkaW8uaHRtbAppbmRleCA0ODMwMWU2MzA1NDA1OGNj Y2MwY2E5YTY1OWFkNzEzMDgwOWE5N2UzLi44NjRlZDAyODU0NzNlODhmMGY2NDg5OGM4NmMwMzg4 ZTgzOTY5Yzc3IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL2Z1bGwtc2l6ZS1hdXRvcGxheWluZy12aWRlby13aXRoLWF1ZGlvLmh0bWwKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9mdWxsLXNpemUtYXV0b3BsYXlpbmct dmlkZW8td2l0aC1hdWRpby5odG1sCkBAIC04LDE0ICs4LDE4IEBACiAgICAgICAgIH0KICAgICA8 L3N0eWxlPgogICAgIDxzY3JpcHQ+Ci0gICAgZnVuY3Rpb24gZmluaXNoVGVzdCgpIHsKLSAgICAg ICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHRyeSB7Ci0gICAgICAgICAg ICAgICAgd2luZG93LndlYmtpdC5tZXNzYWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1lc3Nh Z2UoInBsYXlpbmciKTsKLSAgICAgICAgICAgIH0gY2F0Y2goZSkgeyB9Ci0gICAgICAgIH0sIDAp OwotICAgIH0KLSAgIDwvc2NyaXB0PgorICAgICAgICBmdW5jdGlvbiBmaW5pc2hUZXN0KCkKKyAg ICAgICAgeworICAgICAgICAgICAgLy8gQXMgb2YgdGhpcyB3cml0aW5nLCB0d28gdGltZXMgdGhy b3VnaCB0aGUgcnVuIGxvb3AgaXMgbG9uZyBlbm91Z2ggZm9yIHRoZSBjb250cm9scyB0byBjb21l IHVwLgorICAgICAgICAgICAgLy8gVGhlcmUncyBubyBndWFyYW50ZWU7IHdoZXRoZXIgdGhlIGNv bnRyb2xzIGFyZSB2aXNpYmxlIGlzIG5vdCB3ZWIgZXhwb3NlZCwgc28gaXQgZG9lc24ndCBoYXZl CisgICAgICAgICAgICAvLyB0byBoYXBwZW4gaW4gYSBjZXJ0YWluIG51bWJlciBvZiB0aW1lb3V0 cy4KKyAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAg c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgd2Via2l0Lm1lc3Nh Z2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgicGxheWluZyIpOworICAgICAgICAg ICAgICAgIH0sIDApOworICAgICAgICAgICAgfSwgMCk7CisgICAgICAgIH0KKyAgICA8L3Njcmlw dD4KIDwvaGVhZD4KIDxib2R5PgogICAgIDx2aWRlbyBhdXRvcGxheSBzcmM9InZpZGVvLXdpdGgt YXVkaW8ubXA0IiB3ZWJraXQtcGxheXNpbmxpbmUgb25wbGF5aW5nPWZpbmlzaFRlc3QoKT48L3Zp ZGVvPgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9z a2lubnktYXV0b3BsYXlpbmctdmlkZW8td2l0aC1hdWRpby5odG1sIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9za2lubnktYXV0b3BsYXlpbmctdmlkZW8td2l0aC1hdWRp by5odG1sCmluZGV4IDI2ZWY1M2RjMjM0Y2MyYmZkM2FjMTk3N2Q5MjI5NTA1ZjUwNjBlNmUuLmNi MzM5YWRiYTdmZmJmZDAyYWQ1MDVjMzUxNjhmNzg4Y2EwNDRmMDYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Evc2tpbm55LWF1dG9wbGF5aW5nLXZpZGVv LXdpdGgtYXVkaW8uaHRtbAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL3NraW5ueS1hdXRvcGxheWluZy12aWRlby13aXRoLWF1ZGlvLmh0bWwKQEAgLTgsMTQgKzgs MTggQEAKICAgICAgICAgfQogICAgIDwvc3R5bGU+CiAgICAgPHNjcmlwdD4KLSAgICBmdW5jdGlv biBmaW5pc2hUZXN0KCkgewotICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewotICAgICAg ICAgICAgdHJ5IHsKLSAgICAgICAgICAgICAgICB3aW5kb3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVy cy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgicGxheWluZyIpOwotICAgICAgICAgICAgfSBjYXRj aChlKSB7IH0KLSAgICAgICAgfSwgMCk7Ci0gICAgfQotICAgPC9zY3JpcHQ+CisgICAgICAgIGZ1 bmN0aW9uIGZpbmlzaFRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICAvLyBBcyBvZiB0aGlz IHdyaXRpbmcsIHR3byB0aW1lcyB0aHJvdWdoIHRoZSBydW4gbG9vcCBpcyBsb25nIGVub3VnaCBm b3IgdGhlIGNvbnRyb2xzIHRvIGNvbWUgdXAuCisgICAgICAgICAgICAvLyBUaGVyZSdzIG5vIGd1 YXJhbnRlZTsgd2hldGhlciB0aGUgY29udHJvbHMgYXJlIHZpc2libGUgaXMgbm90IHdlYiBleHBv c2VkLCBzbyBpdCBkb2Vzbid0IGhhdmUKKyAgICAgICAgICAgIC8vIHRvIGhhcHBlbiBpbiBhIGNl cnRhaW4gbnVtYmVyIG9mIHRpbWVvdXRzLgorICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlv bigpIHsKKyAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICAg ICAgICAgICAgICB3ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5kbGVyLnBvc3RNZXNzYWdl KCJwbGF5aW5nIik7CisgICAgICAgICAgICAgICAgfSwgMCk7CisgICAgICAgICAgICB9LCAwKTsK KyAgICAgICAgfQorICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CiAgICAgPHZpZGVvIGF1 dG9wbGF5IHNyYz0idmlkZW8td2l0aC1hdWRpby5tcDQiIHdlYmtpdC1wbGF5c2lubGluZSBvbnBs YXlpbmc9ZmluaXNoVGVzdCgpPjwvdmlkZW8+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL3dpZGUtYXV0b3BsYXlpbmctdmlkZW8td2l0aC1hdWRpby5o dG1sIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS93aWRlLWF1dG9wbGF5 aW5nLXZpZGVvLXdpdGgtYXVkaW8uaHRtbAppbmRleCBlYTJjYjUwNjMyMzBhNzZkMzJlNmM2NzVj OThhNTczYTRkZmFjNWVlLi45NzdjODM2NWVmODUwNTgxYzM4OTIxY2E5M2FmMjU5MjYwMjMwNjM1 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL3dpZGUt YXV0b3BsYXlpbmctdmlkZW8td2l0aC1hdWRpby5odG1sCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2Evd2lkZS1hdXRvcGxheWluZy12aWRlby13aXRoLWF1ZGlvLmh0 bWwKQEAgLTgsMTQgKzgsMTggQEAKICAgICAgICAgfQogICAgIDwvc3R5bGU+CiAgICAgPHNjcmlw dD4KLSAgICBmdW5jdGlvbiBmaW5pc2hUZXN0KCkgewotICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0 aW9uKCkgewotICAgICAgICAgICAgdHJ5IHsKLSAgICAgICAgICAgICAgICB3aW5kb3cud2Via2l0 Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgicGxheWluZyIpOwotICAg ICAgICAgICAgfSBjYXRjaChlKSB7IH0KLSAgICAgICAgfSwgMCk7Ci0gICAgfQotICAgPC9zY3Jp cHQ+CisgICAgICAgIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKQorICAgICAgICB7CisgICAgICAgICAg ICAvLyBBcyBvZiB0aGlzIHdyaXRpbmcsIHR3byB0aW1lcyB0aHJvdWdoIHRoZSBydW4gbG9vcCBp cyBsb25nIGVub3VnaCBmb3IgdGhlIGNvbnRyb2xzIHRvIGNvbWUgdXAuCisgICAgICAgICAgICAv LyBUaGVyZSdzIG5vIGd1YXJhbnRlZTsgd2hldGhlciB0aGUgY29udHJvbHMgYXJlIHZpc2libGUg aXMgbm90IHdlYiBleHBvc2VkLCBzbyBpdCBkb2Vzbid0IGhhdmUKKyAgICAgICAgICAgIC8vIHRv IGhhcHBlbiBpbiBhIGNlcnRhaW4gbnVtYmVyIG9mIHRpbWVvdXRzLgorICAgICAgICAgICAgc2V0 VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9u KCkgeworICAgICAgICAgICAgICAgICAgICB3ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5k bGVyLnBvc3RNZXNzYWdlKCJwbGF5aW5nIik7CisgICAgICAgICAgICAgICAgfSwgMCk7CisgICAg ICAgICAgICB9LCAwKTsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+ CiAgICAgPHZpZGVvIGF1dG9wbGF5IHNyYz0idmlkZW8td2l0aC1hdWRpby5tcDQiIHdlYmtpdC1w bGF5c2lubGluZSBvbnBsYXlpbmc9ZmluaXNoVGVzdCgpPjwvdmlkZW8+Cg==