175323 2017-08-08 07:37:07 -0700 [GStreamer][MSE] Add missing lock around getStreamByTrackId 2017-08-09 10:23:21 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply calvaris commit-queue eocanha zan oldest_to_newest 1336470 0 cturner 2017-08-08 07:37:07 -0700 This fixes several tests that were crashing (but not accounted for in gardening) in Debug builds when the track queues were being modified concurrently by separate threads. 1336472 1 317569 cturner 2017-08-08 07:41:16 -0700 Created attachment 317569 Patch 1336473 2 317570 cturner 2017-08-08 07:42:14 -0700 Created attachment 317570 Patch 1337021 3 317570 commit-queue 2017-08-09 10:23:19 -0700 Comment on attachment 317570 Patch Clearing flags on attachment: 317570 Committed r220461: <http://trac.webkit.org/changeset/220461> 1337022 4 commit-queue 2017-08-09 10:23:21 -0700 All reviewed patches have been landed. Closing bug. 317569 2017-08-08 07:41:16 -0700 2017-08-08 07:42:11 -0700 Patch bug-175323-20170808154115.patch text/plain 1719 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNkNjJjMmRhYzFmOGRk YjY2ZmM3NmE4YTQxMjhiODJlOGMyZGNhOS4uMjY2MGI1ODZmZDlkZDEyYzcxOGZmNzA1NjNkODU0 YjdjYzQ1NmY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTA4ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtN U0VdIEFkZCBtaXNzaW5nIGxvY2sgYXJvdW5kIGdldFN0cmVhbUJ5VHJhY2tJZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MzIzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvUGxh eWJhY2tQaXBlbGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1BpcGVsaW5lOjpl bnF1ZXVlU2FtcGxlKTogRW5zdXJlIHRoZSBtZWRpYSBzb3VyY2UKKyAgICAgICAgbG9jayBpcyB0 YWtlbiBiZWZvcmUgbW9kaWZpeWluZyB0aGUgdHJhY2sgcXVldWVzIGluZGlyZWN0bHkgdmlhIHRo ZQorICAgICAgICBpdGVyYXRvciB1c2UgaW4gZ2V0VHJhY2tJZC4KKwogMjAxNy0wOC0wMyAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCA6Om1hcmtl ciBwc2V1ZG8tZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvUGxheWJhY2tQaXBlbGluZS5jcHAKaW5k ZXggOGEyZmY0M2FjYWJiMmI5ZDA5N2JiMjJlMjVhNjM2YmFhYWVmOWZkYS4uM2ZlNjJjZjU5NzNm NDVkYzU2ZjNlNjUyNmM4NGVjMDM5OWI0OTg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1BsYXliYWNr UGlwZWxpbmUuY3BwCkBAIC00ODgsNiArNDg4LDcgQEAgdm9pZCBQbGF5YmFja1BpcGVsaW5lOjpl bnF1ZXVlU2FtcGxlKFJlZjxNZWRpYVNhbXBsZT4mJiBtZWRpYVNhbXBsZSkKICAgICAgICAgR1NU X1RJTUVfQVJHUyhXZWJDb3JlOjp0b0dzdENsb2NrVGltZShtZWRpYVNhbXBsZS0+cHJlc2VudGF0 aW9uVGltZSgpLnRvRG91YmxlKCkpKSwKICAgICAgICAgR1NUX1RJTUVfQVJHUyhXZWJDb3JlOjp0 b0dzdENsb2NrVGltZShtZWRpYVNhbXBsZS0+ZHVyYXRpb24oKS50b0RvdWJsZSgpKSkpOwogCisg ICAgV1RGOjpHTXV0ZXhMb2NrZXI8R011dGV4PiBsb2NrZXIoKkdTVF9PQkpFQ1RfR0VUX0xPQ0so bV93ZWJLaXRNZWRpYVNyYy5nZXQoKSkpOwogICAgIFN0cmVhbSogc3RyZWFtID0gZ2V0U3RyZWFt QnlUcmFja0lkKG1fd2ViS2l0TWVkaWFTcmMuZ2V0KCksIHRyYWNrSWQpOwogCiAgICAgaWYgKCFz dHJlYW0pIHsK 317570 2017-08-08 07:42:14 -0700 2017-08-09 10:23:19 -0700 Patch bug-175323-20170808154213.patch text/plain 1719 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNkNjJjMmRhYzFmOGRk YjY2ZmM3NmE4YTQxMjhiODJlOGMyZGNhOS4uMjY2MGI1ODZmZDlkZDEyYzcxOGZmNzA1NjNkODU0 YjdjYzQ1NmY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTA4ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtN U0VdIEFkZCBtaXNzaW5nIGxvY2sgYXJvdW5kIGdldFN0cmVhbUJ5VHJhY2tJZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MzIzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvUGxh eWJhY2tQaXBlbGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1BpcGVsaW5lOjpl bnF1ZXVlU2FtcGxlKTogRW5zdXJlIHRoZSBtZWRpYSBzb3VyY2UKKyAgICAgICAgbG9jayBpcyB0 YWtlbiBiZWZvcmUgbW9kaWZpeWluZyB0aGUgdHJhY2sgcXVldWVzIGluZGlyZWN0bHkgdmlhIHRo ZQorICAgICAgICBpdGVyYXRvciB1c2UgaW4gZ2V0VHJhY2tJZC4KKwogMjAxNy0wOC0wMyAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCA6Om1hcmtl ciBwc2V1ZG8tZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvUGxheWJhY2tQaXBlbGluZS5jcHAKaW5k ZXggOGEyZmY0M2FjYWJiMmI5ZDA5N2JiMjJlMjVhNjM2YmFhYWVmOWZkYS4uM2ZlNjJjZjU5NzNm NDVkYzU2ZjNlNjUyNmM4NGVjMDM5OWI0OTg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1BsYXliYWNr UGlwZWxpbmUuY3BwCkBAIC00ODgsNiArNDg4LDcgQEAgdm9pZCBQbGF5YmFja1BpcGVsaW5lOjpl bnF1ZXVlU2FtcGxlKFJlZjxNZWRpYVNhbXBsZT4mJiBtZWRpYVNhbXBsZSkKICAgICAgICAgR1NU X1RJTUVfQVJHUyhXZWJDb3JlOjp0b0dzdENsb2NrVGltZShtZWRpYVNhbXBsZS0+cHJlc2VudGF0 aW9uVGltZSgpLnRvRG91YmxlKCkpKSwKICAgICAgICAgR1NUX1RJTUVfQVJHUyhXZWJDb3JlOjp0 b0dzdENsb2NrVGltZShtZWRpYVNhbXBsZS0+ZHVyYXRpb24oKS50b0RvdWJsZSgpKSkpOwogCisg ICAgV1RGOjpHTXV0ZXhMb2NrZXI8R011dGV4PiBsb2NrZXIoKkdTVF9PQkpFQ1RfR0VUX0xPQ0so bV93ZWJLaXRNZWRpYVNyYy5nZXQoKSkpOwogICAgIFN0cmVhbSogc3RyZWFtID0gZ2V0U3RyZWFt QnlUcmFja0lkKG1fd2ViS2l0TWVkaWFTcmMuZ2V0KCksIHRyYWNrSWQpOwogCiAgICAgaWYgKCFz dHJlYW0pIHsK