175307 2017-08-07 17:01:37 -0700 GetOwnProperty of TypedArray indexed fields is wrongly configurable 2017-08-07 19:30:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 1 rmorisset rmorisset buildbot commit-queue keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1336264 0 rmorisset 2017-08-07 17:01:37 -0700 ``` let a = new Uint8TypedArray(10); let b = Object.getOwnPropertyDescriptor(a, 0); assert(b.configurable === false); ``` should not fail: by section 9.4.5.1 (https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-getownproperty-p) that applies to integer indexed exotic objects, and section 22.2.7 (https://tc39.github.io/ecma262/#sec-properties-of-typedarray-instances) that says that typed arrays are integer indexed exotic objects. 1336273 1 317516 rmorisset 2017-08-07 17:16:41 -0700 Created attachment 317516 Patch 1336276 2 buildbot 2017-08-07 17:19:43 -0700 Attachment 317516 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1336277 3 317518 rmorisset 2017-08-07 17:21:27 -0700 Created attachment 317518 Patch without the tab character 1336295 4 saam 2017-08-07 17:45:10 -0700 r=me 1336316 5 317518 commit-queue 2017-08-07 19:29:46 -0700 Comment on attachment 317518 Patch without the tab character Clearing flags on attachment: 317518 Committed r220377: <http://trac.webkit.org/changeset/220377> 1336317 6 commit-queue 2017-08-07 19:29:47 -0700 All reviewed patches have been landed. Closing bug. 317516 2017-08-07 17:16:41 -0700 2017-08-07 17:21:27 -0700 Patch patch_175307 text/plain 3429 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjAzNzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgR2V0T3duUHJvcGVydHkgb2YgVHlwZWRBcnJheSBpbmRleGVk IGZpZWxkcyBpcyB3cm9uZ2x5IGNvbmZpZ3VyYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvdHlwZWRhcnJheS1nZXRvd25wcm9wZXJ0 eS1ub3QtY29uZmlndXJhYmxlLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAg IChmb28pOgorCiAyMDE3LTA4LTA2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFByb21pc2UgcmVzb2x2ZSBhbmQgcmVqZWN0IGZ1bmN0aW9uIHNob3Vs ZCBoYXZlIGxlbmd0aCA9IDEKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3R5cGVkYXJyYXktZ2V0b3du cHJvcGVydHktbm90LWNvbmZpZ3VyYWJsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVz cy90eXBlZGFycmF5LWdldG93bnByb3BlcnR5LW5vdC1jb25maWd1cmFibGUuanMJKG5vbmV4aXN0 ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1nZXRvd25wcm9wZXJ0eS1ub3QtY29u ZmlndXJhYmxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjAgQEAKK3R5cGVkQXJyYXlz ID0gW0ludDhBcnJheSwgVWludDhBcnJheSwgVWludDhDbGFtcGVkQXJyYXksIEludDE2QXJyYXks IFVpbnQxNkFycmF5LCBJbnQzMkFycmF5LCBVaW50MzJBcnJheSwgRmxvYXQzMkFycmF5LCBGbG9h dDY0QXJyYXldOworCitmdW5jdGlvbiBhc3NlcnQoY29uZCkgeworICAgIGlmICghY29uZCkKKyAg ICAgICAgdGhyb3cgbmV3IEVycm9yKCJiYWQgYXNzZXJ0aW9uISIpOworfQorCitmdW5jdGlvbiBm b28oKSB7CisgICAgZm9yIChjb25zdHJ1Y3RvciBvZiB0eXBlZEFycmF5cykgeworICAgICAgICBs ZXQgYSA9IG5ldyBjb25zdHJ1Y3RvcigxMCk7CisgICAgICAgIGxldCBiID0gT2JqZWN0LmdldE93 blByb3BlcnR5RGVzY3JpcHRvcihhLCAwKTsKKyAgICAgICAgYXNzZXJ0KGIudmFsdWUgPT09IDAp OworICAgICAgICBhc3NlcnQoYi53cml0YWJsZSA9PT0gZmFsc2UpOworICAgICAgICBhc3NlcnQo Yi5lbnVtZXJhYmxlID09PSB0cnVlKTsKKyAgICAgICAgYXNzZXJ0KGIuY29uZmlndXJhYmxlID09 PSBmYWxzZSk7CisgICAgfQorfQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEwMDsgaSsrKQorICAg IGZvbygpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjAzNTIpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjIgQEAKKzIwMTctMDgtMDcgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNv bT4KKworICAgICAgICBHZXRPd25Qcm9wZXJ0eSBvZiBUeXBlZEFycmF5IGluZGV4ZWQgZmllbGRz IGlzIHdyb25nbHkgY29uZmlndXJhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzUzMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKwkKKyAgICAgICAgYGBgCisgICAgICAgIGxldCBhID0gbmV3IFVpbnQ4QXJyYXkoMTAp OworICAgICAgICBsZXQgYiA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoYSwgMCk7 CisgICAgICAgIGFzc2VydChiLmNvbmZpZ3VyYWJsZSA9PT0gZmFsc2UpOworICAgICAgICBgYGAK KyAgICAgICAgc2hvdWxkIG5vdCBmYWlsOiBieSBzZWN0aW9uIDkuNC41LjEgKGh0dHBzOi8vdGMz OS5naXRodWIuaW8vZWNtYTI2Mi8jc2VjLWludGVnZXItaW5kZXhlZC1leG90aWMtb2JqZWN0cy1n ZXRvd25wcm9wZXJ0eS1wKSAKKyAgICAgICAgdGhhdCBhcHBsaWVzIHRvIGludGVnZXIgaW5kZXhl ZCBleG90aWMgb2JqZWN0cywgYW5kIHNlY3Rpb24gMjIuMi43IChodHRwczovL3RjMzkuZ2l0aHVi LmlvL2VjbWEyNjIvI3NlYy1wcm9wZXJ0aWVzLW9mLXR5cGVkYXJyYXktaW5zdGFuY2VzKQorICAg ICAgICB0aGF0IHNheXMgdGhhdCB0eXBlZCBhcnJheXMgYXJlIGludGVnZXIgaW5kZXhlZCBleG90 aWMgb2JqZWN0cy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZpZXdJ bmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpTR2VuZXJpY1R5cGVkQXJyYXlWaWV3PEFkYXB0b3I+ OjpnZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4KToKKwogMjAxNy0wOC0wNiAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFByaW1pdGl2ZSBhdXhpbGlhcmllcyBhbmQg SlNWYWx1ZSBhdXhpbGlhcmllcyBzaG91bGQgaGF2ZSBzZXBhcmF0ZSBnaWdhY2FnZXMKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3SW5s aW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2Vu ZXJpY1R5cGVkQXJyYXlWaWV3SW5saW5lcy5oCShyZXZpc2lvbiAyMjAzNTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0lubGluZXMuaAko d29ya2luZyBjb3B5KQpAQCAtNDU4LDcgKzQ1OCw3IEBAIGJvb2wgSlNHZW5lcmljVHlwZWRBcnJh eVZpZXc8QWRhcHRvcj46OmcKICAgICBpZiAoIXRoaXNPYmplY3QtPmNhbkdldEluZGV4UXVpY2ts eShwcm9wZXJ0eU5hbWUpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgc2xvdC5z ZXRWYWx1ZSh0aGlzT2JqZWN0LCBOb25lLCB0aGlzT2JqZWN0LT5nZXRJbmRleFF1aWNrbHkocHJv cGVydHlOYW1lKSk7CisgICAgc2xvdC5zZXRWYWx1ZSh0aGlzT2JqZWN0LCBEb250RGVsZXRlLCB0 aGlzT2JqZWN0LT5nZXRJbmRleFF1aWNrbHkocHJvcGVydHlOYW1lKSk7CiAgICAgcmV0dXJuIHRy dWU7CiB9CiAK 317518 2017-08-07 17:21:27 -0700 2017-08-07 19:29:46 -0700 Patch without the tab character patch_175307 text/plain 3428 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjAzNzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgR2V0T3duUHJvcGVydHkgb2YgVHlwZWRBcnJheSBpbmRleGVk IGZpZWxkcyBpcyB3cm9uZ2x5IGNvbmZpZ3VyYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvdHlwZWRhcnJheS1nZXRvd25wcm9wZXJ0 eS1ub3QtY29uZmlndXJhYmxlLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAg IChmb28pOgorCiAyMDE3LTA4LTA2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFByb21pc2UgcmVzb2x2ZSBhbmQgcmVqZWN0IGZ1bmN0aW9uIHNob3Vs ZCBoYXZlIGxlbmd0aCA9IDEKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3R5cGVkYXJyYXktZ2V0b3du cHJvcGVydHktbm90LWNvbmZpZ3VyYWJsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVz cy90eXBlZGFycmF5LWdldG93bnByb3BlcnR5LW5vdC1jb25maWd1cmFibGUuanMJKG5vbmV4aXN0 ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1nZXRvd25wcm9wZXJ0eS1ub3QtY29u ZmlndXJhYmxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjAgQEAKK3R5cGVkQXJyYXlz ID0gW0ludDhBcnJheSwgVWludDhBcnJheSwgVWludDhDbGFtcGVkQXJyYXksIEludDE2QXJyYXks IFVpbnQxNkFycmF5LCBJbnQzMkFycmF5LCBVaW50MzJBcnJheSwgRmxvYXQzMkFycmF5LCBGbG9h dDY0QXJyYXldOworCitmdW5jdGlvbiBhc3NlcnQoY29uZCkgeworICAgIGlmICghY29uZCkKKyAg ICAgICAgdGhyb3cgbmV3IEVycm9yKCJiYWQgYXNzZXJ0aW9uISIpOworfQorCitmdW5jdGlvbiBm b28oKSB7CisgICAgZm9yIChjb25zdHJ1Y3RvciBvZiB0eXBlZEFycmF5cykgeworICAgICAgICBs ZXQgYSA9IG5ldyBjb25zdHJ1Y3RvcigxMCk7CisgICAgICAgIGxldCBiID0gT2JqZWN0LmdldE93 blByb3BlcnR5RGVzY3JpcHRvcihhLCAwKTsKKyAgICAgICAgYXNzZXJ0KGIudmFsdWUgPT09IDAp OworICAgICAgICBhc3NlcnQoYi53cml0YWJsZSA9PT0gZmFsc2UpOworICAgICAgICBhc3NlcnQo Yi5lbnVtZXJhYmxlID09PSB0cnVlKTsKKyAgICAgICAgYXNzZXJ0KGIuY29uZmlndXJhYmxlID09 PSBmYWxzZSk7CisgICAgfQorfQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEwMDsgaSsrKQorICAg IGZvbygpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjAzNTIpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjIgQEAKKzIwMTctMDgtMDcgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNv bT4KKworICAgICAgICBHZXRPd25Qcm9wZXJ0eSBvZiBUeXBlZEFycmF5IGluZGV4ZWQgZmllbGRz IGlzIHdyb25nbHkgY29uZmlndXJhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzUzMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBgYGAKKyAgICAgICAgbGV0IGEgPSBuZXcgVWludDhBcnJheSgxMCk7 CisgICAgICAgIGxldCBiID0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihhLCAwKTsK KyAgICAgICAgYXNzZXJ0KGIuY29uZmlndXJhYmxlID09PSBmYWxzZSk7CisgICAgICAgIGBgYAor ICAgICAgICBzaG91bGQgbm90IGZhaWw6IGJ5IHNlY3Rpb24gOS40LjUuMSAoaHR0cHM6Ly90YzM5 LmdpdGh1Yi5pby9lY21hMjYyLyNzZWMtaW50ZWdlci1pbmRleGVkLWV4b3RpYy1vYmplY3RzLWdl dG93bnByb3BlcnR5LXApIAorICAgICAgICB0aGF0IGFwcGxpZXMgdG8gaW50ZWdlciBpbmRleGVk IGV4b3RpYyBvYmplY3RzLCBhbmQgc2VjdGlvbiAyMi4yLjcgKGh0dHBzOi8vdGMzOS5naXRodWIu aW8vZWNtYTI2Mi8jc2VjLXByb3BlcnRpZXMtb2YtdHlwZWRhcnJheS1pbnN0YW5jZXMpCisgICAg ICAgIHRoYXQgc2F5cyB0aGF0IHR5cGVkIGFycmF5cyBhcmUgaW50ZWdlciBpbmRleGVkIGV4b3Rp YyBvYmplY3RzLgorCisgICAgICAgICogcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0lu bGluZXMuaDoKKyAgICAgICAgKEpTQzo6SlNHZW5lcmljVHlwZWRBcnJheVZpZXc8QWRhcHRvcj46 OmdldE93blByb3BlcnR5U2xvdEJ5SW5kZXgpOgorCiAyMDE3LTA4LTA2ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUHJpbWl0aXZlIGF1eGlsaWFyaWVzIGFuZCBK U1ZhbHVlIGF1eGlsaWFyaWVzIHNob3VsZCBoYXZlIHNlcGFyYXRlIGdpZ2FjYWdlcwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZpZXdJbmxp bmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5l cmljVHlwZWRBcnJheVZpZXdJbmxpbmVzLmgJKHJldmlzaW9uIDIyMDM1MikKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3SW5saW5lcy5oCSh3 b3JraW5nIGNvcHkpCkBAIC00NTgsNyArNDU4LDcgQEAgYm9vbCBKU0dlbmVyaWNUeXBlZEFycmF5 VmlldzxBZGFwdG9yPjo6ZwogICAgIGlmICghdGhpc09iamVjdC0+Y2FuR2V0SW5kZXhRdWlja2x5 KHByb3BlcnR5TmFtZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKLSAgICBzbG90LnNl dFZhbHVlKHRoaXNPYmplY3QsIE5vbmUsIHRoaXNPYmplY3QtPmdldEluZGV4UXVpY2tseShwcm9w ZXJ0eU5hbWUpKTsKKyAgICBzbG90LnNldFZhbHVlKHRoaXNPYmplY3QsIERvbnREZWxldGUsIHRo aXNPYmplY3QtPmdldEluZGV4UXVpY2tseShwcm9wZXJ0eU5hbWUpKTsKICAgICByZXR1cm4gdHJ1 ZTsKIH0KIAo=