175301 2017-08-07 16:22:35 -0700 Avoid a hash lookup in FilterInfo::remove() 2017-08-07 19:54:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino sam simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1336209 0 simon.fraser 2017-08-07 16:22:35 -0700 Avoid a hash lookup in FilterInfo::remove() 1336213 1 317493 simon.fraser 2017-08-07 16:23:30 -0700 Created attachment 317493 Patch 1336235 2 317493 sam 2017-08-07 16:39:45 -0700 Comment on attachment 317493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317493&action=review > Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75 > if (map().remove(&layer)) > layer.m_hasFilterInfo = false; Do you need to check the return value still? Seems like it will always return true now. 1336324 3 simon.fraser 2017-08-07 19:54:03 -0700 https://trac.webkit.org/r220380 1336330 4 webkit-bug-importer 2017-08-07 19:54:51 -0700 <rdar://problem/33768183> 317493 2017-08-07 16:23:30 -0700 2017-08-07 16:39:45 -0700 Patch bug-175301-20170807162330.patch text/plain 2026 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE3MWI4NzcyY2Q4NTIz NjkxMDkzZDcyZTE4NDM3MjdjMGVhMzVmYi4uMWRiZWZkYzUxZGFmMTA1OGQ4NWY4Y2RjODRlZTc1 YjBmN2YwZGVkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE3LTA4LTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEF2b2lkIGEgaGFz aCBsb29rdXAgaW4gRmlsdGVySW5mbzo6cmVtb3ZlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpbHRlckluZm86OnJlbW92ZSgpIGFsd2F5cyBjYWxs ZWQgbWFwKCkucmVtb3ZlKCZsYXllcikpLCBldmVuIHdoZW4gbGF5ZXIubV9oYXNGaWx0ZXJJbmZv CisgICAgICAgIHdhcyBmYWxzZSAoYW5kIGV2ZW4gYXNzZXJ0ZWQgdGhhdCBsYXllci5tX2hhc0Zp bHRlckluZm8gPT0gbWFwKCkuY29udGFpbnMoJmxheWVyKSkuCisKKyAgICAgICAgU28gd2UgY2Fu IGVhcmx5IHJldHVybiBpZiBsYXllci5tX2hhc0ZpbHRlckluZm8gaXMgZmFsc2UuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJGaWx0ZXJJbmZvLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyOjpGaWx0ZXJJbmZvOjpnZXRJZkV4aXN0cyk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllcjo6RmlsdGVySW5mbzo6cmVtb3ZlKToKKworMjAxNy0wOC0wNyAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBNYWtlIFRyYW5z Zm9ybU9wZXJhdGlvbjo6dHlwZSgpIG5vbi12aXJ0dWFsCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUyOTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyRmlsdGVySW5mby5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJGaWx0ZXJJbmZvLmNwcAppbmRleCA1ZTUxYWYzY2MxNDZh ODVmOTYzMGQ2Njc5MGFjY2VmMTFmYzg4NmYxLi5kMmE2Y2Y4ODE1YjQ4ZTY3N2VhN2I4MTIyYzI3 ZDg0ZDgxM2M2MWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJGaWx0ZXJJbmZvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJGaWx0ZXJJbmZvLmNwcApAQCAtNDksNyArNDksNyBAQCBSZW5kZXJMYXllcjo6RmlsdGVy SW5mbyogUmVuZGVyTGF5ZXI6OkZpbHRlckluZm86OmdldElmRXhpc3RzKGNvbnN0IFJlbmRlckxh eWVyJgogewogICAgIEFTU0VSVChsYXllci5tX2hhc0ZpbHRlckluZm8gPT0gbWFwKCkuY29udGFp bnMoJmxheWVyKSk7CiAKLSAgICByZXR1cm4gbGF5ZXIubV9oYXNGaWx0ZXJJbmZvID8gbWFwKCku Z2V0KCZsYXllcikgOiAwOworICAgIHJldHVybiBsYXllci5tX2hhc0ZpbHRlckluZm8gPyBtYXAo KS5nZXQoJmxheWVyKSA6IG51bGxwdHI7CiB9CiAKIFJlbmRlckxheWVyOjpGaWx0ZXJJbmZvJiBS ZW5kZXJMYXllcjo6RmlsdGVySW5mbzo6Z2V0KFJlbmRlckxheWVyJiBsYXllcikKQEAgLTY4LDYg KzY4LDkgQEAgdm9pZCBSZW5kZXJMYXllcjo6RmlsdGVySW5mbzo6cmVtb3ZlKFJlbmRlckxheWVy JiBsYXllcikKIHsKICAgICBBU1NFUlQobGF5ZXIubV9oYXNGaWx0ZXJJbmZvID09IG1hcCgpLmNv bnRhaW5zKCZsYXllcikpOwogCisgICAgaWYgKCFsYXllci5tX2hhc0ZpbHRlckluZm8pCisgICAg ICAgIHJldHVybjsKKwogICAgIGlmIChtYXAoKS5yZW1vdmUoJmxheWVyKSkKICAgICAgICAgbGF5 ZXIubV9oYXNGaWx0ZXJJbmZvID0gZmFsc2U7CiB9Cg==