175286 2017-08-07 14:23:06 -0700 check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions. 2017-08-07 16:26:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned buildbot commit-queue don.olmstead glenn lforschler mmaxfield webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1336127 0 yoshiaki.jitsukawa 2017-08-07 14:23:06 -0700 For example, the following code in Source/WebCore/platform/spi/cocoa/PassKitSPI.h causes a "Place brace on its own line for function definitions. [whitespace/braces] [4]" error typedef NS_ERROR_ENUM(PKPaymentErrorDomain, PKPaymentErrorCode) { PKPaymentUnknownError = -1, ... 1336136 1 yoshiaki.jitsukawa 2017-08-07 14:30:36 -0700 Moving platform/spi/cocoa/ into PAL will raise these kind of style errors so I'm fixing this in advance. 1336146 2 317469 yoshiaki.jitsukawa 2017-08-07 14:39:33 -0700 Created attachment 317469 Patch 1336166 3 yoshiaki.jitsukawa 2017-08-07 15:17:24 -0700 Thank you for your reviewing! 1336221 4 317469 commit-queue 2017-08-07 16:25:31 -0700 Comment on attachment 317469 Patch Clearing flags on attachment: 317469 Committed r220367: <http://trac.webkit.org/changeset/220367> 1336222 5 commit-queue 2017-08-07 16:25:33 -0700 All reviewed patches have been landed. Closing bug. 1336223 6 webkit-bug-importer 2017-08-07 16:26:12 -0700 <rdar://problem/33764837> 317469 2017-08-07 14:39:33 -0700 2017-08-07 16:25:31 -0700 Patch bug-175286-20170808063931.patch text/plain 3818 yoshiaki.jitsukawa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDM1MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA4LTA3ICBZb3NoaWFraSBKaXRzdWthd2EgIDxZb3NoaWFraS5KaXRz dWthd2FAc29ueS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBOU19FUlJPUl9F TlVNIGFuZCBOU19PUFRJT05TIHNob3VsZCBub3QgYmUgaGFuZGxlZCBhcyBmdW5jdGlvbiBkZWZp bml0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NTI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVj a19icmFjZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfYnJhY2VzLk5TX0VS Uk9SX0VOVU0pOgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfYnJhY2VzKToKKyAgICAg ICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X2JyYWNlcy5OU19PUFRJT05TKToKKwogMjAxNy0wOC0w NyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQ0FOVkFT X1BBVEggY29tcGlsYXRpb24gZ3VhcmQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5CShyZXZpc2lvbiAyMjAzNTEpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkod29ya2luZyBjb3B5KQpAQCAtMjQzMSw3 ICsyNDMxLDcgQEAgZGVmIGNoZWNrX2JyYWNlcyhjbGVhbl9saW5lcywgbGluZV9udW1iZQogICAg ICAgICAjIGFuZCAnLSAoJyBhbmQgJysgKCcgZm9yIE9iamVjdGl2ZS1DIG1ldGhvZHMuCiAgICAg ICAgIHByZXZpb3VzX2xpbmUgPSBnZXRfcHJldmlvdXNfbm9uX2JsYW5rX2xpbmUoY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyKVswXQogICAgICAgICBpZiAoKG5vdCBzZWFyY2gocidbOzp9eyk9XVxz KiR8XClccyooKGNvbnN0fG92ZXJyaWRlfGNvbnN0IG92ZXJyaWRlfGZpbmFsfGNvbnN0IGZpbmFs KVxzKik/KC0+XHMqXFMrKT9ccyokJywgcHJldmlvdXNfbGluZSkKLSAgICAgICAgICAgICBvciBz ZWFyY2gocidcYihpZnxmb3J8d2hpbGV8c3dpdGNofGVsc2V8TlNfRU5VTSlcYicsIHByZXZpb3Vz X2xpbmUpCisgICAgICAgICAgICAgb3Igc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRjaHxl bHNlfE5TX0VOVU18TlNfRVJST1JfRU5VTXxOU19PUFRJT05TKVxiJywgcHJldmlvdXNfbGluZSkK ICAgICAgICAgICAgICBvciByZWdleF9mb3JfbGFtYmRhc19hbmRfYmxvY2tzKHByZXZpb3VzX2xp bmUsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikpCiAgICAgICAgICAgICBhbmQgcHJl dmlvdXNfbGluZS5maW5kKCcjJykgPCAwCiAgICAgICAgICAgICBhbmQgcHJldmlvdXNfbGluZS5m aW5kKCctICgnKSAhPSAwCkBAIC0yNDQwLDcgKzI0NDAsNyBAQCBkZWYgY2hlY2tfYnJhY2VzKGNs ZWFuX2xpbmVzLCBsaW5lX251bWJlCiAgICAgICAgICAgICAgICAgICAnVGhpcyB7IHNob3VsZCBi ZSBhdCB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBsaW5lJykKICAgICBlbGlmIChzZWFyY2gocidc KVxzKigoKGNvbnN0fG92ZXJyaWRlfGZpbmFsKVxzKikqXHMqKT97XHMqJCcsIGxpbmUpCiAgICAg ICAgICAgYW5kIGxpbmUuY291bnQoJygnKSA9PSBsaW5lLmNvdW50KCcpJykKLSAgICAgICAgICBh bmQgbm90IHNlYXJjaChyJyhccyooaWZ8Zm9yfHdoaWxlfHN3aXRjaHxOU19FTlVNfEBzeW5jaHJv bml6ZWQpfH0gQGNhdGNoKVxiJywgbGluZSkKKyAgICAgICAgICBhbmQgbm90IHNlYXJjaChyJyhc cyooaWZ8Zm9yfHdoaWxlfHN3aXRjaHxOU19FTlVNfE5TX0VSUk9SX0VOVU18TlNfT1BUSU9OU3xA c3luY2hyb25pemVkKXx9IEBjYXRjaClcYicsIGxpbmUpCiAgICAgICAgICAgYW5kIG5vdCByZWdl eF9mb3JfbGFtYmRhc19hbmRfYmxvY2tzKGxpbmUsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBl cnJvcikKICAgICAgICAgICBhbmQgbGluZS5maW5kKCJdKCIpIDwgMAogICAgICAgICAgIGFuZCBu b3QgbWF0Y2gocidccytbQS1aX11bQS1aXzAtOV0rXGInLCBsaW5lKSk6CkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eQkocmV2aXNpb24gMjIwMzUxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ1MDQsNiArNDUwNCwzMCBA QCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAn ICAgIDFcbicKICAgICAgICAgICAgICd9OycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0 aV9saW5lX2xpbnQoCisgICAgICAgICAgICAndHlwZWRlZiBOU19FUlJPUl9FTlVNKE5TSW50ZWdl ciwgdHlwZSlcbicKKyAgICAgICAgICAgICd7XG4nCisgICAgICAgICAgICAnICAgIDAsXG4nCisg ICAgICAgICAgICAnICAgIDFcbicKKyAgICAgICAgICAgICd9OycsCisgICAgICAgICAgICAnVGhp cyB7IHNob3VsZCBiZSBhdCB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBsaW5lICBbd2hpdGVzcGFj ZS9icmFjZXNdIFs0XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAg ICAgICAgICAgICd0eXBlZGVmIE5TX0VSUk9SX0VOVU0oTlNJbnRlZ2VyLCB0eXBlKSB7XG4nCisg ICAgICAgICAgICAnICAgIDAsXG4nCisgICAgICAgICAgICAnICAgIDFcbicKKyAgICAgICAgICAg ICd9OycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAg ICAgICAndHlwZWRlZiBOU19PUFRJT05TKE5TSW50ZWdlciwgdHlwZSlcbicKKyAgICAgICAgICAg ICd7XG4nCisgICAgICAgICAgICAnICAgIDAsXG4nCisgICAgICAgICAgICAnICAgIDFcbicKKyAg ICAgICAgICAgICd9OycsCisgICAgICAgICAgICAnVGhpcyB7IHNob3VsZCBiZSBhdCB0aGUgZW5k IG9mIHRoZSBwcmV2aW91cyBsaW5lICBbd2hpdGVzcGFjZS9icmFjZXNdIFs0XScpCisgICAgICAg IHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICd0eXBlZGVmIE5TX09Q VElPTlMoTlNJbnRlZ2VyLCB0eXBlKSB7XG4nCisgICAgICAgICAgICAnICAgIDAsXG4nCisgICAg ICAgICAgICAnICAgIDFcbicKKyAgICAgICAgICAgICd9OycsICcnKQorICAgICAgICBzZWxmLmFz c2VydF9tdWx0aV9saW5lX2xpbnQoCiAgICAgICAgICAgICAnZW51bSBjbGFzcyBDUFAxMUVudW1D bGFzc1xuJwogICAgICAgICAgICAgJ3tcbicKICAgICAgICAgICAgICcgICAgVmFsdWUxLFxuJwo=