<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175281</bug_id>
          
          <creation_ts>2017-08-07 13:12:09 -0700</creation_ts>
          <short_desc>Sandbox flags do not support document.domain control</short_desc>
          <delta_ts>2017-08-18 09:45:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=175300</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>175300</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>buildbot</cc>
    
    <cc>cdumez</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1336099</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-07 13:12:09 -0700</bug_when>
    <thetext>The SandboxingFlag enumeration is missing an option for &quot;Document.Domain&quot; access. We should add this so that websites can block frames from manipulating the frame&apos;s domain.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336110</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-07 13:35:19 -0700</bug_when>
    <thetext>It seems like this might just be a matter of merging this Blink revision:

https://crrev.com/162703</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336111</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-07 13:35:42 -0700</bug_when>
    <thetext>Whoops. I meant:

https://bugs.chromium.org/p/chromium/issues/detail?id=277084</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336545</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-08-08 11:03:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/33778936&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336569</commentid>
    <comment_count>4</comment_count>
      <attachid>317594</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-08 12:06:26 -0700</bug_when>
    <thetext>Created attachment 317594
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336586</commentid>
    <comment_count>5</comment_count>
      <attachid>317594</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-08-08 12:19:17 -0700</bug_when>
    <thetext>Comment on attachment 317594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317594&amp;action=review

&gt; Source/WebCore/dom/Document.cpp:4490
&gt; +    if (isSandboxed(SandboxDocumentDomain))

Eh.. Would you mind removing the &quot;// FIXME(175281): Check for &apos;document.domain&apos; sandbox flag and return an exception if present.&quot; comment a few lines below? :)

&gt; LayoutTests/fast/frames/sandboxed-iframe-domain-expected.txt:6
&gt; +Denied: SecurityError: Assignment is forbidden for sandboxed iframes.

I think this is going to be flaky. Given how the test is written, there is currently no guarantee the script in one particular iframe will run before the other. Therefore, those &quot;Denied&quot; lines may be switched.
I think the test need to be written in a way that first inserts the first iframe, tests it and then does so for a second iframe.

&gt; LayoutTests/fast/frames/sandboxed-iframe-domain-expected.txt:7
&gt; +Denied: SecurityError: The document has a null effectiveDomain.

Would this actually succeed if we moved the test to http/tests? If so, I&apos;d suggest we do this.

&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:6
&gt; +    testRunner.dumpAsText();

Not needed with js-test.

&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:23
&gt; +            window.testRunner.notifyDone();

finishJSTest() since you&apos;re using js-test.

&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:27
&gt; +description(&quot;This test verifies that a sandboxed iframe does not have permission to modify the document.domain property.&quot;);

I think it would look better if the description was at the beginning of the script.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336589</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-08-08 12:20:43 -0700</bug_when>
    <thetext>As an FYI, there is some discussion about removing document.origin from the spec:
https://github.com/whatwg/dom/issues/410</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336685</commentid>
    <comment_count>7</comment_count>
      <attachid>317627</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-08 15:19:53 -0700</bug_when>
    <thetext>Created attachment 317627
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336688</commentid>
    <comment_count>8</comment_count>
      <attachid>317594</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-08 15:25:09 -0700</bug_when>
    <thetext>Comment on attachment 317594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317594&amp;action=review

&gt;&gt; Source/WebCore/dom/Document.cpp:4490
&gt;&gt; +    if (isSandboxed(SandboxDocumentDomain))
&gt; 
&gt; Eh.. Would you mind removing the &quot;// FIXME(175281): Check for &apos;document.domain&apos; sandbox flag and return an exception if present.&quot; comment a few lines below? :)

Oh gosh! Doh!

&gt;&gt; LayoutTests/fast/frames/sandboxed-iframe-domain-expected.txt:6
&gt;&gt; +Denied: SecurityError: Assignment is forbidden for sandboxed iframes.
&gt; 
&gt; I think this is going to be flaky. Given how the test is written, there is currently no guarantee the script in one particular iframe will run before the other. Therefore, those &quot;Denied&quot; lines may be switched.
&gt; I think the test need to be written in a way that first inserts the first iframe, tests it and then does so for a second iframe.

Good point.

I had originally hoped to be able to have one &quot;succeeded&quot; and one &quot;denied&quot;, but the nature of our test environment prevents us from setting domain to anything legal.

So another option would just be to test the sandbox case, but I wanted to show that with the sandbox property, you get a sandbox error, and without you get different behavior.

&gt;&gt; LayoutTests/fast/frames/sandboxed-iframe-domain-expected.txt:7
&gt;&gt; +Denied: SecurityError: The document has a null effectiveDomain.
&gt; 
&gt; Would this actually succeed if we moved the test to http/tests? If so, I&apos;d suggest we do this.

I just gave up on having a pass and a fail case. I can&apos;t get our test system (which runs on 127.0.0.1:8000 to play nice with CORS and the various rules for setting a domain as a subdomain of the current domain. It&apos;s just not feasible.

&gt;&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:6
&gt;&gt; +    testRunner.dumpAsText();
&gt; 
&gt; Not needed with js-test.

OK!

&gt;&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:23
&gt;&gt; +            window.testRunner.notifyDone();
&gt; 
&gt; finishJSTest() since you&apos;re using js-test.

OK!

&gt;&gt; LayoutTests/fast/frames/sandboxed-iframe-domain.html:27
&gt;&gt; +description(&quot;This test verifies that a sandboxed iframe does not have permission to modify the document.domain property.&quot;);
&gt; 
&gt; I think it would look better if the description was at the beginning of the script.

OK!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1336742</commentid>
    <comment_count>9</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2017-08-08 16:27:11 -0700</bug_when>
    <thetext>Committed r220427: &lt;http://trac.webkit.org/changeset/220427&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317594</attachid>
            <date>2017-08-08 12:06:26 -0700</date>
            <delta_ts>2017-08-08 15:19:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175281-20170808120626.patch</filename>
            <type>text/plain</type>
            <size>5640</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA4LTA4ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFNhbmRib3ggZmxhZ3MgZG8g
bm90IHN1cHBvcnQgZG9jdW1lbnQuZG9tYWluIGNvbnRyb2wKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTI4MQorICAgICAgICA8cmRhcjovL3Byb2Js
ZW0vMzM3Nzg5MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgVXBkYXRlIHRoZSAnc2V0RG9tYWluJyBsb2dpYyB0byBob25vciB0aGUgc2FuZGJveCBw
cm9wZXJ0aWVzIGFzIGRlZmluZWQgaW4gdGhlIGN1cnJlbnQKKyAgICAgICAgSFRNTDUgc3BlY2lm
aWNhdGlvbi4gVGhpcyBicmluZ3MgdXMgaW4gbGluZSB3aXRoIGhvdyBDaHJvbWUgYW5kIG90aGVy
IGJyb3dzZXJzIGhhdmUKKyAgICAgICAgd29ya2VkIGZvciBzb21lIHRpbWUuCisKKyAgICAgICAg
VGVzdDogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4uaHRtbAorCisgICAgICAg
ICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXREb21h
aW4pOiBBZGQgY2hlY2sgZm9yIHNhbmRib3ggZmxhZyAod2l0aCBhcHByb3ByaWF0ZSBlcnJvciBt
ZXNzYWdlKQorICAgICAgICAqIGRvbS9TZWN1cml0eUNvbnRleHQuaDoKKwogMjAxNy0wOC0wOCAg
TXMyZ2VyICA8TXMyZ2VyQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ29ycmVj
dCB0aGUgZnVuY3Rpb24gbmFtZSBpbiBhIGRlYnVnIG1lc3NhZ2UuCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9E
b2N1bWVudC5jcHAJKHJldmlzaW9uIDIyMDQwNSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1
bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0ODcsNiArNDQ4Nyw5IEBAIEV4Y2VwdGlvbk9y
PHZvaWQ+IERvY3VtZW50OjpzZXREb21haW4oY28KICAgICBpZiAoIWZyYW1lKCkpCiAgICAgICAg
IHJldHVybiBFeGNlcHRpb24geyBTZWN1cml0eUVycm9yLCAiQSBicm93c2luZyBjb250ZXh0IGlz
IHJlcXVpcmVkIHRvIHNldCBhIGRvbWFpbi4iIH07CiAKKyAgICBpZiAoaXNTYW5kYm94ZWQoU2Fu
ZGJveERvY3VtZW50RG9tYWluKSkKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFNlY3VyaXR5
RXJyb3IsICJBc3NpZ25tZW50IGlzIGZvcmJpZGRlbiBmb3Igc2FuZGJveGVkIGlmcmFtZXMuIiB9
OworCiAgICAgaWYgKFNjaGVtZVJlZ2lzdHJ5Ojppc0RvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW5G
b3JVUkxTY2hlbWUoc2VjdXJpdHlPcmlnaW4oKS5wcm90b2NvbCgpKSkKICAgICAgICAgcmV0dXJu
IEV4Y2VwdGlvbiB7IFNlY3VyaXR5RXJyb3IgfTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9t
L1NlY3VyaXR5Q29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TZWN1
cml0eUNvbnRleHQuaAkocmV2aXNpb24gMjIwNDA0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1Nl
Y3VyaXR5Q29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2ICs1MSw3IEBAIGVudW0gU2Fu
ZGJveEZsYWcgewogICAgIFNhbmRib3hQb2ludGVyTG9jayAgICAgICAgICA9IDEgPDwgOCwKICAg
ICBTYW5kYm94UHJvcGFnYXRlc1RvQXV4aWxpYXJ5QnJvd3NpbmdDb250ZXh0cyA9IDEgPDwgOSwK
ICAgICBTYW5kYm94VG9wTmF2aWdhdGlvbkJ5VXNlckFjdGl2YXRpb24gPSAxIDw8IDEwLAorICAg
IFNhbmRib3hEb2N1bWVudERvbWFpbiAgICAgICA9IDEgPDwgMTEsCiAgICAgU2FuZGJveEFsbCAg
ICAgICAgICAgICAgICAgID0gLTEgLy8gTWFzayB3aXRoIGFsbCBiaXRzIHNldCB0byAxLgogfTsK
IApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz
L0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNDEzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3
b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDgtMDggIEJyZW50IEZ1bGdoYW0g
IDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgU2FuZGJveCBmbGFncyBkbyBub3Qgc3Vw
cG9ydCBkb2N1bWVudC5kb21haW4gY29udHJvbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MjgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzc3
ODkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq
IGZhc3QvZnJhbWVzL3Jlc291cmNlcy9zYW5kYm94ZWQtaWZyYW1lLXNldC1kb21haW4uaHRtbDog
QWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4uaHRt
bDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4t
ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxNy0wOC0wOCAgTXMyZ2VyICA8TXMyZ2VyQGlnYWxp
YS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG9ic29sZXRlIGZhaWx1cmUgZXhwZWN0YXRpb25zIGZv
ciBldmVudF9sb2FkZWRtZXRhZGF0YS5odG1sLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mcmFt
ZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NhbmRib3hlZC1pZnJhbWUtZG9tYWluLWV4cGVjdGVkLnR4
dAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZy
YW1lLWRvbWFpbi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMiBAQAor
VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYSBzYW5kYm94ZWQgaWZyYW1lIGRvZXMgbm90IGhhdmUg
cGVybWlzc2lvbiB0byBtb2RpZnkgdGhlIGRvY3VtZW50LmRvbWFpbiBwcm9wZXJ0eS4KKworT24g
c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93
ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK0RlbmllZDogU2VjdXJpdHlFcnJvcjogQXNzaWdu
bWVudCBpcyBmb3JiaWRkZW4gZm9yIHNhbmRib3hlZCBpZnJhbWVzLgorRGVuaWVkOiBTZWN1cml0
eUVycm9yOiBUaGUgZG9jdW1lbnQgaGFzIGEgbnVsbCBlZmZlY3RpdmVEb21haW4uCitQQVNTIHN1
Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKyAgCitQQVNTCkluZGV4
OiBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZyYW1lLWRvbWFpbi5odG1sCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NhbmRib3hlZC1pZnJhbWUtZG9t
YWluLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2FuZGJv
eGVkLWlmcmFtZS1kb21haW4uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM2IEBACis8
aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48
L3NjcmlwdD4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5l
ci5kdW1wQXNUZXh0KCk7CisKK3ZhciB0ZXN0Q291bnQgPSAwOwordmFyIGRpc2FsbG93ZWREb21h
aW5DaGFuZ2UgPSBmYWxzZTsKKworZnVuY3Rpb24gcGVyZm9ybWVkRG9tYWluQ2hhbmdlKG1lc3Nh
Z2UsIGFsbG93ZWQpCit7CisgICAgKyt0ZXN0Q291bnQ7CisgICAgZGVidWcobWVzc2FnZSk7CisK
KyAgICBpZiAoIWFsbG93ZWQpCisgICAgICAgIGRpc2FsbG93ZWREb21haW5DaGFuZ2UgPSB0cnVl
OworCisgICAgaWYgKHRlc3RDb3VudCA9PSAyKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1l
bnRCeUlkKCJ0ZXN0X3N0YXR1cyIpLmlubmVySFRNTCA9IChkaXNhbGxvd2VkRG9tYWluQ2hhbmdl
ID8gIlBBU1MiIDogIkZBSUwiKTsKKworICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisg
ICAgICAgICAgICB3aW5kb3cudGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgfQorfQorCitk
ZXNjcmlwdGlvbigiVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYSBzYW5kYm94ZWQgaWZyYW1lIGRv
ZXMgbm90IGhhdmUgcGVybWlzc2lvbiB0byBtb2RpZnkgdGhlIGRvY3VtZW50LmRvbWFpbiBwcm9w
ZXJ0eS4iKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGlmcmFtZSBzYW5kYm94
PSJhbGxvdy1zY3JpcHRzIGFsbG93LXNhbWUtb3JpZ2luIiBzcmM9InJlc291cmNlcy9zYW5kYm94
ZWQtaWZyYW1lLXNldC1kb21haW4uaHRtbCI+PC9pZnJhbWU+CisgICAgPGlmcmFtZSBzcmM9InJl
c291cmNlcy9zYW5kYm94ZWQtaWZyYW1lLXNldC1kb21haW4uaHRtbCI+PC9pZnJhbWU+CisKKyAg
ICA8cCBpZD0ndGVzdF9zdGF0dXMnPkZBSUw6IFNjcmlwdCBkaWRuJ3QgcnVuPC9wPgorPC9ib2R5
PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVzb3VyY2VzL3NhbmRi
b3hlZC1pZnJhbWUtc2V0LWRvbWFpbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh
c3QvZnJhbWVzL3Jlc291cmNlcy9zYW5kYm94ZWQtaWZyYW1lLXNldC1kb21haW4uaHRtbAkobm9u
ZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvc2FuZGJveGVk
LWlmcmFtZS1zZXQtZG9tYWluLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAor
PHNjcmlwdD4KK2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICAgIHRyeSB7CisgICAgICAgX2F2ID0g
ZXZhbCgiZG9jdW1lbnQuZG9tYWluID0gJzEyNy4wLjAuMSciKTsKKyAgICAgICB3aW5kb3cudG9w
LnBlcmZvcm1lZERvbWFpbkNoYW5nZSgiQWxsb3dlZCB0byBzZXQgZG9jdW1lbnQuZG9tYWluIiwg
dHJ1ZSk7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgICB3aW5kb3cudG9wLnBlcmZvcm1lZERv
bWFpbkNoYW5nZSgiRGVuaWVkOiAiICsgZSwgZmFsc2UpOworICAgIH0KK30KKzwvc2NyaXB0Pgor
PGJvZHkgb25sb2FkPSJydW5UZXN0KCk7Ij4KKyAgICBURVNUIENPTlRFTlQKKzwvYm9keT4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>317627</attachid>
            <date>2017-08-08 15:19:53 -0700</date>
            <delta_ts>2017-08-08 15:22:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175281-20170808151952.patch</filename>
            <type>text/plain</type>
            <size>5404</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA4LTA4ICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFNhbmRib3ggZmxhZ3MgZG8g
bm90IHN1cHBvcnQgZG9jdW1lbnQuZG9tYWluIGNvbnRyb2wKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTI4MQorICAgICAgICA8cmRhcjovL3Byb2Js
ZW0vMzM3Nzg5MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgVXBkYXRlIHRoZSAnc2V0RG9tYWluJyBsb2dpYyB0byBob25vciB0aGUgc2FuZGJveCBw
cm9wZXJ0aWVzIGFzIGRlZmluZWQgaW4gdGhlIGN1cnJlbnQKKyAgICAgICAgSFRNTDUgc3BlY2lm
aWNhdGlvbi4gVGhpcyBicmluZ3MgdXMgaW4gbGluZSB3aXRoIGhvdyBDaHJvbWUgYW5kIG90aGVy
IGJyb3dzZXJzIGhhdmUKKyAgICAgICAgd29ya2VkIGZvciBzb21lIHRpbWUuCisKKyAgICAgICAg
VGVzdDogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4uaHRtbAorCisgICAgICAg
ICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXREb21h
aW4pOiBBZGQgY2hlY2sgZm9yIHNhbmRib3ggZmxhZyAod2l0aCBhcHByb3ByaWF0ZSBlcnJvciBt
ZXNzYWdlKQorICAgICAgICAqIGRvbS9TZWN1cml0eUNvbnRleHQuaDoKKwogMjAxNy0wOC0wOCAg
TXMyZ2VyICA8TXMyZ2VyQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ29ycmVj
dCB0aGUgZnVuY3Rpb24gbmFtZSBpbiBhIGRlYnVnIG1lc3NhZ2UuCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9E
b2N1bWVudC5jcHAJKHJldmlzaW9uIDIyMDQwNSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1
bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0ODcsMTEgKzQ0ODcsMTIgQEAgRXhjZXB0aW9u
T3I8dm9pZD4gRG9jdW1lbnQ6OnNldERvbWFpbihjbwogICAgIGlmICghZnJhbWUoKSkKICAgICAg
ICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFNlY3VyaXR5RXJyb3IsICJBIGJyb3dzaW5nIGNvbnRleHQg
aXMgcmVxdWlyZWQgdG8gc2V0IGEgZG9tYWluLiIgfTsKIAorICAgIGlmIChpc1NhbmRib3hlZChT
YW5kYm94RG9jdW1lbnREb21haW4pKQorICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgU2VjdXJp
dHlFcnJvciwgIkFzc2lnbm1lbnQgaXMgZm9yYmlkZGVuIGZvciBzYW5kYm94ZWQgaWZyYW1lcy4i
IH07CisKICAgICBpZiAoU2NoZW1lUmVnaXN0cnk6OmlzRG9tYWluUmVsYXhhdGlvbkZvcmJpZGRl
bkZvclVSTFNjaGVtZShzZWN1cml0eU9yaWdpbigpLnByb3RvY29sKCkpKQogICAgICAgICByZXR1
cm4gRXhjZXB0aW9uIHsgU2VjdXJpdHlFcnJvciB9OwogCi0gICAgLy8gRklYTUUoMTc1MjgxKTog
Q2hlY2sgZm9yICdkb2N1bWVudC5kb21haW4nIHNhbmRib3ggZmxhZyBhbmQgcmV0dXJuIGFuIGV4
Y2VwdGlvbiBpZiBwcmVzZW50LgotCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBhZGQgbG9nZ2lu
ZyBpbmRpY2F0aW5nIHdoeSBhIGRvbWFpbiB3YXMgbm90IGFsbG93ZWQuCiAKICAgICBjb25zdCBT
dHJpbmcmIGVmZmVjdGl2ZURvbWFpbiA9IGRvbWFpbigpOwpJbmRleDogU291cmNlL1dlYkNvcmUv
ZG9tL1NlY3VyaXR5Q29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9T
ZWN1cml0eUNvbnRleHQuaAkocmV2aXNpb24gMjIwNDA0KQorKysgU291cmNlL1dlYkNvcmUvZG9t
L1NlY3VyaXR5Q29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2ICs1MSw3IEBAIGVudW0g
U2FuZGJveEZsYWcgewogICAgIFNhbmRib3hQb2ludGVyTG9jayAgICAgICAgICA9IDEgPDwgOCwK
ICAgICBTYW5kYm94UHJvcGFnYXRlc1RvQXV4aWxpYXJ5QnJvd3NpbmdDb250ZXh0cyA9IDEgPDwg
OSwKICAgICBTYW5kYm94VG9wTmF2aWdhdGlvbkJ5VXNlckFjdGl2YXRpb24gPSAxIDw8IDEwLAor
ICAgIFNhbmRib3hEb2N1bWVudERvbWFpbiAgICAgICA9IDEgPDwgMTEsCiAgICAgU2FuZGJveEFs
bCAgICAgICAgICAgICAgICAgID0gLTEgLy8gTWFzayB3aXRoIGFsbCBiaXRzIHNldCB0byAxLgog
fTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl
c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNDEzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDgtMDggIEJyZW50IEZ1bGdo
YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgU2FuZGJveCBmbGFncyBkbyBub3Qg
c3VwcG9ydCBkb2N1bWVudC5kb21haW4gY29udHJvbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MjgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z
Mzc3ODkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGZhc3QvZnJhbWVzL3Jlc291cmNlcy9zYW5kYm94ZWQtaWZyYW1lLXNldC1kb21haW4uaHRt
bDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4u
aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21h
aW4tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxNy0wOC0wOCAgTXMyZ2VyICA8TXMyZ2VyQGln
YWxpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG9ic29sZXRlIGZhaWx1cmUgZXhwZWN0YXRpb25z
IGZvciBldmVudF9sb2FkZWRtZXRhZGF0YS5odG1sLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9m
cmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NhbmRib3hlZC1pZnJhbWUtZG9tYWluLWV4cGVjdGVk
LnR4dAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zYW5kYm94ZWQt
aWZyYW1lLWRvbWFpbi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMSBA
QAorVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYSBzYW5kYm94ZWQgaWZyYW1lIGRvZXMgbm90IGhh
dmUgcGVybWlzc2lvbiB0byBtb2RpZnkgdGhlIGRvY3VtZW50LmRvbWFpbiBwcm9wZXJ0eS4KKwor
T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s
bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK0RlbmllZDogQXNzaWdubWVudCBpcyBmb3Ji
aWRkZW4gZm9yIHNhbmRib3hlZCBpZnJhbWVzLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg
dHJ1ZQorCitURVNUIENPTVBMRVRFCisKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZnJh
bWVzL3NhbmRib3hlZC1pZnJhbWUtZG9tYWluLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz
dHMvZmFzdC9mcmFtZXMvc2FuZGJveGVkLWlmcmFtZS1kb21haW4uaHRtbAkobm9uZXhpc3RlbnQp
CisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZyYW1lLWRvbWFpbi5odG1s
CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTkgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0
IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Rl
c2NyaXB0aW9uKCJUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBhIHNhbmRib3hlZCBpZnJhbWUgZG9l
cyBub3QgaGF2ZSBwZXJtaXNzaW9uIHRvIG1vZGlmeSB0aGUgZG9jdW1lbnQuZG9tYWluIHByb3Bl
cnR5LiIpOworCitmdW5jdGlvbiBwZXJmb3JtZWREb21haW5DaGFuZ2UobWVzc2FnZSwgYWxsb3dl
ZCkKK3sKKyAgICBkZWJ1ZyhtZXNzYWdlKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi
dGVzdF9zdGF0dXMiKS5pbm5lckhUTUwgPSAoYWxsb3dlZCA/ICJGQUlMIiA6ICJQQVNTIik7Cisg
ICAgZmluaXNoSlNUZXN0KCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxp
ZnJhbWUgc2FuZGJveD0iYWxsb3ctc2NyaXB0cyBhbGxvdy1zYW1lLW9yaWdpbiIgc3JjPSJyZXNv
dXJjZXMvc2FuZGJveGVkLWlmcmFtZS1zZXQtZG9tYWluLmh0bWwiPjwvaWZyYW1lPgorICAgIDxw
IGlkPSd0ZXN0X3N0YXR1cyc+RkFJTDogU2NyaXB0IGRpZG4ndCBydW48L3A+Cis8L2JvZHk+Cis8
L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvc2FuZGJveGVk
LWlmcmFtZS1zZXQtZG9tYWluLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9m
cmFtZXMvcmVzb3VyY2VzL3NhbmRib3hlZC1pZnJhbWUtc2V0LWRvbWFpbi5odG1sCShub25leGlz
dGVudCkKKysrIExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9zYW5kYm94ZWQtaWZy
YW1lLXNldC1kb21haW4uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0IEBACis8c2Ny
aXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgdHJ5IHsKKyAgICAgICAgZG9jdW1lbnQu
ZG9tYWluID0gJ2xvY2FsaG9zdCc7CisgICAgICAgIHdpbmRvdy50b3AucGVyZm9ybWVkRG9tYWlu
Q2hhbmdlKCJBbGxvd2VkIHRvIHNldCBkb2N1bWVudC5kb21haW4iLCB0cnVlKTsKKyAgICB9IGNh
dGNoIChlKSB7CisgICAgICAgIHdpbmRvdy50b3AucGVyZm9ybWVkRG9tYWluQ2hhbmdlKCJEZW5p
ZWQ6ICIgKyBlLm1lc3NhZ2UsIGZhbHNlKTsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzxib2R5IG9u
bG9hZD0icnVuVGVzdCgpOyI+CisgICAgVEVTVCBDT05URU5UCis8L2JvZHk+Cg==
</data>
<flag name="review"
          id="338146"
          type_id="1"
          status="+"
          setter="cdumez"
    />
          </attachment>
      

    </bug>

</bugzilla>