175272 2017-08-07 11:14:01 -0700 Layout test accessibility/press-target-uses-text-descendant-node.html is flaky. 2017-08-10 18:42:01 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=174849 InRadar P2 Normal --- 1 jlewis3 webkit-unassigned aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig jdiggs n_wang ryanhaddad samuel_white webkit-bug-importer oldest_to_newest 1336042 0 jlewis3 2017-08-07 11:14:01 -0700 The test accessibility/press-target-uses-text-descendant-node.html is flaky on macOS Debug according to the flakiness dashboard. The test looks to have been flaky on these platforms since addition in https://trac.webkit.org/changeset/219906/webkit https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r220333%20(2400)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/2400 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-actual.txt @@ -4,10 +4,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -Clicked on element: SPAN Now pressing on button +Clicked on element: SPAN Clicked on element: IMG PASS successfullyParsed is true 1336043 1 webkit-bug-importer 2017-08-07 11:14:19 -0700 <rdar://problem/33756962> 1336044 2 n_wang 2017-08-07 11:16:08 -0700 Will look into this 1337082 3 317729 n_wang 2017-08-09 12:33:19 -0700 Created attachment 317729 patch 1337111 4 317729 cfleizach 2017-08-09 13:44:57 -0700 Comment on attachment 317729 patch is there some way that's more deterministic? could we post an internal notification when the press happens and listen for that? 1337628 5 317859 n_wang 2017-08-10 15:08:57 -0700 Created attachment 317859 patch update 1337775 6 317859 commit-queue 2017-08-10 18:41:59 -0700 Comment on attachment 317859 patch Clearing flags on attachment: 317859 Committed r220570: <http://trac.webkit.org/changeset/220570> 1337776 7 commit-queue 2017-08-10 18:42:01 -0700 All reviewed patches have been landed. Closing bug. 317729 2017-08-09 12:33:19 -0700 2017-08-10 15:08:57 -0700 patch patch.txt text/plain 1421 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyMDQ3MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTA5ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IHRlc3QgYWNjZXNzaWJpbGl0eS9wcmVzcy10 YXJnZXQtdXNlcy10ZXh0LWRlc2NlbmRhbnQtbm9kZS5odG1sIGlzIGZsYWt5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MjcyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zMzc1Njk2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTaW5jZSBhY2Nlc3NpYmlsaXR5UHJlc3MgaXMgYXN5bmMgbm93LCB3 ZSBzaG91bGQgZ2l2ZSBpdCBtb3JlIHRpbWUKKyAgICAgICAgdG8gbWFrZSBzdXJlIHRoZSBsb2dn aW5nIGlzIGluIGNvcnJlY3Qgb3JkZXIuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L3ByZXNz LXRhcmdldC11c2VzLXRleHQtZGVzY2VuZGFudC1ub2RlLmh0bWw6CisKIDIwMTctMDgtMDkgIEtp cmlsbCBPdmNoaW5uaWtvdiAgPGtpcmlsbC5vdmNoaW5uaWtvdkBsZ2UuY29tPgogCiAgICAgICAg IE9sZCBzdWJ0aXRsZSB0cmFjayBpcyBub3QgZGVsZXRlZCBvbiAnc3JjJyBhdHRyaWJ1dGUgY2hh bmdlIGV2ZW50CkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXRhcmdldC11 c2VzLXRleHQtZGVzY2VuZGFudC1ub2RlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9wcmVzcy10YXJnZXQtdXNlcy10ZXh0LWRlc2NlbmRhbnQtbm9kZS5odG1s CShyZXZpc2lvbiAyMjAyNDgpCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXRh cmdldC11c2VzLXRleHQtZGVzY2VuZGFudC1ub2RlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTQ1 LDggKzQ1LDggQEAKICAgICAgICAgICAgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJs ZUVsZW1lbnRCeUlkKCJidXR0b24iKS5wcmVzcygpOwogICAgICAgICAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgewogICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAgICAgICAgIH0s IDEwKTsKLSAgICAgICB9LCAxMCk7CisgICAgICAgICAgIH0sIDUwKTsKKyAgICAgICB9LCA1MCk7 CiAgICAgfQogCiAgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewo= 317859 2017-08-10 15:08:57 -0700 2017-08-10 18:41:59 -0700 patch patch.txt text/plain 2081 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyMDU0OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTEwICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IHRlc3QgYWNjZXNzaWJpbGl0eS9wcmVzcy10 YXJnZXQtdXNlcy10ZXh0LWRlc2NlbmRhbnQtbm9kZS5odG1sIGlzIGZsYWt5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MjcyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zMzc1Njk2Mj4KKworICAgICAgICBTaW5jZSBhY2Nlc3NpYmlsaXR5UHJl c3MgaXMgYXN5bmMsIHdlIHNob3VsZG4ndCByZWx5IG9uIHRoZSB0aW1lb3V0LgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9w cmVzcy10YXJnZXQtdXNlcy10ZXh0LWRlc2NlbmRhbnQtbm9kZS5odG1sOgorCiAyMDE3LTA4LTEw ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW0JlYWNvbl0gRG8g Y29ubmVjdC1zcmMgQ1NQIGNoZWNrIG9uIHJlZGlyZWN0cyBhcyB3ZWxsCkluZGV4OiBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXRhcmdldC11c2VzLXRleHQtZGVzY2VuZGFudC1ub2Rl Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wcmVzcy10YXJn ZXQtdXNlcy10ZXh0LWRlc2NlbmRhbnQtbm9kZS5odG1sCShyZXZpc2lvbiAyMjA1MjIpCisrKyBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXRhcmdldC11c2VzLXRleHQtZGVzY2VuZGFu dC1ub2RlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTM4LDIwICszOCwyNCBAQAogCiAgICAgZGVz Y3JpcHRpb24oIk1ha2Ugc3VyZSB0aGF0IHdoZW4gcGVyZm9ybWluZyBhIHByZXNzLCB3ZSB0YXJn ZXQgdGhlIGRlZXBlc3QgZGVzY2VuZGFudCwgYnV0IGFsc28gb25lIHRoYXQgaXMgYW4gRWxlbWVu dCBhdCB0aGUgbGVhc3QuIik7CiAKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibGluayIp LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgcHJlc3NlZExpbmspOworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJidXR0b24iKS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHByZXNzZWRC dXR0b24pOwogICAgIGZ1bmN0aW9uIHN0YXJ0VGVzdCgpIHsKICAgICAgICBhY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImxpbmsiKS5wcmVzcygpOwotICAgICAg IHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgIGRlYnVnKCJcbk5vdyBwcmVzc2lu ZyBvbiBidXR0b25cbiIpOwotICAgICAgICAgICBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nl c3NpYmxlRWxlbWVudEJ5SWQoImJ1dHRvbiIpLnByZXNzKCk7Ci0gICAgICAgICAgIHNldFRpbWVv dXQoZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKLSAgICAgICAg ICAgfSwgMTApOwotICAgICAgIH0sIDEwKTsKICAgICB9CiAKICAgICBpZiAod2luZG93LmFjY2Vz c2liaWxpdHlDb250cm9sbGVyKSB7CiAgICAgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVl OwogICAgIH0KKyAgICAKKyAgICBmdW5jdGlvbiBwcmVzc2VkTGluaygpIHsKKyAgICAgICAgZGVi dWcoIlxuTm93IHByZXNzaW5nIG9uIGJ1dHRvblxuIik7CisgICAgICAgIGFjY2Vzc2liaWxpdHlD b250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiYnV0dG9uIikucHJlc3MoKTsKKyAgICB9 CisgICAgCisgICAgZnVuY3Rpb24gcHJlc3NlZEJ1dHRvbigpIHsKKyAgICAgICAgZmluaXNoSlNU ZXN0KCk7CisgICAgfQogCiA8L3NjcmlwdD4KIAo=