175230 2017-08-04 17:17:45 -0700 Fix typo in testmasm.cpp: ENABLE(JSVALUE64) should be USE(JSVALUE64). 2017-08-04 18:01:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam buildbot keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1335605 0 mark.lam 2017-08-04 17:17:45 -0700 Patch coming. 1335606 1 webkit-bug-importer 2017-08-04 17:18:24 -0700 <rdar://problem/33735857> 1335612 2 317318 mark.lam 2017-08-04 17:35:50 -0700 Created attachment 317318 proposed patch. Let's try this on the EWS. 1335613 3 317318 mark.lam 2017-08-04 17:44:04 -0700 Comment on attachment 317318 proposed patch. This patch has passed for 32-bit and 64-bit on my local builds. Time for a review. 1335620 4 mark.lam 2017-08-04 18:01:58 -0700 Thanks for the review. Landed in r220308: <http://trac.webkit.org/r220308>. 317318 2017-08-04 17:35:50 -0700 2017-08-04 17:44:55 -0700 proposed patch. bug-175230.patch text/plain 2642 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwMzA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTA4LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggdHlwbyBpbiB0ZXN0bWFzbS5jcHA6IEVOQUJMRShKU1ZBTFVFNjQpIHNob3VsZCBiZSBVU0Uo SlNWQUxVRTY0KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NTIzMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM3MzU4NTc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvdGVzdG1h c20uY3BwOgorICAgICAgICAoSlNDOjp0ZXN0UHJvYmVSZWFkc0FyZ3VtZW50UmVnaXN0ZXJzKToK KyAgICAgICAgKEpTQzo6dGVzdFByb2JlV3JpdGVzQXJndW1lbnRSZWdpc3RlcnMpOgorCiAyMDE3 LTA4LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIERG Rzo6T1NSRXhpdENvbXBpbGVyIG1ldGhvZHMgaW50byBERkc6Ok9TUkV4aXQgW3N0ZXAgMl0uCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAkocmV2 aXNpb24gMjIwMzA2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFz bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2LDcgKzY2LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUg VD4gVCBuZXh0SUQoVCBpZCkgeyByZQogI2RlZmluZSB0ZXN0V29yZDMyKHgpIChURVNUV09SRDMy ICsgc3RhdGljX2Nhc3Q8dWludDMyX3Q+KHgpKQogI2RlZmluZSB0ZXN0V29yZDY0KHgpIChURVNU V09SRDY0ICsgc3RhdGljX2Nhc3Q8dWludDY0X3Q+KHgpKQogCi0jaWYgRU5BQkxFKEpTVkFMVUU2 NCkKKyNpZiBVU0UoSlNWQUxVRTY0KQogI2RlZmluZSB0ZXN0V29yZCh4KSB0ZXN0V29yZDY0KHgp CiAjZWxzZQogI2RlZmluZSB0ZXN0V29yZCh4KSB0ZXN0V29yZDMyKHgpCkBAIC0xNTYsMTEgKzE1 NiwxMSBAQCB2b2lkIHRlc3RQcm9iZVJlYWRzQXJndW1lbnRSZWdpc3RlcnMoKQogICAgIGNvbXBp bGVBbmRSdW48dm9pZD4oWyZdIChDQ2FsbEhlbHBlcnMmIGppdCkgewogICAgICAgICBqaXQuZW1p dEZ1bmN0aW9uUHJvbG9ndWUoKTsKIAotICAgICAgICBqaXQubW92ZShDQ2FsbEhlbHBlcnM6OlRy dXN0ZWRJbW0zMih0ZXN0V29yZCgwKSksIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAgICAg IGppdC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKHRlc3RXb3JkMzIoMCkpLCBHUFJJ bmZvOjphcmd1bWVudEdQUjApOwogICAgICAgICBqaXQuY29udmVydEludDMyVG9Eb3VibGUoR1BS SW5mbzo6YXJndW1lbnRHUFIwLCBGUFJJbmZvOjpmcFJlZ1QwKTsKLSAgICAgICAgaml0Lm1vdmUo Q0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1tMzIodGVzdFdvcmQoMSkpLCBHUFJJbmZvOjphcmd1bWVu dEdQUjApOworICAgICAgICBqaXQubW92ZShDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMih0ZXN0 V29yZDMyKDEpKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKICAgICAgICAgaml0LmNvbnZlcnRJ bnQzMlRvRG91YmxlKEdQUkluZm86OmFyZ3VtZW50R1BSMCwgRlBSSW5mbzo6ZnBSZWdUMSk7Ci0j aWYgRU5BQkxFKEpTVkFMVUU2NCkKKyNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAgICBqaXQubW92 ZShDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW02NCh0ZXN0V29yZCgwKSksIEdQUkluZm86OmFyZ3Vt ZW50R1BSMCk7CiAgICAgICAgIGppdC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTY0KHRl c3RXb3JkKDEpKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIxKTsKICAgICAgICAgaml0Lm1vdmUoQ0Nh bGxIZWxwZXJzOjpUcnVzdGVkSW1tNjQodGVzdFdvcmQoMikpLCBHUFJJbmZvOjphcmd1bWVudEdQ UjIpOwpAQCAtMTk4LDcgKzE5OCw3IEBAIHZvaWQgdGVzdFByb2JlV3JpdGVzQXJndW1lbnRSZWdp c3RlcnMoKQogICAgICAgICBqaXQuZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKTsKIAogICAgICAgICAv LyBQcmUtaW5pdGlhbGl6ZSB3aXRoIG5vbi1leHBlY3RlZCB2YWx1ZXMuCi0jaWYgRU5BQkxFKEpT VkFMVUU2NCkKKyNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAgICBqaXQubW92ZShDQ2FsbEhlbHBl cnM6OlRydXN0ZWRJbW02NCgwKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKICAgICAgICAgaml0 Lm1vdmUoQ0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1tNjQoMCksIEdQUkluZm86OmFyZ3VtZW50R1BS MSk7CiAgICAgICAgIGppdC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTY0KDApLCBHUFJJ bmZvOjphcmd1bWVudEdQUjIpOwo=