175205 2017-08-04 13:35:41 -0700 [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default 2017-08-07 08:59:31 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 175207 P2 Normal --- 175207 1 bburg bburg bburg bugs-noreply cgarcia joepeck mcatanzaro oldest_to_newest 1335422 0 bburg 2017-08-04 13:35:41 -0700 This was introduced to CMake here, turned off by default: https://trac.webkit.org/changeset/170964/webkit It's enabled everywhere else. Let's turn it on so I can remove another pointless compile flag. 1335424 1 317276 bburg 2017-08-04 13:37:35 -0700 Created attachment 317276 Patch 1335668 2 317276 cgarcia 2017-08-05 00:23:32 -0700 Comment on attachment 317276 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317276&action=review > Source/cmake/OptionsGTK.cmake:155 > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF) > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE ON) I have no idea why we have OFF here. Since the default is ON, we can probably remove the line, but you are going to remove the build gflag eventually, so it doesn't really matter. > ChangeLog:3 > + [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default This doesn't change WPE 1335718 3 mcatanzaro 2017-08-05 12:23:39 -0700 Yes, just remove it from OptionsGTK.cmake. 1335964 4 bburg 2017-08-07 08:59:18 -0700 (In reply to Michael Catanzaro from comment #3) > Yes, just remove it from OptionsGTK.cmake. Ok, I'll just mark this patch invalid and land 175207 (removes the guard entirely) 1335965 5 bburg 2017-08-07 08:59:31 -0700 *** This bug has been marked as a duplicate of bug 175207 *** 317276 2017-08-04 13:37:35 -0700 2017-08-05 00:23:32 -0700 Patch bug-175205-20170804133734.patch text/plain 1394 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGNmOTBi NWViMWNlZGQ3MzliYTY1NDEzNzhiMmQ0ZTJkZjc1ZGUzZDkuLmMwZDA5MTVmMmNmMzU2YTJjNWEy OWM4MDViNDJlY2YwODBhMDFjN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNTIsNyArMTUy LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoVVNFX1NZU1RFTV9NQUxMT0Mg UFVCTElDIE9GRikKICMgQ2hhbmdpbmcgdGhlc2Ugb3B0aW9ucyBpcyBjb21wbGV0ZWx5IHVuc3Vw cG9ydGVkLgogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFXzNEX1RSQU5T Rk9STVMgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9BQ0NFU1NJQklMSVRZIFBSSVZBVEUgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQ0FOVkFTX1BBVEggUFJJVkFURSBPRkYpCitXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfQ0FOVkFTX1BBVEggUFJJVkFURSBPTikKIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfUkVHSU9OUyBQUklWQVRFIE9OKQogV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19TRUxFQ1RPUlNfTEVWRUw0 IFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRE9X TkxPQURfQVRUUklCVVRFIFBSSVZBVEUgT04pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggNmJlYjUwNTZlODA1MzljMTdiZmViN2JhZWQzMGFhN2Y3ZTI4NTA4MS4uNzU1 N2Q2NjFkZmRlZDcyMzhmNjJlMDYwMzI2MjUyNmRiNzdjZjNlNiAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA4LTA0ICBCcmlhbiBC dXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gVHVybiBvbiBFTkFC TEVfQ0FOVkFTX1BBVEggYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAx Ny0wOC0wMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg RU5BQkxFKFdFQl9TT0NLRVQpIGd1YXJkcwo=