175194 2017-08-04 10:04:52 -0700 LayoutTest accessibility/presentation-role-iframe.html is a flaky failure 2017-08-09 15:37:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173930 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned aboxhall apinheiro buildbot cfleizach dmazzoni jcraig jdiggs jlewis3 n_wang samuel_white webkit-bug-importer oldest_to_newest 1335303 0 ryanhaddad 2017-08-04 10:04:52 -0700 LayoutTest accessibility/presentation-role-iframe.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r220267%20(2810)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fpresentation-role-iframe.html 1335304 1 ryanhaddad 2017-08-04 10:06:14 -0700 This test was added with https://trac.webkit.org/changeset/219075/webkit 1335306 2 ryanhaddad 2017-08-04 10:07:36 -0700 --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-actual.txt @@ -8,10 +8,10 @@ 1. Content child: AXRole: AXGroup 1. Content grand child: AXRole: AXButton +3. Content child: AXRole: AXGroup +3. Content grand child: AXRole: AXButton 2. Content child: AXRole: AXScrollArea 2. Content grand child: AXRole: AXWebArea -3. Content child: AXRole: AXGroup -3. Content grand child: AXRole: AXButton PASS successfullyParsed is true TEST COMPLETE 1335307 3 ryanhaddad 2017-08-04 10:08:00 -0700 Chris, it looks like this test has been flaky since it was added. Could you take a look? 1335621 4 cfleizach 2017-08-04 18:05:43 -0700 (In reply to Ryan Haddad from comment #3) > Chris, it looks like this test has been flaky since it was added. Could you > take a look? Yep, will do. 1337113 5 317735 n_wang 2017-08-09 13:52:48 -0700 Created attachment 317735 patch 1337166 6 317735 cfleizach 2017-08-09 15:24:26 -0700 Comment on attachment 317735 patch View in context: https://bugs.webkit.org/attachment.cgi?id=317735&action=review r+ with style change > LayoutTests/accessibility/presentation-role-iframe.html:33 > +var test1Log, test2Log, test3Log semi-colon at the end? also I think WebKit likes to put each variable on a separate line. > LayoutTests/accessibility/presentation-role-iframe.html:62 > + var result = testNumber + ". Content child: " + content.childAtIndex(0).role; extra space after = 1337181 7 n_wang 2017-08-09 15:36:06 -0700 Committed r220486: <http://trac.webkit.org/changeset/220486> 1337182 8 webkit-bug-importer 2017-08-09 15:37:32 -0700 <rdar://problem/33813333> 317735 2017-08-09 13:52:48 -0700 2017-08-09 15:24:26 -0700 patch patch.txt text/plain 2386 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyMDQ3NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTA5ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBhY2Nlc3NpYmlsaXR5L3ByZXNlbnRh dGlvbi1yb2xlLWlmcmFtZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MTk0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIHRlc3Qgd2UgaGF2ZSBubyB3 YXkgdG8gY29udHJvbCB3aGljaCBpZnJhbWUgd2lsbCBiZSBsb2FkZWQgZmlyc3QuCisgICAgICAg IE91dHB1dCB0aGUgbG9ncyBhdCB0aGUgZW5kIG9mIHRoZSB0ZXN0IHNvIHRoYXQgdGhleSBhcmUg aW4gb3JkZXIuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L3ByZXNlbnRhdGlvbi1yb2xlLWlm cmFtZS5odG1sOgorCiAyMDE3LTA4LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBJbXBvcnQgQ1NTLVVJLTMgV2ViIFBsYXRmb3JtIFRlc3RzCkluZGV4OiBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNlbnRhdGlvbi1yb2xlLWlmcmFtZS5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcHJlc2VudGF0aW9uLXJvbGUt aWZyYW1lLmh0bWwJKHJldmlzaW9uIDIyMDQ2MikKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxp dHkvcHJlc2VudGF0aW9uLXJvbGUtaWZyYW1lLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMwLDI3 ICszMCwzOSBAQCB2YXIgdGVzdDFSYW4gPSBmYWxzZTsKIHZhciB0ZXN0MlJhbiA9IGZhbHNlOwog dmFyIHRlc3QzUmFuID0gZmFsc2U7CiAKK3ZhciB0ZXN0MUxvZywgdGVzdDJMb2csIHRlc3QzTG9n CisKIC8vIFJ1biB0aGUgdGVzdCBmb3IgYSBpZnJhbWUgdGhhdCBoYXMgcHJlc2VudGF0aW9uIHJv bGUgYW5kIG9uZSB0aGF0IGRvZXMgbm90LgogLy8gVGhlIGNoaWxkcmVuIHNob3VsZCBiZSBkaWZm ZXJlbnQuCiBmdW5jdGlvbiBydW5UZXN0KHRlc3ROdW1iZXIpCiB7CiAgIGlmICh3aW5kb3cuYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKICAgICB2YXIgY29udGVudCA9IGFjY2Vzc2liaWxpdHlD b250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiY29udGVudCIgKyB0ZXN0TnVtYmVyKTsK LSAgICBkZWJ1Zyh0ZXN0TnVtYmVyICsgIi4gQ29udGVudCBjaGlsZDogIiArIGNvbnRlbnQuY2hp bGRBdEluZGV4KDApLnJvbGUpOwotICAgIGRlYnVnKHRlc3ROdW1iZXIgKyAiLiBDb250ZW50IGdy YW5kIGNoaWxkOiAiICsgY29udGVudC5jaGlsZEF0SW5kZXgoMCkuY2hpbGRBdEluZGV4KDApLnJv bGUpOwogICAgIGlmICh0ZXN0TnVtYmVyID09IDEpIHsKICAgICAgICAgIHRlc3QxUmFuID0gdHJ1 ZTsKKyAgICAgICAgIHRlc3QxTG9nID0gdGVzdExvZyhjb250ZW50LCB0ZXN0TnVtYmVyKTsKICAg ICB9IGVsc2UgaWYgKHRlc3ROdW1iZXIgPT0gMikgewogICAgICAgICAgdGVzdDJSYW4gPSB0cnVl OworICAgICAgICAgdGVzdDJMb2cgPSB0ZXN0TG9nKGNvbnRlbnQsIHRlc3ROdW1iZXIpOwogICAg IH0gZWxzZSBpZiAodGVzdE51bWJlciA9PSAzKSB7CiAgICAgICAgICB0ZXN0M1JhbiA9IHRydWU7 CisgICAgICAgICB0ZXN0M0xvZyA9IHRlc3RMb2coY29udGVudCwgdGVzdE51bWJlcik7CiAgICAg fQogCiAgICAgaWYgKHRlc3QzUmFuICYmIHRlc3QyUmFuICYmIHRlc3QxUmFuKSB7CisgICAgICAg IGRlYnVnKHRlc3QxTG9nKTsKKyAgICAgICAgZGVidWcodGVzdDJMb2cpOworICAgICAgICBkZWJ1 Zyh0ZXN0M0xvZyk7CiAgICAgICAgIGZpbmlzaEpTVGVzdCgpOwogICAgIH0KICAgfQogfQorCitm dW5jdGlvbiB0ZXN0TG9nKGNvbnRlbnQsIHRlc3ROdW1iZXIpIHsKKyAgICB2YXIgcmVzdWx0ID0g IHRlc3ROdW1iZXIgKyAiLiBDb250ZW50IGNoaWxkOiAiICsgY29udGVudC5jaGlsZEF0SW5kZXgo MCkucm9sZTsKKyAgICByZXN1bHQgKz0gIlxuIiArIHRlc3ROdW1iZXIgKyAiLiBDb250ZW50IGdy YW5kIGNoaWxkOiAiICsgY29udGVudC5jaGlsZEF0SW5kZXgoMCkuY2hpbGRBdEluZGV4KDApLnJv bGU7CisgICAgcmV0dXJuIHJlc3VsdDsKK30KIDwvc2NyaXB0PgogCiA8L2JvZHk+Cg==