175190 2017-08-04 09:16:22 -0700 Cleanup: simplify WebSockets code for RuntimeEnabledFeatures 2017-08-07 09:32:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 167044 1 bburg bburg bburg commit-queue joepeck sam webkit-bug-importer oldest_to_newest 1335275 0 bburg 2017-08-04 09:16:22 -0700 . 1335505 1 317297 bburg 2017-08-04 14:59:30 -0700 Created attachment 317297 Patch 1335750 2 317297 joepeck 2017-08-05 16:46:45 -0700 Comment on attachment 317297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317297&action=review > Source/WebCore/Modules/websockets/WebSocket.idl:-38 > - EnabledAtRuntime=WebSocket, It's not accurate to say it wasn't used for anything when it was used for this! But I guess we don't expect anyone to toggle it off. 1335984 3 317297 commit-queue 2017-08-07 09:32:28 -0700 Comment on attachment 317297 Patch Clearing flags on attachment: 317297 Committed r220337: <http://trac.webkit.org/changeset/220337> 1335985 4 commit-queue 2017-08-07 09:32:29 -0700 All reviewed patches have been landed. Closing bug. 1335986 5 webkit-bug-importer 2017-08-07 09:32:47 -0700 <rdar://problem/33754436> 317297 2017-08-04 14:59:30 -0700 2017-08-07 09:32:28 -0700 Patch bug-175190-20170804145929.patch text/plain 4413 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYyZTdkNTM2NzNhZDAy NmFjYjExODlmZDUxMDhmNjFhODYwZDAzYy4uN2I3ZmI1ZDAwYjdlMzA4NWY2MTdhMmU3NmE4NmM2 NzQ5YzEwZDIwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA4LTA0ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIENsZWFudXA6IHNpbXBsaWZ5IFdl YlNvY2tldHMgY29kZSBmb3IgUnVudGltZUVuYWJsZWRGZWF0dXJlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MTkwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBydW50aW1lIGVuYWJsZWQgZmxh ZyBpcyBub3QgdXNlZCBieSBhbnl0aGluZy4gSXQgd2FzIGFkZGVkCisgICAgICAgIGZvciBWOCBp biA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5ODk2Pi4KKworICAg ICAgICAqIE1vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V2ViU29ja2V0OjpzZXRJc0F2YWlsYWJsZSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3Jl OjpXZWJTb2NrZXQ6OmlzQXZhaWxhYmxlKTogRGVsZXRlZC4KKyAgICAgICAgKiBNb2R1bGVzL3dl YnNvY2tldHMvV2ViU29ja2V0Lmg6CisgICAgICAgICogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNv Y2tldC5pZGw6CisgICAgICAgICogcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OndlYlNvY2tldEVuYWJsZWQg Y29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5o OgorCiAyMDE3LTA4LTA0ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjAyNjguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCmluZGV4IDAwMDYxOGQ5MDRiZDFj Yzk5ZWUwMWE4YzVjZTlmNWMyNjgwNzVmMzkuLjcyM2EwYjZjOGUxZThmYzgyZGRkZDYwZGM2ODJj MDRkODQxYjA5ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0 cy9XZWJTb2NrZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9X ZWJTb2NrZXQuY3BwCkBAIC0xMjYsMTggKzEyNiw2IEBAIHN0YXRpYyB1bnNpZ25lZCBzYXR1cmF0 ZUFkZCh1bnNpZ25lZCBhLCB1bnNpZ25lZCBiKQogICAgIHJldHVybiBhICsgYjsKIH0KIAotc3Rh dGljIGJvb2wgd2ViU29ja2V0c0F2YWlsYWJsZSA9IHRydWU7Ci0KLXZvaWQgV2ViU29ja2V0Ojpz ZXRJc0F2YWlsYWJsZShib29sIGF2YWlsYWJsZSkKLXsKLSAgICB3ZWJTb2NrZXRzQXZhaWxhYmxl ID0gYXZhaWxhYmxlOwotfQotCi1ib29sIFdlYlNvY2tldDo6aXNBdmFpbGFibGUoKQotewotICAg IHJldHVybiB3ZWJTb2NrZXRzQXZhaWxhYmxlOwotfQotCiBjb25zdCBjaGFyKiBXZWJTb2NrZXQ6 OnN1YnByb3RvY29sU2VwYXJhdG9yKCkKIHsKICAgICByZXR1cm4gIiwgIjsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuaCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXQuaAppbmRleCBkMjgzNzk5MjFlYTgy OTFhNDc2MmY3MmYyMjRiZTMyNjlmYjBmZmU4Li5kOGE5MGQ5NWVjZTYyNjVjZDg5ZGJiM2E1YTY0 ZGJkZjFkNTkxNGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tl dHMvV2ViU29ja2V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dl YlNvY2tldC5oCkBAIC01Miw5ICs1Miw2IEBAIGNsYXNzIFRocmVhZGFibGVXZWJTb2NrZXRDaGFu bmVsOwogCiBjbGFzcyBXZWJTb2NrZXQgZmluYWwgOiBwdWJsaWMgUmVmQ291bnRlZDxXZWJTb2Nr ZXQ+LCBwdWJsaWMgRXZlbnRUYXJnZXRXaXRoSW5saW5lRGF0YSwgcHVibGljIEFjdGl2ZURPTU9i amVjdCwgcHJpdmF0ZSBXZWJTb2NrZXRDaGFubmVsQ2xpZW50IHsKIHB1YmxpYzoKLSAgICBzdGF0 aWMgdm9pZCBzZXRJc0F2YWlsYWJsZShib29sKTsKLSAgICBzdGF0aWMgYm9vbCBpc0F2YWlsYWJs ZSgpOwotCiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIHN1YnByb3RvY29sU2VwYXJhdG9yKCk7CiAK ICAgICBzdGF0aWMgRXhjZXB0aW9uT3I8UmVmPFdlYlNvY2tldD4+IGNyZWF0ZShTY3JpcHRFeGVj dXRpb25Db250ZXh0JiwgY29uc3QgU3RyaW5nJiB1cmwpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmlkbAppbmRleCA1MmY2MWY0YTIzY2UyMmEzMzc3 NzQ1Mzk0MGZlNjNkMjI1ZWY4MGNhLi4yZDE3ZWQ5YzY1MDU0YzEzNjBlOWE4MTE2MjVmZGE0NDEw YmNiYTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2Vi U29ja2V0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2ViU29j a2V0LmlkbApAQCAtMzUsNyArMzUsNiBAQAogICAgIENvbnN0cnVjdG9yKFVTVlN0cmluZyB1cmws IERPTVN0cmluZyBwcm90b2NvbCksCiAgICAgQ29uc3RydWN0b3JNYXlUaHJvd0V4Y2VwdGlvbiwK ICAgICBDb25zdHJ1Y3RvckNhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCi0gICAgRW5h YmxlZEF0UnVudGltZT1XZWJTb2NrZXQsCiAgICAgRXhwb3NlZD0oV2luZG93LFdvcmtlciksCiBd IGludGVyZmFjZSBXZWJTb2NrZXQgOiBFdmVudFRhcmdldCB7CiAgICAgcmVhZG9ubHkgYXR0cmli dXRlIFVTVlN0cmluZyBVUkw7IC8vIExvd2VyY2FzZWQgLnVybCBpcyB0aGUgb25lIGluIHRoZSBz cGVjLCBidXQgbGVhdmluZyAuVVJMIGZvciBjb21wYXRpYmlsaXR5IHJlYXNvbnMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAppbmRleCBiMzJmYTdk OWJmODY0YjFmMTc2MjA1NWE5Nzc3NTI1Yzc0ZTIzYWJkLi5kZWYxMTg4ODQxOGI1MTkyNDM0Njdj M2VkYjM3OGZiMjc4MmU2YjI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRp bWVFbmFibGVkRmVhdHVyZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVu YWJsZWRGZWF0dXJlcy5jcHAKQEAgLTMzLDcgKzMzLDYgQEAKICNpbmNsdWRlICJSdW50aW1lRW5h YmxlZEZlYXR1cmVzLmgiCiAKICNpbmNsdWRlICJNZWRpYVBsYXllci5oIgotI2luY2x1ZGUgIldl YlNvY2tldC5oIgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CkBAIC01OSw5ICs1OCw0IEBAIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6 YXVkaW9FbmFibGVkKCkgY29uc3QKIH0KICNlbmRpZgogCi1ib29sIFJ1bnRpbWVFbmFibGVkRmVh dHVyZXM6OndlYlNvY2tldEVuYWJsZWQoKSBjb25zdAotewotICAgIHJldHVybiBXZWJTb2NrZXQ6 OmlzQXZhaWxhYmxlKCk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIGIvU291cmNlL1dl YkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKaW5kZXggODA5MmIyZWM5MjU0Yjgz ODNjOTAxMjE3ZjA2ZTA4ODhkYWExNzA0Yy4uNmI1YTNmNzU3NGUwYWY2OTIxYWNjMzM4NzJmODc3 YWVjMDM2N2QxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxl ZEZlYXR1cmVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1 cmVzLmgKQEAgLTIwMiw4ICsyMDIsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBhdWRpb0VuYWJsZWQo KSBjb25zdDsKICNlbmRpZgogCi0gICAgYm9vbCB3ZWJTb2NrZXRFbmFibGVkKCkgY29uc3Q7Ci0K ICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgUnVudGltZUVuYWJsZWRGZWF0dXJlcyYgc2hhcmVk RmVhdHVyZXMoKTsKIAogcHJpdmF0ZToK