<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175189</bug_id>
          
          <creation_ts>2017-08-04 08:43:39 -0700</creation_ts>
          <short_desc>[SOUP] Too many redirections when loading google.com</short_desc>
          <delta_ts>2018-02-09 10:03:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>MOVED</resolution>
          
          <see_also>https://bugzilla.gnome.org/show_bug.cgi?id=792130</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christian Hergert">christian</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cedric.bellegarde</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1335263</commentid>
    <comment_count>0</comment_count>
    <who name="Christian Hergert">christian</who>
    <bug_when>2017-08-04 08:43:39 -0700</bug_when>
    <thetext>Using Epiphany 3.25.2 (with WebKit2 Gtk) and loading https://google.com results in a failure of the &quot;notifications bubble&quot; in the top right of the page. I can see the list of notifications available, but clicking the &quot;popover&quot; fails with an error in the console like:

https://notifications.google.com/accounts/SetOSID?...

Failed to load resource: Too many redirections

If there is a better component to use for filing these sort of bugs, I&apos;d be happy to set that on future bug reports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1335382</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-08-04 12:09:18 -0700</bug_when>
    <thetext>WebKitGTK+ was the best component to pick since it ensures we see it.

This is a longstanding issue. Good to know it&apos;s the cause of the Google notifications problem too.

*** This bug has been marked as a duplicate of bug 109576 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363174</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-22 15:03:57 -0700</bug_when>
    <thetext>Actually this doesn&apos;t seem like a duplicate. It&apos;s caused by blocking third-party cookies. If you muck with your cookie settings in Epiphany&apos;s preferences dialog, it should start working again.

I noticed it when testing another redirection loop that I thought was an Epiphany bug, but which I could reproduce in Firefox. Firefox displayed a warning that sometimes loops can occur due to blocking cookies. So that&apos;s a bit surprising.

Not sure what to do here. I guess it&apos;ll just have to remain broken. We want to be tightening cookie policy going forward, not loosening it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363293</commentid>
    <comment_count>3</comment_count>
    <who name="Cédric Bellegarde">cedric.bellegarde</who>
    <bug_when>2017-10-23 09:06:17 -0700</bug_when>
    <thetext>You are right, changing cookie policy fix the issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363294</commentid>
    <comment_count>4</comment_count>
    <who name="Cédric Bellegarde">cedric.bellegarde</who>
    <bug_when>2017-10-23 09:09:35 -0700</bug_when>
    <thetext>As it works in Chrome and Firefox, I guess WebKit2.CookieAcceptPolicy.NO_THIRD_PARTY should check base domain name instead of netloc.

If I visit plus.google.com, it should accept any google.com cookie request. Does it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363485</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-23 17:27:12 -0700</bug_when>
    <thetext>(In reply to Cédric Bellegarde from comment #4)
&gt; As it works in Chrome and Firefox, I guess
&gt; WebKit2.CookieAcceptPolicy.NO_THIRD_PARTY should check base domain name
&gt; instead of netloc.

What&apos;s netloc?

Anyway no, the cookie is only allowed if the domain matches exactly, see soup_cookie_jar_add_cookie_with_first_party() which calls soup_cookie_domain_matches() which calls soup_host_matches_host().

&gt; If I visit plus.google.com, it should accept any google.com cookie request.
&gt; Does it?

Should it really? Is that how Safari works? We should match whatever Safari does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363577</commentid>
    <comment_count>6</comment_count>
    <who name="Cédric Bellegarde">cedric.bellegarde</who>
    <bug_when>2017-10-23 22:28:03 -0700</bug_when>
    <thetext>My girlfrien is using Safari on her Mac and notifications are working, but not sure third party cookies are blocked, will give a look this evening.

Here, the issue is that for example, while opening notifications popover from plus.google.com, it does a request for a cookie from notifications.google.com and so WebKit blocks it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385126</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-02 07:45:54 -0800</bug_when>
    <thetext>Moved to GNOME Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=792130</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1385346</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-02 17:48:04 -0800</bug_when>
    <thetext>Unlikely coincidence that this happened today... but after working on bug #181231, I now have a layout test that I want to mark against this bug:

http/tests/resourceLoadStatistics/grandfathering.html

Reopening since we need an open WebKit bug for the test expectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394860</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-01-30 17:50:08 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #8)
&gt; Unlikely coincidence that this happened today... but after working on bug
&gt; #181231, I now have a layout test that I want to mark against this bug:
&gt; 
&gt; http/tests/resourceLoadStatistics/grandfathering.html
&gt; 
&gt; Reopening since we need an open WebKit bug for the test expectations.

That&apos;s wrong, the problem in that test is unrelated. I&apos;ll reassign the expectation to some other bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397990</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-09 10:03:12 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #7)
&gt; Moved to GNOME Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=792130

Should be fixed in libsoup. Please reopen if you have trouble with updated libsoup.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>