175182 2017-08-04 03:41:00 -0700 check-webkit-style: fix path-specific rules for WebKit2 rename 2017-08-07 14:22:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned buildbot commit-queue ddkilzer glenn jbedard lforschler matthew_hanson webkit-bug-importer oldest_to_newest 1335206 0 yoshiaki.jitsukawa 2017-08-04 03:41:00 -0700 The path-specific rules should be fixed for the WebKit2 -> WebKit renaming. 1335207 1 317232 yoshiaki.jitsukawa 2017-08-04 03:48:02 -0700 Created attachment 317232 Patch 1335524 2 yoshiaki.jitsukawa 2017-08-04 15:18:20 -0700 (Let me CC ddkilzer from the commit log.) Hello, David. I found some "WebKit2" remain in the style checker script. Would you please review my patch to fix them? 1335748 3 317232 ddkilzer 2017-08-05 16:18:10 -0700 Comment on attachment 317232 Patch Nice find! r=me 1335749 4 yoshiaki.jitsukawa 2017-08-05 16:44:18 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 317232 [details] > Patch > > Nice find! r=me Thank you for your reviewing! 1335751 5 317232 commit-queue 2017-08-05 16:48:29 -0700 Comment on attachment 317232 Patch Clearing flags on attachment: 317232 Committed r220321: <http://trac.webkit.org/changeset/220321> 1335752 6 commit-queue 2017-08-05 16:48:30 -0700 All reviewed patches have been landed. Closing bug. 1335753 7 webkit-bug-importer 2017-08-05 16:49:14 -0700 <rdar://problem/33742368> 1336041 8 matthew_hanson 2017-08-07 11:12:34 -0700 Thank you for finding/fixing this, Yoshiaki! 1336126 9 yoshiaki.jitsukawa 2017-08-07 14:22:16 -0700 (In reply to Matthew Hanson from comment #8) > Thank you for finding/fixing this, Yoshiaki! Not at all, Matthew! 317232 2017-08-04 03:48:02 -0700 2017-08-05 16:48:29 -0700 Patch bug-175182-20170804194802.patch text/plain 4019 yoshiaki.jitsukawa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDI2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTA4LTA0ICBZb3NoaWFraSBKaXRzdWthd2EgIDxZb3NoaWFraS5KaXRz dWthd2FAc29ueS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBmaXggcGF0aC1z cGVjaWZpYyBydWxlcyBmb3IgV2ViS2l0MiByZW5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5OgorCiAyMDE3LTA4LTAzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBFTkFCTEUoV0VCX1NPQ0tFVCkgZ3VhcmRzCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CShyZXZpc2lvbiAyMjAyNTIpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1MCwxMyAr MTUwLDEzIEBAIF9QQVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKIAogICAgIChbIyBUaGUgR1RLKyBh bmQgV1BFIEFQSXMgdXNlIHVwcGVyIGNhc2UsIHVuZGVyc2NvcmUgc2VwYXJhdGVkLCB3b3JkcyBp bgogICAgICAgIyBjZXJ0YWluIHR5cGVzIG9mIGVudW1zIChlLmcuIHNpZ25hbHMsIHByb3BlcnRp ZXMpLgotICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViS2l0MicsICdTaGFyZWQnLCAn QVBJJywgJ2dsaWInKSwKLSAgICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYktpdDInLCAn VUlQcm9jZXNzJywgJ0FQSScsICdnbGliJyksCi0gICAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScs ICdXZWJLaXQyJywgJ1VJUHJvY2VzcycsICdBUEknLCAnZ3RrJyksCi0gICAgICBvcy5wYXRoLmpv aW4oJ1NvdXJjZScsICdXZWJLaXQyJywgJ1VJUHJvY2VzcycsICdBUEknLCAnd3BlJyksCi0gICAg ICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQyJywgJ1dlYlByb2Nlc3MnLCAnSW5qZWN0 ZWRCdW5kbGUnLCAnQVBJJywgJ2dsaWInKSwKLSAgICAgIG9zLnBhdGguam9pbignU291cmNlJywg J1dlYktpdDInLCAnV2ViUHJvY2VzcycsICdJbmplY3RlZEJ1bmRsZScsICdBUEknLCAnZ3RrJyks Ci0gICAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQyJywgJ1dlYlByb2Nlc3MnLCAn SW5qZWN0ZWRCdW5kbGUnLCAnQVBJJywgJ3dwZScpXSwKKyAgICAgIG9zLnBhdGguam9pbignU291 cmNlJywgJ1dlYktpdCcsICdTaGFyZWQnLCAnQVBJJywgJ2dsaWInKSwKKyAgICAgIG9zLnBhdGgu am9pbignU291cmNlJywgJ1dlYktpdCcsICdVSVByb2Nlc3MnLCAnQVBJJywgJ2dsaWInKSwKKyAg ICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYktpdCcsICdVSVByb2Nlc3MnLCAnQVBJJywg J2d0aycpLAorICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViS2l0JywgJ1VJUHJvY2Vz cycsICdBUEknLCAnd3BlJyksCisgICAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQn LCAnV2ViUHJvY2VzcycsICdJbmplY3RlZEJ1bmRsZScsICdBUEknLCAnZ2xpYicpLAorICAgICAg b3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViS2l0JywgJ1dlYlByb2Nlc3MnLCAnSW5qZWN0ZWRC dW5kbGUnLCAnQVBJJywgJ2d0aycpLAorICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2Vi S2l0JywgJ1dlYlByb2Nlc3MnLCAnSW5qZWN0ZWRCdW5kbGUnLCAnQVBJJywgJ3dwZScpXSwKICAg ICAgWyItcmVhZGFiaWxpdHkvZW51bV9jYXNpbmciXSksCiAKICAgICAoWyMgVG8gdXNlIEdTdHJl YW1lciBHTCB3aXRob3V0IGNvbmZsaWN0cyBvZiBHTCBzeW1ib2xzLApAQCAtMTc4LDE5ICsxNzgs MTkgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICBbIi1yZWFkYWJpbGl0eS9wYXJh bWV0ZXJfbmFtZSIsCiAgICAgICAiLXdoaXRlc3BhY2UvcGFyZW5zIl0pLAogCi0gICAgIyBXZWJL aXQyIHJ1bGVzOgotICAgICMgV2ViS2l0MiBhbmQgY2VydGFpbiBkaXJlY3RvcmllcyBoYXZlIGlk aW9zeW5jcmFjaWVzLgorICAgICMgV2ViS2l0IHJ1bGVzOgorICAgICMgV2ViS2l0IGFuZCBjZXJ0 YWluIGRpcmVjdG9yaWVzIGhhdmUgaWRpb3N5bmNyYWNpZXMuCiAgICAgKFsjIE5QQVBJIGhhcyBm dW5jdGlvbiBuYW1lcyB3aXRoIHVuZGVyc2NvcmVzLgotICAgICAgb3MucGF0aC5qb2luKCdTb3Vy Y2UnLCAnV2ViS2l0MicsICdXZWJQcm9jZXNzJywgJ1BsdWdpbnMnLCAnTmV0c2NhcGUnKV0sCisg ICAgICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQnLCAnV2ViUHJvY2VzcycsICdQbHVn aW5zJywgJ05ldHNjYXBlJyldLAogICAgICBbIi1yZWFkYWJpbGl0eS9uYW1pbmciXSksCi0gICAg KFsjIFRoZSBXZWJLaXQyIEMgQVBJIGhhcyBuYW1lcyB3aXRoIHVuZGVyc2NvcmVzIGFuZCB3aGl0 ZXNwYWNlLWFsaWduZWQKKyAgICAoWyMgVGhlIFdlYktpdCBDIEFQSSBoYXMgbmFtZXMgd2l0aCB1 bmRlcnNjb3JlcyBhbmQgd2hpdGVzcGFjZS1hbGlnbmVkCiAgICAgICAjIHN0cnVjdCBtZW1iZXJz LiBBbHNvLCB3ZSBhbGxvdyB1bm5lY2Vzc2FyeSBwYXJhbWV0ZXIgbmFtZXMgaW4KLSAgICAgICMg V2ViS2l0MiBBUElzIGJlY2F1c2Ugd2UncmUgbWF0Y2hpbmcgQ0YncyBoZWFkZXIgc3R5bGUuCisg ICAgICAjIFdlYktpdCBBUElzIGJlY2F1c2Ugd2UncmUgbWF0Y2hpbmcgQ0YncyBoZWFkZXIgc3R5 bGUuCiAgICAgICAjIEFkZGl0aW9uYWxseSwgd2UgdXNlIHdvcmQgd2hpY2ggc3RhcnRzIHdpdGgg bm9uLWNhcGl0YWwgbGV0dGVyICdrJwogICAgICAgIyBmb3IgdHlwZXMgb2YgZW51bXMuCi0gICAg ICBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJLaXQyJywgJ1VJUHJvY2VzcycsICdBUEknLCAn QycpLAotICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViS2l0MicsICdTaGFyZWQnLCAn QVBJJywgJ2MnKSwKLSAgICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYktpdDInLCAnV2Vi UHJvY2VzcycsICdJbmplY3RlZEJ1bmRsZScsICdBUEknLCAnYycpXSwKKyAgICAgIG9zLnBhdGgu am9pbignU291cmNlJywgJ1dlYktpdCcsICdVSVByb2Nlc3MnLCAnQVBJJywgJ0MnKSwKKyAgICAg IG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYktpdCcsICdTaGFyZWQnLCAnQVBJJywgJ2MnKSwK KyAgICAgIG9zLnBhdGguam9pbignU291cmNlJywgJ1dlYktpdCcsICdXZWJQcm9jZXNzJywgJ0lu amVjdGVkQnVuZGxlJywgJ0FQSScsICdjJyldLAogICAgICBbIi1yZWFkYWJpbGl0eS9lbnVtX2Nh c2luZyIsCiAgICAgICAiLXJlYWRhYmlsaXR5L25hbWluZyIsCiAgICAgICAiLXJlYWRhYmlsaXR5 L3BhcmFtZXRlcl9uYW1lIiwKQEAgLTM0Myw3ICszNDMsNyBAQCBfU0tJUFBFRF9GSUxFU19XSVRI T1VUX1dBUk5JTkcgPSBbCiAgICAgIyBJQ1UgaGVhZGVycyBhcmUgaW1wb3J0ZWQuCiAgICAgb3Mu cGF0aC5qb2luKCdTb3VyY2UnLCAnSmF2YVNjcmlwdENvcmUnLCAnaWN1JyksCiAgICAgb3MucGF0 aC5qb2luKCdTb3VyY2UnLCAnV2ViQ29yZScsICdpY3UnKSwKLSAgICBvcy5wYXRoLmpvaW4oJ1Nv dXJjZScsICdXZWJLaXQnLCAnbWFjJywgJ2ljdScpLAorICAgIG9zLnBhdGguam9pbignU291cmNl JywgJ1dlYktpdExlZ2FjeScsICdtYWMnLCAnaWN1JyksCiAgICAgb3MucGF0aC5qb2luKCdTb3Vy Y2UnLCAnV1RGJywgJ2ljdScpLAogICAgIF0KIAo=