175157 2017-08-03 15:00:57 -0700 Dashboard bubbles sometimes show failure count instead of crash count 2017-08-04 13:01:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=142364 https://bugs.webkit.org/show_bug.cgi?id=175200 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates jlewis3 lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1334962 0 aakash_jain 2017-08-03 15:00:57 -0700 See <rdar://problem/33709009> 1334965 1 317163 aakash_jain 2017-08-03 15:05:41 -0700 Created attachment 317163 Proposed patch 1335048 2 aakash_jain 2017-08-03 17:41:05 -0700 This change wasn't required earlier, because with buildbot 0.8, testStep.results[1] used to be an array, but in buildbot 0.9, the same is replaced with state_string which is a string (equivalent to concatenated array). Old Sample testStep.results[1]: [ "53 failures", "37 new passes", "1 crashes" ] New sample state_string: "53 failures 37 new passes 1 crashes" 1335087 3 dbates 2017-08-03 19:11:04 -0700 Can we write a unit test for this change? 1335284 4 317163 ap 2017-08-04 09:35:14 -0700 Comment on attachment 317163 Proposed patch I think it's worth adding a comment explaining which two cases we support here, especially given that there is no regression test. 1335371 5 317263 aakash_jain 2017-08-04 11:55:04 -0700 Created attachment 317263 Patch for landing Added a comment mentioning sample data. We only support the new format (buildbot 0.8 data is already converted to buildbot 0.9 format before reaching here). Filed https://bugs.webkit.org/show_bug.cgi?id=175200 for adding unit tests. 1335408 6 317263 commit-queue 2017-08-04 13:01:19 -0700 Comment on attachment 317263 Patch for landing Clearing flags on attachment: 317263 Committed r220287: <http://trac.webkit.org/changeset/220287> 1335409 7 commit-queue 2017-08-04 13:01:21 -0700 All reviewed patches have been landed. Closing bug. 317163 2017-08-03 15:05:41 -0700 2017-08-04 11:55:04 -0700 Proposed patch patch_buildbot_os_dashboard_regex.txt text/plain 1800 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDIzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA4LTAzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEYXNoYm9hcmQgYnViYmxlcyBzb21ldGltZXMgc2hvdyBmYWlsdXJlIGNv dW50IGluc3RlYWQgb2YgY3Jhc2ggY291bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTE1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM3MDkw MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3RSZXN1bHRzLmpzOgorICAgICAgICAoQnVpbGRib3RU ZXN0UmVzdWx0cy5wcm90b3R5cGUucmVzdWx0U3VtbWFyaXplcik6IFVzZSB0aGUgcmVnZXggZm9y IHRoZSBwcmVjaXNlIG1hdGNoIGZpcnN0LgorCiAyMDE3LTA4LTAzICBDYXJsb3MgQWxiZXJ0byBM b3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dLRV0gUGFz cyB0aGUgLS1tZW1vcnktbGltaXRlZCBvcHRpb24gb24gdGhlIEdUSyBhbmQgV1BFIGJ1aWxkYm90 cyBmb3IgdGhlIEpTQyB0ZXN0cy4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90 VGVzdFJlc3VsdHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRi b3RUZXN0UmVzdWx0cy5qcwkocmV2aXNpb24gMjIwMjMxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Njcmlw dHMvQnVpbGRib3RUZXN0UmVzdWx0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNzUsMTAgKzc1LDEw IEBAIEJ1aWxkYm90VGVzdFJlc3VsdHMucHJvdG90eXBlID0gewogCiAgICAgICAgIGZ1bmN0aW9u IHJlc3VsdFN1bW1hcml6ZXIobWF0Y2hTdHJpbmcsIHN1bSwgb3V0cHV0TGluZSkKICAgICAgICAg ewotICAgICAgICAgICAgdmFyIG1hdGNoID0gL14oXGQrKVxzLy5leGVjKG91dHB1dExpbmUpOwor ICAgICAgICAgICAgdmFyIHJlZ2V4ID0gbmV3IFJlZ0V4cCgiKFxcZCspXFxzIiArIG1hdGNoU3Ry aW5nKTsKKyAgICAgICAgICAgIG1hdGNoID0gcmVnZXguZXhlYyhvdXRwdXRMaW5lKTsKICAgICAg ICAgICAgIGlmICghbWF0Y2gpIHsKLSAgICAgICAgICAgICAgICB2YXIgcmVnZXggPSBuZXcgUmVn RXhwKCIoXFxkKylcXHMiICsgbWF0Y2hTdHJpbmcpOwotICAgICAgICAgICAgICAgIG1hdGNoID0g cmVnZXguZXhlYyhvdXRwdXRMaW5lKTsKKyAgICAgICAgICAgICAgICBtYXRjaCA9IC9eKFxkKylc cy8uZXhlYyhvdXRwdXRMaW5lKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmICghbWF0 Y2gpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHN1bTsK 317263 2017-08-04 11:55:04 -0700 2017-08-04 13:01:19 -0700 Patch for landing patch_buildbot_os_dashboard_regex_v2.txt text/plain 1803 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDI4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA4LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEYXNoYm9hcmQgYnViYmxlcyBzb21ldGltZXMgc2hvdyBmYWlsdXJlIGNv dW50IGluc3RlYWQgb2YgY3Jhc2ggY291bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTE1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM3MDkw MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90VGVzdFJlc3VsdHMuanM6CisgICAgICAgIChCdWls ZGJvdFRlc3RSZXN1bHRzLnByb3RvdHlwZS5yZXN1bHRTdW1tYXJpemVyKTogVXNlIHRoZSByZWdl eCBmb3IgdGhlIHByZWNpc2UgbWF0Y2ggZmlyc3QuCisKIDIwMTctMDgtMDQgIE1hdHQgTGV3aXMg IDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MjIwMjcxLgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RUZXN0UmVzdWx0cy5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3RSZXN1bHRz LmpzCShyZXZpc2lvbiAyMjAyODApCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRl c3RSZXN1bHRzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC03NSwxMCArNzUsMTEgQEAgQnVpbGRib3RU ZXN0UmVzdWx0cy5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVuY3Rpb24gcmVzdWx0U3VtbWFy aXplcihtYXRjaFN0cmluZywgc3VtLCBvdXRwdXRMaW5lKQogICAgICAgICB7Ci0gICAgICAgICAg ICB2YXIgbWF0Y2ggPSAvXihcZCspXHMvLmV4ZWMob3V0cHV0TGluZSk7CisgICAgICAgICAgICAv LyBTYW1wbGUgb3V0cHV0TGluZTogIjUzIGZhaWx1cmVzIDM3IG5ldyBwYXNzZXMgMSBjcmFzaGVz IgorICAgICAgICAgICAgdmFyIHJlZ2V4ID0gbmV3IFJlZ0V4cCgiKFxcZCspXFxzIiArIG1hdGNo U3RyaW5nKTsKKyAgICAgICAgICAgIG1hdGNoID0gcmVnZXguZXhlYyhvdXRwdXRMaW5lKTsKICAg ICAgICAgICAgIGlmICghbWF0Y2gpIHsKLSAgICAgICAgICAgICAgICB2YXIgcmVnZXggPSBuZXcg UmVnRXhwKCIoXFxkKylcXHMiICsgbWF0Y2hTdHJpbmcpOwotICAgICAgICAgICAgICAgIG1hdGNo ID0gcmVnZXguZXhlYyhvdXRwdXRMaW5lKTsKKyAgICAgICAgICAgICAgICBtYXRjaCA9IC9eKFxk Kylccy8uZXhlYyhvdXRwdXRMaW5lKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmICgh bWF0Y2gpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHN1bTsK