175147 2017-08-03 12:38:41 -0700 [Win] DRT should only allow any https certificate for localhost. 2017-11-17 14:37:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Windows 10 RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen ap bfulgham dbates lforschler webkit-bug-importer oldest_to_newest 1334891 0 pvollan 2017-08-03 12:38:41 -0700 The same restriction is enforced on macOS. 1334906 1 317142 pvollan 2017-08-03 13:13:26 -0700 Created attachment 317142 Patch 1334909 2 317144 pvollan 2017-08-03 13:21:04 -0700 Created attachment 317144 Patch 1334964 3 317144 ap 2017-08-03 15:04:56 -0700 Comment on attachment 317144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317144&action=review > Source/WebCore/ChangeLog:3 > + [Win] DRT should only allow any https certificate for localhost. Is SSL completely broken on Windows? There is a change in WebCore, what is its impact other than on testing? 1334988 4 pvollan 2017-08-03 15:37:51 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 317144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317144&action=review > > > Source/WebCore/ChangeLog:3 > > + [Win] DRT should only allow any https certificate for localhost. > > Is SSL completely broken on Windows? There is a change in WebCore, what is > its impact other than on testing? SSL works on Windows, but SSL tests are failing because the layout test certificate has expired. To work around this, I recently committed a change to allow any https certificate in layout tests, but this was not enough to get SSL tests to pass, since there appears to be a bug in CFNetwork on Windows where the certificate will not be accepted when the certificate chain validation is skipped. This is addressed in this patch, and I believe it only will impact WebKit on Windows clients which allow any https certificate. It actually makes the certificate check a little stricter when any https certificate is allowed, since the certificate chain validation is not skipped with this patch. 1337046 5 pvollan 2017-08-09 11:01:25 -0700 I believe this patch fixes ~40 layout tests :) 1337086 6 ap 2017-08-09 12:53:31 -0700 Brent or Alex would be the best reviewers for this change I think. 1340107 7 317144 bfulgham 2017-08-18 09:28:58 -0700 Comment on attachment 317144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317144&action=review r=me assuming you add the Radar reference I requested. > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:183 > CFDictionaryAddValue(sslProps.get(), kCFStreamSSLValidatesCertificateChain, kCFBooleanFalse); Is this a bug in CFNetwork on Windows? Can you add a <rdar> reference for this, if it is? > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1217 > + request->setAllowsAnyHTTPSCertificate(); This is a harmless check, but I'm not sure it's necessary since DRT only runs against servers we specify. 1340621 8 pvollan 2017-08-21 09:35:55 -0700 (In reply to Brent Fulgham from comment #7) > Comment on attachment 317144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317144&action=review > > r=me assuming you add the Radar reference I requested. > > > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:183 > > CFDictionaryAddValue(sslProps.get(), kCFStreamSSLValidatesCertificateChain, kCFBooleanFalse); > > Is this a bug in CFNetwork on Windows? Can you add a <rdar> reference for > this, if it is? Yes. I will add a <rdar> reference. Thanks for reviewing! 1340631 9 pvollan 2017-08-21 10:22:42 -0700 Committed r220970: <https://trac.webkit.org/changeset/220970/webkit> 1373262 10 webkit-bug-importer 2017-11-17 13:42:07 -0800 <rdar://problem/35622830> 1373263 11 webkit-bug-importer 2017-11-17 13:42:10 -0800 <rdar://problem/35622831> 317142 2017-08-03 13:13:26 -0700 2017-08-03 13:21:03 -0700 Patch bug-175147-20170803221326.patch text/plain 3351 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA4LTAzICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBEUlQgc2hvdWxk IG9ubHkgYWxsb3cgYW55IGh0dHBzIGNlcnRpZmljYXRlIGZvciBsb2NhbGhvc3QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUxNDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxpbmcgdmFsaWRh dGlvbiBvZiBjZXJ0aWZpY2F0ZSBjaGFpbnMsIGJyZWFrcyBTU0wgb24gV2luZG93cy4gSW4gb3Jk ZXIKKyAgICAgICAgZm9yIFNTTCB0ZXN0cyB0byBzdWNjZWVkIG9uIFdpbmRvd3MsIHdlIHNob3Vs ZCBhdm9pZCBkaXNhYmxpbmcgaXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJj ZUhhbmRsZUNGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpjcmVh dGVDRlVSTENvbm5lY3Rpb24pOgorCiAyMDE3LTA4LTAzICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBGYWN0b3IgY29tbW9uIGNvZGUgaW4gU3R5bGU6OipDaGFu Z2VJbnZhbGlkYXRpb24gaW50byBoZWxwZXIgZnVuY3Rpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5l dC5jcHAJKHJldmlzaW9uIDIyMDIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OSw3ICsx NzksOSBAQCB2b2lkIFJlc291cmNlSGFuZGxlOjpjcmVhdGVDRlVSTENvbm5lY3RpCiAgICAgICAg IENGRGljdGlvbmFyeUFkZFZhbHVlKHNzbFByb3BzLmdldCgpLCBrQ0ZTdHJlYW1TU0xBbGxvd3NF eHBpcmVkUm9vdHMsIGtDRkJvb2xlYW5UcnVlKTsKICAgICAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFs dWUoc3NsUHJvcHMuZ2V0KCksIGtDRlN0cmVhbVNTTEFsbG93c0V4cGlyZWRDZXJ0aWZpY2F0ZXMs IGtDRkJvb2xlYW5UcnVlKTsKICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyNpZiAhUExB VEZPUk0oV0lOKSAvLyBEaXNhYmxpbmcgdmFsaWRhdGlvbiBvZiBjZXJ0aWZpY2F0ZSBjaGFpbiBi cmVha3MgU1NMIG9uIFdpbmRvd3MuCiAgICAgICAgIENGRGljdGlvbmFyeUFkZFZhbHVlKHNzbFBy b3BzLmdldCgpLCBrQ0ZTdHJlYW1TU0xWYWxpZGF0ZXNDZXJ0aWZpY2F0ZUNoYWluLCBrQ0ZCb29s ZWFuRmFsc2UpOworI2VuZGlmCiAgICAgfQogCiAgICAgYXV0byBjbGllbnRDZXJ0ID0gY2xpZW50 Q2VydGlmaWNhdGVzKCkuZmluZChmaXJzdFJlcXVlc3QoKS51cmwoKS5ob3N0KCkpOwpJbmRleDog VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24g MjIwMjIxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTctMDgtMDMgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisg ICAgICAgIFtXaW5dIERSVCBzaG91bGQgb25seSBhbGxvdyBhbnkgaHR0cHMgY2VydGlmaWNhdGUg Zm9yIGxvY2FsaG9zdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NTE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBjaGVjayB0byBtYWtlIHN1cmUgb25seSBsb2NhbGhvc3QgcmVxdWVzdHMgYWxs b3cgYW55IGh0dHBzIGNlcnRpZmljYXRlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2lu L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHJ1blRlc3QpOgorCiAyMDE3LTA4LTAzICBD YXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdW1dLRV0gUGFzcyB0aGUgLS1tZW1vcnktbGltaXRlZCBvcHRpb24gb24gdGhlIEdUSyBh bmQgV1BFIGJ1aWxkYm90cyBmb3IgdGhlIEpTQyB0ZXN0cy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gMjIwMjA1KQorKysgVG9v bHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTEyNSw2ICsxMTI1LDggQEAgc3RhdGljIHZvaWQgcnVuVGVzdChjb25zdCBzdHJpbmcmIGlu cHV0TAogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgU3RyaW5nIGhvc3ROYW1lID0gU3Ry aW5nKGFkb3B0Q0YoQ0ZVUkxDb3B5SG9zdE5hbWUodXJsKSkuZ2V0KCkpOworCiAgICAgU3RyaW5n IGZhbGxiYWNrUGF0aCA9IGZpbmRGb250RmFsbGJhY2socGF0aE9yVVJMLmNfc3RyKCkpOwogCiAg ICAgc3RyID0gQ0ZVUkxHZXRTdHJpbmcodXJsKTsKQEAgLTEyMTEsNiArMTIxMyw4IEBAIHN0YXRp YyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5nJiBpbnB1dEwKIAogICAgIHJlcXVlc3QtPmluaXRX aXRoVVJMKHVybEJTdHIsIFdlYlVSTFJlcXVlc3RVc2VQcm90b2NvbENhY2hlUG9saWN5LCA2MCk7 CiAgICAgcmVxdWVzdC0+c2V0SFRUUE1ldGhvZChtZXRob2RCU3RyKTsKKyAgICBpZiAoaG9zdE5h bWUgPT0gImxvY2FsaG9zdCIgfHwgaG9zdE5hbWUgPT0gIjEyNy4wLjAuMSIpCisgICAgICAgIHJl cXVlc3QtPnNldEFsbG93c0FueUhUVFBTQ2VydGlmaWNhdGUoKTsKICAgICBmcmFtZS0+bG9hZFJl cXVlc3QocmVxdWVzdC5nZXQoKSk7CiAKICAgICB3aGlsZSAoIWRvbmUpIHsK 317144 2017-08-03 13:21:04 -0700 2017-08-18 09:28:58 -0700 Patch bug-175147-20170803222104.patch text/plain 3372 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDIyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA4LTAzICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBEUlQgc2hvdWxk IG9ubHkgYWxsb3cgYW55IGh0dHBzIGNlcnRpZmljYXRlIGZvciBsb2NhbGhvc3QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUxNDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxpbmcgdmFsaWRh dGlvbiBvZiBjZXJ0aWZpY2F0ZSBjaGFpbnMsIGJyZWFrcyBTU0wgb24gV2luZG93cy4gSW4gb3Jk ZXIKKyAgICAgICAgZm9yIFNTTCB0ZXN0cyB0byBzdWNjZWVkIG9uIFdpbmRvd3MsIHdlIHNob3Vs ZCBhdm9pZCBkaXNhYmxpbmcgaXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJj ZUhhbmRsZUNGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpjcmVh dGVDRlVSTENvbm5lY3Rpb24pOgorCiAyMDE3LTA4LTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU1cgSURMcyBhbmQgc3R1YiBvdXQgYmFzaWMgZnVu Y3Rpb25hbGl0eS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVz b3VyY2VIYW5kbGVDRk5ldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNwcAkocmV2aXNpb24gMjIwMjIxKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc5LDcgKzE3OSw5IEBAIHZvaWQgUmVzb3VyY2VIYW5k bGU6OmNyZWF0ZUNGVVJMQ29ubmVjdGkKICAgICAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoc3Ns UHJvcHMuZ2V0KCksIGtDRlN0cmVhbVNTTEFsbG93c0V4cGlyZWRSb290cywga0NGQm9vbGVhblRy dWUpOwogICAgICAgICBDRkRpY3Rpb25hcnlBZGRWYWx1ZShzc2xQcm9wcy5nZXQoKSwga0NGU3Ry ZWFtU1NMQWxsb3dzRXhwaXJlZENlcnRpZmljYXRlcywga0NGQm9vbGVhblRydWUpOwogI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIHBvcAorI2lmICFQTEFURk9STShXSU4pIC8vIERpc2FibGluZyB2 YWxpZGF0aW9uIG9mIGNlcnRpZmljYXRlIGNoYWluIGJyZWFrcyBTU0wgb24gV2luZG93cy4KICAg ICAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoc3NsUHJvcHMuZ2V0KCksIGtDRlN0cmVhbVNTTFZh bGlkYXRlc0NlcnRpZmljYXRlQ2hhaW4sIGtDRkJvb2xlYW5GYWxzZSk7CisjZW5kaWYKICAgICB9 CiAKICAgICBhdXRvIGNsaWVudENlcnQgPSBjbGllbnRDZXJ0aWZpY2F0ZXMoKS5maW5kKGZpcnN0 UmVxdWVzdCgpLnVybCgpLmhvc3QoKSk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjAyMjEpCisrKyBUb29scy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOC0wMyAgUGVyIEFybmUg Vm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gRFJUIHNob3VsZCBv bmx5IGFsbG93IGFueSBodHRwcyBjZXJ0aWZpY2F0ZSBmb3IgbG9jYWxob3N0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MTQ3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNoZWNrIHRvIG1ha2Ug c3VyZSBvbmx5IGxvY2FsaG9zdCByZXF1ZXN0cyBhbGxvdyBhbnkgaHR0cHMgY2VydGlmaWNhdGUu CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAg ICAgICAocnVuVGVzdCk6CisKIDIwMTctMDgtMDMgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6 ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV0tFXSBQYXNzIHRoZSAtLW1l bW9yeS1saW1pdGVkIG9wdGlvbiBvbiB0aGUgR1RLIGFuZCBXUEUgYnVpbGRib3RzIGZvciB0aGUg SlNDIHRlc3RzLgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCShyZXZpc2lvbiAyMjAyMjEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVt cFJlbmRlclRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTI1LDYgKzExMjUsOCBAQCBzdGF0 aWMgdm9pZCBydW5UZXN0KGNvbnN0IHN0cmluZyYgaW5wdXRMCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKKyAgICBTdHJpbmcgaG9zdE5hbWUgPSBTdHJpbmcoYWRvcHRDRihDRlVSTENvcHlIb3N0 TmFtZSh1cmwpKS5nZXQoKSk7CisKICAgICBTdHJpbmcgZmFsbGJhY2tQYXRoID0gZmluZEZvbnRG YWxsYmFjayhwYXRoT3JVUkwuY19zdHIoKSk7CiAKICAgICBzdHIgPSBDRlVSTEdldFN0cmluZyh1 cmwpOwpAQCAtMTIxMSw3ICsxMjEzLDggQEAgc3RhdGljIHZvaWQgcnVuVGVzdChjb25zdCBzdHJp bmcmIGlucHV0TAogCiAgICAgcmVxdWVzdC0+aW5pdFdpdGhVUkwodXJsQlN0ciwgV2ViVVJMUmVx dWVzdFVzZVByb3RvY29sQ2FjaGVQb2xpY3ksIDYwKTsKICAgICByZXF1ZXN0LT5zZXRIVFRQTWV0 aG9kKG1ldGhvZEJTdHIpOwotICAgIHJlcXVlc3QtPnNldEFsbG93c0FueUhUVFBTQ2VydGlmaWNh dGUoKTsKKyAgICBpZiAoaG9zdE5hbWUgPT0gImxvY2FsaG9zdCIgfHwgaG9zdE5hbWUgPT0gIjEy Ny4wLjAuMSIpCisgICAgICAgIHJlcXVlc3QtPnNldEFsbG93c0FueUhUVFBTQ2VydGlmaWNhdGUo KTsKICAgICBmcmFtZS0+bG9hZFJlcXVlc3QocmVxdWVzdC5nZXQoKSk7CiAKICAgICB3aGlsZSAo IWRvbmUpIHsK