175143 2017-08-03 11:27:54 -0700 REGRESSION (r220052):VideoControlsManager.VideoControlsManagerMultipleVideosWithAudioAndAutoplay is a flaky API test. 2025-12-31 01:03:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=175329 https://bugs.webkit.org/show_bug.cgi?id=130653 https://bugs.webkit.org/show_bug.cgi?id=175909 InRadar P2 Normal --- 1 jlewis3 jer.noble achristensen ap jer.noble peng.liu6 ryanhaddad s3s3_55 webkit-bug-importer youennf oldest_to_newest 1334850 0 jlewis3 2017-08-03 11:27:54 -0700 VideoControlsManager.VideoControlsManagerMultipleVideosWithAudioAndAutoplay has been a flaky timeout on macOS Sierra. The test first failed with this build: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/3552 https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/3552/steps/run-api-tests/logs/stdio The test became flaky after the revision: https://trac.webkit.org/changeset/220053/webkit However I don't think this was the cause. 1336160 1 webkit-bug-importer 2017-08-07 15:03:48 -0700 <rdar://problem/33762612> 1337186 2 jlewis3 2017-08-09 15:47:30 -0700 Spoke with Jer about the Timeout and determined the regression point is most likely https://trac.webkit.org/changeset/220052/webkit and likely deals with the change in html/HTMLMediaElement.cpp 1338416 3 ryanhaddad 2017-08-14 11:33:07 -0700 Skipped this flaky test in https://trac.webkit.org/changeset/220711/webkit 1392055 4 332028 jer.noble 2018-01-23 07:22:21 -0800 Created attachment 332028 Patch 1683178 5 332028 peng.liu6 2020-08-26 16:05:52 -0700 Comment on attachment 332028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332028&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:157 > +TEST(VideoControlsManager, VideoControlsManagerMultipleVideosWithAudioAndAutoplay) Looks like this test still fails on Mac. 1683309 6 332028 youennf 2020-08-27 01:10:48 -0700 Comment on attachment 332028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332028&action=review > Tools/ChangeLog:9 > + Add the same "twice through the event loop" fix for this tast as was done in r221589. s/tast/task/ > Tools/TestWebKitAPI/Tests/WebKitCocoa/large-videos-with-audio-autoplay.html:7 > + // to happen in a certain number of timeouts. Is there a way to make Internals API know whether controls are visible? If so, we could inject Internals in that test instead of using setTimeout. > Tools/TestWebKitAPI/Tests/WebKitCocoa/large-videos-with-audio-autoplay.html:10 > + webkit.messageHandlers.testHandler.postMessage("autoplaying"); Should it be "autoplayed" instead of "autoplaying"? 1810714 7 332028 achristensen 2021-11-01 12:01:16 -0700 Comment on attachment 332028 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 332028 2018-01-23 07:22:21 -0800 2021-11-01 12:01:16 -0700 Patch bug-175143-20180123072220.patch text/plain 2974 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3MDA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGIxMjliYmUyNWY3YWVhOGI0YTQwMTRmZGI3Y2Y3YzEz OGIwOGI3Yi4uZDg0ZmU4YjBkOWRhMTA2YWNhZDBlMGQ5NTM5YzI0YWQzOTgwZjA0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTAxLTIzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIyMjAwNTIpOlZpZGVvQ29udHJvbHNNYW5hZ2VyLlZpZGVvQ29udHJv bHNNYW5hZ2VyTXVsdGlwbGVWaWRlb3NXaXRoQXVkaW9BbmRBdXRvcGxheSBpcyBhIGZsYWt5IEFQ SSB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc1MTQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzc2MjYxMj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHNhbWUgInR3aWNlIHRo cm91Z2ggdGhlIGV2ZW50IGxvb3AiIGZpeCBmb3IgdGhpcyB0YXN0IGFzIHdhcyBkb25lIGluIHIy MjE1ODkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1ZpZGVv Q29udHJvbHNNYW5hZ2VyLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9sYXJnZS12aWRlb3Mtd2l0aC1h dWRpby1hdXRvcGxheS5odG1sOgorCiAyMDE4LTAxLTE2ICBaYWNoIExpICA8emFjaGxpQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgcG9wLXVwIHBvbGljeSBzdXBwb3J0IGluIHdlYnNpdGUgcG9s aWNpZXMuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1ZpZGVvQ29udHJvbHNNYW5hZ2VyLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9WaWRlb0NvbnRyb2xzTWFuYWdlci5tbQppbmRleCBjNmRjMDA5MDM2NmVlYTJhZmE5 ZjliOTllZjRiODYyNWM3MGFlYmI5Li5kMTkyYzRhYmZjMjlkOTIzMDFlYTg4ODNhMjJmMWEwMDhh ODQ2NzNmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1ZpZGVvQ29udHJvbHNNYW5hZ2VyLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvVmlkZW9Db250cm9sc01hbmFnZXIubW0KQEAgLTE1NCw4ICsxNTQsNyBAQCBU RVNUKFZpZGVvQ29udHJvbHNNYW5hZ2VyLCBWaWRlb0NvbnRyb2xzTWFuYWdlck11bHRpcGxlVmlk ZW9zV2l0aEF1ZGlvKQogICAgIEVYUEVDVF9GQUxTRShbd2ViVmlldyBfaGFzQWN0aXZlVmlkZW9G b3JDb250cm9sc01hbmFnZXJdKTsKIH0KIAotLy8gRklYTUU6IFJlLWVuYWJsZSB0aGlzIHRlc3Qg b25jZSA8d2Via2l0Lm9yZy9iLzE3NTE0Mz4gaXMgcmVzb2x2ZWQuCi1URVNUKFZpZGVvQ29udHJv bHNNYW5hZ2VyLCBESVNBQkxFRF9WaWRlb0NvbnRyb2xzTWFuYWdlck11bHRpcGxlVmlkZW9zV2l0 aEF1ZGlvQW5kQXV0b3BsYXkpCitURVNUKFZpZGVvQ29udHJvbHNNYW5hZ2VyLCBWaWRlb0NvbnRy b2xzTWFuYWdlck11bHRpcGxlVmlkZW9zV2l0aEF1ZGlvQW5kQXV0b3BsYXkpCiB7CiAgICAgUmV0 YWluUHRyPFZpZGVvQ29udHJvbHNNYW5hZ2VyVGVzdFdlYlZpZXcqPiB3ZWJWaWV3ID0gc2V0VXBX ZWJWaWV3Rm9yVGVzdGluZ1ZpZGVvQ29udHJvbHNNYW5hZ2VyKE5TTWFrZVJlY3QoMCwgMCwgMTAw LCAxMDApKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9sYXJnZS12aWRlb3Mtd2l0aC1hdWRpby1hdXRvcGxheS5odG1sIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9sYXJnZS12aWRlb3Mtd2l0aC1hdWRpby1hdXRvcGxh eS5odG1sCmluZGV4IDNlMTcwY2VkNWQyOWRlYTJlMGQzN2JmZTg2MTZmZGVkNTNmYTkzODMuLmVl ZDk2YTU2YTRhM2I0YTU4MTU3ZGJhMGY4Y2QzMmYzM2M3Y2ZiNmMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvbGFyZ2UtdmlkZW9zLXdpdGgtYXVkaW8t YXV0b3BsYXkuaHRtbAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L2xhcmdlLXZpZGVvcy13aXRoLWF1ZGlvLWF1dG9wbGF5Lmh0bWwKQEAgLTIsMTIgKzIsMTQgQEAK IDxodG1sPgogPHNjcmlwdD4KICAgICBmdW5jdGlvbiBiZWdhbkF1dG9wbGF5aW5nKCkgeworICAg ICAgICAvLyBBcyBvZiB0aGlzIHdyaXRpbmcsIHR3byB0aW1lcyB0aHJvdWdoIHRoZSBydW4gbG9v cCBpcyBsb25nIGVub3VnaCBmb3IgdGhlIGNvbnRyb2xzIHRvIGNvbWUgdXAuCisgICAgICAgIC8v IFRoZXJlJ3Mgbm8gZ3VhcmFudGVlOyB3aGV0aGVyIHRoZSBjb250cm9scyBhcmUgdmlzaWJsZSBp cyBub3Qgd2ViIGV4cG9zZWQsIHNvIGl0IGRvZXNuJ3QgaGF2ZQorICAgICAgICAvLyB0byBoYXBw ZW4gaW4gYSBjZXJ0YWluIG51bWJlciBvZiB0aW1lb3V0cy4KICAgICAgICAgc2V0VGltZW91dChm dW5jdGlvbigpIHsKLSAgICAgICAgICAgIHRyeSB7Ci0gICAgICAgICAgICAgICAgd2luZG93Lndl YmtpdC5tZXNzYWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1lc3NhZ2UoImF1dG9wbGF5ZWQi KTsKLSAgICAgICAgICAgIH0gY2F0Y2goZSkgewotICAgICAgICAgICAgfQotICAgICAgICB9LCAw KQorICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICB3 ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5kbGVyLnBvc3RNZXNzYWdlKCJhdXRvcGxheWlu ZyIpOworICAgICAgICAgICAgfSwgMCk7CisgICAgICAgIH0sIDApOwogICAgIH0KIDwvc2NyaXB0 PgogPGJvZHk+Cg==