175140 2017-08-03 10:37:46 -0700 [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests. 2022-03-01 02:36:52 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=174502 https://bugs.webkit.org/show_bug.cgi?id=175100 https://bugs.webkit.org/show_bug.cgi?id=171630 https://bugs.webkit.org/show_bug.cgi?id=175150 InRadar P2 Normal --- 1 clopez clopez aakash_jain ap bugs-noreply lforschler ossy saam webkit-bug-importer oldest_to_newest 1334828 0 clopez 2017-08-03 10:37:46 -0700 We are having lately (not sure when this started, but as time goes is getting worse and worse) lots of issues with JSC tests causing OOM problems on the GTK+ and WPE bots. Sometimes even bringing the machines down requiring a hard reboot. The machines have as much as RAM as the Mac bots. However meanwhile the Mac bots seem to handle this fine, Linux bots don't. Follow the bugs on the see also list to read more details about this if you are interested. The best thing we can do now is to workaround this by disabling all the tests marked as memoryLimited on the GTK and WPE bots. We may revise this on the future when we understand better what causes this. 1334846 1 317131 clopez 2017-08-03 11:21:30 -0700 Created attachment 317131 Patch 1334847 2 aakash_jain 2017-08-03 11:25:05 -0700 looks fine to me. 1334882 3 317131 ap 2017-08-03 12:23:08 -0700 Comment on attachment 317131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317131&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:338 > + # Linux bots have problems with JSC tests that try to use large amounts of memory. It would help to have a link to more information right here. It's of course possible to get back to the bug using svn blame, but having the link in the comment will save some time in the future. The questions people will be asking are "Can I remove this now? What should I test to confirm whether I can?" 1334886 4 clopez 2017-08-03 12:37:22 -0700 Committed r220221: <http://trac.webkit.org/changeset/220221> 1334889 5 webkit-bug-importer 2017-08-03 12:38:27 -0700 <rdar://problem/33706286> 317131 2017-08-03 11:21:30 -0700 2022-03-01 02:36:52 -0800 Patch bug-175140-20170803202128.patch text/plain 2145 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMjEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzg3NWJmODUxNmNiNjM5NTVhZThhZjNlODU5ZTFkMzhj ZGFkYjliMy4uNTk5YTRkZWJmY2U4OWU5ZmQzZWE0MzNiMjhiYzFlZGNiODkwZDVlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE3LTA4LTAzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dLRV0gUGFzcyB0aGUgLS1tZW1vcnktbGltaXRlZCBv cHRpb24gb24gdGhlIEdUSyBhbmQgV1BFIGJ1aWxkYm90cyBmb3IgdGhlIEpTQyB0ZXN0cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTE0MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFyZSBoYXZp bmcgbGF0ZWx5IGlzc3VlcyB3aXRoIEpTQyB0ZXN0cyBjYXVzaW5nIHByb2JsZW1zIG9uCisgICAg ICAgIHRoZSBHVEsrIGFuZCBXUEUgYm90cyBkdWUgdG8gdGhlIGhpZ2ggYW1vdW50IG9mIG1lbW9y eSBzb21lIHRlc3RzCisgICAgICAgIG5lZWQgdG8gcnVuLgorCisgICAgICAgIFRoZSBiZXN0IHRo aW5nIHdlIGNhbiBkbyBub3cgaXMgdG8gd29ya2Fyb3VuZCB0aGlzIGJ5IGRpc2FibGluZworICAg ICAgICBhbGwgdGhlIHRlc3RzIG1hcmtlZCBhcyBtZW1vcnlMaW1pdGVkIG9uIHRoZSBHVEsgYW5k IFdQRSBib3RzLgorICAgICAgICBXZSBtYXkgcmV2aXNlIHRoaXMgb24gdGhlIGZ1dHVyZS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rl ci5jZmc6CisgICAgICAgIChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLnN0YXJ0KToKKwogMjAxNy0w OC0wMyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dp bl0gVGhlIHRlc3QgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvdXBn cmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy9iYXNpYy11cGdyYWRlLmh0dHBzLmh0bWwgaXMgZmFpbGlu Zy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDAwNGNlODVlYzUwNzRmNzRiMWU2NDEzNzEyY2Y4 NTEyNWEwODZkNDMuLmRlZGNjMjliODVjYmNkMjBiOTY2MjY0NDFjZDFkNjlkYjQ1ZGZkZmYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvbWFzdGVyLmNmZwpAQCAtMzM0LDcgKzMzNCwxMSBAQCBjbGFzcyBSdW5KYXZhU2Ny aXB0Q29yZVRlc3RzKFRlc3RXaXRoRmFpbHVyZUNvdW50KToKICAgICBsb2dmaWxlcyA9IHsianNv biI6IGpzb25GaWxlTmFtZX0KIAogICAgIGRlZiBzdGFydChzZWxmKToKLSAgICAgICAgYXBwZW5k Q3VzdG9tQnVpbGRGbGFncyhzZWxmLCBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpLCBzZWxm LmdldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nKSkKKyAgICAgICAgcGxhdGZvcm0gPSBzZWxmLmdl dFByb3BlcnR5KCdwbGF0Zm9ybScpCisgICAgICAgICMgTGludXggYm90cyBoYXZlIHByb2JsZW1z IHdpdGggSlNDIHRlc3RzIHRoYXQgdHJ5IHRvIHVzZSBsYXJnZSBhbW91bnRzIG9mIG1lbW9yeS4K KyAgICAgICAgaWYgcGxhdGZvcm0gaW4gKCdndGsnLCAnd3BlJyk6CisgICAgICAgICAgICBzZWxm LnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLW1lbW9yeS1saW1pdGVkJ10pCisgICAgICAg IGFwcGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxhdGZvcm0sIHNlbGYuZ2V0UHJvcGVydHko J2Z1bGxQbGF0Zm9ybScpKQogICAgICAgICByZXR1cm4gc2hlbGwuVGVzdC5zdGFydChzZWxmKQog CiAgICAgZGVmIGNvdW50RmFpbHVyZXMoc2VsZiwgY21kKToK