175101 2017-08-02 16:58:55 -0700 [Win] WebKit COM header file is not placed in the correct location. 2017-08-03 07:48:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue matthew_hanson webkit-bug-importer oldest_to_newest 1334494 0 pvollan 2017-08-02 16:58:55 -0700 When building WebKit with the WebKitLegacy.proj project file, the WebKitCOMAPI.h file is not copied to the correct location. 1334511 1 317039 pvollan 2017-08-02 17:17:13 -0700 Created attachment 317039 Patch 1334553 2 matthew_hanson 2017-08-02 18:22:46 -0700 Looks good to me, but I don't have reviewer privileges. 1334632 3 317039 bfulgham 2017-08-02 20:46:42 -0700 Comment on attachment 317039 Patch r=me 1334768 4 pvollan 2017-08-03 07:19:11 -0700 Thanks for reviewing! 1334775 5 317039 commit-queue 2017-08-03 07:47:51 -0700 Comment on attachment 317039 Patch Clearing flags on attachment: 317039 Committed r220205: <http://trac.webkit.org/changeset/220205> 1334776 6 commit-queue 2017-08-03 07:47:52 -0700 All reviewed patches have been landed. Closing bug. 1334777 7 webkit-bug-importer 2017-08-03 07:48:55 -0700 <rdar://problem/33699866> 317039 2017-08-02 17:17:13 -0700 2017-08-03 07:47:51 -0700 Patch bug-175101-20170803021712.patch text/plain 5772 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjAxNDcpCisrKyBTb3VyY2UvV2Vi S2l0TGVnYWN5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3 LTA4LTAyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBb V2luXSBXZWJLaXQgQ09NIGhlYWRlciBmaWxlIGlzIG5vdCBwbGFjZWQgaW4gdGhlIGNvcnJlY3Qg bG9jYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzUxMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZnRlciB0aGUgdHJhbnNpdGlvbiB0byBXZWJLaXRMZWdhY3ksIHRoZSBnZW5lcmF0ZWQgV2Vi S2l0IGhlYWRlciBmaWxlcyBzaG91bGQgc3RpbGwKKyAgICAgICAgYmUgcGxhY2VkIGluIHRoZSBX ZWJLaXQgZm9sZGVyLCBzbyBXZWJLaXQgY2xpZW50cyB3aWxsIGZpbmQgdGhlIGhlYWRlciBmaWxl cyBpbiB0aGUKKyAgICAgICAgc2FtZSBwbGFjZS4KKworICAgICAgICAqIFdlYktpdExlZ2FjeS52 Y3hwcm9qL1dlYktpdExlZ2FjeS5wcm9qOgorCiAyMDE3LTA4LTAyICBNYXR0aGV3IEhhbnNvbiAg PG1hdHRoZXdfaGFuc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZC1maXggZm9yIFdpbmRv d3MgaW4gVmlzdWFsIFN0dWRpbyBhZnRlciBkaXJlY3RvcnkgcmVuYW1lLgpJbmRleDogU291cmNl L1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kudmN4cHJvai9XZWJLaXRMZWdhY3kucHJvago9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS52Y3hwcm9qL1dlYktp dExlZ2FjeS5wcm9qCShyZXZpc2lvbiAyMjAxNDcpCisrKyBTb3VyY2UvV2ViS2l0TGVnYWN5L1dl YktpdExlZ2FjeS52Y3hwcm9qL1dlYktpdExlZ2FjeS5wcm9qCSh3b3JraW5nIGNvcHkpCkBAIC00 Nyw3ICs0Nyw3IEBACiAgICAgPE1lc3NhZ2UgVGV4dD0iQnVpbGQgb3V0cHV0IC0+ICQoT0JKUk9P VCkiIC8+DQogICAgIDxNZXNzYWdlIFRleHQ9IkZpbmFsIG91dHB1dCAtPiAkKERTVFJPT1QpIiAv Pg0KICAgICA8TWFrZURpciBEaXJlY3Rvcmllcz0iJChBcHBsZUludGVybmFsTGliMzIpOyQoQXBw bGVJbnRlcm5hbExpYjY0KTskKEFwcGxlSW50ZXJuYWxCaW4zMik7JChBcHBsZUludGVybmFsQmlu NjQpOyQoQXBwbGVJbnRlcm5hbDMyU3ltYm9scyk7JChBcHBsZUludGVybmFsNjRTeW1ib2xzKTsk KEFwcGxlSW50ZXJuYWwpXGluY2x1ZGU7JChEU1RST09UKVwkKFByb2dyYW1GaWxlc0FBUzMyKTsk KERTVFJPT1QpXCQoUHJvZ3JhbUZpbGVzQUFTNjQpIiAvPg0KLSAgICA8TWFrZURpciBEaXJlY3Rv cmllcz0iJChEU1RST09UKVwkKFByb2dyYW1GaWxlc0FBUzMyKVxXZWJLaXRMZWdhY3kucmVzb3Vy Y2VzOyQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVM2NClcV2ViS2l0TGVnYWN5LnJlc291cmNl cyIgLz4NCisgICAgPE1ha2VEaXIgRGlyZWN0b3JpZXM9IiQoRFNUUk9PVClcJChQcm9ncmFtRmls ZXNBQVMzMilcV2ViS2l0LnJlc291cmNlczskKERTVFJPT1QpXCQoUHJvZ3JhbUZpbGVzQUFTNjQp XFdlYktpdC5yZXNvdXJjZXMiIC8+DQogICA8L1RhcmdldD4NCiANCiAgIDwhLS0gQnVpbGQgV2Vi S2l0TGVnYWN5IFNvZnR3YXJlIC0tPg0KQEAgLTY1LDcgKzY1LDcgQEAKICAgICA8TWVzc2FnZSBU ZXh0PSJNb3ZpbmcgJChDT05GSUcpIGJ1aWxkIHJlc3VsdHMgdG8gJChEU1RST09UKSIgLz4NCiAN CiAgICAgPCEtLSBJZGVudGlmeSB0aGUgZmlsZXMgdG8gY29weSBvdmVyIC0tPg0KLSAgICA8Q3Jl YXRlSXRlbSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcYnVpbGQzMlxEZXJpdmVk U291cmNlc1xGb3J3YXJkaW5nSGVhZGVyc1xXZWJLaXRMZWdhY3lcKipcKi4qIj4NCisgICAgPENy ZWF0ZUl0ZW0gSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXGJ1aWxkMzJcRGVyaXZl ZFNvdXJjZXNcRm9yd2FyZGluZ0hlYWRlcnNcV2ViS2l0XCoqXCouKiI+DQogICAgICAgPE91dHB1 dCBUYXNrUGFyYW1ldGVyPSJJbmNsdWRlIiBJdGVtTmFtZT0iSW5jRmlsZXMiIC8+DQogICAgIDwv Q3JlYXRlSXRlbT4NCiAgICAgPENyZWF0ZUl0ZW0gSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVp bGREaXIpXGJ1aWxkMzJcYmluMzJcKiI+DQpAQCAtOTIsMTAgKzkyLDEwIEBACiAgICAgPENyZWF0 ZUl0ZW0gSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXGJ1aWxkNjRcYmluNjRcKi5w ZGIiPg0KICAgICAgIDxPdXRwdXQgVGFza1BhcmFtZXRlcj0iSW5jbHVkZSIgSXRlbU5hbWU9IkJp bjY0U3ltYm9sRmlsZXMiIC8+DQogICAgIDwvQ3JlYXRlSXRlbT4NCi0gICAgPENyZWF0ZUl0ZW0g SW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXGJ1aWxkMzJcYmluMzJcV2ViS2l0TGVn YWN5LnJlc291cmNlc1wqKlwqLioiPg0KKyAgICA8Q3JlYXRlSXRlbSBJbmNsdWRlPSIkKENvbmZp Z3VyYXRpb25CdWlsZERpcilcYnVpbGQzMlxiaW4zMlxXZWJLaXQucmVzb3VyY2VzXCoqXCouKiI+ DQogICAgICAgPE91dHB1dCBUYXNrUGFyYW1ldGVyPSJJbmNsdWRlIiBJdGVtTmFtZT0iQmluMzJS ZXNvdXJjZXMiIC8+DQogICAgIDwvQ3JlYXRlSXRlbT4NCi0gICAgPENyZWF0ZUl0ZW0gSW5jbHVk ZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXGJ1aWxkNjRcYmluNjRcV2ViS2l0TGVnYWN5LnJl c291cmNlc1wqKlwqLioiPg0KKyAgICA8Q3JlYXRlSXRlbSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRp b25CdWlsZERpcilcYnVpbGQ2NFxiaW42NFxXZWJLaXQucmVzb3VyY2VzXCoqXCouKiI+DQogICAg ICAgPE91dHB1dCBUYXNrUGFyYW1ldGVyPSJJbmNsdWRlIiBJdGVtTmFtZT0iQmluNjRSZXNvdXJj ZXMiIC8+DQogICAgIDwvQ3JlYXRlSXRlbT4NCiAgICAgPENyZWF0ZUl0ZW0gSW5jbHVkZT0iJChD b25maWd1cmF0aW9uQnVpbGREaXIpXGJ1aWxkMzJcbGliMzJcKiI+DQpAQCAtMTA0LDI0ICsxMDQs MjQgQEAKICAgICA8Q3JlYXRlSXRlbSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilc YnVpbGQ2NFxsaWI2NFwqIj4NCiAgICAgICA8T3V0cHV0IFRhc2tQYXJhbWV0ZXI9IkluY2x1ZGUi IEl0ZW1OYW1lPSJMaWI2NEZpbGVzIiAvPg0KICAgICA8L0NyZWF0ZUl0ZW0+DQotICAgIDxDcmVh dGVJdGVtIEluY2x1ZGU9IiQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxidWlsZDY0XG9iajMyXFdl YktpdExlZ2FjeVxEZXJpdmVkU291cmNlc1wqKlwqLioiPg0KKyAgICA8Q3JlYXRlSXRlbSBJbmNs dWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcYnVpbGQ2NFxvYmozMlxXZWJLaXRcRGVyaXZl ZFNvdXJjZXNcKipcKi4qIj4NCiAgICAgICA8T3V0cHV0IFRhc2tQYXJhbWV0ZXI9IkluY2x1ZGUi IEl0ZW1OYW1lPSJEZXJpdmVkMzJTb3VyY2VzIiAvPg0KICAgICA8L0NyZWF0ZUl0ZW0+DQotICAg IDxDcmVhdGVJdGVtIEluY2x1ZGU9IiQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxidWlsZDMyXG9i ajY0XFdlYktpdExlZ2FjeVxEZXJpdmVkU291cmNlc1wqKlwqLioiPg0KKyAgICA8Q3JlYXRlSXRl bSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcYnVpbGQzMlxvYmo2NFxXZWJLaXRc RGVyaXZlZFNvdXJjZXNcKipcKi4qIj4NCiAgICAgICA8T3V0cHV0IFRhc2tQYXJhbWV0ZXI9Iklu Y2x1ZGUiIEl0ZW1OYW1lPSJEZXJpdmVkNjRTb3VyY2VzIiAvPg0KICAgICA8L0NyZWF0ZUl0ZW0+ DQogDQotICAgIDxDb3B5IFNvdXJjZUZpbGVzPSJAKEluY0ZpbGVzKSIgRGVzdGluYXRpb25GaWxl cz0iQChJbmNGaWxlcy0+JyQoRFNUUk9PVClcQXBwbGVJbnRlcm5hbFxpbmNsdWRlXFdlYktpdExl Z2FjeVwlKFJlY3Vyc2l2ZURpciklKEZpbGVuYW1lKSUoRXh0ZW5zaW9uKScpIiAvPg0KKyAgICA8 Q29weSBTb3VyY2VGaWxlcz0iQChJbmNGaWxlcykiIERlc3RpbmF0aW9uRmlsZXM9IkAoSW5jRmls ZXMtPickKERTVFJPT1QpXEFwcGxlSW50ZXJuYWxcaW5jbHVkZVxXZWJLaXRcJShSZWN1cnNpdmVE aXIpJShGaWxlbmFtZSklKEV4dGVuc2lvbiknKSIgLz4NCiAgICAgPENvcHkgU291cmNlRmlsZXM9 IkAoTGliMzJGaWxlcykiIERlc3RpbmF0aW9uRm9sZGVyPSIkKEFwcGxlSW50ZXJuYWxMaWIzMiki IC8+DQogICAgIDxDb3B5IFNvdXJjZUZpbGVzPSJAKExpYjY0RmlsZXMpIiBEZXN0aW5hdGlvbkZv bGRlcj0iJChBcHBsZUludGVybmFsTGliNjQpIiAvPg0KICAgICA8Q29weSBTb3VyY2VGaWxlcz0i QChCaW4zMkRMTEZpbGVzKSIgRGVzdGluYXRpb25Gb2xkZXI9IiQoRFNUUk9PVClcJChQcm9ncmFt RmlsZXNBQVMzMikiIC8+DQogICAgIDxDb3B5IFNvdXJjZUZpbGVzPSJAKEJpbjMyUmVzb3VyY2VG b2xkZXJzKSIgRGVzdGluYXRpb25Gb2xkZXI9IiQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVMz MikiIC8+DQogICAgIDxDb3B5IFNvdXJjZUZpbGVzPSJAKEJpbjMyU3ltYm9sRmlsZXMpIiBEZXN0 aW5hdGlvbkZvbGRlcj0iJChEU1RST09UKVwkKFByb2dyYW1GaWxlc0FBUzMyKSIgLz4NCi0gICAg PENvcHkgU291cmNlRmlsZXM9IkAoQmluMzJSZXNvdXJjZXMpIiBEZXN0aW5hdGlvbkZpbGVzPSJA KEJpbjMyUmVzb3VyY2VzLT4nJChEU1RST09UKVwkKFByb2dyYW1GaWxlc0FBUzMyKVxXZWJLaXRM ZWdhY3kucmVzb3VyY2VzXCUoUmVjdXJzaXZlRGlyKSUoRmlsZW5hbWUpJShFeHRlbnNpb24pJyki IC8+DQorICAgIDxDb3B5IFNvdXJjZUZpbGVzPSJAKEJpbjMyUmVzb3VyY2VzKSIgRGVzdGluYXRp b25GaWxlcz0iQChCaW4zMlJlc291cmNlcy0+JyQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVMz MilcV2ViS2l0LnJlc291cmNlc1wlKFJlY3Vyc2l2ZURpciklKEZpbGVuYW1lKSUoRXh0ZW5zaW9u KScpIiAvPg0KICAgICA8Q29weSBTb3VyY2VGaWxlcz0iQChCaW42NERMTEZpbGVzKSIgRGVzdGlu YXRpb25Gb2xkZXI9IiQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVM2NCkiIC8+DQogICAgIDxD b3B5IFNvdXJjZUZpbGVzPSJAKEJpbjY0UmVzb3VyY2VGb2xkZXJzKSIgRGVzdGluYXRpb25Gb2xk ZXI9IiQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVM2NCkiIC8+DQogICAgIDxDb3B5IFNvdXJj ZUZpbGVzPSJAKEJpbjY0U3ltYm9sRmlsZXMpIiBEZXN0aW5hdGlvbkZvbGRlcj0iJChEU1RST09U KVwkKFByb2dyYW1GaWxlc0FBUzY0KSIgLz4NCi0gICAgPENvcHkgU291cmNlRmlsZXM9IkAoQmlu NjRSZXNvdXJjZXMpIiBEZXN0aW5hdGlvbkZpbGVzPSJAKEJpbjY0UmVzb3VyY2VzLT4nJChEU1RS T09UKVwkKFByb2dyYW1GaWxlc0FBUzY0KVxXZWJLaXRMZWdhY3kucmVzb3VyY2VzXCUoUmVjdXJz aXZlRGlyKSUoRmlsZW5hbWUpJShFeHRlbnNpb24pJykiIC8+DQorICAgIDxDb3B5IFNvdXJjZUZp bGVzPSJAKEJpbjY0UmVzb3VyY2VzKSIgRGVzdGluYXRpb25GaWxlcz0iQChCaW42NFJlc291cmNl cy0+JyQoRFNUUk9PVClcJChQcm9ncmFtRmlsZXNBQVM2NClcV2ViS2l0LnJlc291cmNlc1wlKFJl Y3Vyc2l2ZURpciklKEZpbGVuYW1lKSUoRXh0ZW5zaW9uKScpIiAvPg0KICAgPC9UYXJnZXQ+DQog DQogPC9Qcm9qZWN0Pg0K