175092 2017-08-02 15:01:55 -0700 inspector/runtime/CommandLineAPI-inspect.html is flaky. 2017-08-02 15:47:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=149344 InRadar P2 Normal --- 1 jlewis3 webkit-unassigned bburg commit-queue joepeck webkit-bug-importer oldest_to_newest 1334421 0 jlewis3 2017-08-02 15:01:55 -0700 inspector/runtime/CommandLineAPI-inspect.html is a flaky failure. Looks to have been flaky from being added in: https://trac.webkit.org/changeset/219749/webkit https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fruntime%2FCommandLineAPI-inspect.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r220134%20(2757)/results.html https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/2757 --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/runtime/CommandLineAPI-inspect-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/runtime/CommandLineAPI-inspect-actual.txt @@ -70,7 +70,7 @@ "description": "Database" }, "hints": { - "databaseId": "1" + "databaseId": "2" } } } Talked to Joe, looks to be a simple fix 1334424 1 317011 joepeck 2017-08-02 15:06:47 -0700 Created attachment 317011 [PATCH] Proposed Fix 1334425 2 317011 bburg 2017-08-02 15:07:38 -0700 Comment on attachment 317011 [PATCH] Proposed Fix rs=me 1334457 3 317011 commit-queue 2017-08-02 15:46:30 -0700 Comment on attachment 317011 [PATCH] Proposed Fix Clearing flags on attachment: 317011 Committed r220159: <http://trac.webkit.org/changeset/220159> 1334458 4 commit-queue 2017-08-02 15:46:32 -0700 All reviewed patches have been landed. Closing bug. 1334459 5 webkit-bug-importer 2017-08-02 15:47:39 -0700 <rdar://problem/33687630> 317011 2017-08-02 15:06:47 -0700 2017-08-02 15:46:30 -0700 [PATCH] Proposed Fix fix-flakey-1.patch text/plain 2247 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNTdhOGMxMmFmYy4uM2UxYTM5N2ExMDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0wOC0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIGluc3BlY3Rvci9ydW50aW1lL0NvbW1hbmRMaW5lQVBJLWluc3BlY3QuaHRtbCBpcyBmbGFr eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTA5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL3J1bnRpbWUvQ29tbWFuZExpbmVBUEktaW5zcGVjdC1leHBlY3RlZC50eHQ6CisgICAg ICAgICogaW5zcGVjdG9yL3J1bnRpbWUvQ29tbWFuZExpbmVBUEktaW5zcGVjdC5odG1sOgorCiAy MDE3LTA4LTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBM YXlvdXQgdGVzdHMgd2l0aCAnaHR0cHMnIHN1ZmZpeCBzaG91bGQgYmUgcnVuIG92ZXIgSFRUUFMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1lL0NvbW1hbmRMaW5lQVBJ LWluc3BlY3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3J1bnRpbWUvQ29t bWFuZExpbmVBUEktaW5zcGVjdC1leHBlY3RlZC50eHQKaW5kZXggODlhYzE5MzJiMDIuLjVlZDJk OTkzNDFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcnVudGltZS9Db21tYW5k TGluZUFQSS1pbnNwZWN0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv cnVudGltZS9Db21tYW5kTGluZUFQSS1pbnNwZWN0LWV4cGVjdGVkLnR4dApAQCAtNzAsNyArNzAs NyBAQCBFWFBSRVNTSU9OOiBpbnNwZWN0KG9wZW5EYXRhYmFzZSgiQ29tbWFuZExpbmVBUElUZXN0 REIiLCAiIiwgIiIsIDEpKQogICAgICAgImRlc2NyaXB0aW9uIjogIkRhdGFiYXNlIgogICAgIH0s CiAgICAgImhpbnRzIjogewotICAgICAgImRhdGFiYXNlSWQiOiAiMSIKKyAgICAgICJkYXRhYmFz ZUlkIjogIjxmaWx0ZXJlZD4iCiAgICAgfQogICB9CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvcnVudGltZS9Db21tYW5kTGluZUFQSS1pbnNwZWN0Lmh0bWwgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvcnVudGltZS9Db21tYW5kTGluZUFQSS1pbnNwZWN0Lmh0bWwKaW5kZXgg ZWEwMGJhMjljMDcuLmU2MzdkYmIyZDczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvcnVudGltZS9Db21tYW5kTGluZUFQSS1pbnNwZWN0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL3J1bnRpbWUvQ29tbWFuZExpbmVBUEktaW5zcGVjdC5odG1sCkBAIC04LDYgKzgs OCBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICBmdW5jdGlvbiBwYXlsb2FkSlNPTkZpbHRlcihrZXks IHZhbHVlKSB7CiAgICAgICAgIGlmIChrZXkgPT09ICJvYmplY3RJZCIpCiAgICAgICAgICAgICBy ZXR1cm4gIjxmaWx0ZXJlZD4iOworICAgICAgICBpZiAoa2V5ID09PSAiZGF0YWJhc2VJZCIpCisg ICAgICAgICAgICByZXR1cm4gIjxmaWx0ZXJlZD4iOwogICAgICAgICByZXR1cm4gdmFsdWU7CiAg ICAgfQogCkBAIC0yOSw3ICszMSw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgbmFt ZSwgZGVzY3JpcHRpb24sCiAgICAgICAgICAgICB0ZXN0KHJlc29sdmUsIHJlamVjdCkgewogICAg ICAgICAgICAgICAgIGV2YWx1YXRlV2l0aENvbW1hbmRMaW5lQVBJKGV4cHJlc3Npb24pOwotICAg ICAgICAgICAgICAgIFByb3RvY29sVGVzdC5sb2coIkVYUFJFU1NJT046ICIgKyBleHByZXNzaW9u KTsgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgUHJvdG9jb2xUZXN0LmxvZygiRVhQ UkVTU0lPTjogIiArIGV4cHJlc3Npb24pOwogICAgICAgICAgICAgICAgIEluc3BlY3RvclByb3Rv Y29sLmF3YWl0RXZlbnQoe2V2ZW50OiAiSW5zcGVjdG9yLmluc3BlY3QifSkudGhlbigobWVzc2Fn ZU9iamVjdCkgPT4gewogICAgICAgICAgICAgICAgICAgICBQcm90b2NvbFRlc3QubG9nKEpTT04u c3RyaW5naWZ5KG1lc3NhZ2VPYmplY3QsIHBheWxvYWRKU09ORmlsdGVyLCAyKSk7CiAgICAgICAg ICAgICAgICAgICAgIHJlc29sdmUoKTsK