175088 2017-08-02 14:29:02 -0700 [Cocoa] Web Automation: copy JavaScript atoms to WebKit.framework private headers 2017-08-04 09:44:49 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia commit-queue joepeck sam webkit-bug-importer oldest_to_newest 1334386 0 bburg 2017-08-02 14:29:02 -0700 To be used by safaridriver, like Automation.json. 1334400 1 bburg 2017-08-02 14:44:55 -0700 <rdar://problem/33685818> 1334405 2 317003 bburg 2017-08-02 14:48:40 -0700 Created attachment 317003 Patch 1334462 3 sam 2017-08-02 15:52:14 -0700 Seems really weird for .js files to be in PrivateHeaders. Why not Resources? 1334641 4 joepeck 2017-08-02 21:07:28 -0700 > Seems really weird for .js files to be in PrivateHeaders. Why not Resources? We have perl and python files in WebCore's PrivateHeaders. I think making these PrivateHeaders is because we will want to expose them or ingest them in another framework, but not actually make them be resources of WebKit.framework? 1334790 5 bburg 2017-08-03 08:51:19 -0700 Sam and I discussed offline that private headers is how we usually share build-time resources between frameworks, due to internal build considerations. We could hypothetically put the atoms in WebKit.framework or WebDriver.framework bundle resources, but the current strategy uses xxd.pl to turn them into C++ files. So they are needed at build time not runtime. 1335019 6 317003 joepeck 2017-08-03 16:30:53 -0700 Comment on attachment 317003 Patch r=me 1335289 7 bburg 2017-08-04 09:44:49 -0700 Committed r220275: <http://trac.webkit.org/changeset/220275> 317003 2017-08-02 14:48:40 -0700 2017-08-03 16:37:04 -0700 Patch bug-175088-20170802144801.patch text/plain 6970 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4Mjc2OTc4YjFmNjdhOWVk YzBkN2UxYjUyYjBlODIwN2I0MDlmNWMuLmZmNDhjNDAxZmMwYjQyOGJlMjU3NzUwMmRlMWE1ZWFk ZjlmYjY0ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDgtMDIgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXZWIgQXV0b21hdGlvbjog Y29weSBKYXZhU2NyaXB0IGF0b21zIHRvIFdlYktpdC5mcmFtZXdvcmsgcHJpdmF0ZSBoZWFkZXJz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzUwODgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMzNjg1ODE4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2o6CisKIDIwMTctMDgtMDEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgaW5pdGlhbCBzdXBwb3J0IGZvciBuYXZpZ2F0b3Iuc2VuZEJlYWNvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBi L1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggNGJj YmNiNjVjMDRmYzI3NTM2NTBlYmExZWU3YmRhMWNjMjM1ZTI5Zi4uNGY0ZDhkMDEzYjgzNzFiZmYw MTQ1ZTY5MWFkZTdmYzJlMTgwYzFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJLaXQu eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29k ZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC0xNDA4LDYgKzE0MDgsMTEgQEAKIAkJOTNFNkE0RUUx QkM1REQzOTAwRjhBMEU3IC8qIF9XS0hpdFRlc3RSZXN1bHQuaCBpbiBIZWFkZXJzICovID0ge2lz YSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzRTZBNEVEMUJDNUREMzkwMEY4QTBFNyAvKiBf V0tIaXRUZXN0UmVzdWx0LmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwg KTsgfTsgfTsKIAkJOTNGNTQ5QjQxRTMxNzRCNzAwMEU3MjM5IC8qIFdLU25hcHNob3RDb25maWd1 cmF0aW9uLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5 M0Y1NDlCMzFFMzE3NEI3MDAwRTcyMzkgLyogV0tTbmFwc2hvdENvbmZpZ3VyYXRpb24uaCAqLzsg c2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQdWJsaWMsICk7IH07IH07CiAJCTkzRjU0OUI2MUUz MTc0REEwMDBFNzIzOSAvKiBXS1NuYXBzaG90Q29uZmlndXJhdGlvbi5tbSBpbiBTb3VyY2VzICov ID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzRjU0OUI1MUUzMTc0REEwMDBFNzIz OSAvKiBXS1NuYXBzaG90Q29uZmlndXJhdGlvbi5tbSAqLzsgfTsKKwkJOTkwNjU3M0IxRjMyNzM4 NDAwOTQ0RjlDIC8qIEVsZW1lbnRBdHRyaWJ1dGUuanMgaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5OTA2NTczNDFGMzIzQ0JGMDA5NDRGOUMgLyogRWxlbWVu dEF0dHJpYnV0ZS5qcyAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9 OyB9OworCQk5OTA2NTczQzFGMzI3Mzg0MDA5NDRGOUMgLyogRWxlbWVudERpc3BsYXllZC5qcyBp biBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk5MDY1NzMzMUYz MjNDQkYwMDk0NEY5QyAvKiBFbGVtZW50RGlzcGxheWVkLmpzICovOyBzZXR0aW5ncyA9IHtBVFRS SUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CisJCTk5MDY1NzNEMUYzMjczODQwMDk0NEY5QyAv KiBGaW5kTm9kZXMuanMgaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVS ZWYgPSA5OTA2NTczMTFGMzIzQ0JGMDA5NDRGOUMgLyogRmluZE5vZGVzLmpzICovOyBzZXR0aW5n cyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CisJCTk5MDY1NzNFMUYzMjczODQw MDk0NEY5QyAvKiBGb3JtRWxlbWVudENsZWFyLmpzIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJY QnVpbGRGaWxlOyBmaWxlUmVmID0gOTkwNjU3MzIxRjMyM0NCRjAwOTQ0RjlDIC8qIEZvcm1FbGVt ZW50Q2xlYXIuanMgKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwgKTsgfTsg fTsKKwkJOTkwNjU3M0YxRjMyNzM4NDAwOTQ0RjlDIC8qIEZvcm1TdWJtaXQuanMgaW4gSGVhZGVy cyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5OTA2NTczNTFGMzIzQ0JGMDA5 NDRGOUMgLyogRm9ybVN1Ym1pdC5qcyAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2 YXRlLCApOyB9OyB9OwogCQk5OTBEMjhBQjFDNjQyMEM2MDA5ODY5NzcgLyogX1dLQXV0b21hdGlv blNlc3Npb24uaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IDk5MEQyOEE3MUM2NDA0QjAwMDk4Njk3NyAvKiBfV0tBdXRvbWF0aW9uU2Vzc2lvbi5oICovOyBz ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTk5MEQyOEFDMUM2 NDIwQ0YwMDk4Njk3NyAvKiBfV0tBdXRvbWF0aW9uU2Vzc2lvbkRlbGVnYXRlLmggaW4gSGVhZGVy cyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5OTBEMjhBODFDNjQwNEIwMDA5 ODY5NzcgLyogX1dLQXV0b21hdGlvblNlc3Npb25EZWxlZ2F0ZS5oICovOyBzZXR0aW5ncyA9IHtB VFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTk5MEQyOEIxMUM2NTIwOEQwMDk4Njk3 NyAvKiBfV0tBdXRvbWF0aW9uU2Vzc2lvbkludGVybmFsLmggaW4gSGVhZGVycyAqLyA9IHtpc2Eg PSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5OTBEMjhBRjFDNjUyMDM5MDA5ODY5NzcgLyogX1dL QXV0b21hdGlvblNlc3Npb25JbnRlcm5hbC5oICovOyB9OwpAQCAtMzcwMSw2ICszNzA2LDExIEBA CiAJCTkzRTZBNEVEMUJDNUREMzkwMEY4QTBFNyAvKiBfV0tIaXRUZXN0UmVzdWx0LmggKi8gPSB7 aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5 cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9IF9XS0hpdFRlc3RSZXN1bHQuaDsgc291cmNlVHJl ZSA9ICI8Z3JvdXA+IjsgfTsKIAkJOTNGNTQ5QjMxRTMxNzRCNzAwMEU3MjM5IC8qIFdLU25hcHNo b3RDb25maWd1cmF0aW9uLmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29k aW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9IFdLU25h cHNob3RDb25maWd1cmF0aW9uLmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTkzRjU0 OUI1MUUzMTc0REEwMDBFNzIzOSAvKiBXS1NuYXBzaG90Q29uZmlndXJhdGlvbi5tbSAqLyA9IHtp c2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlw ZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsgcGF0aCA9IFdLU25hcHNob3RDb25maWd1cmF0aW9u Lm1tOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OworCQk5OTA2NTczMTFGMzIzQ0JGMDA5NDRG OUMgLyogRmluZE5vZGVzLmpzICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNv ZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5qYXZhc2NyaXB0OyBwYXRo ID0gRmluZE5vZGVzLmpzOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OworCQk5OTA2NTczMjFG MzIzQ0JGMDA5NDRGOUMgLyogRm9ybUVsZW1lbnRDbGVhci5qcyAqLyA9IHtpc2EgPSBQQlhGaWxl UmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNv ZGUuamF2YXNjcmlwdDsgcGF0aCA9IEZvcm1FbGVtZW50Q2xlYXIuanM7IHNvdXJjZVRyZWUgPSAi PGdyb3VwPiI7IH07CisJCTk5MDY1NzMzMUYzMjNDQkYwMDk0NEY5QyAvKiBFbGVtZW50RGlzcGxh eWVkLmpzICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxh c3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5qYXZhc2NyaXB0OyBwYXRoID0gRWxlbWVudERp c3BsYXllZC5qczsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJOTkwNjU3MzQxRjMyM0NC RjAwOTQ0RjlDIC8qIEVsZW1lbnRBdHRyaWJ1dGUuanMgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVy ZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmph dmFzY3JpcHQ7IHBhdGggPSBFbGVtZW50QXR0cmlidXRlLmpzOyBzb3VyY2VUcmVlID0gIjxncm91 cD4iOyB9OworCQk5OTA2NTczNTFGMzIzQ0JGMDA5NDRGOUMgLyogRm9ybVN1Ym1pdC5qcyAqLyA9 IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxl VHlwZSA9IHNvdXJjZWNvZGUuamF2YXNjcmlwdDsgcGF0aCA9IEZvcm1TdWJtaXQuanM7IHNvdXJj ZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTk5MEQyOEE3MUM2NDA0QjAwMDk4Njk3NyAvKiBfV0tB dXRvbWF0aW9uU2Vzc2lvbi5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNv ZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBfV0tB dXRvbWF0aW9uU2Vzc2lvbi5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQk5OTBEMjhB ODFDNjQwNEIwMDA5ODY5NzcgLyogX1dLQXV0b21hdGlvblNlc3Npb25EZWxlZ2F0ZS5oICovID0g e2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVU eXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBfV0tBdXRvbWF0aW9uU2Vzc2lvbkRlbGVnYXRl Lmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTk5MEQyOEFEMUM2NTE5MDQwMDk4Njk3 NyAvKiBfV0tBdXRvbWF0aW9uU2Vzc2lvbi5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNl OyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9i amNwcDsgcGF0aCA9IF9XS0F1dG9tYXRpb25TZXNzaW9uLm1tOyBzb3VyY2VUcmVlID0gIjxncm91 cD4iOyB9OwpAQCAtNjQ0NCw2ICs2NDU0LDE4IEBACiAJCQlwYXRoID0gbWFjOwogCQkJc291cmNl VHJlZSA9ICI8Z3JvdXA+IjsKIAkJfTsKKwkJOTkwNjU3MzAxRjMyM0NBRTAwOTQ0RjlDIC8qIGF0 b21zICovID0geworCQkJaXNhID0gUEJYR3JvdXA7CisJCQljaGlsZHJlbiA9ICgKKwkJCQk5OTA2 NTczNDFGMzIzQ0JGMDA5NDRGOUMgLyogRWxlbWVudEF0dHJpYnV0ZS5qcyAqLywKKwkJCQk5OTA2 NTczMzFGMzIzQ0JGMDA5NDRGOUMgLyogRWxlbWVudERpc3BsYXllZC5qcyAqLywKKwkJCQk5OTA2 NTczMTFGMzIzQ0JGMDA5NDRGOUMgLyogRmluZE5vZGVzLmpzICovLAorCQkJCTk5MDY1NzMyMUYz MjNDQkYwMDk0NEY5QyAvKiBGb3JtRWxlbWVudENsZWFyLmpzICovLAorCQkJCTk5MDY1NzM1MUYz MjNDQkYwMDk0NEY5QyAvKiBGb3JtU3VibWl0LmpzICovLAorCQkJKTsKKwkJCXBhdGggPSBhdG9t czsKKwkJCXNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7CisJCX07CiAJCTk5NDZFRjgyMUU3QjAyM0Qw MDU0MUU3OSAvKiBpb3MgKi8gPSB7CiAJCQlpc2EgPSBQQlhHcm91cDsKIAkJCWNoaWxkcmVuID0g KApAQCAtNjQ1NSw2ICs2NDc3LDcgQEAKIAkJOTk1NUE2RTgxQzc5ODA5MDAwRUI2QTkzIC8qIEF1 dG9tYXRpb24gKi8gPSB7CiAJCQlpc2EgPSBQQlhHcm91cDsKIAkJCWNoaWxkcmVuID0gKAorCQkJ CTk5MDY1NzMwMUYzMjNDQUUwMDk0NEY5QyAvKiBhdG9tcyAqLywKIAkJCQk5OUMzQUUyNTFEQUQ5 NDY3MDBBRjVDMTYgLyogY29jb2EgKi8sCiAJCQkJOTk0NkVGODIxRTdCMDIzRDAwNTQxRTc5IC8q IGlvcyAqLywKIAkJCQk5OUMzQUUyMjFEQUQ4RTE0MDBBRjVDMTYgLyogbWFjICovLApAQCAtODE2 Myw2ICs4MTg2LDExIEBACiAJCQkJOTMyMzYxMUUxQjAxNURBODAwRkE5MjMyIC8qIF9XS092ZXJs YXlTY3JvbGxiYXJTdHlsZS5oIGluIEhlYWRlcnMgKi8sCiAJCQkJMUE0M0U4MkExODhGM0NEQzAw OUU0RDMwIC8qIF9XS1Byb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5oIGluIEhlYWRlcnMgKi8sCiAJ CQkJN0M4OUQyRDcxQTZDNkJFNjAwM0E1RkRFIC8qIF9XS1Byb2Nlc3NQb29sQ29uZmlndXJhdGlv bkludGVybmFsLmggaW4gSGVhZGVycyAqLywKKwkJCQk5OTA2NTczRjFGMzI3Mzg0MDA5NDRGOUMg LyogRm9ybVN1Ym1pdC5qcyBpbiBIZWFkZXJzICovLAorCQkJCTk5MDY1NzNFMUYzMjczODQwMDk0 NEY5QyAvKiBGb3JtRWxlbWVudENsZWFyLmpzIGluIEhlYWRlcnMgKi8sCisJCQkJOTkwNjU3M0Qx RjMyNzM4NDAwOTQ0RjlDIC8qIEZpbmROb2Rlcy5qcyBpbiBIZWFkZXJzICovLAorCQkJCTk5MDY1 NzNDMUYzMjczODQwMDk0NEY5QyAvKiBFbGVtZW50RGlzcGxheWVkLmpzIGluIEhlYWRlcnMgKi8s CisJCQkJOTkwNjU3M0IxRjMyNzM4NDAwOTQ0RjlDIC8qIEVsZW1lbnRBdHRyaWJ1dGUuanMgaW4g SGVhZGVycyAqLywKIAkJCQkxQTlFMzI4RDE4MjE2NUE5MDBGNUQwNEMgLyogX1dLUmVtb3RlT2Jq ZWN0SW50ZXJmYWNlLmggaW4gSGVhZGVycyAqLywKIAkJCQkxQUFCRkUzQTE4MjlDMUVEMDA1QjA3 MEUgLyogX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlSW50ZXJuYWwuaCBpbiBIZWFkZXJzICovLAog CQkJCTFBOUUzMjg5MTgyMTYzNjkwMEY1RDA0QyAvKiBfV0tSZW1vdGVPYmplY3RSZWdpc3RyeS5o IGluIEhlYWRlcnMgKi8sCg==