175072 2017-08-02 09:29:47 -0700 Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard 2017-08-02 10:55:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates lforschler webkit-bug-importer oldest_to_newest 1334239 0 aakash_jain 2017-08-02 09:29:47 -0700 For buildbot 0.9, few times, dashboard fails to load the builder name to ID mapping (e.g.: intermittent network issue). In such cases buildPageURLForIteration() in dashboard/Scripts/Buildbot.js throws an exception: "TypeError: undefined is not an object (evaluating 'this._builderNameToIDMap[iteration.queue.id]')" This causes the bubbles for those queues to disappear from the dashboard. We should handle such cases gracefully. 1334241 1 316966 aakash_jain 2017-08-02 09:36:36 -0700 Created attachment 316966 Proposed patch 1334252 2 aakash_jain 2017-08-02 09:54:10 -0700 This issue was uncovered as I was playing around with web server configuration, and a misconfiguration caused network issue while fetching Builder name to ID mapping. Following error was seen in console. "Failed to load resource: The network connection was lost. http://<BUILDBOT09_SERVER_NAME>/api/v2/builders" 1334293 3 316966 commit-queue 2017-08-02 10:54:44 -0700 Comment on attachment 316966 Proposed patch Clearing flags on attachment: 316966 Committed r220139: <http://trac.webkit.org/changeset/220139> 1334294 4 commit-queue 2017-08-02 10:54:46 -0700 All reviewed patches have been landed. Closing bug. 1334295 5 webkit-bug-importer 2017-08-02 10:55:56 -0700 <rdar://problem/33680174> 316966 2017-08-02 09:36:36 -0700 2017-08-02 10:54:44 -0700 Proposed patch patch_buildbot_os_dashboard_builderNameToIDMap.txt text/plain 1845 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDEzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA4LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBJbnRlcm1pdHRlbnQgZXhjZXB0aW9uIGluIGJ1aWxkUGFnZVVSTEZvckl0 ZXJhdGlvbiBmb3IgQnVpbGRib3QgMC45IGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdC5qczoK KyAgICAgICAgKEJ1aWxkYm90KTogTWFrZSBzdXJlIHRoaXMuX2J1aWxkZXJOYW1lVG9JRE1hcCBp cyBhbHdheXMgZGVmaW5lZCBmb3IgQnVpbGRib3QgMC45LgorCiAyMDE3LTA4LTAyICBNaWNoYWVs IENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIFJl bW92ZSBvYnNvbGV0ZSBjb2RlIGluIFRlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKSW5kZXg6 IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCShyZXZpc2lvbiAyMjAxMzApCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9h cmQvU2NyaXB0cy9CdWlsZGJvdC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDQsOCArNDQsMTAgQEAg QnVpbGRib3QgPSBmdW5jdGlvbihiYXNlVVJMLCBxdWV1ZXNJbmZvLAogCiAgICAgdGhpcy5WRVJT SU9OX0xFU1NfVEhBTl8wOSA9IG9wdGlvbnMgJiYgb3B0aW9ucy5VU0VfQlVJTERCT1RfVkVSU0lP Tl9MRVNTX1RIQU5fMDk7CiAKLSAgICBpZiAoIXRoaXMuVkVSU0lPTl9MRVNTX1RIQU5fMDkpCisg ICAgaWYgKCF0aGlzLlZFUlNJT05fTEVTU19USEFOXzA5KSB7CisgICAgICAgIHRoaXMuX2J1aWxk ZXJOYW1lVG9JRE1hcCA9IHt9OwogICAgICAgICB0aGlzLl9jb21wdXRlQnVpbGRlck5hbWVUb0lE TWFwKCk7CisgICAgfQogCiAgICAgZm9yICh2YXIgaWQgaW4gcXVldWVzSW5mbykgewogICAgICAg ICBpZiAocXVldWVzSW5mb1tpZF0uY29tYmluZWRRdWV1ZXMpIHsKQEAgLTE1OCw3ICsxNjAsNiBA QCBCdWlsZGJvdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAoIWRhdGEgfHwgIShkYXRh LmJ1aWxkZXJzIGluc3RhbmNlb2YgQXJyYXkpKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICAgICAgdGhpcy5fYnVpbGRlck5hbWVUb0lETWFwID0ge307CiAgICAgICAgICAgICBm b3IgKHZhciBidWlsZGVyIG9mIGRhdGEuYnVpbGRlcnMpCiAgICAgICAgICAgICAgICAgdGhpcy5f YnVpbGRlck5hbWVUb0lETWFwW2J1aWxkZXIubmFtZV0gPSBidWlsZGVyLmJ1aWxkZXJpZDsKICAg ICAgICAgfS5iaW5kKHRoaXMpKTsK