17502 2008-02-23 10:54:02 -0800 Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange 2010-07-19 11:47:13 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED DUPLICATE 40996 P2 Normal --- 1 jchaffraix webkit-unassigned ap oldest_to_newest 71613 0 jchaffraix 2008-02-23 10:54:02 -0800 While testing XMLHttpRequest behaviour, I have hit that assertion. Test case will come. 71616 1 19302 jchaffraix 2008-02-23 11:22:03 -0800 Created attachment 19302 test case Explanation : the readystatechange listener is called from processSyncLoadResults line changeState(Sent). When we call open in the previous listener, we first set m_aborted to true in internalAbort but later in open we set it to false. As a consequence, when we come to processSyncLoadResults the previous XMLHttpRequest is not cancelled (m_aborted is false) and then triggers the assertion as m_loader != 0 (we have created an async XHR in the listener). 252735 2 ap 2010-07-16 15:46:39 -0700 There are no assertions in XMLHttpRequest::didFinishLoading() now, but I'm getting an assertion failure in a different place: ASSERTION FAILED: !m_didTellLoaderAboutRequest (/Volumes/Data/Safari/OpenSource/WebCore/xml/XMLHttpRequest.cpp:571 void WebCore::XMLHttpRequest::createRequest(WebCore::ExceptionCode&)) 253306 3 ap 2010-07-19 11:47:13 -0700 This is fixed by r63680, as we no longer dispatch readystatechange at wrong times. *** This bug has been marked as a duplicate of bug 40996 *** 19302 2008-02-23 11:22:03 -0800 2008-02-23 11:22:03 -0800 test case xmlhttprequest-sync-vs-async-assertion-failure.html text/html 546 jchaffraix PGh0bWw+PGhlYWQ+PC9oZWFkPjxib2R5PgoKPHA+WW91IHNob3VsZCBzZWUgIlBBU1MiIG9uY2Ug OjwvcD4KCjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KdmFyIHhocjsKCmlmICh3aW5k b3cuWE1MSHR0cFJlcXVlc3QpIHsKICAgIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwp9IGVs c2UgewogICAgdHJ5IHsKICAgICAgICB4aHIgPSBuZXcgQWN0aXZlWE9iamVjdCgiTXN4bWwyLlhN TEhUVFAiKTsKICAgIH0gY2F0Y2ggKGV4KSB7CiAgICAgICAgeGhyID0gbmV3IEFjdGl2ZVhPYmpl Y3QoIk1pY3Jvc29mdC5YTUxIVFRQIik7CiAgICB9Cn0KCnhoci5vcGVuKCJHRVQiLCAicmVzb3Vy Y2VzLzEyNTEuaHRtbCIsIGZhbHNlKTsKeGhyLm9ucmVhZHlzdGF0ZWNoYW5nZSA9IGZ1bmN0aW9u ICgpIHsKICAgIHhoci5vcGVuKCJHRVQiLCAicmVzb3VyY2VzLzEyNTEuaHRtbCIsIHRydWUpOwog ICAgeGhyLnNlbmQobnVsbCk7Cn0KCnhoci5zZW5kKG51bGwpOwoKZG9jdW1lbnQud3JpdGUoIlBB U1MiKTsKCjwvc2NyaXB0PgoKPC9ib2R5PjwvaHRtbD4K