175012 2017-07-31 22:59:17 -0700 [PAL][Win] Copy forwarding headers 2017-08-01 15:48:53 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned commit-queue don.olmstead mmaxfield webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1333665 0 yoshiaki.jitsukawa 2017-07-31 22:59:17 -0700 [PAL][Win] Copy forwarding headers 1333666 1 316835 yoshiaki.jitsukawa 2017-07-31 23:01:51 -0700 Created attachment 316835 Patch 1333670 2 yoshiaki.jitsukawa 2017-07-31 23:16:00 -0700 This is to prepare for moving the SPI headers from WebCore/platform/spi to PAL. In the PAL Xcode project, "Copy PAL headers" script copies(rsync) PAL headers. This patch is intended to do a similar thing on Windows, mainly for the SPI headers, to use the same include paths, for example <pal/spi/cocoa/QuartzCoreSPI.h>. 1333749 3 316835 mmaxfield 2017-08-01 08:29:34 -0700 Comment on attachment 316835 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316835&action=review > Source/WebCore/PAL/pal/PlatformAppleWin.cmake:2 > +# spi/cf We don't leave code commented in our checked-in sources. 1333959 4 316897 yoshiaki.jitsukawa 2017-08-01 14:44:15 -0700 Created attachment 316897 Patch 1333962 5 yoshiaki.jitsukawa 2017-08-01 14:46:03 -0700 (In reply to Myles C. Maxfield from comment #3) > Comment on attachment 316835 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316835&action=review > > > Source/WebCore/PAL/pal/PlatformAppleWin.cmake:2 > > +# spi/cf > > We don't leave code commented in our checked-in sources. Thank you for reviewing! I removed the lines. 1333992 6 316897 commit-queue 2017-08-01 15:33:22 -0700 Comment on attachment 316897 Patch Clearing flags on attachment: 316897 Committed r220113: <http://trac.webkit.org/changeset/220113> 1333993 7 commit-queue 2017-08-01 15:33:23 -0700 All reviewed patches have been landed. Closing bug. 1334001 8 webkit-bug-importer 2017-08-01 15:48:53 -0700 <rdar://problem/33664331> 316835 2017-07-31 23:01:51 -0700 2017-08-01 14:44:11 -0700 Patch bug-175012-20170801150150.patch text/plain 2715 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA4ZjRmMjZj NjIxMjJlY2IwMzUxMTVhMGI3N2NjZWRkZmIxOGFiMzk5Li5iOTJjZDg4MzQ3NjJjZDcwOTc2YTA2 NmU2MTQyNDY0NjBhNGE2YjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNy0wNy0zMSAgWW9zaGlha2kgSml0c3VrYXdhICA8aml0c3VAcmQuc2NlaS5zb255LmNvLmpw PgorCisgICAgICAgIFtQQUxdW1dpbl0gQ29weSBmb3J3YXJkaW5nIGhlYWRlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTAxMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL1BsYXRmb3JtQXBw bGVXaW4uY21ha2U6IEFkZGVkLgorICAgICAgICAqIHBhbC9QbGF0Zm9ybVdpbi5jbWFrZToKKyAg ICAgICAgKiBwYWwvUGxhdGZvcm1XaW5DYWlyby5jbWFrZTogQWRkZWQuCisKIDIwMTctMDctMjYg IEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIFdFQl9USU1J TkcgZmVhdHVyZSBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRm b3JtQXBwbGVXaW4uY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtQXBwbGVX aW4uY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZTlhMTNlZjY0N2EyNmM1NGM4ZWZjMzFhNDI0OTdmYTJiOTkw Yjk2MQotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1B cHBsZVdpbi5jbWFrZQpAQCAtMCwwICsxLDEwIEBACitsaXN0KEFQUEVORCBQQUxfRk9SV0FSRElO R19IRUFERVJTX0RJUkVDVE9SSUVTCisjICAgIHNwaS9jZgorKQorCitpZiAoJHtVU0VfRElSRUNU MkR9KQorZWxzZSAoKQorICAgIGxpc3QoQVBQRU5EIFBBTF9GT1JXQVJESU5HX0hFQURFUlNfRElS RUNUT1JJRVMKKyMgICAgICAgIHNwaS9jZworICAgICkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtV2luLmNtYWtlIGIvU291cmNlL1dlYkNvcmUv UEFML3BhbC9QbGF0Zm9ybVdpbi5jbWFrZQppbmRleCA0MWI2MzBkOThhMjQxN2VhOTk5Zjc3ODBj NjcxZTA0ZmMwNDYzMThlLi4yMDY5YzNhZWE2NWM2MDFjOTVjZTkwZjg1YWFjNTgwMDRjMGY4NmUw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtV2luLmNtYWtlCisr KyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1XaW4uY21ha2UKQEAgLTExLDEwICsx MSwyMSBAQCBsaXN0KEFQUEVORCBQQUxfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke0NNQUtF X0JJTkFSWV9ESVJ9Ly4uL2luY2x1ZGUvcHJpdmF0ZSIKICkKIAorbGlzdChBUFBFTkQgUEFMX0ZP UldBUkRJTkdfSEVBREVSU19ESVJFQ1RPUklFUyAuKQorCitpZiAoJHtXVEZfUExBVEZPUk1fV0lO X0NBSVJPfSkKKyAgICBpbmNsdWRlKFBsYXRmb3JtV2luQ2Fpcm8uY21ha2UpCitlbHNlICgpCisg ICAgaW5jbHVkZShQbGF0Zm9ybUFwcGxlV2luLmNtYWtlKQorZW5kaWYgKCkKKwogc2V0KFBBTF9P VVRQVVRfTkFNRSBQQUwke0RFQlVHX1NVRkZJWH0pCiAKIGZpbGUoTUFLRV9ESVJFQ1RPUlkgJHtG T1JXQVJESU5HX0hFQURFUlNfRElSfS9XZWJDb3JlL3BhbCkKLWZpbGUoR0xPQiBfZmlsZXNfUEFM ICIke1BBTF9ESVJ9L3BhbC8qLmgiKQotZm9yZWFjaCAoX2ZpbGUgJHtfZmlsZXNfUEFMfSkKLSAg ICBmaWxlKENPUFkgJHtfZmlsZX0gREVTVElOQVRJT04gJHtGT1JXQVJESU5HX0hFQURFUlNfRElS fS9XZWJDb3JlL3BhbC8pCitmb3JlYWNoIChfZGlyZWN0b3J5ICR7UEFMX0ZPUldBUkRJTkdfSEVB REVSU19ESVJFQ1RPUklFU30pCisgICAgZmlsZShNQUtFX0RJUkVDVE9SWSAke0ZPUldBUkRJTkdf SEVBREVSU19ESVJ9L1dlYkNvcmUvcGFsLyR7X2RpcmVjdG9yeX0pCisgICAgZmlsZShHTE9CIF9m aWxlcyAiJHtQQUxfRElSfS9wYWwvJHtfZGlyZWN0b3J5fS8qLmgiKQorICAgIGZvcmVhY2ggKF9m aWxlICR7X2ZpbGVzfSkKKyAgICAgICAgZmlsZShDT1BZICR7X2ZpbGV9IERFU1RJTkFUSU9OICR7 Rk9SV0FSRElOR19IRUFERVJTX0RJUn0vV2ViQ29yZS9wYWwvJHtfZGlyZWN0b3J5fSkKKyAgICBl bmRmb3JlYWNoICgpCiBlbmRmb3JlYWNoICgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvcGFsL1BsYXRmb3JtV2luQ2Fpcm8uY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1Bs YXRmb3JtV2luQ2Fpcm8uY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjg0MmFkYzliNjI3MjEwYzUxM2MyZWUx NTc1ODkzOTZiZWM5ODc3MwotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9w YWwvUGxhdGZvcm1XaW5DYWlyby5jbWFrZQpAQCAtMCwwICsxLDIgQEAKK2xpc3QoQVBQRU5EIFBB TF9GT1JXQVJESU5HX0hFQURFUlNfRElSRUNUT1JJRVMKKykK 316897 2017-08-01 14:44:15 -0700 2017-08-01 15:33:22 -0700 Patch bug-175012-20170802064415.patch text/plain 2687 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA4ZjRmMjZj NjIxMjJlY2IwMzUxMTVhMGI3N2NjZWRkZmIxOGFiMzk5Li5lZTI4N2Y3MmRjMjJlODkyOTNmNDA3 YWQwYjlhM2E3YTRkYmY3NThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNy0wNy0zMSAgWW9zaGlha2kgSml0c3VrYXdhICA8aml0c3VAcmQuc2NlaS5zb255LmNvLmpw PgorCisgICAgICAgIFtQQUxdW1dpbl0gQ29weSBmb3J3YXJkaW5nIGhlYWRlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTAxMgorCisgICAgICAg IFJldmlld2VkIGJ5IE15bGVzIEMuIE1heGZpZWxkLgorCisgICAgICAgICogcGFsL1BsYXRmb3Jt QXBwbGVXaW4uY21ha2U6IEFkZGVkLgorICAgICAgICAqIHBhbC9QbGF0Zm9ybVdpbi5jbWFrZToK KyAgICAgICAgKiBwYWwvUGxhdGZvcm1XaW5DYWlyby5jbWFrZTogQWRkZWQuCisKIDIwMTctMDct MjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIFdFQl9U SU1JTkcgZmVhdHVyZSBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1Bs YXRmb3JtQXBwbGVXaW4uY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtQXBw bGVXaW4uY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWY1ZjkzMjEzYzdmZTI3NDM1NDU4OTZiZjIwMGFlZDU5 NDI0NmRjYgotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZv cm1BcHBsZVdpbi5jbWFrZQpAQCAtMCwwICsxLDggQEAKK2xpc3QoQVBQRU5EIFBBTF9GT1JXQVJE SU5HX0hFQURFUlNfRElSRUNUT1JJRVMKKykKKworaWYgKCR7VVNFX0RJUkVDVDJEfSkKK2Vsc2Ug KCkKKyAgICBsaXN0KEFQUEVORCBQQUxfRk9SV0FSRElOR19IRUFERVJTX0RJUkVDVE9SSUVTCisg ICAgKQorZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZv cm1XaW4uY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtV2luLmNtYWtlCmlu ZGV4IDQxYjYzMGQ5OGEyNDE3ZWE5OTlmNzc4MGM2NzFlMDRmYzA0NjMxOGUuLjIwNjljM2FlYTY1 YzYwMWM5NWNlOTBmODVhYWM1ODAwNGMwZjg2ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9Q bGF0Zm9ybVdpbi5jbWFrZQpAQCAtMTEsMTAgKzExLDIxIEBAIGxpc3QoQVBQRU5EIFBBTF9JTkNM VURFX0RJUkVDVE9SSUVTCiAgICAgIiR7Q01BS0VfQklOQVJZX0RJUn0vLi4vaW5jbHVkZS9wcml2 YXRlIgogKQogCitsaXN0KEFQUEVORCBQQUxfRk9SV0FSRElOR19IRUFERVJTX0RJUkVDVE9SSUVT IC4pCisKK2lmICgke1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQorICAgIGluY2x1ZGUoUGxhdGZv cm1XaW5DYWlyby5jbWFrZSkKK2Vsc2UgKCkKKyAgICBpbmNsdWRlKFBsYXRmb3JtQXBwbGVXaW4u Y21ha2UpCitlbmRpZiAoKQorCiBzZXQoUEFMX09VVFBVVF9OQU1FIFBBTCR7REVCVUdfU1VGRklY fSkKIAogZmlsZShNQUtFX0RJUkVDVE9SWSAke0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9L1dlYkNv cmUvcGFsKQotZmlsZShHTE9CIF9maWxlc19QQUwgIiR7UEFMX0RJUn0vcGFsLyouaCIpCi1mb3Jl YWNoIChfZmlsZSAke19maWxlc19QQUx9KQotICAgIGZpbGUoQ09QWSAke19maWxlfSBERVNUSU5B VElPTiAke0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9L1dlYkNvcmUvcGFsLykKK2ZvcmVhY2ggKF9k aXJlY3RvcnkgJHtQQUxfRk9SV0FSRElOR19IRUFERVJTX0RJUkVDVE9SSUVTfSkKKyAgICBmaWxl KE1BS0VfRElSRUNUT1JZICR7Rk9SV0FSRElOR19IRUFERVJTX0RJUn0vV2ViQ29yZS9wYWwvJHtf ZGlyZWN0b3J5fSkKKyAgICBmaWxlKEdMT0IgX2ZpbGVzICIke1BBTF9ESVJ9L3BhbC8ke19kaXJl Y3Rvcnl9LyouaCIpCisgICAgZm9yZWFjaCAoX2ZpbGUgJHtfZmlsZXN9KQorICAgICAgICBmaWxl KENPUFkgJHtfZmlsZX0gREVTVElOQVRJT04gJHtGT1JXQVJESU5HX0hFQURFUlNfRElSfS9XZWJD b3JlL3BhbC8ke19kaXJlY3Rvcnl9KQorICAgIGVuZGZvcmVhY2ggKCkKIGVuZGZvcmVhY2ggKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1XaW5DYWlyby5jbWFr ZSBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1XaW5DYWlyby5jbWFrZQpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4yODQyYWRjOWI2MjcyMTBjNTEzYzJlZTE1NzU4OTM5NmJlYzk4NzczCi0tLSAvZGV2L251 bGwKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9QbGF0Zm9ybVdpbkNhaXJvLmNtYWtlCkBA IC0wLDAgKzEsMiBAQAorbGlzdChBUFBFTkQgUEFMX0ZPUldBUkRJTkdfSEVBREVSU19ESVJFQ1RP UklFUworKQo=