175005 2017-07-31 17:08:06 -0700 Support quirk for letting media autoplay if the user interacted with at least one media element 2017-07-31 17:41:13 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrajca mrajca eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1333612 0 mrajca 2017-07-31 17:08:06 -0700 Support quirk for letting media autoplay if the user interacted with at least one media element. 1333613 1 316815 mrajca 2017-07-31 17:10:56 -0700 Created attachment 316815 Patch 1333621 2 316815 eric.carlson 2017-07-31 17:23:08 -0700 Comment on attachment 316815 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316815&action=review > Source/WebCore/ChangeLog:5 > + Radar? > Source/WebCore/html/MediaElementSession.cpp:194 > + if (needsDocumentLevelMediaUserGestureQuirk(element.document()) && element.document().topDocument().mediaState() & MediaProducer::HasUserInteractedWithMediaElement) Nit: may be worth swapping the order of the comparisons. 1333627 3 mrajca 2017-07-31 17:38:28 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 316815 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316815&action=review > > > Source/WebCore/ChangeLog:5 > > + > > Radar? Added. > > > Source/WebCore/html/MediaElementSession.cpp:194 > > + if (needsDocumentLevelMediaUserGestureQuirk(element.document()) && element.document().topDocument().mediaState() & MediaProducer::HasUserInteractedWithMediaElement) > > Nit: may be worth swapping the order of the comparisons. Done. 1333628 4 mrajca 2017-07-31 17:39:00 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 316815 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316815&action=review > > > Source/WebCore/ChangeLog:5 > > + > > Radar? > > > Source/WebCore/html/MediaElementSession.cpp:194 > > + if (needsDocumentLevelMediaUserGestureQuirk(element.document()) && element.document().topDocument().mediaState() & MediaProducer::HasUserInteractedWithMediaElement) > > Nit: may be worth swapping the order of the comparisons. I also put the quirk in #if PLATFORM(MAC) like we talked about. 1333629 5 mrajca 2017-07-31 17:39:22 -0700 Committed r220085: <http://trac.webkit.org/changeset/220085> 1333632 6 webkit-bug-importer 2017-07-31 17:41:13 -0700 <rdar://problem/33641773> 316815 2017-07-31 17:10:56 -0700 2017-07-31 17:23:08 -0700 Patch bug-175005-20170731171055.patch text/plain 6294 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgzMTgwNWJlMWI1YzY0 ZDE1ZjFlOWEzYWFkOThkZjI5MWZhOTkwNi4uODRkNjJmMGI4YmUyODJhMGVkMWI1NGRhMWIxMjgy MWU5Y2RjMzQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA3LTMxICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBTdXBwb3J0IHF1aXJrIGZvciBs ZXR0aW5nIG1lZGlhIGF1dG9wbGF5IGlmIHRoZSB1c2VyIGludGVyYWN0ZWQgd2l0aCBhdCBsZWFz dCBvbmUgbWVkaWEgZWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NTAwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHRoZSB1c2VyIGhhcyBpbnRlcmFjdGVkIHdpdGggYXQgbGVhc3Qgb25l IG1lZGlhIGVsZW1lbnQsIGxldCBvdGhlciBtZWRpYSBlbGVtZW50cyBhdXRvLXBsYXkKKyAgICAg ICAgYXMgYSBxdWlyay4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlSXNQbGF5aW5nTWVkaWEpOgorICAgICAgICAqIGRvbS9E b2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Om5vdGVVc2VySW50ZXJhY3Rp b25XaXRoTWVkaWFFbGVtZW50KToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cmVtb3ZlQmVoYXZpb3JzUmVz dHJpY3Rpb25zQWZ0ZXJGaXJzdFVzZXJHZXN0dXJlKToKKyAgICAgICAgKiBodG1sL01lZGlhRWxl bWVudFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6bmVlZHNEb2N1bWVudExldmVsTWVk aWFVc2VyR2VzdHVyZVF1aXJrKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Np b246OnBsYXliYWNrUGVybWl0dGVkIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL01lZGlhUHJvZHVj ZXIuaDoKKwogMjAxNy0wNy0yOCAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUHJvcGFnYXRlIHVzZXIgZ2VzdHVyZSB0b2tlbnMgd2hlbiBzY3JpcHQgZWxlbWVudHMg YXJlIGxvYWRlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDllZWRmZTdhNjAwZDMxZGM0 MTM4Yjc0N2JiODg3YzcwZGIzY2U2MDcuLjA5NjcwNTNlY2JlMGI4NDc3NjY0ZGZiN2UxNDcyMTMx YjQ1MjEyYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMzYzMCw2ICszNjMwLDkgQEAg dm9pZCBEb2N1bWVudDo6dXBkYXRlSXNQbGF5aW5nTWVkaWEodWludDY0X3Qgc291cmNlRWxlbWVu dElEKQogICAgIH0KICNlbmRpZgogCisgICAgaWYgKG1fdXNlckhhc0ludGVyYWN0ZWRXaXRoTWVk aWFFbGVtZW50KQorICAgICAgICBzdGF0ZSB8PSBNZWRpYVByb2R1Y2VyOjpIYXNVc2VySW50ZXJh Y3RlZFdpdGhNZWRpYUVsZW1lbnQ7CisKICAgICBpZiAoc3RhdGUgPT0gbV9tZWRpYVN0YXRlKQog ICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggYzdkN2RjN2MzZjQxMTEx N2UwYjQwMGNiNzE3M2E5MjQwYTkwMTA1MC4uMjMyNmRkZGU3M2QxNmU1NzgxMmQwNWFkMDFhYmJk MGJlMDk1MTM1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTEyNzksNiArMTI3OSw3IEBAIHB1 YmxpYzoKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGFkZEF1ZGlvUHJvZHVjZXIoTWVkaWFQcm9k dWNlciopOwogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgcmVtb3ZlQXVkaW9Qcm9kdWNlcihNZWRp YVByb2R1Y2VyKik7CiAgICAgTWVkaWFQcm9kdWNlcjo6TWVkaWFTdGF0ZUZsYWdzIG1lZGlhU3Rh dGUoKSBjb25zdCB7IHJldHVybiBtX21lZGlhU3RhdGU7IH0KKyAgICB2b2lkIG5vdGVVc2VySW50 ZXJhY3Rpb25XaXRoTWVkaWFFbGVtZW50KCkgeyBtX3VzZXJIYXNJbnRlcmFjdGVkV2l0aE1lZGlh RWxlbWVudCA9IHRydWU7IH0KICAgICBib29sIGlzQ2FwdHVyaW5nKCkgY29uc3QgeyByZXR1cm4g TWVkaWFQcm9kdWNlcjo6aXNDYXB0dXJpbmcobV9tZWRpYVN0YXRlKTsgfQogICAgIFdFQkNPUkVf RVhQT1JUIHZvaWQgdXBkYXRlSXNQbGF5aW5nTWVkaWEodWludDY0X3QgPSBIVE1MTWVkaWFFbGVt ZW50SW52YWxpZElEKTsKICAgICB2b2lkIHBhZ2VNdXRlZFN0YXRlRGlkQ2hhbmdlKCk7CkBAIC0x NzM2LDYgKzE3MzcsNyBAQCBwcml2YXRlOgogCiAgICAgSW5oZXJpdGVkQm9vbCBtX2Rlc2lnbk1v ZGUgeyBpbmhlcml0IH07CiAgICAgTWVkaWFQcm9kdWNlcjo6TWVkaWFTdGF0ZUZsYWdzIG1fbWVk aWFTdGF0ZSB7IE1lZGlhUHJvZHVjZXI6OklzTm90UGxheWluZyB9OworICAgIGJvb2wgbV91c2Vy SGFzSW50ZXJhY3RlZFdpdGhNZWRpYUVsZW1lbnQgeyBmYWxzZSB9OwogICAgIFBhZ2VDYWNoZVN0 YXRlIG1fcGFnZUNhY2hlU3RhdGUgeyBOb3RJblBhZ2VDYWNoZSB9OwogICAgIFJlZmVycmVyUG9s aWN5IG1fcmVmZXJyZXJQb2xpY3kgeyBSZWZlcnJlclBvbGljeTo6RGVmYXVsdCB9OwogICAgIFJl YWR5U3RhdGUgbV9yZWFkeVN0YXRlIHsgQ29tcGxldGUgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IDFjMmE1ZTk5YjJlNjAzNzI5Y2U4NDhkMGJiODdiZTIw MTkwNWE5Y2YuLjQ5MGVjZTk4NDk3YjQxNDU1Yzc3MjIzNTY4ZWU5M2Q0YzhkN2EzOTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNjcxMyw2ICs2NzEzLDcg QEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpyZW1vdmVCZWhhdmlvcnNSZXN0cmljdGlvbnNBZnRl ckZpcnN0VXNlckdlc3R1cmUoTWVkaWFFbGUKICAgICAgICAgfCBNZWRpYUVsZW1lbnRTZXNzaW9u OjpSZXF1aXJlVXNlckdlc3R1cmVUb0NvbnRyb2xDb250cm9sc01hbmFnZXIpOwogCiAgICAgbV9t ZWRpYVNlc3Npb24tPnJlbW92ZUJlaGF2aW9yUmVzdHJpY3Rpb24ocmVzdHJpY3Rpb25zVG9SZW1v dmUpOworICAgIGRvY3VtZW50KCkudG9wRG9jdW1lbnQoKS5ub3RlVXNlckludGVyYWN0aW9uV2l0 aE1lZGlhRWxlbWVudCgpOwogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVJhdGVD aGFuZ2VSZXN0cmljdGlvbnMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRp YUVsZW1lbnRTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vz c2lvbi5jcHAKaW5kZXggNDFjZWJiMTJjZmFhZmJmOTQzYzU2ZWJmYzI5ZTdhM2VhOWRlYjkwMi4u Yzg5NjFmNGJiNmZlOTRhNzZmNjYyZjM5NTQ5YjA1MjkwM2M1Njk1MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCkBAIC0xNDgsNiArMTQ4LDI0IEBAIHZv aWQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6cmVtb3ZlQmVoYXZpb3JSZXN0cmljdGlvbihCZWhhdmlv clJlc3RyaWN0aW9ucyByZXN0cmljCiAgICAgbV9yZXN0cmljdGlvbnMgJj0gfnJlc3RyaWN0aW9u OwogfQogCitzdGF0aWMgYm9vbCBuZWVkc0RvY3VtZW50TGV2ZWxNZWRpYVVzZXJHZXN0dXJlUXVp cmsoRG9jdW1lbnQmIGRvY3VtZW50KQoreworICAgIGlmICghZG9jdW1lbnQuc2V0dGluZ3MoKS5u ZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBT dHJpbmcgaG9zdCA9IGRvY3VtZW50LnRvcERvY3VtZW50KCkudXJsKCkuaG9zdCgpOworICAgIGlm IChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAic2xhdGUuY29tIikgfHwgaG9z dC5lbmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIuc2xhdGUuY29tIikpCisgICAgICAgIHJldHVy biB0cnVlOworCisgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJp Z24uY29tIikgfHwgaG9zdC5lbmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIuaWduLmNvbSIpKQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJ Q2FzZShob3N0LCAid2FzaGluZ3RvbnBvc3QuY29tIikgfHwgaG9zdC5lbmRzV2l0aElnbm9yaW5n QVNDSUlDYXNlKCIud2FzaGluZ3RvbnBvc3QuY29tIikpCisgICAgICAgIHJldHVybiB0cnVlOwor CisgICAgcmV0dXJuIGZhbHNlOworfQorCiBTdWNjZXNzT3I8TWVkaWFQbGF5YmFja0RlbmlhbFJl YXNvbj4gTWVkaWFFbGVtZW50U2Vzc2lvbjo6cGxheWJhY2tQZXJtaXR0ZWQoY29uc3QgSFRNTE1l ZGlhRWxlbWVudCYgZWxlbWVudCkgY29uc3QKIHsKICAgICBpZiAoZWxlbWVudC5kb2N1bWVudCgp LmlzTWVkaWFEb2N1bWVudCgpICYmICFlbGVtZW50LmRvY3VtZW50KCkub3duZXJFbGVtZW50KCkp CkBAIC0xNzMsNiArMTkxLDkgQEAgU3VjY2Vzc09yPE1lZGlhUGxheWJhY2tEZW5pYWxSZWFzb24+ IE1lZGlhRWxlbWVudFNlc3Npb246OnBsYXliYWNrUGVybWl0dGVkKGNvbnMKICAgICB9CiAjZW5k aWYKIAorICAgIGlmIChuZWVkc0RvY3VtZW50TGV2ZWxNZWRpYVVzZXJHZXN0dXJlUXVpcmsoZWxl bWVudC5kb2N1bWVudCgpKSAmJiBlbGVtZW50LmRvY3VtZW50KCkudG9wRG9jdW1lbnQoKS5tZWRp YVN0YXRlKCkgJiBNZWRpYVByb2R1Y2VyOjpIYXNVc2VySW50ZXJhY3RlZFdpdGhNZWRpYUVsZW1l bnQpCisgICAgICAgIHJldHVybiB7IH07CisKICAgICBpZiAobV9yZXN0cmljdGlvbnMgJiBSZXF1 aXJlVXNlckdlc3R1cmVGb3JWaWRlb1JhdGVDaGFuZ2UgJiYgZWxlbWVudC5pc1ZpZGVvKCkgJiYg IWVsZW1lbnQuZG9jdW1lbnQoKS5wcm9jZXNzaW5nVXNlckdlc3R1cmVGb3JNZWRpYSgpKSB7CiAg ICAgICAgIFJFTEVBU0VfTE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6cGxheWJhY2tQ ZXJtaXR0ZWQgLSByZXR1cm5pbmcgRkFMU0UgYmVjYXVzZSBvZiB2aWRlbyByYXRlIGNoYW5nZSBy ZXN0cmljdGlvbiIpOwogICAgICAgICByZXR1cm4gTWVkaWFQbGF5YmFja0RlbmlhbFJlYXNvbjo6 VXNlckdlc3R1cmVSZXF1aXJlZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTWVk aWFQcm9kdWNlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9NZWRpYVByb2R1Y2VyLmgKaW5kZXgg ZGM0ODhhMGVhMDk4MjlmYWQ3Y2Q5ZDRhMWZmMDZmYzg0OTQwNGUyNi4uZjQ2ZTE0YjYyMzU5ZGE1 YzEzOTA5ODBmMjA2MTRiYzkzZWJmYjBhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9NZWRpYVByb2R1Y2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9NZWRpYVByb2R1Y2Vy LmgKQEAgLTQ4LDYgKzQ4LDcgQEAgcHVibGljOgogICAgICAgICBIYXNNdXRlZFZpZGVvQ2FwdHVy ZURldmljZSA9IDEgPDwgMTQsCiAgICAgICAgIEhhc0ludGVycnVwdGVkQXVkaW9DYXB0dXJlRGV2 aWNlID0gMSA8PCAxNSwKICAgICAgICAgSGFzSW50ZXJydXB0ZWRWaWRlb0NhcHR1cmVEZXZpY2Ug PSAxIDw8IDE2LAorICAgICAgICBIYXNVc2VySW50ZXJhY3RlZFdpdGhNZWRpYUVsZW1lbnQgPSAx IDw8IDE3LAogCiAgICAgICAgIEF1ZGlvQ2FwdHVyZU1hc2sgPSBIYXNBY3RpdmVBdWRpb0NhcHR1 cmVEZXZpY2UgfCBIYXNNdXRlZEF1ZGlvQ2FwdHVyZURldmljZSB8IEhhc0ludGVycnVwdGVkQXVk aW9DYXB0dXJlRGV2aWNlLAogICAgICAgICBWaWRlb0NhcHR1cmVNYXNrID0gSGFzQWN0aXZlVmlk ZW9DYXB0dXJlRGV2aWNlIHwgSGFzTXV0ZWRWaWRlb0NhcHR1cmVEZXZpY2UgfCBIYXNJbnRlcnJ1 cHRlZFZpZGVvQ2FwdHVyZURldmljZSwK