175002 2017-07-31 15:38:23 -0700 AX: CFEqual is failing on text markers with exact same data 2017-07-31 17:18:06 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1333582 0 n_wang 2017-07-31 15:38:23 -0700 When we have a collapsed selected text marker range, using CFEqual to compare the start and end text marker would fail. <rdar://problem/33341537> 1333583 1 webkit-bug-importer 2017-07-31 15:38:38 -0700 <rdar://problem/33636985> 1333584 2 316810 n_wang 2017-07-31 15:44:36 -0700 Created attachment 316810 patch 1333616 3 316810 commit-queue 2017-07-31 17:18:05 -0700 Comment on attachment 316810 patch Clearing flags on attachment: 316810 Committed r220084: <http://trac.webkit.org/changeset/220084> 1333617 4 commit-queue 2017-07-31 17:18:06 -0700 All reviewed patches have been landed. Closing bug. 316810 2017-07-31 15:44:36 -0700 2017-07-31 17:18:05 -0700 patch patch.txt text/plain 2178 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDA3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA3LTMxICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENGRXF1YWwgaXMgZmFpbGluZyBv biB0ZXh0IG1hcmtlcnMgd2l0aCBleGFjdCBzYW1lIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTAwMgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzM2MzY5ODU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2Ugc2hvdWxkIHplcm8gdGhlIG1lbW9yeSBvZiB0aGUgVGV4dE1hcmtlckRhdGEgaW5z dGFuY2Ugc28gdGhhdCBpdAorICAgICAgICBjYW4gYmUgdGVzdGVkIGZvciBieXRlLWVxdWl2YWxl bmNlLgorCisgICAgICAgIE1hZGUgc3VyZSB0aGlzIGNoYW5nZSB3b24ndCBicmVhayBhbnkgb2Yg dGhlIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENh Y2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnRleHRNYXJrZXJEYXRh Rm9yVmlzaWJsZVBvc2l0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnRl eHRNYXJrZXJEYXRhRm9yRmlyc3RQb3NpdGlvbkluVGV4dENvbnRyb2wpOgorCiAyMDE3LTA3LTI4 ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9wYWdhdGUgdXNl ciBnZXN0dXJlIHRva2VucyB3aGVuIHNjcmlwdCBlbGVtZW50cyBhcmUgbG9hZGVkLgpJbmRleDog U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCShyZXZp c2lvbiAyMjAwNDYpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYwLDcgKzIxNjAsMTAgQEAgc3RkOjpvcHRpb25h bDxUZXh0TWFya2VyRGF0YT4gQVhPYmplY3RDYQogICAgIEFYT2JqZWN0Q2FjaGUqIGNhY2hlID0g ZG9tTm9kZS0+ZG9jdW1lbnQoKS5heE9iamVjdENhY2hlKCk7CiAgICAgUmVmUHRyPEFjY2Vzc2li aWxpdHlPYmplY3Q+IG9iaiA9IGNhY2hlLT5nZXRPckNyZWF0ZShkb21Ob2RlKTsKIAorICAgIC8v IFRoaXMgbWVtb3J5IG11c3QgYmUgemVybydkIHNvIGluc3RhbmNlcyBvZiBUZXh0TWFya2VyRGF0 YSBjYW4gYmUgdGVzdGVkIGZvciBieXRlLWVxdWl2YWxlbmNlLgogICAgIFRleHRNYXJrZXJEYXRh IHRleHRNYXJrZXJEYXRhOworICAgIG1lbXNldCgmdGV4dE1hcmtlckRhdGEsIDAsIHNpemVvZihU ZXh0TWFya2VyRGF0YSkpOworICAgIAogICAgIHRleHRNYXJrZXJEYXRhLmF4SUQgPSBvYmouZ2V0 KCktPmF4T2JqZWN0SUQoKTsKICAgICB0ZXh0TWFya2VyRGF0YS5ub2RlID0gZG9tTm9kZTsKICAg ICB0ZXh0TWFya2VyRGF0YS5vZmZzZXQgPSBkZWVwUG9zLmRlcHJlY2F0ZWRFZGl0aW5nT2Zmc2V0 KCk7CkBAIC0yMTg1LDcgKzIxODgsMTAgQEAgc3RkOjpvcHRpb25hbDxUZXh0TWFya2VyRGF0YT4g QVhPYmplY3RDYQogICAgIGlmICghb2JqKQogICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0Owog CisgICAgLy8gVGhpcyBtZW1vcnkgbXVzdCBiZSB6ZXJvJ2Qgc28gaW5zdGFuY2VzIG9mIFRleHRN YXJrZXJEYXRhIGNhbiBiZSB0ZXN0ZWQgZm9yIGJ5dGUtZXF1aXZhbGVuY2UuCiAgICAgVGV4dE1h cmtlckRhdGEgdGV4dE1hcmtlckRhdGE7CisgICAgbWVtc2V0KCZ0ZXh0TWFya2VyRGF0YSwgMCwg c2l6ZW9mKFRleHRNYXJrZXJEYXRhKSk7CisgICAgCiAgICAgdGV4dE1hcmtlckRhdGEuYXhJRCA9 IG9iai5nZXQoKS0+YXhPYmplY3RJRCgpOwogICAgIHRleHRNYXJrZXJEYXRhLm5vZGUgPSAmdGV4 dENvbnRyb2w7CiAK