174991 2017-07-31 13:27:20 -0700 REGRESSION (r219992-219998): Speedometer fails 2017-08-01 10:29:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 175004 1 ap webkit-unassigned addyo jlewis3 mathias rniwa webkit-bug-importer oldest_to_newest 1333516 0 ap 2017-07-31 13:27:20 -0700 Speedometer has started to fail every time on the perf bot: Running Speedometer (181 of 181) timeout: Speedometer FAILED Finished: 605.017019 s 1333523 1 mathias 2017-07-31 13:53:10 -0700 Do we have any more information on what’s going wrong exactly, or on how the perf bot runs Speedometer exactly? 1333552 2 ap 2017-07-31 14:54:41 -0700 I do not. Ryosuke likely knows more. 1333598 3 rniwa 2017-07-31 16:35:07 -0700 Probably https://trac.webkit.org/changeset/219993. 1333600 4 rniwa 2017-07-31 16:35:40 -0700 Tools/Scripts/run-perf-tests PerformanceTests/Speedometer/ to run the test. 1333602 5 mathias 2017-07-31 16:38:40 -0700 One thing I noticed is that https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> to PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html. That line wasn’t there before, despite it being part of the corresponding src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). Was this line manually removed after building previously? If so, we should just remove it from src/index.html. 1333603 6 rniwa 2017-07-31 16:40:04 -0700 (In reply to Mathias Bynens from comment #5) > One thing I noticed is that > https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> > to > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > dist/index.html. > > That line wasn’t there before, despite it being part of the corresponding > src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). > > Was this line manually removed after building previously? If so, we should > just remove it from src/index.html. We should do that although I'm not certain it would completely fix it. 1333611 7 mathias 2017-07-31 17:02:23 -0700 (In reply to Ryosuke Niwa from comment #6) > (In reply to Mathias Bynens from comment #5) > > One thing I noticed is that > > https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> > > to > > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > > dist/index.html. > > > > That line wasn’t there before, despite it being part of the corresponding > > src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). > > > > Was this line manually removed after building previously? If so, we should > > just remove it from src/index.html. > > We should do that although I'm not certain it would completely fix it. Patch: https://bugs.webkit.org/show_bug.cgi?id=175004 1333838 8 ap 2017-08-01 10:28:13 -0700 That fixed it. 1333840 9 webkit-bug-importer 2017-08-01 10:29:12 -0700 <rdar://problem/33656691>