174988 2017-07-31 13:16:21 -0700 REGRESSION (r220052): http/tests/media/video-play-stall.html times out 2017-08-01 09:15:02 -0700 1 1 1 Unclassified WebKit Page Loading Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=130653 InRadar, LayoutTestFailure, Regression P2 Normal --- 1 ap darin ap beidson commit-queue darin eric.carlson jlewis3 kling koivisto sam webkit-bug-importer oldest_to_newest 1333505 0 ap 2017-07-31 13:16:21 -0700 http/tests/media/video-play-stall.html has started to time out every time on macOS Sierra and on Gtk after https://trac.webkit.org/r220052 (Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout). Happens with both WK1 and WK2. It passes on El Capitan, which is why EWS didn't catch this. 1333510 1 darin 2017-07-31 13:22:34 -0700 Should be easy to fix. I fixed lots of other bugs like this one. 1333512 2 darin 2017-07-31 13:24:05 -0700 It would be good to skip this test to make the bots green. I promise I will re-enable it when I fix it. 1333547 3 jlewis3 2017-07-31 14:44:15 -0700 Skipped in: https://trac.webkit.org/changeset/220075/webkitx 1333548 4 jlewis3 2017-07-31 14:44:38 -0700 (In reply to Matt Lewis from comment #3) > Skipped in: > https://trac.webkit.org/changeset/220075/webkitx typo https://trac.webkit.org/changeset/220075/webkit 1333668 5 316836 darin 2017-07-31 23:10:58 -0700 Created attachment 316836 Patch 1333669 6 darin 2017-07-31 23:14:23 -0700 In fixing this bug I learned that it's very hard to get HTMLMediaElement to ever cancel a load once it's going. It even keeps loading when you switch src to load a different video. That is not a good thing, and worth investigating and fixing separately. It’s also not great that starting a load from inside a load event handler has any effect on the loading state at all. By the time the load event has been sent, it should be too late for new loads to have this kind of effect. We should make some other tests for that while making future fixes to the frame loading logic. 1333751 7 darin 2017-08-01 08:39:09 -0700 I’d love to get this test re-enabled. Anyone willing to review? 1333784 8 316836 commit-queue 2017-08-01 09:13:59 -0700 Comment on attachment 316836 Patch Clearing flags on attachment: 316836 Committed r220098: <http://trac.webkit.org/changeset/220098> 1333785 9 commit-queue 2017-08-01 09:14:01 -0700 All reviewed patches have been landed. Closing bug. 1333787 10 webkit-bug-importer 2017-08-01 09:15:02 -0700 <rdar://problem/33655124> 316836 2017-07-31 23:10:58 -0700 2017-08-01 09:13:59 -0700 Patch bug-174988-20170731231057.patch text/plain 2241 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDg2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTIwMjIzNmJmZmFjMTkwZmNmNzA5 NjY4NDZhOGM2YTAzYzI5MTkyNS4uZmRkNGJjMzUwYWQ0MzIyZDA3MjQxOGEwZDhkOTljZTMwN2Qy YTIwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA3LTMxICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjIwMDUyKTogaHR0cC90ZXN0 cy9tZWRpYS92aWRlby1wbGF5LXN0YWxsLmh0bWwgdGltZXMgb3V0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ5ODgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IFN0b3Ag c2tpcHBpbmcgdGhpcyB0ZXN0LgorCisgICAgICAgICogaHR0cC90ZXN0cy9tZWRpYS92aWRlby1w bGF5LXN0YWxsLmh0bWw6IFVzZSBhIDAtZHVyYXRpb24gdGltZW91dCB0byBzaWRlc3RlcCBhbgor ICAgICAgICBpc3N1ZSB3aGVyZSB0aGUgdGVzdCBydW5uZXIgbmV2ZXIgdGhpbmtzIHRoZSB0ZXN0 IGlzIGRvbmUgYmVjYXVzZSBvZiB0aGUgc3RhbGxlZAorICAgICAgICBtZWRpYSBsb2FkaW5nLCBh bmQgdGltZXMgb3V0LiBUaGUgYmVoYXZpb3JzIGhlcmUgYXJlbid0IGdyZWF0LCBidXQgdGhlcmUg aXMgbm8KKyAgICAgICAgcmVhc29uIHRvIHRoaW5rIHRoYXQgdGhpcyBjb25mdXNlZCBzdGF0ZSBo YXMgYW55IGVmZmVjdCBvbiB3ZWIgYnJvd3Npbmc7IGp1c3Qgb24KKyAgICAgICAgb3VyIHRlc3Qg cnVubmVycyBpbiBhIHRlc3QgdGhhdCBpbnRlbnRpb25hbGx5IGhhcyBhIHN0aWxsIGxvYWRpbmcg dmlkZW8gaW4gaXQuCisKIDIwMTctMDctMzEgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCB0ZXN0IGdhcmRlbmluZwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggZDQ1Zjg4ZWMyZDk0ZGM1ZTc3ZmIwNGVlYWY5MTc0NzRkOWZlMTBjMi4uMzk3ODFl ODczYjIxNzZmYTgzZjJjZGNlMWMxNTRlNjA3ZDQwZmNiYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBA IC0xMzk4LDUgKzEzOTgsMyBAQCB3ZWJraXQub3JnL2IvMTcyNjA5IGZldGNoL2Nsb3Npbmctd2hp bGUtZmV0Y2hpbmctYmxvYi5odG1sIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTcyNTE0IFsgRGVi dWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2lubmVyVGV4dC9nZXR0ZXIuaHRt bCBbIFNraXAgXQogCiB3ZWJraXQub3JnL2IvMTczMzMzIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZG9tL25vZGVzL0RvY3VtZW50LWNvbnN0cnVjdG9yLXN2Zy5zdmcgWyBTa2lwIF0K LQotd2Via2l0Lm9yZy9iLzE3NDk4OCBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwu aHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS92 aWRlby1wbGF5LXN0YWxsLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVv LXBsYXktc3RhbGwuaHRtbAppbmRleCA2OTZkNGE4ZDA1YTNjNzRiYzYwMGU5YWQ2YjE1ZTFkMmE0 ZDliMmM1Li41MWNkMDNkNTRmMDdmYTUxODMxMTA2MWEyYjYyYTNiYjM2YjUzMDA0IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwuaHRtbApA QCAtMzgsNyArMzgsNyBAQAogCiAgICAgICAgIDwvc2NyaXB0PgogICAgIDwvaGVhZD4KLSAgICA8 Ym9keSBvbmxvYWQ9InN0YXJ0KCkiPgorICAgIDxib2R5IG9ubG9hZD0ic2V0VGltZW91dChzdGFy dCwgMCkiPgogICAgICAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KICAgICAgICAgPHA+VGVz dCB0aGF0IGEgc3RhbGxlZCBldmVudCBpcyBzZW50IHdoZW4gbWVkaWEgbG9hZGluZyBzdGFsbHMu PC9wPgogICAgIDwvYm9keT4K