174947 2017-07-28 12:21:08 -0700 Don't add autoplay restrictions to media elements created in response to user gestures 2017-07-28 17:29:15 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrajca mrajca eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1333030 0 mrajca 2017-07-28 12:21:08 -0700 Don't add autoplay restrictions to media elements created in response to user gestures. 1333031 1 mrajca 2017-07-28 12:22:21 -0700 This fixes playback on the New York Times homepage (and possibly other sites). 1333034 2 316665 mrajca 2017-07-28 12:27:28 -0700 Created attachment 316665 Patch 1333073 3 316665 eric.carlson 2017-07-28 15:02:31 -0700 Comment on attachment 316665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316665&action=review > Source/WebCore/html/HTMLMediaElement.cpp:466 > + const bool isProcessingUserGesture = processingUserGestureForMedia(); Why const for this and not the other bool variables? > LayoutTests/media/video-create-with-user-gesture.html:17 > + failTestIn(1000); Nit: this is probably too short for a heavily laden machine (e.g. a bot). I would set it to something like 10 seconds. 1333137 4 mrajca 2017-07-28 17:24:11 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 316665 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316665&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:466 > > + const bool isProcessingUserGesture = processingUserGestureForMedia(); > > Why const for this and not the other bool variables? I can change the other ones for consistency. None of these are modified after they're declared. > > > LayoutTests/media/video-create-with-user-gesture.html:17 > > + failTestIn(1000); > > Nit: this is probably too short for a heavily laden machine (e.g. a bot). I > would set it to something like 10 seconds. Will do. 1333138 5 mrajca 2017-07-28 17:27:22 -0700 http://trac.webkit.org/changeset/220035/webkit 1333139 6 webkit-bug-importer 2017-07-28 17:29:15 -0700 <rdar://problem/33602620> 316665 2017-07-28 12:27:28 -0700 2017-07-28 15:02:31 -0700 Patch bug-174947-20170728122727.patch text/plain 5410 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNmMDZlNjA3MTcyN2Q3 YmIwMzgyOWFlNzExNjM3ODU5NDU3OThmMi4uZmVkYmNjMmRlYjdkNDM3YzkxMGZjMjU3NGZhOTEw MjJiM2ZmMTQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA3LTI4ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBhZGQgYXV0b3BsYXkg cmVzdHJpY3Rpb25zIHRvIG1lZGlhIGVsZW1lbnRzIGNyZWF0ZWQgaW4gcmVzcG9uc2UgdG8gdXNl ciBnZXN0dXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NDk0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3Q6IG1lZGlhL3ZpZGVvLWNyZWF0ZS13aXRoLXVzZXItZ2VzdHVyZS5odG1sCisKKyAg ICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudCk6CisKIDIwMTctMDctMjQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIEV4Y2VwdGlvbkNvZGUgYSBw cm9wZXIgZW51bWVyYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CmluZGV4IGFmY2Q3MGI5MDg4MTY0OTI3ZTk3ODcxZDJhZWRkY2Y5YzMxYWRhODYuLmRiMGE4NDE5 MjdhYTdjMTUzOTBhOGM4YWZkYmY3NDJiZTVlZGY0ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNDYzLDggKzQ2Myw5IEBAIEhUTUxNZWRpYUVsZW1lbnQ6 OkhUTUxNZWRpYUVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQm IGRvY3VtCiAKICAgICBpZiAoZG9jdW1lbnQub3duZXJFbGVtZW50KCkgfHwgIWRvY3VtZW50Lmlz TWVkaWFEb2N1bWVudCgpKSB7CiAgICAgICAgIGNvbnN0IGF1dG8mIHRvcERvY3VtZW50ID0gZG9j dW1lbnQudG9wRG9jdW1lbnQoKTsKLSAgICAgICAgYm9vbCBzaG91bGRBdWRpb1BsYXliYWNrUmVx dWlyZVVzZXJHZXN0dXJlID0gdG9wRG9jdW1lbnQuYXVkaW9QbGF5YmFja1JlcXVpcmVzVXNlckdl c3R1cmUoKTsKLSAgICAgICAgYm9vbCBzaG91bGRWaWRlb1BsYXliYWNrUmVxdWlyZVVzZXJHZXN0 dXJlID0gdG9wRG9jdW1lbnQudmlkZW9QbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUoKTsKKyAg ICAgICAgY29uc3QgYm9vbCBpc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSA9IHByb2Nlc3NpbmdVc2Vy R2VzdHVyZUZvck1lZGlhKCk7CisgICAgICAgIGJvb2wgc2hvdWxkQXVkaW9QbGF5YmFja1JlcXVp cmVVc2VyR2VzdHVyZSA9IHRvcERvY3VtZW50LmF1ZGlvUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0 dXJlKCkgJiYgIWlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlOworICAgICAgICBib29sIHNob3VsZFZp ZGVvUGxheWJhY2tSZXF1aXJlVXNlckdlc3R1cmUgPSB0b3BEb2N1bWVudC52aWRlb1BsYXliYWNr UmVxdWlyZXNVc2VyR2VzdHVyZSgpICYmICFpc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZTsKIAogICAg ICAgICBpZiAoc2hvdWxkVmlkZW9QbGF5YmFja1JlcXVpcmVVc2VyR2VzdHVyZSkgewogICAgICAg ICAgICAgbV9tZWRpYVNlc3Npb24tPmFkZEJlaGF2aW9yUmVzdHJpY3Rpb24oTWVkaWFFbGVtZW50 U2Vzc2lvbjo6UmVxdWlyZVVzZXJHZXN0dXJlRm9yVmlkZW9SYXRlQ2hhbmdlKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4 MTA4NDJjMTU0MzZiZTQyOTEwZGY3M2Y5MjgzNWJiMGI0OWZmYzJhLi5kY2JlYjQzNmMxODJjZGQ0 OGU0ZTI0YjgyMDMyYTVmNGI1YTI0ZjBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTctMDct MjggIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGFkZCBh dXRvcGxheSByZXN0cmljdGlvbnMgdG8gbWVkaWEgZWxlbWVudHMgY3JlYXRlZCBpbiByZXNwb25z ZSB0byB1c2VyIGdlc3R1cmVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0OTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU2tpcCB0aGUgdGVzdCBvbiBpT1MgYmVjYXVzZSAicnVuV2l0aEtleURvd24i IGRvZXMgbm90IHdvcmsgdGhlcmUuCisKKyAgICAgICAgSmVyOiAiVHVybnMgb3V0IHRoZSBwcm9i bGVtIHdpdGggaU9TIGlzIHRoYXQgdGhlIFdLVFIgRXZlbnRTZW5kZXIgaXMgYmFzaWNhbGx5IHVu d3JpdHRlbi4gSXQKKyAgICAgICAgZG9lc24ndCBzdXBwb3J0IHNlbmRpbmcgbW91c2UsIGtleSwg b3IgdG91Y2ggZXZlbnRzLCBzbyBvdXIgImRvIHRoaXMgZHVyaW5nIGEgdXNlciBnZXN0dXJlIgor ICAgICAgICBoZWxwZXIgaW4gdmlkZW8tdGVzdC5qcyBkb2Vzbid0IHdvcmsuIgorCisgICAgICAg ICogbWVkaWEvdmlkZW8tY3JlYXRlLXdpdGgtdXNlci1nZXN0dXJlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogbWVkaWEvdmlkZW8tY3JlYXRlLXdpdGgtdXNlci1nZXN0dXJlLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3 LTA3LTI0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmVydCAiY2xpZW50IiBjb29yZGluYXRlcyB0byBiZSBpbiBzY3JvbGxpbmcgY29vcmRpbmF0 ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNyZWF0ZS13aXRoLXVzZXIt Z2VzdHVyZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jcmVhdGUtd2l0 aC11c2VyLWdlc3R1cmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcyMzE1ZjBmMTc0NjY5OWRm ZjIwYjk2Yjc3YjcwMzY0NGU4ZGEyYjgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1jcmVhdGUtd2l0aC11c2VyLWdlc3R1cmUtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsOCBAQAorUlVOKHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0VmlkZW9QbGF5YmFja1Jl cXVpcmVzVXNlckdlc3R1cmUodHJ1ZSk7KQorUlVOKHZpZGVvID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgidmlkZW8iKSkKK1JVTih2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJj b250ZW50L3Rlc3QiKSkKK1JVTih2aWRlby5zZXRBdHRyaWJ1dGUoImF1dG9wbGF5IiwgIiIpKQor UlVOKGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pKQorRVZFTlQocGxheWluZykKK0VO RCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNyZWF0ZS13 aXRoLXVzZXItZ2VzdHVyZS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3JlYXRlLXdp dGgtdXNlci1nZXN0dXJlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2M0OTI0YTkwNzViMDY4YmE5Njg5NDZm Nzc5MzI1NzE4ZDQwNmMyOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3Zp ZGVvLWNyZWF0ZS13aXRoLXVzZXItZ2VzdHVyZS5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+dmlkZW8tY3JlYXRlLXdpdGgt dXNlci1nZXN0dXJlPC90aXRsZT4KKyAgICA8c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2Ny aXB0PgorICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgPHNjcmlw dD4KKyAgICBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgICAgICBydW4oJ3dpbmRvdy5pbnRlcm5h bHMuc2V0dGluZ3Muc2V0VmlkZW9QbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUodHJ1ZSk7Jyk7 CisgICAgICAgIHJ1bldpdGhLZXlEb3duKCgpID0+IHsKKyAgICAgICAgICAgIHJ1bigndmlkZW8g PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ2aWRlbyIpJyk7CisgICAgICAgIH0pOworICAgICAg ICBydW4oJ3ZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvdGVzdCIp Jyk7CisgICAgICAgIHJ1bigndmlkZW8uc2V0QXR0cmlidXRlKCJhdXRvcGxheSIsICIiKScpOwor ICAgICAgICBydW4oJ2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pJyk7CisgICAgICAg IHdhaXRGb3JFdmVudEFuZEVuZCgncGxheWluZycpOworICAgICAgICBmYWlsVGVzdEluKDEwMDAp OworICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgp Ij4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggNmJlN2M0MDhhYzRkYTFlY2IyMDM0ZDQ4NDRkMjE5MmRkNzhmYmM0Mi4uYWYx YWU4Y2E1MzFhOGU3OTU0MmQzMzg0ZThjOWE1MGUzNjRiOTMyOSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI1NjksNiArMjU2OSw3IEBAIG1lZGlhL3Zp ZGVvLWNvbnRyb2xzLWRyYWcuaHRtbAogbWVkaWEvdmlkZW8tY29udHJvbHMtZnVsbHNjcmVlbi12 b2x1bWUuaHRtbAogbWVkaWEvdmlkZW8tY29udHJvbHMtbm8tZGlzcGxheS13aXRoLXRleHQtdHJh Y2suaHRtbAogbWVkaWEvdmlkZW8tY29udHJvbHMtc2hvdy1vbi1rYi1vci1heC1ldmVudC5odG1s CittZWRpYS92aWRlby1jcmVhdGUtd2l0aC11c2VyLWdlc3R1cmUuaHRtbAogbWVkaWEvdmlkZW8t ZnVsbHNjcmVlbi1yZXN0cmljdGlvbi1yZW1vdmVkLmh0bWwKIG1lZGlhL3ZpZGVvLXBsYXlzaW5s aW5lLmh0bWwKIG1lZGlhL3ZpZGVvLXJlbW90ZS1jb250cm9sLXBsYXlwYXVzZS5odG1sCg==