174940 2017-07-28 09:39:32 -0700 [GTK] Building with ENABLE_VIDEO=OFF fails 2017-07-28 11:07:05 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED P2 Normal --- 1 aperez aperez achristensen aestes bburg beidson bugs-noreply cgarcia commit-queue oldest_to_newest 1332971 0 aperez 2017-07-28 09:39:32 -0700 This issue was reported in the Buildroot mailing list, it happens with the latest releases (at least 2.16.5 and 2.16.6), and also with “trunk”. The error is: /home/peko/buildroot/output/build/webkitgtk-2.16.5/DerivedSources/WebCore/JSWebGLRenderingContextBase.cpp:3100:207: required from here /home/peko/buildroot/output/build/webkitgtk-2.16.5/Source/WTF/wtf/PassRefPtr.h:40:13: error: invalid use of incomplete type ‘class WebCore::HTMLVideoElement’ ptr->deref(); ^ In file included from /home/peko/buildroot/output/build/webkitgtk-2.16.5/Source/WebCore/html/canvas/WebGLRenderingContextBase.h:32:0, from /home/peko/buildroot/output/build/webkitgtk-2.16.5/DerivedSources/WebCore/JSWebGLRenderingContextBase.h:26, from /home/peko/buildroot/output/build/webkitgtk-2.16.5/DerivedSources/WebCore/JSWebGLRenderingContextBase.cpp:25: /home/peko/buildroot/output/build/webkitgtk-2.16.5/Source/WebCore/html/canvas/CanvasRenderingContext.h:40:7: note: forward declaration of ‘class WebCore::HTMLVideoElement’ class HTMLVideoElement; ^ Original report: http://lists.busybox.net/pipermail/buildroot/2017-July/198467.html 1332974 1 aperez 2017-07-28 09:41:20 -0700 I looked a bit into this, and it's caused because MEDIA_STREAM is enabled anyway, and it tries to use the definition of HTMLVideoElement, which is guarded by ENABLE(VIDEO). This is due to a missing feature dependency in the CMake build files. We need to add: WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_STREAM ENABLE_VIDEO) I'll be submitting a patch. 1332978 2 aperez 2017-07-28 09:46:29 -0700 A test build with of “trunk” with “-DENABLE_MEDIA_STREAM=OFF” failed with: ../../Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:25:10: fatal error: gst/gst.h: No such file or directory #include <gst/gst.h> ^~~~~~~~~~~ If all of “-DENABLE_VIDEO=OFF”, “-DENABLE_WEB_AUDIO=OFF” and “-DENABLE_MEDIA_STREAM=OFF” is passed, then GStreamer is not needed, and no GStreamer flags are queried using “pkg-config”. Which results in the header not found. I think in this case we would want to guard the use of GStreamer in the tests as well, so I'll add that to the patch. 1332980 3 316646 aperez 2017-07-28 09:55:02 -0700 Created attachment 316646 Patch 1332998 4 316646 commit-queue 2017-07-28 11:07:03 -0700 Comment on attachment 316646 Patch Clearing flags on attachment: 316646 Committed r220007: <http://trac.webkit.org/changeset/220007> 1332999 5 commit-queue 2017-07-28 11:07:05 -0700 All reviewed patches have been landed. Closing bug. 316646 2017-07-28 09:55:02 -0700 2017-07-28 11:07:03 -0700 Patch bug-174940-20170728195501.patch text/plain 3746 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggZjdmOGU3ZTJhMDIyMGEyNTAzOGI1ZGY0NDMzZmI5Y2M4YmU2NjU1Yy4uNzlkNDU5NGMyOGFi MjQwOGIzNmU4ZDE3ZTc2ZmY1YjI4NWJkMjc2YiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMjAyLDYgKzIwMiw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX0lOREVYRURfREFUQUJBU0VfSU5fV09SS0VSUyBFTkFC TEVfSU5ERVhFRF9EQVRBQkFTRSkKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfTUVE SUFfQ09OVFJPTFNfU0NSSVBUIEVOQUJMRV9WSURFTykKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVO RChFTkFCTEVfTUVESUFfU09VUkNFIEVOQUJMRV9WSURFTykKKyAgICBXRUJLSVRfT1BUSU9OX0RF UEVORChFTkFCTEVfTUVESUFfU1RSRUFNIEVOQUJMRV9WSURFTykKICAgICBXRUJLSVRfT1BUSU9O X0RFUEVORChFTkFCTEVfVklERU9fVFJBQ0sgRU5BQkxFX1ZJREVPKQogICAgIFdFQktJVF9PUFRJ T05fREVQRU5EKEVOQUJMRV9UT1VDSF9TTElERVIgRU5BQkxFX1RPVUNIX0VWRU5UUykKIGVuZG1h Y3JvKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBjMDZkYTA0NDQ2ZGU4MjlmYzAxYjhmNjViYWYwMzkwMjg4ZmFlZDUyLi5mZWIyMmQzZDA5MzU3 Njc4NGI1OTkxZGMwOGMxZWZiY2Q2YTY1OTY4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDctMjggIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBC dWlsZGluZyB3aXRoIEVOQUJMRV9WSURFTz1PRkYgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDk0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gR1N0cmVhbWVyIHVzYWdlIGlzIGNvbXBs ZXRlbHkgZGlzYWJsZWQgYXQgYnVpbGQgdGltZSwgQ01ha2UgZG9lcyBub3QgcXVlcnkgcGtnLWNv bmZpZyBmb3IgdGhlIEdTdHJlYW1lci4KKyAgICAgICAgVGhpcyBhZGRzIG1pc3NpbmcgVVNFKEdT VFJFQU1FUikgZ3VhcmRzIGluIG9yZGVyIHRvIG1ha2UgdGVzdGluZyBjb2RlIGJ1aWxkYWJsZSB3 aGVuIEdTdHJlYW1lciB1c2FnZSBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0R0xpYi9XZWJFeHRlbnNpb25UZXN0LmNwcDoKKyAgICAgICAgKG1ldGhv ZENhbGxDYWxsYmFjayk6IEFkZCBtaXNzaW5nIFVTRShHU1RSRUFNRVIpIGd1YXJkLgorCiAyMDE3 LTA3LTI4ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW1dQRV0gSW1wbGVtZW50IEV2ZW50U2VuZGVyUHJveHkgaW4gV1RSCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvV2ViRXh0ZW5zaW9uVGVzdC5jcHAg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvV2ViRXh0ZW5zaW9uVGVzdC5j cHAKaW5kZXggMGM3YjBmOTQxNWNhYTEyMjUwZDEwYmVlZDFjMjgzMjA0NzZmNjc2My4uMzdhMjc2 NGYyNmUwMjI3NDk1NTdiZTVhMGUyMmQ5MTA2ODBiZDBiZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1dlYkV4dGVuc2lvblRlc3QuY3BwCisrKyBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9XZWJFeHRlbnNpb25UZXN0LmNwcApA QCAtMjIsNyArMjIsOSBAQAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ29udGV4dFJlZi5o PgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTUmV0YWluUHRyLmg+CiAjaW5jbHVkZSA8Z2lv L2dpby5oPgorI2lmIFVTRShHU1RSRUFNRVIpCiAjaW5jbHVkZSA8Z3N0L2dzdC5oPgorI2VuZGlm CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSA8d3Rm L0RlcXVlLmg+CkBAIC0zOTYsNiArMzk4LDcgQEAgc3RhdGljIHZvaWQgbWV0aG9kQ2FsbENhbGxi YWNrKEdEQnVzQ29ubmVjdGlvbiogY29ubmVjdGlvbiwgY29uc3QgY2hhciogc2VuZGVyLAogICAg ICAgICBnX2RidXNfbWV0aG9kX2ludm9jYXRpb25fcmV0dXJuX3ZhbHVlKGludm9jYXRpb24sCiAg ICAgICAgICAgICBnX3ZhcmlhbnRfbmV3KCIodSkiLCBzdGF0aWNfY2FzdDxndWludDMyPihnZXRD dXJyZW50UHJvY2Vzc0lEKCkpKSk7CiAgICAgfSBlbHNlIGlmICghZ19zdHJjbXAwKG1ldGhvZE5h bWUsICJSZW1vdmVBVlBsdWdpbnNGcm9tR1NUUmVnaXN0cnkiKSkgeworI2lmIFVTRShHU1RSRUFN RVIpCiAgICAgICAgIGdzdF9pbml0KG51bGxwdHIsIG51bGxwdHIpOwogICAgICAgICBzdGF0aWMg Y29uc3QgY2hhciogYXZQbHVnaW5zW10gPSB7ICJsaWJhdiIsICJvbXgiLCAidmFhcGkiLCBudWxs cHRyIH07CiAgICAgICAgIEdzdFJlZ2lzdHJ5KiByZWdpc3RyeSA9IGdzdF9yZWdpc3RyeV9nZXQo KTsKQEAgLTQwNSw2ICs0MDgsNyBAQCBzdGF0aWMgdm9pZCBtZXRob2RDYWxsQ2FsbGJhY2soR0RC dXNDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBjb25zdCBjaGFyKiBzZW5kZXIsCiAgICAgICAgICAg ICAgICAgZ3N0X29iamVjdF91bnJlZihwbHVnaW4pOwogICAgICAgICAgICAgfQogICAgICAgICB9 CisjZW5kaWYKICAgICAgICAgZ19kYnVzX21ldGhvZF9pbnZvY2F0aW9uX3JldHVybl92YWx1ZShp bnZvY2F0aW9uLCBudWxscHRyKTsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggM2U4ZDU1Y2VkZTAyOGY3OTQ5Zjk1MjU4Yzg1NDQxMzcwZDFhZTEwYy4u MTU0NmQwYTA2M2VhNDcwMTMxMjE0NTk2MDAxNDJhZTMyZjhmMTg4MCAxMDA2NDQKLS0tIGEvQ2hh bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA3LTI4ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g QnVpbGRpbmcgd2l0aCBFTkFCTEVfVklERU89T0ZGIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ5NDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2RlIGd1YXJkZWQgYnkgRU5BQkxFKE1FRElB X1NUUkVBTSkgcmVxdWlyZXMgdGhlIGRlZmluaXRpb24gb2YgSFRNTFZpZGVvRWxlbWVudCB0bwor ICAgICAgICBiZSBhdmFpbGFibGUsIHdoaWNoIGluIHR1cm4gaXMgZ3VhcmRlZCBieSBFTkFCTEUo VklERU8pLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOiBN YWtlIEVOQUJMRV9NRURJQV9TVFJFQU0gZGVwZW5kIG9uIEVOQUJMRV9WSURFTy4KKwogMjAxNy0w Ny0yOCAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtXUEVdIEltcGxlbWVudCBFdmVudFNlbmRlclByb3h5IGluIFdUUgo=