174930 2017-07-27 23:33:38 -0700 Using "auto <function()> -> returnType" breaks prepare-ChangeLog 2017-07-28 15:04:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jfbastien jfbastien beidson buildbot commit-queue dbates jbedard jfbastien lforschler webkit-bug-importer oldest_to_newest 1332902 0 jfbastien 2017-07-27 23:33:38 -0700 From Brady: I just noticed this tonight. When a change is made to one of these functions, prepare-ChangeLog doesn't log the functions that changed. I have a question and a request. Question: The functions in question where I noticed this: auto WebURLSchemeTask::didComplete(const ResourceError& error) -> ExceptionType Would normally be written as: WebURLSchemeTask::ExceptionType WebURLSchemeTask::didComplete(const ResourceError& error) Is there some actual value to using this syntax other than… being syntactically different, and being just a little shorter? Request: Until we fix prepare-ChangeLog, and unless there is some great advantage to this syntax that I'm not aware of… it's hold off on using it more. 1332904 1 316624 jfbastien 2017-07-27 23:35:18 -0700 Created attachment 316624 patch Pardon my perl. 1332929 2 dbates 2017-07-28 02:42:38 -0700 We have unit tests for this code. Please add a unit test to <https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp> and update the expected result in <https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt>. You can run the unit tests using the script Tools/Scripts/test-webkitperl. 1332972 3 316644 jfbastien 2017-07-28 09:40:48 -0700 Created attachment 316644 patch (In reply to Daniel Bates from comment #2) > We have unit tests for this code. Please add a unit test to "unit tests"? What are those? ;-) While I'm here, I also added const and volatile overloads. 1332975 4 buildbot 2017-07-28 09:42:43 -0700 Attachment 316644 did not pass style-queue: ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:396: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:420: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:425: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1333024 5 316644 commit-queue 2017-07-28 11:54:37 -0700 Comment on attachment 316644 patch Clearing flags on attachment: 316644 Committed r220010: <http://trac.webkit.org/changeset/220010> 1333025 6 commit-queue 2017-07-28 11:54:38 -0700 All reviewed patches have been landed. Closing bug. 1333043 7 webkit-bug-importer 2017-07-28 12:38:53 -0700 <rdar://problem/33596121> 1333074 8 jbedard 2017-07-28 15:04:04 -0700 Committed r220017: <http://trac.webkit.org/changeset/220017> 316624 2017-07-27 23:35:18 -0700 2017-07-28 09:40:48 -0700 patch 0001-ChangeLog-auto-function-returnType.patch text/plain 1573 jfbastien RnJvbSBlY2FmM2ZkZmVlN2QxNWQ5ZDc0ZGQ0Njg2NzNkNzQ2ODg4MTE0MzE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUaHUsIDI3IEp1bCAyMDE3IDIzOjM0OjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQ2hhbmdl TG9nIGF1dG8gPGZ1bmN0aW9uKCk+IC0+IHJldHVyblR5cGUKCi0tLQogVG9vbHMvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1D aGFuZ2VMb2cgfCAgNiArKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMGUx ZTcxLi41MWVhMGJjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDctMjcgIEpGIEJhc3RpZW4gIDxqZmJhc3Rp ZW5AYXBwbGUuY29tPgorCisgICAgICAgIFVzaW5nICJhdXRvIDxmdW5jdGlvbigpPiAtPiByZXR1 cm5UeXBlIiBicmVha3MgcHJlcGFyZS1DaGFuZ2VMb2cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDkzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAg ICAgICAgKGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfY3BwKToKKwogMjAxNy0wNy0yNiAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBydW4tamF2YXNj cmlwdGNvcmUtdGVzdCBydW4gdGVzdGFpciwgdGVzdGIzLCBhbmQgdGVzdG1hc20uCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZwppbmRleCAwZjQ0ZjIwLi4yYTVlZTM5IDEwMDc1NQotLS0gYS9Ub29scy9T Y3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFu Z2VMb2cKQEAgLTEwMDcsNiArMTAwNywxMiBAQCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2Vz X2Zvcl9jcHAoJCQpCiAgICAgICAgICAgICAgICAgbmV4dDsKICAgICAgICAgICAgIH0KIAorICAg ICAgICAgICAgIyBDKysgYXV0byBmdW5jdGlvbigpIC0+IHR5cGUKKyAgICAgICAgICAgIGlmICgk MSBlcSAiPiIpIHsKKyAgICAgICAgICAgICAgICAkc2tpcF90aWxfYnJhY2Vfb3Jfc2VtaWNvbG9u ID0gMSB1bmxlc3MgKCRpbl9wYXJlbnRoZXNlcyB8fCAkaW5fYnJhY2VzKTsKKyAgICAgICAgICAg ICAgICBuZXh0OworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICAjIEMrKyBjb25zdHJ1Y3Rv ciBpbml0aWFsaXplcnMKICAgICAgICAgICAgIGlmICgkMSBlcSAiOiIpIHsKICAgICAgICAgICAg ICAgICAgICRza2lwX3RpbF9icmFjZV9vcl9zZW1pY29sb24gPSAxIHVubGVzcyAoJGluX3BhcmVu dGhlc2VzIHx8ICRpbl9icmFjZXMpOwotLSAKMi45LjMKCg== 316644 2017-07-28 09:40:48 -0700 2017-07-28 11:54:37 -0700 patch 0001-ChangeLog-auto-function-returnType.patch text/plain 5055 jfbastien RnJvbSAyODlmNDBkOWM5MzM4ZDAyMjIwOThjZmNiMWE5YWZmMzg3YTg1NDg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUaHUsIDI3IEp1bCAyMDE3IDIzOjM0OjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQ2hhbmdl TG9nIGF1dG8gPGZ1bmN0aW9uKCk+IC0+IHJldHVyblR5cGUKCi0tLQogVG9vbHMvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKwog VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgfCAxOCAr KysrKysrKysrLQogLi4uL3Jlc291cmNlcy9jcHBfdW5pdHRlc3RzLWV4cGVjdGVkLnR4dCAgICAg ICAgICAgfCAyNSArKysrKysrKysrKysrKysrCiAuLi4vcmVzb3VyY2VzL2NwcF91bml0dGVzdHMu Y3BwICAgICAgICAgICAgICAgICAgICB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysKIDQgZmls ZXMgY2hhbmdlZCwgMTAwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjBlMWU3MS4uMTcwOTc2 MiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI2IEBACisyMDE3LTA3LTI4ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNv bT4KKworICAgICAgICBVc2luZyAiYXV0byA8ZnVuY3Rpb24oKT4gLT4gcmV0dXJuVHlwZSIgYnJl YWtzIHByZXBhcmUtQ2hhbmdlTG9nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzQ5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZWFjaCBwcmVwYXJlLUNoYW5nZUxvZyBhYm91dCBDKysgYXV0byBhcnJv dyByZXR1cm4sIGFuZCB3aGlsZSBJJ20KKyAgICAgICAgaGVyZSBhbHNvIHRlYWNoIGl0IGFib3V0 IGNvbnN0IGFuZCB2b2xhdGlsZSBvdmVybG9hZHMuIEkgZGlkbid0IGRvCisgICAgICAgIHJlZmVy ZW5jZSBhbmQgcnZhbHVlIHJlZmVyZW5jZSBvdmVybG9hZHMgYmVjYXVzZSB3ZSBkb24ndCByZWFs bHkKKyAgICAgICAgdXNlIHRoZW0sIGFuZCB0aGUgY3VycmVudCBwYXJzZXIgdGhyb3dzIGF3YXkg dGhvc2UgY2hhcmFjdGVycyBhbmQKKyAgICAgICAgaXQgZG9lc24ndCBzZWVtIHdvcnRoIG1ha2lu ZyBpdCBtb3JlIGNvbXBsZXguCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9n OgorICAgICAgICAoZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHApOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMv Y3BwX3VuaXR0ZXN0cy1leHBlY3RlZC50eHQ6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJs L3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9jcHBfdW5pdHRlc3RzLmNwcDoK KyAgICAgICAgKEZvbzo6QXJyb3c6OmFycm93KToKKyAgICAgICAgKEZvbzo6QXJyb3c6Om90aGVy QXJyb3cpOgorICAgICAgICAoRm9vOjpBcnJvdzo6b3RoZXJBcnJvdyBjb25zdCk6CisgICAgICAg IChGb286OkFycm93OjpvdGhlckFycm93IHZvbGF0aWxlKToKKyAgICAgICAgKEZvbzo6QXJyb3c6 Om90aGVyQXJyb3cgY29uc3Qgdm9sYXRpbGUpOgorCiAyMDE3LTA3LTI2ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0 IHJ1biB0ZXN0YWlyLCB0ZXN0YjMsIGFuZCB0ZXN0bWFzbS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9n CmluZGV4IDBmNDRmMjAuLjg4OGU5YjcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFy ZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMTAw Nyw5ICsxMDA3LDI1IEBAIHN1YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX2NwcCgkJCkK ICAgICAgICAgICAgICAgICBuZXh0OwogICAgICAgICAgICAgfQogCisgICAgICAgICAgICBpZiAo JDEgZXEgImNvbnN0IikgeworICAgICAgICAgICAgICAgICRwb3RlbnRpYWxfbmFtZSAuPSAiIGNv bnN0IjsKKyAgICAgICAgICAgICAgICBuZXh0OworICAgICAgICAgICAgfQorCisgICAgICAgICAg ICBpZiAoJDEgZXEgInZvbGF0aWxlIikgeworICAgICAgICAgICAgICAgICRwb3RlbnRpYWxfbmFt ZSAuPSAiIHZvbGF0aWxlIjsKKyAgICAgICAgICAgICAgICBuZXh0OworICAgICAgICAgICAgfQor CisgICAgICAgICAgICAjIEMrKyBhdXRvIGZ1bmN0aW9uKCkgLT4gdHlwZQorICAgICAgICAgICAg aWYgKCQxIGVxICI+IikgeworICAgICAgICAgICAgICAgICRza2lwX3RpbF9icmFjZV9vcl9zZW1p Y29sb24gPSAxIHVubGVzcyAoJGluX3BhcmVudGhlc2VzIHx8ICRpbl9icmFjZXMpOworICAgICAg ICAgICAgICAgIG5leHQ7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgICMgQysrIGNvbnN0 cnVjdG9yIGluaXRpYWxpemVycwogICAgICAgICAgICAgaWYgKCQxIGVxICI6IikgewotICAgICAg ICAgICAgICAgICAgJHNraXBfdGlsX2JyYWNlX29yX3NlbWljb2xvbiA9IDEgdW5sZXNzICgkaW5f cGFyZW50aGVzZXMgfHwgJGluX2JyYWNlcyk7CisgICAgICAgICAgICAgICAgJHNraXBfdGlsX2Jy YWNlX29yX3NlbWljb2xvbiA9IDEgdW5sZXNzICgkaW5fcGFyZW50aGVzZXMgfHwgJGluX2JyYWNl cyk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgICMgT3BlbiBicmFjZS4KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9y ZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy1leHBlY3RlZC50eHQgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL2NwcF91bml0dGVzdHMt ZXhwZWN0ZWQudHh0CmluZGV4IDhmMTFmN2EuLmYyNzU1NzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3Bw X3VuaXR0ZXN0cy1leHBlY3RlZC50eHQKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3By ZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9jcHBfdW5pdHRlc3RzLWV4cGVjdGVk LnR4dApAQCAtMjIxLDYgKzIyMSwzMSBAQAogICAgICAgJzM5MScsCiAgICAgICAnMzkzJywKICAg ICAgICdDbGFzczExMDxUZW1wbGF0ZUNsYXNzPjo6ZnVuYzM2JworICAgIF0sCisgICAgWworICAg ICAgJzM5OScsCisgICAgICAnNDAyJywKKyAgICAgICdGb286OkFycm93OjphcnJvdycKKyAgICBd LAorICAgIFsKKyAgICAgICc0MDknLAorICAgICAgJzQxMicsCisgICAgICAnRm9vOjpBcnJvdzo6 b3RoZXJBcnJvdycKKyAgICBdLAorICAgIFsKKyAgICAgICc0MTQnLAorICAgICAgJzQxNycsCisg ICAgICAnRm9vOjpBcnJvdzo6b3RoZXJBcnJvdyBjb25zdCcKKyAgICBdLAorICAgIFsKKyAgICAg ICc0MTknLAorICAgICAgJzQyMicsCisgICAgICAnRm9vOjpBcnJvdzo6b3RoZXJBcnJvdyB2b2xh dGlsZScKKyAgICBdLAorICAgIFsKKyAgICAgICc0MjQnLAorICAgICAgJzQyNycsCisgICAgICAn Rm9vOjpBcnJvdzo6b3RoZXJBcnJvdyBjb25zdCB2b2xhdGlsZScKICAgICBdCiAgIF0KIH0KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0 dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy5jcHAgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBl cmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL2NwcF91bml0dGVzdHMuY3Bw CmluZGV4IDkzNmY4MGIuLjFkOGQ5MTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy5j cHAKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0 ZXN0L3Jlc291cmNlcy9jcHBfdW5pdHRlc3RzLmNwcApAQCAtMzkxLDMgKzM5MSwzOCBAQCBjbGFz cyBDbGFzczEwOSB7CiB2b2lkIENsYXNzMTEwPFRlbXBsYXRlQ2xhc3M+OjpmdW5jMzYoKQogewog fQorCituYW1lc3BhY2UgRm9vIHsKKyAgICBjbGFzcyBBcnJvdyB7CisgICAgcHVibGljOgorICAg ICAgICB0eXBlZGVmIGludCBNeVR5cGU7CisgICAgICAgIGF1dG8gYXJyb3coTXlUeXBlIGEsIE15 VHlwZSBiKSAtPiBNeVR5cGUKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIDQyOworICAg ICAgICB9CisgICAgICAgIE15VHlwZSBvdGhlckFycm93KE15VHlwZSBhKTsKKyAgICAgICAgTXlU eXBlIG90aGVyQXJyb3coTXlUeXBlIGEpIGNvbnN0OworICAgICAgICBNeVR5cGUgb3RoZXJBcnJv dyhNeVR5cGUgYSkgdm9sYXRpbGU7CisgICAgICAgIE15VHlwZSBvdGhlckFycm93KE15VHlwZSBh KSBjb25zdCB2b2xhdGlsZTsKKyAgICB9OworCisgICAgYXV0byBBcnJvdzo6b3RoZXJBcnJvdyhN eVR5cGUgYSkgLT4gTXlUeXBlCisgICAgeworICAgICAgICByZXR1cm4gMHhjMGRlZmVmZTsKKyAg ICB9CisKKyAgICBhdXRvIEFycm93OjpvdGhlckFycm93KE15VHlwZSBhKSBjb25zdCAtPiBNeVR5 cGUKKyAgICB7CisgICAgICAgIHJldHVybiAweGMwZGVmZWZlOworICAgIH0KKworICAgIGF1dG8g QXJyb3c6Om90aGVyQXJyb3coTXlUeXBlIGEpIHZvbGF0aWxlIC0+IE15VHlwZQorICAgIHsKKyAg ICAgICAgcmV0dXJuIDB4YzBkZWZlZmU7CisgICAgfQorCisgICAgYXV0byBBcnJvdzo6b3RoZXJB cnJvdyhNeVR5cGUgYSkgY29uc3Qgdm9sYXRpbGUgLT4gTXlUeXBlCisgICAgeworICAgICAgICBy ZXR1cm4gMHhjMGRlZmVmZTsKKyAgICB9Cit9Ci0tIAoyLjkuMwoK