174928 2017-07-27 22:25:37 -0700 [iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down 2017-07-28 00:31:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue mitz thorton oldest_to_newest 1332878 0 wenson_hsieh 2017-07-27 22:25:37 -0700 <rdar://problem/33584280> 1332892 1 316621 wenson_hsieh 2017-07-27 22:54:01 -0700 Created attachment 316621 Patch 1332897 2 316621 thorton 2017-07-27 23:10:31 -0700 Comment on attachment 316621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316621&action=review > Source/WebCore/ChangeLog:25 > + Add a FIXME to point out that having an additional context flip inside the UIGraphicsImageRenderer block results > + in an upside-down drag image being returned from createDragImageFromImage. This image is being flipped elsewhere > + in drag initiation code, which eventually results in the correct orientation; we'll need further investigation > + to remove this extraneous flip. The DragImage code is full of flips in odd places. 1332914 3 316621 commit-queue 2017-07-28 00:31:09 -0700 Comment on attachment 316621 Patch Clearing flags on attachment: 316621 Committed r219998: <http://trac.webkit.org/changeset/219998> 1332915 4 commit-queue 2017-07-28 00:31:11 -0700 All reviewed patches have been landed. Closing bug. 316621 2017-07-27 22:54:01 -0700 2017-07-28 00:31:09 -0700 Patch bug-174928-20170727225400.patch text/plain 5113 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5Nzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDJlYjI2YmE2OWE4ODg2 ZThlZWYxYWJjNTcwMTBjODc0NzBjZDRkNS4uNTcwNTczZjg2ZGQwOTFhNWZkMzU5OWM3NGNmZTJm OWIzMTMyMDYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE3LTA3LTI3ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgRG5EXSBb V0sxXSBTbmFwc2hvdHMgZ2VuZXJhdGVkIHVzaW5nIC1bRE9NUmFuZ2UgcmVuZGVySW1hZ2VGb3Jj aW5nQmxhY2tUZXh0Ol0gYXJlIHVwc2lkZSBkb3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ5MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMz NTg0MjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFB1bGxzIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBjcmVhdGVEcmFnSW1hZ2VGb3JSYW5nZSBvdXQg aW50byBEcmFnSW1hZ2VJT1MsIGFuZCB1c2UgVGV4dEluZGljYXRvciB0byBnZW5lcmF0ZSBhCisg ICAgICAgIHNuYXBzaG90IGluc3RlYWQgb2YgRnJhbWVTZWxlY3Rpb24ncyBzbmFwc2hvdHRpbmcg dXRpbGl0aWVzLiBUaGlzIG1ha2VzIHNuYXBzaG90dGluZyBhIERPTVJhbmdlIGJlaGF2ZSB0aGUg c2FtZQorICAgICAgICB3YXkgYXMgc25hcHNob3R0aW5nIGEgZHJhZ2dlZCBzZWxlY3Rpb24uCisK KyAgICAgICAgTm8gd2F5IG9mIHRlc3RpbmcgVGV4dEluZGljYXRvci1iYXNlZCBzbmFwc2hvdHRp bmcgeWV0LgorCisgICAgICAgICogcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcDoKKworICAgICAgICBH dWFyZCBjcmVhdGVEcmFnSW1hZ2VGb3JSYW5nZSBmb3IgIVBMQVRGT1JNKElPUykuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9pb3MvRHJhZ0ltYWdlSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6Y3Jl YXRlRHJhZ0ltYWdlRm9yU2VsZWN0aW9uKToKKworICAgICAgICBBZGQgYSBGSVhNRSB0byBwb2lu dCBvdXQgdGhhdCBoYXZpbmcgYW4gYWRkaXRpb25hbCBjb250ZXh0IGZsaXAgaW5zaWRlIHRoZSBV SUdyYXBoaWNzSW1hZ2VSZW5kZXJlciBibG9jayByZXN1bHRzCisgICAgICAgIGluIGFuIHVwc2lk ZS1kb3duIGRyYWcgaW1hZ2UgYmVpbmcgcmV0dXJuZWQgZnJvbSBjcmVhdGVEcmFnSW1hZ2VGcm9t SW1hZ2UuIFRoaXMgaW1hZ2UgaXMgYmVpbmcgZmxpcHBlZCBlbHNld2hlcmUKKyAgICAgICAgaW4g ZHJhZyBpbml0aWF0aW9uIGNvZGUsIHdoaWNoIGV2ZW50dWFsbHkgcmVzdWx0cyBpbiB0aGUgY29y cmVjdCBvcmllbnRhdGlvbjsgd2UnbGwgbmVlZCBmdXJ0aGVyIGludmVzdGlnYXRpb24KKyAgICAg ICAgdG8gcmVtb3ZlIHRoaXMgZXh0cmFuZW91cyBmbGlwLgorCisgICAgICAgIChXZWJDb3JlOjpj cmVhdGVEcmFnSW1hZ2VGb3JSYW5nZSk6CisKIDIwMTctMDctMjMgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBXSzJdIDUgRGF0YUludGVyYWN0 aW9uVGVzdHMgYXJlIGZhaWxpbmc6IG9ic2VydmVkIHNlbGVjdGlvbiByZWN0cyBhZnRlciBkcm9w cGluZyBkb24ndCBtYXRjaCBleHBlY3RlZCB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFn SW1hZ2UuY3BwCmluZGV4IDExMzNiOTlhZWM4YjM2OWY0NmFhNGJhZTQyZDI5MDE1YWVlY2Q3YjEu LmNkMmJkNDM3NTE3YjYzMjBmNmM5NTM0MDgyMjliOTFiNWQ3MDFhYjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vRHJhZ0ltYWdlLmNwcApAQCAtMTUyLDYgKzE1Miw4IEBAIHN0cnVjdCBTY29wZWRG cmFtZVNlbGVjdGlvblN0YXRlIHsKICAgICBzdGQ6Om9wdGlvbmFsPHVuc2lnbmVkPiBlbmRPZmZz ZXQ7CiB9OwogCisjaWYgIVBMQVRGT1JNKElPUykKKwogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJ bWFnZUZvclJhbmdlKEZyYW1lJiBmcmFtZSwgUmFuZ2UmIHJhbmdlLCBib29sIGZvcmNlQmxhY2tU ZXh0KQogewogICAgIGZyYW1lLmRvY3VtZW50KCktPnVwZGF0ZUxheW91dCgpOwpAQCAtMTkwLDYg KzE5Miw4IEBAIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VGb3JSYW5nZShGcmFtZSYgZnJh bWUsIFJhbmdlJiByYW5nZSwgYm9vbCBmb3JjZUJsYWNrCiAgICAgcmV0dXJuIGNyZWF0ZURyYWdJ bWFnZUZyb21TbmFwc2hvdChzbmFwc2hvdEZyYW1lUmVjdChmcmFtZSwgdmlldy0+c2VsZWN0aW9u Qm91bmRzKCksIG9wdGlvbnMpLCBudWxscHRyKTsKIH0KIAorI2VuZGlmCisKIERyYWdJbWFnZVJl ZiBjcmVhdGVEcmFnSW1hZ2VGb3JJbWFnZShGcmFtZSYgZnJhbWUsIE5vZGUmIG5vZGUsIEludFJl Y3QmIGltYWdlUmVjdCwgSW50UmVjdCYgZWxlbWVudFJlY3QpCiB7CiAgICAgU2NvcGVkTm9kZURy YWdFbmFibGVyIGVuYWJsZURyYWcoZnJhbWUsIG5vZGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL0RyYWdJbWFnZUlPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9EcmFnSW1hZ2VJT1MubW0KaW5kZXggMDI1NDkxNzdiMDI1MTJkZjY3NTQ2MTI1ZTc2 ODM3MzRkZjk3ZmFhOS4uYTc5OTZmZDBkYjFkMjJkZTY4Nzk0YzRhYzNjOGY5Y2JlMjQwMjBiNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0RyYWdJbWFnZUlPUy5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvRHJhZ0ltYWdlSU9TLm1tCkBAIC0yMDks NiArMjA5LDggQEAgRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUZvclNlbGVjdGlvbihGcmFt ZSYgZnJhbWUsIFRleHRJbmRpY2F0b3JEYXRhJiBpbmRpY2EKICAgICBSZXRhaW5QdHI8VUlHcmFw aGljc0ltYWdlUmVuZGVyZXI+IHJlbmRlciA9IGFkb3B0TlMoW2FsbG9jVUlHcmFwaGljc0ltYWdl UmVuZGVyZXJJbnN0YW5jZSgpIGluaXRXaXRoU2l6ZTppbWFnZVJlY3Quc2l6ZSgpXSk7CiAgICAg VUlJbWFnZSAqZmluYWxJbWFnZSA9IFtyZW5kZXIuZ2V0KCkgaW1hZ2VXaXRoQWN0aW9uczpeKFVJ R3JhcGhpY3NJbWFnZVJlbmRlcmVyQ29udGV4dCAqcmVuZGVyZXJDb250ZXh0KSB7CiAgICAgICAg IEdyYXBoaWNzQ29udGV4dCBjb250ZXh0KHJlbmRlcmVyQ29udGV4dC5DR0NvbnRleHQpOworICAg ICAgICAvLyBGSVhNRTogVGhlIGNvbnRleHQgZmxpcCBoZXJlIHNob3VsZCBub3QgYmUgbmVjZXNz YXJ5LCBhbmQgc3VnZ2VzdHMgdGhhdCBzb21ld2hlcmUgZWxzZSBpbiB0aGUgcmVndWxhcgorICAg ICAgICAvLyBkcmFnIGluaXRpYXRpb24gZmxvdywgd2UgdW5uZWNlc3NhcmlseSBmbGlwIHRoZSBn cmFwaGljcyBjb250ZXh0LgogICAgICAgICBjb250ZXh0LnRyYW5zbGF0ZSgwLCBpbWFnZVJlY3Qu aGVpZ2h0KCkpOwogICAgICAgICBjb250ZXh0LnNjYWxlKHsgMSwgLTEgfSk7CiAgICAgICAgIGNv bnRleHQuZHJhd0ltYWdlKCppbWFnZSwgaW1hZ2VSZWN0KTsKQEAgLTIyMyw2ICsyMjUsMzIgQEAg RHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1h Z2UsIGZsb2F0KQogICAgIHJldHVybiBpbWFnZTsKIH0KIAorRHJhZ0ltYWdlUmVmIGNyZWF0ZURy YWdJbWFnZUZvclJhbmdlKEZyYW1lJiBmcmFtZSwgUmFuZ2UmIHJhbmdlLCBib29sIGZvcmNlQmxh Y2tUZXh0KQoreworICAgIGlmIChhdXRvIGRvY3VtZW50ID0gZnJhbWUuZG9jdW1lbnQoKSkKKyAg ICAgICAgZG9jdW1lbnQtPnVwZGF0ZUxheW91dCgpOworCisgICAgaWYgKHJhbmdlLmNvbGxhcHNl ZCgpKQorICAgICAgICByZXR1cm4gbmlsOworCisgICAgVGV4dEluZGljYXRvck9wdGlvbnMgb3B0 aW9ucyA9IGRlZmF1bHRTZWxlY3Rpb25EcmFnSW1hZ2VUZXh0SW5kaWNhdG9yT3B0aW9uczsKKyAg ICBpZiAoIWZvcmNlQmxhY2tUZXh0KQorICAgICAgICBvcHRpb25zIHw9IFRleHRJbmRpY2F0b3JP cHRpb25SZXNwZWN0VGV4dENvbG9yOworCisgICAgYXV0byB0ZXh0SW5kaWNhdG9yID0gVGV4dElu ZGljYXRvcjo6Y3JlYXRlV2l0aFJhbmdlKHJhbmdlLCBvcHRpb25zLCBUZXh0SW5kaWNhdG9yUHJl c2VudGF0aW9uVHJhbnNpdGlvbjo6Tm9uZSk7CisgICAgaWYgKCF0ZXh0SW5kaWNhdG9yIHx8ICF0 ZXh0SW5kaWNhdG9yLT5jb250ZW50SW1hZ2UoKSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKworICAg IGF1dG8mIGltYWdlID0gKnRleHRJbmRpY2F0b3ItPmNvbnRlbnRJbWFnZSgpOworICAgIGF1dG8g cmVuZGVyID0gYWRvcHROUyhbYWxsb2NVSUdyYXBoaWNzSW1hZ2VSZW5kZXJlckluc3RhbmNlKCkg aW5pdFdpdGhTaXplOmltYWdlLnNpemUoKV0pOworICAgIFVJSW1hZ2UgKmZpbmFsSW1hZ2UgPSBb cmVuZGVyLmdldCgpIGltYWdlV2l0aEFjdGlvbnM6WyZpbWFnZV0oVUlHcmFwaGljc0ltYWdlUmVu ZGVyZXJDb250ZXh0ICpyZW5kZXJlckNvbnRleHQpIHsKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0 IGNvbnRleHQocmVuZGVyZXJDb250ZXh0LkNHQ29udGV4dCk7CisgICAgICAgIGNvbnRleHQuZHJh d0ltYWdlKGltYWdlLCBGbG9hdFBvaW50KCkpOworICAgIH1dOworCisgICAgcmV0dXJuIGZpbmFs SW1hZ2UuQ0dJbWFnZTsKK30KKwogI2Vsc2UKIAogdm9pZCBkZWxldGVEcmFnSW1hZ2UoUmV0YWlu UHRyPENHSW1hZ2VSZWY+KQpAQCAtMjQ3LDYgKzI3NSwxMSBAQCBSZXRhaW5QdHI8Q0dJbWFnZVJl Zj4gY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKEltYWdlKiwgSW1hZ2VPcmllbnRhdGlvbkRlc2Ny aXB0aQogICAgIHJldHVybiBudWxscHRyOwogfQogCitEcmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0lt YWdlRm9yUmFuZ2UoRnJhbWUmLCBSYW5nZSYsIGJvb2wpCit7CisgICAgcmV0dXJuIG51bGxwdHI7 Cit9CisKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==