<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>174893</bug_id>
          
          <creation_ts>2017-07-27 08:47:43 -0700</creation_ts>
          <short_desc>Created a bool pretty printer at WTF for debugging purposes</short_desc>
          <delta_ts>2017-07-31 02:15:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Xabier Rodríguez Calvar">calvaris</reporter>
          <assigned_to name="Xabier Rodríguez Calvar">calvaris</assigned_to>
          <cc>benjamin</cc>
    
    <cc>buildbot</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1332647</commentid>
    <comment_count>0</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-27 08:47:43 -0700</bug_when>
    <thetext>created boolToChars in WTFString.h for debugging purposes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332648</commentid>
    <comment_count>1</comment_count>
      <attachid>316548</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-27 08:48:42 -0700</bug_when>
    <thetext>Created attachment 316548
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332657</commentid>
    <comment_count>2</comment_count>
      <attachid>316548</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2017-07-27 09:18:16 -0700</bug_when>
    <thetext>Comment on attachment 316548
Patch

Seems OK to have this function in WTF. But &quot;chars&quot; is not an abbreviation we should use in new code, and I don’t think this necessarily should be in WTFString.h either, since it has nothing to do with WTF::String. I’d also like to see an example of using it in the patch that adds it rather than just adding the unused function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332732</commentid>
    <comment_count>3</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-27 14:42:45 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #2)
&gt; Comment on attachment 316548 [details]
&gt; Patch
&gt; 
&gt; Seems OK to have this function in WTF. But &quot;chars&quot; is not an abbreviation we
&gt; should use in new code, and I don’t think this necessarily should be in
&gt; WTFString.h either, since it has nothing to do with WTF::String. I’d also
&gt; like to see an example of using it in the patch that adds it rather than
&gt; just adding the unused function.

Any suggestions on where to locate it or a better name? About the examples I guess I can just use it somewhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332940</commentid>
    <comment_count>4</comment_count>
      <attachid>316632</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-28 04:48:37 -0700</bug_when>
    <thetext>Created attachment 316632
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332941</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-28 04:50:11 -0700</bug_when>
    <thetext>How about adding MAKE_PRINT_ADAPTOR instead?
For example, JSC/SpeculatedType uses this mechanism to dump a special string while SpeculatedType is just uint64_t.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332966</commentid>
    <comment_count>6</comment_count>
      <attachid>316642</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-28 08:47:46 -0700</bug_when>
    <thetext>Created attachment 316642
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1332967</commentid>
    <comment_count>7</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2017-07-28 08:49:57 -0700</bug_when>
    <thetext>(In reply to Yusuke Suzuki from comment #5)
&gt; How about adding MAKE_PRINT_ADAPTOR instead?
&gt; For example, JSC/SpeculatedType uses this mechanism to dump a special string
&gt; while SpeculatedType is just uint64_t.

I think it&apos;s overengineering for what I need. Besides, there&apos;s already PrintStream taking bool and I don&apos;t use it because I just want to avoid casting when printing log or doing what the function does but inlined.

Anyway, you gave me the idea of PrintStream.h maybe being the place for the function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1333378</commentid>
    <comment_count>8</comment_count>
      <attachid>316642</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-07-31 02:15:02 -0700</bug_when>
    <thetext>Comment on attachment 316642
Patch

Clearing flags on attachment: 316642

Committed r220058: &lt;http://trac.webkit.org/changeset/220058&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1333379</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-07-31 02:15:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1333380</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-07-31 02:15:42 -0700</bug_when>
    <thetext>&lt;rdar://problem/33621437&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>316548</attachid>
            <date>2017-07-27 08:48:42 -0700</date>
            <delta_ts>2017-07-28 04:48:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174893-20170727174841.patch</filename>
            <type>text/plain</type>
            <size>2052</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5OTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiZTM2ZTc5YzQ4YjE4M2EwZTIxMzE5
YTI5YzJjNmIwMzNlZjBkNGYuLjIwZTg1N2IzYTQ4YWNhNjdiNjlkNzBhNTEzOTEwMWMxODNmYWVj
YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDctMjcgIFhhYmllciBSb2RyaWd1ZXogQ2Fs
dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBjcmVhdGVkIGJvb2xUb0NoYXJz
IGluIFdURlN0cmluZy5oIGZvciBkZWJ1Z2dpbmcgcHVycG9zZXMKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDg5MworCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3RleHQvV1RGU3RyaW5nLmg6Cisg
ICAgICAgIChXVEY6OmJvb2xUb0NoYXJzKTogQ29udmVydHMgYSBib29sIGluICJ0cnVlIiBvciAi
ZmFsc2UiLgorCiAyMDE3LTA3LTI2ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAg
ICAgICAgIFJlbW92ZSBXRUJfVElNSU5HIGZlYXR1cmUgZmxhZwpkaWZmIC0tZ2l0IGEvU291cmNl
L1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5n
LmgKaW5kZXggODNkNjYyODAyMDAzOWYxYTU3MDRmODU5MDVkODBlMzkwY2Y0MjE2Yi4uMjBlNjA1
ZTBlMTNkYTUxOTM3NzZlYjQ2YTk5MzAyNTc4NGYwYzM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dU
Ri93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmlu
Zy5oCkBAIC03Miw2ICs3Miw4IEBAIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBmbG9hdCBjaGFyYWN0
ZXJzVG9GbG9hdChjb25zdCBVQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSBuCiBXVEZfRVhQT1JU
X1NUUklOR19BUEkgZmxvYXQgY2hhcmFjdGVyc1RvRmxvYXQoY29uc3QgTENoYXIqLCBzaXplX3Qs
IHNpemVfdCYgcGFyc2VkTGVuZ3RoKTsKIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBmbG9hdCBjaGFy
YWN0ZXJzVG9GbG9hdChjb25zdCBVQ2hhciosIHNpemVfdCwgc2l6ZV90JiBwYXJzZWRMZW5ndGgp
OwogCitXVEZfRVhQT1JUX1NUUklOR19BUEkgY29uc3QgY2hhciogYm9vbFRvQ2hhcnMoYm9vbCk7
CisKIHRlbXBsYXRlPGJvb2wgaXNTcGVjaWFsQ2hhcmFjdGVyKFVDaGFyKSwgdHlwZW5hbWUgQ2hh
cmFjdGVyVHlwZT4gYm9vbCBpc0FsbFNwZWNpYWxDaGFyYWN0ZXJzKGNvbnN0IENoYXJhY3RlclR5
cGUqLCBzaXplX3QpOwogCiBlbnVtIFRyYWlsaW5nWmVyb3NUcnVuY2F0aW5nUG9saWN5IHsgS2Vl
cFRyYWlsaW5nWmVyb3MsIFRydW5jYXRlVHJhaWxpbmdaZXJvcyB9OwpAQCAtNzU5LDYgKzc2MSwx
MSBAQCB0ZW1wbGF0ZTw+IHN0cnVjdCBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uVHJhaXQ8U3Ry
aW5nPiB7CiAgICAgc3RhdGljIFN0cmluZyBmbHVzaChMQ2hhciogY2hhcmFjdGVycywgdW5zaWdu
ZWQgbGVuZ3RoLCB2b2lkKikgeyByZXR1cm4geyBjaGFyYWN0ZXJzLCBsZW5ndGggfTsgfQogfTsK
IAoraW5saW5lIGNvbnN0IGNoYXIqIGJvb2xUb0NoYXJzKGJvb2wgdHJ1ZU9yRmFsc2UpCit7Cisg
ICAgcmV0dXJuIHRydWVPckZhbHNlID8gInRydWUiIDogImZhbHNlIjsKK30KKwogfSAvLyBuYW1l
c3BhY2UgV1RGCiAKIHVzaW5nIFdURjo6Q1N0cmluZzsKQEAgLTc2Niw2ICs3NzMsNyBAQCB1c2lu
ZyBXVEY6OktlZXBUcmFpbGluZ1plcm9zOwogdXNpbmcgV1RGOjpTdHJpbmc7CiB1c2luZyBXVEY6
OmVtcHR5U3RyaW5nOwogdXNpbmcgV1RGOjphcHBlbmROdW1iZXI7Cit1c2luZyBXVEY6OmJvb2xU
b0NoYXJzOwogdXNpbmcgV1RGOjpjaGFyYWN0ZXJzQXJlQWxsQVNDSUk7CiB1c2luZyBXVEY6OmNo
YXJhY3RlcnNUb0ludFN0cmljdDsKIHVzaW5nIFdURjo6Y2hhcmFjdGVyc1RvVUludFN0cmljdDsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>316632</attachid>
            <date>2017-07-28 04:48:37 -0700</date>
            <delta_ts>2017-07-28 08:47:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174893-20170728134835.patch</filename>
            <type>text/plain</type>
            <size>4234</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5OTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiZTM2ZTc5YzQ4YjE4M2EwZTIxMzE5
YTI5YzJjNmIwMzNlZjBkNGYuLjlhNzBlODg5YWRhY2IzMzcwN2Y0NDc0NzczNGM2ZGYxNDY2MWIx
MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDctMjggIFhhYmllciBSb2RyaWd1ZXogQ2Fs
dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBDcmVhdGVkIFdURjo6Ym9vbFBy
ZXR0eVByaW50ZXIgZm9yIGRlYnVnZ2luZyBwdXJwb3NlcworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdDb21tb24uaDoKKyAg
ICAgICAgKFdURjo6Ym9vbFByZXR0eVByaW50ZXIpOiBDb252ZXJ0cyBhIGJvb2wgaW4gInRydWUi
IG9yICJmYWxzZSIuCisKIDIwMTctMDctMjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+
CiAKICAgICAgICAgUmVtb3ZlIFdFQl9USU1JTkcgZmVhdHVyZSBmbGFnCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NWEwMDA0NGI2MzRkMzA2MmFjNTQ5Mjc3MThiM2QzZWJjN2I1OWFmYi4uMTU4OTAzY2ZiM2NmODJm
ODNmYmY2OWMwYmNhMjU1MGIzZjJhY2VhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh
bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy
MDE3LTA3LTI4ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+
CisKKyAgICAgICAgQ3JlYXRlZCBXVEY6OmJvb2xQcmV0dHlQcmludGVyIGZvciBkZWJ1Z2dpbmcg
cHVycG9zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE3NDg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFVzZSBXVEY6OmJvb2xQcmV0dHlQcmludGVyIGluIGRlYnVnZ2luZyBtZXNzYWdlcy4KKworICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry
ZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl
YW1lckJhc2U6OnN1cHBvcnRzS2V5U3lzdGVtKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj
cy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OnNlZWspOgorCiAy
MDE3LTA3LTI3ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+
CiAKICAgICAgICAgW0dTdHJlYW1lcl1bRU1FXSBOb3QgaGF2aW5nIGEga2V5IGlkIGJ1ZmZlciBz
aG91bGQgbm90IGFsd2F5cyBlcnJvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9T
dHJpbmdDb21tb24uaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29tbW9uLmgKaW5kZXgg
OTMzMjk1N2MwMTViZWUzYTZhM2NjMjAzNTg5OTdmZDM5YmVkNTZjZC4uNTFkZDYxMzQ1OTExMmNh
YWUxNjc5MTUxMjU5NDhmNjU2MTY3MzJjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4
dC9TdHJpbmdDb21tb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0NvbW1vbi5o
CkBAIC00Myw2ICs0MywxMSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlLCB1bnNp
Z25lZCBsb3dlcmNhc2VMZXR0ZXJzTGVuZ3RoPiBib29sIGVxdWFsTGV0dAogCiB0ZW1wbGF0ZTx0
eXBlbmFtZSBTdHJpbmdDbGFzcywgdW5zaWduZWQgbGVuZ3RoPiBib29sIGVxdWFsTGV0dGVyc0ln
bm9yaW5nQVNDSUlDYXNlQ29tbW9uKGNvbnN0IFN0cmluZ0NsYXNzJiwgY29uc3QgY2hhciAoJmxv
d2VyY2FzZUxldHRlcnMpW2xlbmd0aF0pOwogCitpbmxpbmUgY29uc3QgY2hhciogYm9vbFByZXR0
eVByaW50ZXIoYm9vbCB0cnVlT3JGYWxzZSkKK3sKKyAgICByZXR1cm4gdHJ1ZU9yRmFsc2UgPyAi
dHJ1ZSIgOiAiZmFsc2UiOworfQorCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogaW5saW5lIFQgbG9h
ZFVuYWxpZ25lZChjb25zdCBjaGFyKiBzKQogewpAQCAtNjUyLDYgKzY1Nyw3IEBAIHRlbXBsYXRl
PHR5cGVuYW1lIFN0cmluZ0NsYXNzLCB1bnNpZ25lZCBsZW5ndGg+IGlubGluZSBib29sIHN0YXJ0
c1dpdGhMZXR0ZXJzSWduCiAKIH0KIAordXNpbmcgV1RGOjpib29sUHJldHR5UHJpbnRlcjsKIHVz
aW5nIFdURjo6ZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZTsKIHVzaW5nIFdURjo6ZXF1YWxMZXR0ZXJz
SWdub3JpbmdBU0NJSUNhc2U7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy
aXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCA5MDYzYWUzYmJmZGRjMjkxZTBiNmUwOGE1YTVh
ZTZmMzkyMzA1MzA5Li44Yjc1YmVkOGI4OTAwNDI4MTNhMTMzMDkxNThmNDM2MDZiYzRlYjVjIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk
aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu
Y3BwCkBAIC0xMDQwLDcgKzEwNDAsNyBAQCBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l
ckJhc2U6OnN1cHBvcnRzS2V5U3lzdGVtKGNvbnN0IFN0cmluZyYga2V5U3lzdGVtLAogICAgICAg
ICByZXN1bHQgPSB0cnVlOwogI2VuZGlmCiAKLSAgICBHU1RfREVCVUcoImNoZWNraW5nIGZvciBL
ZXlTeXN0ZW0gc3VwcG9ydCB3aXRoICVzIGFuZCB0eXBlICVzOiAlcyIsIGtleVN5c3RlbS51dGY4
KCkuZGF0YSgpLCBtaW1lVHlwZS51dGY4KCkuZGF0YSgpLCByZXN1bHQgPyAidHJ1ZSIgOiAiZmFs
c2UiKTsKKyAgICBHU1RfREVCVUcoImNoZWNraW5nIGZvciBLZXlTeXN0ZW0gc3VwcG9ydCB3aXRo
ICVzIGFuZCB0eXBlICVzOiAlcyIsIGtleVN5c3RlbS51dGY4KCkuZGF0YSgpLCBtaW1lVHlwZS51
dGY4KCkuZGF0YSgpLCBib29sUHJldHR5UHJpbnRlcihyZXN1bHQpKTsKICAgICByZXR1cm4gcmVz
dWx0OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0
ZUdTdHJlYW1lck1TRS5jcHAKaW5kZXggMjQxNjA1ODI5OTI2ZjUxY2JmYmQwNDcwZGViZDJiN2Rk
MGE3N2IzZC4uNzkyZjhkOTk2MjM2YjBkYjAzZWFlNmIzYTk0NjcxN2U3ZTE1NzQyZSAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRp
YVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNF
LmNwcApAQCAtMTk3LDcgKzE5Nyw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy
TVNFOjpzZWVrKGZsb2F0IHRpbWUpCiAgICAgfQogCiAgICAgbV9pc0VuZFJlYWNoZWQgPSBmYWxz
ZTsKLSAgICBHU1RfREVCVUcoIm1fc2Vla2luZz0lcywgbV9zZWVrVGltZT0lZiIsIG1fc2Vla2lu
ZyA/ICJ0cnVlIiA6ICJmYWxzZSIsIG1fc2Vla1RpbWUpOworICAgIEdTVF9ERUJVRygibV9zZWVr
aW5nPSVzLCBtX3NlZWtUaW1lPSVmIiwgYm9vbFByZXR0eVByaW50ZXIobV9zZWVraW5nKSwgbV9z
ZWVrVGltZSk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFOjpjb25m
aWd1cmVQbGF5U2luaygpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>316642</attachid>
            <date>2017-07-28 08:47:46 -0700</date>
            <delta_ts>2017-07-31 02:15:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174893-20170728174745.patch</filename>
            <type>text/plain</type>
            <size>4726</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5OTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRiZTM2ZTc5YzQ4YjE4M2EwZTIxMzE5
YTI5YzJjNmIwMzNlZjBkNGYuLjRhOTkxNWM2OWU5ZDA1NmQ3MTMwM2Q4OTM4YjE3ZmYyODEyMGVk
ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDctMjggIFhhYmllciBSb2RyaWd1ZXogQ2Fs
dmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBDcmVhdGVkIGEgYm9vbCBwcmV0
dHkgcHJpbnRlciBhdCBXVEYgZm9yIGRlYnVnZ2luZyBwdXJwb3NlcworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODkzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUHJpbnRTdHJlYW0uY3BwOgor
ICAgICAgICAoV1RGOjpwcmludEludGVybmFsKTogVGhlIG92ZXJsb2FkIHRha2luZyBib29sIHVz
ZXMgYm9vbEZvclByaW50aW5nCisgICAgICAgICogd3RmL1ByaW50U3RyZWFtLmg6CisgICAgICAg
IChXVEY6OmJvb2xGb3JQcmludGluZyk6IENvbnZlcnRzIGEgYm9vbCBpbiAidHJ1ZSIgb3IgImZh
bHNlIi4KKwogMjAxNy0wNy0yNiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAg
ICAgICBSZW1vdmUgV0VCX1RJTUlORyBmZWF0dXJlIGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1YTAwMDQ0
YjYzNGQzMDYyYWM1NDkyNzcxOGIzZDNlYmM3YjU5YWZiLi4xYWEyZmM5NmEyMjYyYTQwZThiYzNm
ODY4ZDAwZjllYzYxMGI5YTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDct
MjggIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAg
ICAgICBDcmVhdGVkIGEgYm9vbCBwcmV0dHkgcHJpbnRlciBhdCBXVEYgZm9yIGRlYnVnZ2luZyBw
dXJwb3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTc0ODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
VXNlIFdURjo6Ym9vbFByZXR0eVByaW50ZXIgaW4gZGVidWdnaW5nIG1lc3NhZ2VzLgorCisgICAg
ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl
YW1lckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh
bWVyQmFzZTo6c3VwcG9ydHNLZXlTeXN0ZW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRTo6c2Vlayk6CisKIDIw
MTctMDctMjcgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4K
IAogICAgICAgICBbR1N0cmVhbWVyXVtFTUVdIE5vdCBoYXZpbmcgYSBrZXkgaWQgYnVmZmVyIHNo
b3VsZCBub3QgYWx3YXlzIGVycm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QcmludFN0
cmVhbS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9QcmludFN0cmVhbS5jcHAKaW5kZXggOTdmYWYzMDMx
ODlhY2E5OWU5OGVlNmMzMWM2ODBjMzYzY2VlODEyYy4uOWUxMWM5OTM0YjViNTE4ZmNhNjVjOTEz
ZGVhZTRiNWMzZjQyMmNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUHJpbnRTdHJlYW0u
Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1ByaW50U3RyZWFtLmNwcApAQCAtMTA4LDEwICsxMDgs
NyBAQCB2b2lkIHByaW50SW50ZXJuYWwoUHJpbnRTdHJlYW0mIG91dCwgY29uc3QgU3RyaW5nSW1w
bCogc3RyaW5nKQogCiB2b2lkIHByaW50SW50ZXJuYWwoUHJpbnRTdHJlYW0mIG91dCwgYm9vbCB2
YWx1ZSkKIHsKLSAgICBpZiAodmFsdWUpCi0gICAgICAgIG91dC5wcmludCgidHJ1ZSIpOwotICAg
IGVsc2UKLSAgICAgICAgb3V0LnByaW50KCJmYWxzZSIpOworICAgIG91dC5wcmludChib29sRm9y
UHJpbnRpbmcodmFsdWUpKTsKIH0KIAogdm9pZCBwcmludEludGVybmFsKFByaW50U3RyZWFtJiBv
dXQsIGludCB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1ByaW50U3RyZWFtLmgg
Yi9Tb3VyY2UvV1RGL3d0Zi9QcmludFN0cmVhbS5oCmluZGV4IDZhODA2MGIxZDU3ZjI3OTkyN2Uw
YTQ2YzI1ZTBhOGQwYWU0MTQ4M2YuLjViMzkxM2M2ZGE1NTQ5ZmJhZThlZmIwMWFlOTI5ZmY1Mzg3
MTY3NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1ByaW50U3RyZWFtLmgKKysrIGIvU291
cmNlL1dURi93dGYvUHJpbnRTdHJlYW0uaApAQCAtNDQsNiArNDQsMTEgQEAgY2xhc3MgU3RyaW5n
SW1wbDsKIGNsYXNzIFN0cmluZ1ZpZXc7CiBjbGFzcyBVbmlxdWVkU3RyaW5nSW1wbDsKIAoraW5s
aW5lIGNvbnN0IGNoYXIqIGJvb2xGb3JQcmludGluZyhib29sIHZhbHVlKQoreworICAgIHJldHVy
biB2YWx1ZSA/ICJ0cnVlIiA6ICJmYWxzZSI7Cit9CisKIGNsYXNzIFByaW50U3RyZWFtIHsKICAg
ICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsgV1RGX01BS0VfTk9OQ09QWUFCTEUoUHJpbnRTdHJl
YW0pOwogcHVibGljOgpAQCAtMzM3LDYgKzM0Miw3IEBAIHZvaWQgcHJpbnRJbnRlcm5hbChQcmlu
dFN0cmVhbSYgb3V0LCBjb25zdCBzdGQ6Om9wdGlvbmFsPFQ+JiB2YWx1ZSkKIAogfSAvLyBuYW1l
c3BhY2UgV1RGCiAKK3VzaW5nIFdURjo6Ym9vbEZvclByaW50aW5nOwogdXNpbmcgV1RGOjpDaGFy
YWN0ZXJEdW1wOwogdXNpbmcgV1RGOjpQb2ludGVyRHVtcDsKIHVzaW5nIFdURjo6UHJpbnRTdHJl
YW07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt
ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz
ZS5jcHAKaW5kZXggOTA2M2FlM2JiZmRkYzI5MWUwYjZlMDhhNWE1YWU2ZjM5MjMwNTMwOS4uOTZi
NTQyMGMxOThhMjZlMTFlOGVmMWM5ZWM5NjQ1ZjljM2JhN2UxMiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT
dHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAtMTA0MCw3ICsx
MDQwLDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpzdXBwb3J0c0tl
eVN5c3RlbShjb25zdCBTdHJpbmcmIGtleVN5c3RlbSwKICAgICAgICAgcmVzdWx0ID0gdHJ1ZTsK
ICNlbmRpZgogCi0gICAgR1NUX0RFQlVHKCJjaGVja2luZyBmb3IgS2V5U3lzdGVtIHN1cHBvcnQg
d2l0aCAlcyBhbmQgdHlwZSAlczogJXMiLCBrZXlTeXN0ZW0udXRmOCgpLmRhdGEoKSwgbWltZVR5
cGUudXRmOCgpLmRhdGEoKSwgcmVzdWx0ID8gInRydWUiIDogImZhbHNlIik7CisgICAgR1NUX0RF
QlVHKCJjaGVja2luZyBmb3IgS2V5U3lzdGVtIHN1cHBvcnQgd2l0aCAlcyBhbmQgdHlwZSAlczog
JXMiLCBrZXlTeXN0ZW0udXRmOCgpLmRhdGEoKSwgbWltZVR5cGUudXRmOCgpLmRhdGEoKSwgYm9v
bEZvclByaW50aW5nKHJlc3VsdCkpOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQ
bGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcApp
bmRleCAyNDE2MDU4Mjk5MjZmNTFjYmZiZDA0NzBkZWJkMmI3ZGQwYTc3YjNkLi4wMjQ2NzAwZDNm
OTllNjQwZjQyYjQwYzc0N2UyZGI4YzYzOWM0ZmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl
YW1lck1TRS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh
bWVyL21zZS9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3BwCkBAIC0xOTcsNyArMTk3
LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OnNlZWsoZmxvYXQgdGlt
ZSkKICAgICB9CiAKICAgICBtX2lzRW5kUmVhY2hlZCA9IGZhbHNlOwotICAgIEdTVF9ERUJVRygi
bV9zZWVraW5nPSVzLCBtX3NlZWtUaW1lPSVmIiwgbV9zZWVraW5nID8gInRydWUiIDogImZhbHNl
IiwgbV9zZWVrVGltZSk7CisgICAgR1NUX0RFQlVHKCJtX3NlZWtpbmc9JXMsIG1fc2Vla1RpbWU9
JWYiLCBib29sRm9yUHJpbnRpbmcobV9zZWVraW5nKSwgbV9zZWVrVGltZSk7CiB9CiAKIHZvaWQg
TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFOjpjb25maWd1cmVQbGF5U2luaygpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>