174882 2017-07-26 19:45:57 -0700 PDF page number indicator is very flashy when scrolling 2017-07-27 10:06:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes bdakin oldest_to_newest 1332538 0 thorton 2017-07-26 19:45:57 -0700 PDF page number indicator is very flashy when scrolling 1332539 1 316507 thorton 2017-07-26 19:46:22 -0700 Created attachment 316507 Patch 1332540 2 thorton 2017-07-26 19:46:58 -0700 <rdar://problem/23760981> 1332667 3 316507 aestes 2017-07-27 10:02:19 -0700 Comment on attachment 316507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316507&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:743 > +@interface _UIBackdropViewSettings() Needs a space before (). > Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm:69 > + _backdropView = adoptNS([[_UIBackdropView alloc] initWithSettings:backdropViewSettings]); Looks like you need to declare -initWithSettings: in UIKitSPI.h. 1332670 4 thorton 2017-07-27 10:06:31 -0700 https://trac.webkit.org/changeset/219985/webkit 316507 2017-07-26 19:46:22 -0700 2017-07-27 10:02:19 -0700 Patch bug-174882-20170726194622.patch text/plain 3270 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3YmY0NjNhMTcwMzc3MDJl MzBjN2VmYmYzY2E5ZTI5ZWQxZWFiZjYuLmU5YzYyODc3N2ZkNWQ0NTIyYTRhNTVhODdlNDBhNGVi NDcwYmM0N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDctMjYgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUERGIHBhZ2UgbnVtYmVy IGluZGljYXRvciBpcyB2ZXJ5IGZsYXNoeSB3aGVuIHNjcm9sbGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODgyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yMzc2MDk4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLUERGUGFnZU51bWJlckluZGljYXRvci5tbToKKyAgICAgICAgKC1bV0tQREZQ YWdlTnVtYmVySW5kaWNhdG9yIGluaXRXaXRoRnJhbWU6XSk6CisgICAgICAgIEluY3JlYXNlIHRo ZSBiYWNrZHJvcCByZW5kZXJpbmcgcmVzb2x1dGlvbiB0byByZWR1Y2UgZmxhc2hpbmVzcy4KKyAg ICAgICAgSXQncyBzdGlsbCBub3QgcGVyZmVjdCwgYnV0IGl0J3MgcXVpdGUgdmlzaWJseSBiZXR0 ZXIuCisKIDIwMTctMDctMjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIFdFQl9USU1JTkcgZmVhdHVyZSBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0v c3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDM0ZTFlNWViYTI0OWY5ZWVlN2NkOGE3NTI5YThhNGQ2 OTBhY2UyZGEuLmVjNTM1N2RjNmQ3NzE1Zjk1NWI1MjBhYWMzZWI5MGQ4YzJhNzI0ZWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC03Miw2ICs3Miw3IEBA CiAjaW1wb3J0IDxVSUtpdC9VSVdlYlRpbGVkVmlldy5oPgogI2ltcG9ydCA8VUlLaXQvVUlXZWJU b3VjaEV2ZW50c0dlc3R1cmVSZWNvZ25pemVyLmg+CiAjaW1wb3J0IDxVSUtpdC9VSVdpbmRvd19Q cml2YXRlLmg+CisjaW1wb3J0IDxVSUtpdC9fVUlCYWNrZHJvcFZpZXdTZXR0aW5ncy5oPgogI2lt cG9ydCA8VUlLaXQvX1VJQmFja2Ryb3BWaWV3X1ByaXZhdGUuaD4KICNpbXBvcnQgPFVJS2l0L19V SUhpZ2hsaWdodFZpZXcuaD4KICNpbXBvcnQgPFVJS2l0L19VSU5hdmlnYXRpb25JbnRlcmFjdGl2 ZVRyYW5zaXRpb24uaD4KQEAgLTczMCwxMiArNzMxLDIwIEBAIHR5cGVkZWYgTlNfRU5VTShOU0lu dGVnZXIsIF9VSUJhY2tkcm9wVmlld1N0eWxlUHJpdmF0ZSkgewogQGludGVyZmFjZSBfVUlCYWNr ZHJvcFZpZXcgOiBVSVZpZXcKIEBlbmQKIAotQGludGVyZmFjZSBfVUlCYWNrZHJvcFZpZXcgKF9V SUJhY2tkcm9wVmlld0RldGFpbHMpCitAaW50ZXJmYWNlIF9VSUJhY2tkcm9wVmlldyAoKQogLSAo aW5zdGFuY2V0eXBlKWluaXRXaXRoUHJpdmF0ZVN0eWxlOihfVUlCYWNrZHJvcFZpZXdTdHlsZVBy aXZhdGUpc3R5bGU7CiAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KWZyYW1l IHByaXZhdGVTdHlsZTooX1VJQmFja2Ryb3BWaWV3U3R5bGVQcml2YXRlKXN0eWxlOwogQHByb3Bl cnR5IChub25hdG9taWMsIHN0cm9uZywgcmVhZG9ubHkpIFVJVmlldyAqY29udGVudFZpZXc7CiBA ZW5kCiAKK0BpbnRlcmZhY2UgX1VJQmFja2Ryb3BWaWV3U2V0dGluZ3MgOiBOU09iamVjdAorQGVu ZAorCitAaW50ZXJmYWNlIF9VSUJhY2tkcm9wVmlld1NldHRpbmdzKCkKKysgKF9VSUJhY2tkcm9w Vmlld1NldHRpbmdzICopc2V0dGluZ3NGb3JQcml2YXRlU3R5bGU6KF9VSUJhY2tkcm9wVmlld1N0 eWxlUHJpdmF0ZSlzdHlsZTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBhc3NpZ24pIENHRmxvYXQg c2NhbGU7CitAZW5kCisKIEBpbnRlcmZhY2UgX1VJSGlnaGxpZ2h0VmlldyA6IFVJVmlldwogQGVu ZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQREZQYWdlTnVt YmVySW5kaWNhdG9yLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUERGUGFnZU51 bWJlckluZGljYXRvci5tbQppbmRleCAxNjUxMDJkZTFjNjMxMGFjNmU1MjE2NDBmM2Y2NjM3OTNm NjYxMTUxLi45ZjRjNzdmZWY4MWExMWRkOTVkOTgyN2NiNGU5MjhlM2VjM2VhNzQ3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQREZQYWdlTnVtYmVySW5kaWNhdG9y Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1BERlBhZ2VOdW1iZXJJbmRp Y2F0b3IubW0KQEAgLTYzLDcgKzYzLDEwIEBAIC0gKGlkKWluaXRXaXRoRnJhbWU6KENHUmVjdClm cmFtZQogICAgIHNlbGYubGF5ZXIuYWxsb3dzR3JvdXBPcGFjaXR5ID0gTk87CiAgICAgc2VsZi5s YXllci5hbGxvd3NHcm91cEJsZW5kaW5nID0gTk87CiAKLSAgICBfYmFja2Ryb3BWaWV3ID0gYWRv cHROUyhbW19VSUJhY2tkcm9wVmlldyBhbGxvY10gaW5pdFdpdGhQcml2YXRlU3R5bGU6X1VJQmFj a2Ryb3BWaWV3U3R5bGVfTGlnaHRdKTsKKyAgICBfVUlCYWNrZHJvcFZpZXdTZXR0aW5ncyAqYmFj a2Ryb3BWaWV3U2V0dGluZ3MgPSBbX1VJQmFja2Ryb3BWaWV3U2V0dGluZ3Mgc2V0dGluZ3NGb3JQ cml2YXRlU3R5bGU6X1VJQmFja2Ryb3BWaWV3U3R5bGVfTGlnaHRdOworICAgIGJhY2tkcm9wVmll d1NldHRpbmdzLnNjYWxlID0gMC41OworCisgICAgX2JhY2tkcm9wVmlldyA9IGFkb3B0TlMoW1tf VUlCYWNrZHJvcFZpZXcgYWxsb2NdIGluaXRXaXRoU2V0dGluZ3M6YmFja2Ryb3BWaWV3U2V0dGlu Z3NdKTsKICAgICBbX2JhY2tkcm9wVmlldyBzZXRBdXRvcmVzaXppbmdNYXNrOlVJVmlld0F1dG9y ZXNpemluZ0ZsZXhpYmxlV2lkdGggfCBVSVZpZXdBdXRvcmVzaXppbmdGbGV4aWJsZUhlaWdodF07 CiAgICAgW3NlbGYgYWRkU3VidmlldzpfYmFja2Ryb3BWaWV3LmdldCgpXTsKICAgICBbc2VsZiBf bWFrZVJvdW5kZWRDb3JuZXJzXTsK