174870 2017-07-26 13:07:49 -0700 Remove duplicate code from Buildbot.js in dashboard 2017-07-26 14:38:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue dbates jmarcell lforschler oldest_to_newest 1332416 0 aakash_jain 2017-07-26 13:07:49 -0700 Some of the code in dashboard/Scripts/Buildbot.js is duplicated. We should remove the duplication. 1332421 1 316468 aakash_jain 2017-07-26 13:13:18 -0700 Created attachment 316468 Proposed patch 1332429 2 316468 dbates 2017-07-26 13:46:41 -0700 Comment on attachment 316468 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=316468&action=review > Tools/ChangeLog:9 > + (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Removing duplicate code and reusing buildPageURLForIteration() to construct URL. reusing => reuse 1332438 3 316477 aakash_jain 2017-07-26 13:59:52 -0700 Created attachment 316477 Patch for landing 1332454 4 316477 commit-queue 2017-07-26 14:38:07 -0700 Comment on attachment 316477 Patch for landing Clearing flags on attachment: 316477 Committed r219963: <http://trac.webkit.org/changeset/219963> 1332455 5 commit-queue 2017-07-26 14:38:09 -0700 All reviewed patches have been landed. Closing bug. 316468 2017-07-26 13:13:18 -0700 2017-07-26 13:59:52 -0700 Proposed patch patch_dashboard_remove_duplicate_code text/plain 3093 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxOTk1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTA3LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGNvZGUgZnJvbSBCdWlsZGJvdC5qcyBpbiBk YXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NDg3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv ZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3QuanM6CisgICAgICAgIChCdWlsZGJvdC5wcm90b3R5 cGUuamF2YVNjcmlwdENvcmVUZXN0RmFpbHVyZXNVUkxGb3JJdGVyYXRpb24pOiBSZW1vdmluZyBk dXBsaWNhdGUgY29kZSBhbmQgcmV1c2luZyBidWlsZFBhZ2VVUkxGb3JJdGVyYXRpb24oKSB0byBj b25zdHJ1Y3QgVVJMLgorICAgICAgICAoQnVpbGRib3QucHJvdG90eXBlLmphdmFTY3JpcHRDb3Jl VGVzdFN0ZGlvVXJsRm9ySXRlcmF0aW9uKTogRGl0dG8uCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Njcmlw dHMvdGVzdHMvcmVzb3VyY2VzL01vY2tCdWlsZGJvdC5qczoKKyAgICAgICAgKE1vY2tCdWlsZGJv dC5wcm90b3R5cGUuamF2YVNjcmlwdENvcmVUZXN0U3RkaW9VcmxGb3JJdGVyYXRpb24pOiBEaXR0 byBmb3IgdGVzdHMuCisKIDIwMTctMDctMjYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCB0ZXN0IHRvIHZlcmlmeSBjZXJ0YWluIGNoaWxkIHByb2Nlc3Nl cyBhcmUgbm90IGxhdW5jaGVkIGFzIGEgc2lkZSBlZmZlY3Qgb2YgZW5hYmxpbmcgUmVzb3VyY2VM b2FkU3RhdGlzdGljcy4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCShyZXZpc2lvbiAy MTk5NTcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdC5qcwkod29ya2luZyBjb3B5 KQpAQCAtMTUzLDEyICsxNTMsMTIgQEAgQnVpbGRib3QucHJvdG90eXBlID0gewogCiAgICAgamF2 YVNjcmlwdENvcmVUZXN0RmFpbHVyZXNVUkxGb3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlv biwgbmFtZSkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLmJhc2VVUkwgKyAiYnVpbGRlcnMv IiArIGVuY29kZVVSSUNvbXBvbmVudChpdGVyYXRpb24ucXVldWUuaWQpICsgIi9idWlsZHMvIiAr IGl0ZXJhdGlvbi5pZCArICIvc3RlcHMvIiArIG5hbWUgKyAiL2xvZ3MvanNvbi90ZXh0IjsKKyAg ICAgICAgcmV0dXJuIHRoaXMuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAi L3N0ZXBzLyIgKyBuYW1lICsgIi9sb2dzL2pzb24vdGV4dCI7CiAgICAgfSwKIAogICAgIGphdmFT Y3JpcHRDb3JlVGVzdFN0ZGlvVXJsRm9ySXRlcmF0aW9uOiBmdW5jdGlvbihpdGVyYXRpb24sIG5h bWUpCiAgICAgewotICAgICAgICByZXR1cm4gdGhpcy5iYXNlVVJMICsgImJ1aWxkZXJzLyIgKyBl bmNvZGVVUklDb21wb25lbnQoaXRlcmF0aW9uLnF1ZXVlLmlkKSArICIvYnVpbGRzLyIgKyBpdGVy YXRpb24uaWQgKyAiL3N0ZXBzLyIgKyBuYW1lICsgIi9sb2dzL3N0ZGlvIjsKKyAgICAgICAgcmV0 dXJuIHRoaXMuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAiL3N0ZXBzLyIg KyBuYW1lICsgIi9sb2dzL3N0ZGlvIjsKICAgICB9LAogCiAgICAgbGF5b3V0VGVzdFJlc3VsdHNE aXJlY3RvcnlVUkxGb3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbikKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL3Rlc3RzL3Jlc291cmNlcy9Nb2NrQnVpbGRib3QuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL01vY2tCdWlsZGJvdC5q cwkocmV2aXNpb24gMjE5OTU3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3Vy Y2VzL01vY2tCdWlsZGJvdC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDAsNyArNDAsNiBAQCBNb2Nr QnVpbGRib3QucHJvdG90eXBlID0gewogCiAgICAgamF2YVNjcmlwdENvcmVUZXN0U3RkaW9VcmxG b3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbiwgbmFtZSkKICAgICB7Ci0gICAgICAgIHJl dHVybiB0aGlzLmJhc2VVUkwgKyAiYnVpbGRlcnMvIiArIGVuY29kZVVSSUNvbXBvbmVudChpdGVy YXRpb24ucXVldWUuaWQpICsgIi9idWlsZHMvIiArIGl0ZXJhdGlvbi5pZCArICIvc3RlcHMvIiAr IG5hbWUgKyAiL2xvZ3Mvc3RkaW8iOwotCisgICAgICAgIHJldHVybiB0aGlzLmJ1aWxkUGFnZVVS TEZvckl0ZXJhdGlvbihpdGVyYXRpb24pICsgIi9zdGVwcy8iICsgbmFtZSArICIvbG9ncy9zdGRp byI7CiAgICAgfSwKIH0K 316477 2017-07-26 13:59:52 -0700 2017-07-26 14:38:07 -0700 Patch for landing patch_dashboard_remove_duplicate_code_v2 text/plain 3087 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxOTk2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTA3LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGNvZGUgZnJvbSBCdWlsZGJvdC5qcyBpbiBk YXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NDg3MAorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzOgorICAgICAgICAoQnVpbGRib3QucHJvdG90eXBl LmphdmFTY3JpcHRDb3JlVGVzdEZhaWx1cmVzVVJMRm9ySXRlcmF0aW9uKTogUmVtb3ZlIGR1cGxp Y2F0ZSBjb2RlIGFuZCByZXVzZSBidWlsZFBhZ2VVUkxGb3JJdGVyYXRpb24oKSB0byBjb25zdHJ1 Y3QgVVJMLgorICAgICAgICAoQnVpbGRib3QucHJvdG90eXBlLmphdmFTY3JpcHRDb3JlVGVzdFN0 ZGlvVXJsRm9ySXRlcmF0aW9uKTogRGl0dG8uCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVz dHMvcmVzb3VyY2VzL01vY2tCdWlsZGJvdC5qczoKKyAgICAgICAgKE1vY2tCdWlsZGJvdC5wcm90 b3R5cGUuamF2YVNjcmlwdENvcmVUZXN0U3RkaW9VcmxGb3JJdGVyYXRpb24pOiBEaXR0byBmb3Ig dGVzdHMuCisKIDIwMTctMDctMjYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCB0ZXN0IHRvIHZlcmlmeSBjZXJ0YWluIGNoaWxkIHByb2Nlc3NlcyBhcmUg bm90IGxhdW5jaGVkIGFzIGEgc2lkZSBlZmZlY3Qgb2YgZW5hYmxpbmcgUmVzb3VyY2VMb2FkU3Rh dGlzdGljcy4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCShyZXZpc2lvbiAyMTk5NTcp CisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdC5qcwkod29ya2luZyBjb3B5KQpAQCAt MTUzLDEyICsxNTMsMTIgQEAgQnVpbGRib3QucHJvdG90eXBlID0gewogCiAgICAgamF2YVNjcmlw dENvcmVUZXN0RmFpbHVyZXNVUkxGb3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbiwgbmFt ZSkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLmJhc2VVUkwgKyAiYnVpbGRlcnMvIiArIGVu Y29kZVVSSUNvbXBvbmVudChpdGVyYXRpb24ucXVldWUuaWQpICsgIi9idWlsZHMvIiArIGl0ZXJh dGlvbi5pZCArICIvc3RlcHMvIiArIG5hbWUgKyAiL2xvZ3MvanNvbi90ZXh0IjsKKyAgICAgICAg cmV0dXJuIHRoaXMuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAiL3N0ZXBz LyIgKyBuYW1lICsgIi9sb2dzL2pzb24vdGV4dCI7CiAgICAgfSwKIAogICAgIGphdmFTY3JpcHRD b3JlVGVzdFN0ZGlvVXJsRm9ySXRlcmF0aW9uOiBmdW5jdGlvbihpdGVyYXRpb24sIG5hbWUpCiAg ICAgewotICAgICAgICByZXR1cm4gdGhpcy5iYXNlVVJMICsgImJ1aWxkZXJzLyIgKyBlbmNvZGVV UklDb21wb25lbnQoaXRlcmF0aW9uLnF1ZXVlLmlkKSArICIvYnVpbGRzLyIgKyBpdGVyYXRpb24u aWQgKyAiL3N0ZXBzLyIgKyBuYW1lICsgIi9sb2dzL3N0ZGlvIjsKKyAgICAgICAgcmV0dXJuIHRo aXMuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAiL3N0ZXBzLyIgKyBuYW1l ICsgIi9sb2dzL3N0ZGlvIjsKICAgICB9LAogCiAgICAgbGF5b3V0VGVzdFJlc3VsdHNEaXJlY3Rv cnlVUkxGb3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbikKSW5kZXg6IFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL3Rlc3RzL3Jlc291cmNlcy9Nb2NrQnVpbGRib3QuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL01vY2tCdWlsZGJvdC5qcwkocmV2 aXNpb24gMjE5OTU3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL01v Y2tCdWlsZGJvdC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDAsNyArNDAsNiBAQCBNb2NrQnVpbGRi b3QucHJvdG90eXBlID0gewogCiAgICAgamF2YVNjcmlwdENvcmVUZXN0U3RkaW9VcmxGb3JJdGVy YXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbiwgbmFtZSkKICAgICB7Ci0gICAgICAgIHJldHVybiB0 aGlzLmJhc2VVUkwgKyAiYnVpbGRlcnMvIiArIGVuY29kZVVSSUNvbXBvbmVudChpdGVyYXRpb24u cXVldWUuaWQpICsgIi9idWlsZHMvIiArIGl0ZXJhdGlvbi5pZCArICIvc3RlcHMvIiArIG5hbWUg KyAiL2xvZ3Mvc3RkaW8iOwotCisgICAgICAgIHJldHVybiB0aGlzLmJ1aWxkUGFnZVVSTEZvckl0 ZXJhdGlvbihpdGVyYXRpb24pICsgIi9zdGVwcy8iICsgbmFtZSArICIvbG9ncy9zdGRpbyI7CiAg ICAgfSwKIH0K