17487 2008-02-22 01:23:29 -0800 HTMLInput mysteriously fails to work if ICU dat file is missing 2008-02-27 08:51:52 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Linux RESOLVED FIXED P5 Enhancement --- 1 sriram.neelakandan webkit-unassigned ap mrowe oldest_to_newest 71487 0 sriram.neelakandan 2008-02-22 01:23:29 -0800 HTML input box will not work if ICU dat file is not found. This happens due to failure in ICU's Textbreakiterator If an appropriate error message is displayed it will be useful for developers. 71490 1 mrowe 2008-02-22 03:21:43 -0800 I don't see how this is a valid bug. If your ICU installation is broken and you are using a WebKit port that relies on ICU then many things will not work. 71828 2 19336 sriram.neelakandan 2008-02-24 21:08:29 -0800 Created attachment 19336 Print an error if ICU fails to initialize 71829 3 sriram.neelakandan 2008-02-24 21:10:41 -0800 (In reply to comment #1) > I don't see how this is a valid bug. If your ICU installation is broken and > you are using a WebKit port that relies on ICU then many things will not work. > I use GTK port. Its not that many things don't work. Every thing works but for HTMLTextInput. I already have sent a patch for the same. It just prints a message to indicate failure. Can u review it ? Please see this link http://lists.webkit.org/pipermail/webkit-dev/2008-February/003426.html After taking care of Coding Guidelines as mentioned by David, I have attached a modified version of the same patch to this bug (http://bugs.webkit.org/attachment.cgi?id=19336&action=view) 72005 4 ap 2008-02-26 09:09:11 -0800 I think that adding logging for this case is a very good idea. I also had a occasion when debugging an issue caused by a missing (actually, non-matching) ICU dat file took longer than it should have taken. We normally use LOG_ERROR macro in cases like this, not fprintf(stderr, ...) - could you please update the patch to use it? In the future, you can mark a patch for review by clicking "Edit" link - this guarantees that it won't get lost. 72033 5 mrowe 2008-02-26 11:35:41 -0800 Can you please also create the patch using svn-create-patch. See <http://webkit.org/coding/contributing.html> for more information. 72129 6 19399 sriram.neelakandan 2008-02-27 01:48:01 -0800 Created attachment 19399 Patch from svn-create-patch I have corrected the patch as per coding guidelines. also used LOG_ERROR instead of fprintf. Also the patch has been taken using svn-create-patch 72140 7 19399 ap 2008-02-27 07:54:08 -0800 Comment on attachment 19399 Patch from svn-create-patch There are still some issues with this patch, but I'm going to say r=me and fix those when landing. 1. There is no ChangeLog. 2. "+#include <stdio.h>" is no longer needed without fprintf. 3. + if (!createdIterator) + { We put opening brace on the same line as "if". 4. Instead of a combination of LOG_ERROR and ASSERT, one can use ASSERT_WITH_MESSAGE. 72144 8 ap 2008-02-27 08:51:52 -0800 Committed in <http://trac.webkit.org/projects/webkit/changeset/30624>. 19336 2008-02-24 21:08:29 -0800 2008-02-27 01:48:01 -0800 Print an error if ICU fails to initialize HTMLInputText_patch.txt text/plain 1382 sriram.neelakandan LS0tIFRleHRCcmVha0l0ZXJhdG9ySUNVLmNwcCAgICAyMDA4LTAyLTIyIDE1OjA5OjMwLjAwMDAw MDAwMCArMDUzMAoqKioqKioqKioqKioqKioKKioqIDI1LDMwICoqKioKLS0tIDI1LDM0IC0tLS0K ICAjaW5jbHVkZSAiVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVS5oIgoKICAjaW5jbHVkZSA8 dW5pY29kZS91YnJrLmg+CisgI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisgI2luY2x1ZGUg PHN0ZGlvLmg+CisKKyB1c2luZyBuYW1lc3BhY2Ugc3RkOwoKICBuYW1lc3BhY2UgV2ViQ29yZSB7 CgoqKioqKioqKioqKioqKiogc3RhdGljIFRleHRCcmVha0l0ZXJhdG9yKiBzZXRVcEl0ZXJhdG9y KAoqKiogMzQsNDYgKioqKgogICAgICBpZiAoIXN0cmluZykKICAgICAgICAgIHJldHVybiAwOwoK ICAgICAgaWYgKCFjcmVhdGVkSXRlcmF0b3IpIHsKLSAgICAgICAgIFVFcnJvckNvZGUgb3BlblN0 YXR1cyA9IFVfWkVST19FUlJPUjsKICAgICAgICAgIGl0ZXJhdG9yID0gc3RhdGljX2Nhc3Q8VGV4 dEJyZWFrSXRlcmF0b3IqPih1YnJrX29wZW4odHlwZSwgY3VycmVudFRleHRCcmVha0xvY2FsZUlE KCksIDAsIDAsICZvcGVuU3RhdHVzKSk7CiAgICAgICAgICBjcmVhdGVkSXRlcmF0b3IgPSB0cnVl OwogICAgICB9CiAgICAgIGlmICghaXRlcmF0b3IpCiAgICAgICAgICByZXR1cm4gMDsKCiAgICAg IFVFcnJvckNvZGUgc2V0VGV4dFN0YXR1cyA9IFVfWkVST19FUlJPUjsKICAgICAgdWJya19zZXRU ZXh0KGl0ZXJhdG9yLCBzdHJpbmcsIGxlbmd0aCwgJnNldFRleHRTdGF0dXMpOwotLS0gMzgsNTQg LS0tLQogICAgICBpZiAoIXN0cmluZykKICAgICAgICAgIHJldHVybiAwOwoKKyAgICAgVUVycm9y Q29kZSBvcGVuU3RhdHVzID0gVV9aRVJPX0VSUk9SOwogICAgICBpZiAoIWNyZWF0ZWRJdGVyYXRv cikgewogICAgICAgICAgaXRlcmF0b3IgPSBzdGF0aWNfY2FzdDxUZXh0QnJlYWtJdGVyYXRvcio+ KHVicmtfb3Blbih0eXBlLCBjdXJyZW50VGV4dEJyZWFrTG9jYWxlSUQoKSwgMCwgMCwgJm9wZW5T dGF0dXMpKTsKICAgICAgICAgIGNyZWF0ZWRJdGVyYXRvciA9IHRydWU7CiAgICAgIH0KICAgICAg aWYgKCFpdGVyYXRvcikKKyAgICAgeworICAgICAgICAgTE9HX0VSUk9SKCJJQ1UgY291bGQgbm90 IGNyZWF0ZSBpdGVyYXRvciBpbnN0YW5jZSA6ICVzKCVkKSIsIHVfZXJyb3JOYW1lKG9wZW5TdGF0 dXMpLCBvcGVuU3RhdHVzKTsKKyAgICAgICAgIEFTU0VSVChpdGVyYXRvcik7CiAgICAgICAgICBy ZXR1cm4gMDsKKyAgICAgfQoKICAgICAgVUVycm9yQ29kZSBzZXRUZXh0U3RhdHVzID0gVV9aRVJP X0VSUk9SOwogICAgICB1YnJrX3NldFRleHQoaXRlcmF0b3IsIHN0cmluZywgbGVuZ3RoLCAmc2V0 VGV4dFN0YXR1cyk7Cgo= 19399 2008-02-27 01:48:01 -0800 2008-02-27 07:54:08 -0800 Patch from svn-create-patch Bug_17487_patch.txt text/plain 1153 sriram.neelakandan SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0QnJlYWtJdGVyYXRvcklDVS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRCcmVha0l0ZXJhdG9ySUNVLmNw cAkocmV2aXNpb24gMzA2MTcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEJyZWFrSXRl cmF0b3JJQ1UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw2ICsyNSwxMCBAQAogI2luY2x1ZGUg IlRleHRCcmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1UuaCIKIAogI2luY2x1ZGUgPHVuaWNvZGUvdWJy ay5oPgorI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8c3RkaW8uaD4KKwor dXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0zNCwxMyAr MzgsMTggQEAgc3RhdGljIFRleHRCcmVha0l0ZXJhdG9yKiBzZXRVcEl0ZXJhdG9yKAogICAgIGlm ICghc3RyaW5nKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIGlmICghY3JlYXRlZEl0ZXJhdG9y KSB7Ci0gICAgICAgIFVFcnJvckNvZGUgb3BlblN0YXR1cyA9IFVfWkVST19FUlJPUjsKKyAgICBV RXJyb3JDb2RlIG9wZW5TdGF0dXMgPSBVX1pFUk9fRVJST1I7CisgICAgaWYgKCFjcmVhdGVkSXRl cmF0b3IpIAorICAgIHsKICAgICAgICAgaXRlcmF0b3IgPSBzdGF0aWNfY2FzdDxUZXh0QnJlYWtJ dGVyYXRvcio+KHVicmtfb3Blbih0eXBlLCBjdXJyZW50VGV4dEJyZWFrTG9jYWxlSUQoKSwgMCwg MCwgJm9wZW5TdGF0dXMpKTsKICAgICAgICAgY3JlYXRlZEl0ZXJhdG9yID0gdHJ1ZTsKICAgICB9 CiAgICAgaWYgKCFpdGVyYXRvcikKKyAgICB7CisgICAgICAgIExPR19FUlJPUigiSUNVIGNvdWxk IG5vdCBjcmVhdGUgaXRlcmF0b3IgaW5zdGFuY2UgOiAlcyglZCkiLCB1X2Vycm9yTmFtZShvcGVu U3RhdHVzKSwgb3BlblN0YXR1cyk7CisgICAgICAgIEFTU0VSVChpdGVyYXRvcik7CiAgICAgICAg IHJldHVybiAwOworICAgIH0KIAogICAgIFVFcnJvckNvZGUgc2V0VGV4dFN0YXR1cyA9IFVfWkVS T19FUlJPUjsKICAgICB1YnJrX3NldFRleHQoaXRlcmF0b3IsIHN0cmluZywgbGVuZ3RoLCAmc2V0 VGV4dFN0YXR1cyk7Cg==