174855 2017-07-26 01:35:25 -0700 [CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later 2017-08-01 02:00:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned annulen bugs-noreply commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1332288 0 cgarcia 2017-07-26 01:35:25 -0700 WebKitFS.cmake creates the derived sources directories for WebCore, WebKit and WebDriver, but checking ENABLE options that are set in OptionPort files included later. We are already creating those directories in the specirfic makefiles of WebCore, WebKit and WebDriver, probably as a workaround to this. So, we should either create the directories unconditionally in WebKitFS (it's just a hamrless empty dir in case the option is not enabled) and remove the MAKE_DIRECTORY from all other makefiles, or keep it in the other makefiles and simply remove them from WebKitFS.cmake. 1333521 1 316798 mcatanzaro 2017-07-31 13:47:44 -0700 Created attachment 316798 Patch 1333683 2 316798 commit-queue 2017-08-01 01:08:59 -0700 Comment on attachment 316798 Patch Clearing flags on attachment: 316798 Committed r220091: <http://trac.webkit.org/changeset/220091> 1333684 3 commit-queue 2017-08-01 01:09:01 -0700 All reviewed patches have been landed. Closing bug. 1333685 4 webkit-bug-importer 2017-08-01 01:09:34 -0700 <rdar://problem/33648858> 1333690 5 mcatanzaro 2017-08-01 02:00:32 -0700 Why was this imported to rdar? Did it break something? 316798 2017-07-31 13:47:44 -0700 2017-08-01 01:08:59 -0700 Patch patch text/plain 6259 mcatanzaro ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1MTJiYjFlMzEzYi4uMjE3 OTNkMzM4MjkgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNyBAQAorMjAxNy0wNy0zMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBXZWJLaXRGUy5jbWFrZSBkZXBlbmRzIG9uIG9wdGlv bnMgc2V0IGluIE9wdGlvbiBjbWFrZSBmaWxlcyB0aGF0IGFyZSBpbmNsdWRlZCBsYXRlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3JlYXRlIGRlcml2 ZWQgc291cmNlcyBkaXJlY3RvcmllcyBpbiBXZWJLaXRDb21tb24uY21ha2UgaW5zdGVhZCBvZiBX ZWJLaXRGUy5jbWFrZSwgd2hpY2ggaXMKKyAgICAgICAgdG9vIHNvb24uIEkgdHJpZWQgY2hhbmdp bmcgdGhlIGluY2x1ZGUgb3JkZXIsIGJ1dCBvdGhlciBzdHVmZiBpbiBXZWJLaXRGUy5jbWFrZSBy ZWFsbHkgaXMKKyAgICAgICAgbmVlZGVkIGJlZm9yZSBpbmNsdWRpbmcgdGhlIHBvcnQgb3B0aW9u cyBmaWxlLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZToKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RlMuY21ha2U6CisKIDIwMTctMDctMjkgIFl1c3Vr ZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg YnVpbGQgZml4IGZvciBHVEsgYW5kIFdQRSBhYm91dCBTdG9yYWdlUHJvY2VzcyByZW5hbWluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZwppbmRleCAyY2QyODA4NDdkMS4uODY4NDM1ZTNmOGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDctMzEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gV2ViS2l0RlMuY21ha2UgZGVwZW5k cyBvbiBvcHRpb25zIHNldCBpbiBPcHRpb24gY21ha2UgZmlsZXMgdGhhdCBhcmUgaW5jbHVkZWQg bGF0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NDg1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERv bid0IGNyZWF0ZSBkZXJpdmVkIHNvdXJjZXMgZGlyZWN0b3J5IGhlcmUgYW55bW9yZS4KKworICAg ICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAyMDE3LTA3LTI2ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RL IGRpc3RjaGVjay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvUGxhdGZvcm1HVEsuY21h a2UgYi9Tb3VyY2UvV2ViRHJpdmVyL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDI0NTRkYTQ0Mzc5 Li4wZGViNTliODZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9QbGF0Zm9ybUdUSy5j bWFrZQorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0xLDUgKzEs MyBAQAotZmlsZShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJEUklWRVJfRElS fSkKLQogc2V0KFdlYkRyaXZlcl9Qcm9jZXNzX09VVFBVVF9OQU1FIFdlYktpdFdlYkRyaXZlcikK IAogYWRkX2RlZmluaXRpb25zKC1ETElCRVhFQ0RJUj0iJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElC RVhFQ0RJUn0iKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZwppbmRleCBlMjAzMjgzOWVkOC4uOTA3OWY2ZTdjOGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDctMzEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gV2ViS2l0RlMuY21ha2UgZGVwZW5k cyBvbiBvcHRpb25zIHNldCBpbiBPcHRpb24gY21ha2UgZmlsZXMgdGhhdCBhcmUgaW5jbHVkZWQg bGF0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NDg1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERv bid0IGNyZWF0ZSBkZXJpdmVkIHNvdXJjZXMgZGlyZWN0b3J5IGhlcmUgYW55bW9yZS4KKworICAg ICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorICAgICAgICAqIFBsYXRmb3JtTWFjLmNtYWtlOgor ICAgICAgICAqIFBsYXRmb3JtV1BFLmNtYWtlOgorCiAyMDE3LTA3LTMwICBCcmFkeSBFaWRzb24g IDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgVVJMU2NoZW1lSGFuZGxlciBBUEkg dGVzdHMgdGhhdCB2ZXJpZnkgdGhlIGxhY2sgb2YgVVJMU2NoZW1lVGFzayBvYmplY3QgbGVha3Mu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA4MmU3YTk3MzQxMi4uYmIxM2IwZTRiMWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNCw3ICs0LDYgQEAgc2V0KFdlYktpdDJfTmV0d29y a1Byb2Nlc3NfT1VUUFVUX05BTUUgV2ViS2l0TmV0d29ya1Byb2Nlc3MpCiBzZXQoV2ViS2l0Ml9Q bHVnaW5Qcm9jZXNzX09VVFBVVF9OQU1FIFdlYktpdFBsdWdpblByb2Nlc3MpCiBzZXQoV2ViS2l0 Ml9TdG9yYWdlUHJvY2Vzc19PVVRQVVRfTkFNRSBXZWJLaXREYXRhYmFzZVByb2Nlc3MpCiAKLWZp bGUoTUFLRV9ESVJFQ1RPUlkgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMl9ESVJ9KQogZmlsZShN QUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0FQSV9ESVJ9KQogZmls ZShNQUtFX0RJUkVDVE9SWSAke0ZPUldBUkRJTkdfSEVBREVSU19XRUJLSVQyR1RLX0RJUn0pCiBm aWxlKE1BS0VfRElSRUNUT1JZICR7Rk9SV0FSRElOR19IRUFERVJTX1dFQktJVDJHVEtfRVhURU5T SU9OX0RJUn0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtTWFjLmNtYWtlIGIv U291cmNlL1dlYktpdC9QbGF0Zm9ybU1hYy5jbWFrZQppbmRleCBjZWEzMTlmYWMwNC4uMTEwNWNh ZWE4N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1NYWMuY21ha2UKKysrIGIv U291cmNlL1dlYktpdC9QbGF0Zm9ybU1hYy5jbWFrZQpAQCAtMzgzLDggKzM4Myw2IEBAIGxpc3Qo QVBQRU5EIFdlYktpdDJfU09VUkNFUwogICAgIFdlYlByb2Nlc3MvbWFjL1NlY0l0ZW1TaGltTGli cmFyeS5tbQogKQogCi1maWxlKE1BS0VfRElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJ VDJfRElSfSkKLQogbGlzdChBUFBFTkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAg IiR7UEFMX0RJUn0iCiAgICAgIiR7V0VCS0lUMl9ESVJ9L05ldHdvcmtQcm9jZXNzL2NvY29hIgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm1XUEUuY21ha2UKaW5kZXggYThmMGI1OTk3OGUuLjE2YWMxMDU4NmE5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTEsNCArMSwzIEBACi1maWxlKE1BS0VfRElSRUNUT1JZ ICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJfRElSfSkKIGZpbGUoTUFLRV9ESVJFQ1RPUlkgJHtE RVJJVkVEX1NPVVJDRVNfV1BFX0FQSV9ESVJ9KQogZmlsZShNQUtFX0RJUkVDVE9SWSAke0ZPUldB UkRJTkdfSEVBREVSU19XUEVfRElSfSkKIGZpbGUoTUFLRV9ESVJFQ1RPUlkgJHtGT1JXQVJESU5H X0hFQURFUlNfV1BFX0VYVEVOU0lPTl9ESVJ9KQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dl YktpdENvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKaW5kZXgg OWEyOThkMzUzNTUuLjk4NjQ5OTZmOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTU3 LDggKzU3LDI4IEBAIGlmIChOT1QgSEFTX1JVTl9XRUJLSVRfQ09NTU9OKQogICAgIGluY2x1ZGUo T3B0aW9ucyR7UE9SVH0pCiAKICAgICAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi0gICAgIyBjb25m aWcuaAorICAgICMgQ3JlYXRlIGRlcml2ZWQgc291cmNlcyBkaXJlY3RvcmllcwogICAgICMgLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KIAorICAgIGlmIChFTkFCTEVfV0VCQ09SRSkKKyAgICAgICAgZmls ZShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0pCisgICAgZW5k aWYgKCkKKworICAgIGlmIChFTkFCTEVfV0VCS0lUKQorICAgICAgICBmaWxlKE1BS0VfRElSRUNU T1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJfRElSfSkKKyAgICBlbmRpZiAoKQorCisgICAg aWYgKEVOQUJMRV9XRUJLSVRfTEVHQUNZKQorICAgICAgICBmaWxlKE1BS0VfRElSRUNUT1JZICR7 REVSSVZFRF9TT1VSQ0VTX1dFQktJVExFR0FDWV9ESVJ9KQorICAgICAgICBmaWxlKE1BS0VfRElS RUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVF9ESVJ9KQorICAgIGVuZGlmICgpCisKKyAg ICBpZiAoRU5BQkxFX1dFQkRSSVZFUikKKyAgICAgICAgZmlsZShNQUtFX0RJUkVDVE9SWSAke0RF UklWRURfU09VUkNFU19XRUJEUklWRVJfRElSfSkKKyAgICBlbmRpZiAoKQorCisgICAgIyAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQorICAgICMgY29uZmlnLmgKKyAgICAjIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAgICAgQ1JFQVRFX0NPTkZJR1VSQVRJT05fSEVBREVSKCkKIGVuZGlmICgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RlMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RlMu Y21ha2UKaW5kZXggYTNhMmQ0NGE2NzAuLmE1ZDU4NWM3MWM0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvV2ViS2l0RlMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZTLmNtYWtlCkBA IC00NywyMCArNDcsMyBAQCBmaWxlKE1BS0VfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0v U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUpCiBmaWxlKE1BS0VfRElSRUNUT1JZICR7REVS SVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RPUlVJX0RJUn0pCiBmaWxlKE1BS0VfRElSRUNUT1JZICR7 REVSSVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RPUlVJX0RJUn0vUHJvdG9jb2wpCiBmaWxlKE1BS0Vf RElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RPUlVJX0RJUn0vVXNlckludGVy ZmFjZS9Qcm90b2NvbCkKLQotaWYgKEVOQUJMRV9XRUJDT1JFKQotICAgIGZpbGUoTUFLRV9ESVJF Q1RPUlkgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9KQotZW5kaWYgKCkKLQotaWYgKEVO QUJMRV9XRUJLSVQpCi0gICAgZmlsZShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19X RUJLSVQyX0RJUn0pCi1lbmRpZiAoKQotCi1pZiAoRU5BQkxFX1dFQktJVF9MRUdBQ1kpCi0gICAg ZmlsZShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJLSVRMRUdBQ1lfRElSfSkK LSAgICBmaWxlKE1BS0VfRElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVF9ESVJ9KQot ZW5kaWYgKCkKLQotaWYgKEVOQUJMRV9XRUJEUklWRVIpCi0gICAgZmlsZShNQUtFX0RJUkVDVE9S WSAke0RFUklWRURfU09VUkNFU19XRUJEUklWRVJfRElSfSkKLWVuZGlmICgpCg==