174846 2017-07-25 17:09:38 -0700 Remove Broken CompareEq constant folding phase. 2017-08-16 19:58:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller buildbot mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1332175 0 keith_miller 2017-07-25 17:09:38 -0700 This phase is broken because it can lead to patterns that we don't know how to generate. 1332178 1 keith_miller 2017-07-25 17:11:45 -0700 rdar://problem/32978808 1332182 2 316409 keith_miller 2017-07-25 17:19:19 -0700 Created attachment 316409 Patch 1332185 3 316411 keith_miller 2017-07-25 17:20:41 -0700 Created attachment 316411 Patch 1332189 4 316411 saam 2017-07-25 17:34:31 -0700 Comment on attachment 316411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138 > + // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. thing => things. Also, please add bug URL or remove FIXME. 1332190 5 316411 keith_miller 2017-07-25 17:44:25 -0700 Comment on attachment 316411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review >> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138 >> + // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. > > thing => things. > > Also, please add bug URL or remove FIXME. Fixed. 1332195 6 keith_miller 2017-07-25 17:49:31 -0700 Landed in: https://trac.webkit.org/changeset/219895/webkit 316409 2017-07-25 17:19:19 -0700 2017-07-25 17:20:40 -0700 Patch bug-174846-20170725171919.patch text/plain 2266 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YmI1YTZiOGZkNThhZWIyNzUwYzgwOTM2MDg5ODc0YmQ3ZDg1MWYxLi44NjA0NGQxNDkyMTVhMmI2 ZGQ4NzIxODdhN2M3NDliMzJhNzMwM2RlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMSBAQAorMjAxNy0wNy0yNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgQnJva2VuIENvbXBhcmVFcSBjb25zdGFudCBmb2xkaW5n IHBoYXNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc0ODQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjk3ODgwOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJ1ZyBoYXBwZW5lZCB3aGVu IHdlIHdvdWxkIGdldCBjb2RlIGxpa2UgdGhlIGZvbGxvd2luZzoKKworICAgICAgICBhOiBKU0Nv bnN0KFVuZGVmaW5lZCkKKyAgICAgICAgYjogR2V0TG9jYWwoU29tZU9iamVjdE9yVW5kZWZpbmVk KQorICAgICAgICAuLi4KKyAgICAgICAgYzogQ29tcGFyZUVxKENoZWNrOk9iamVjdE9yT3RoZXI6 YiwgQ2hlY2s6T2JqZWN0T3JPdGhlcjphKQorCisgICAgICAgIGNvbnN0YW50IGZvbGRpbmcgd2ls bCB0dXJuIHRoaXMgaW50bzoKKworICAgICAgICBhOiBKU0NvbnN0KFVuZGVmaW5lZCkKKyAgICAg ICAgYjogR2V0TG9jYWwoU29tZU9iamVjdE9yVW5kZWZpbmVkKQorICAgICAgICAuLi4KKyAgICAg ICAgYzogQ29tcGFyZUVxKENoZWNrOk9iamVjdE9yT3RoZXI6YiwgT3RoZXI6YSkKKworICAgICAg ICBCdXQgdGhlIFNwZWN1bGF0aXZlSklUL0ZUTCBsb3dlcmluZyB3aWxsIGZhaWwgdG8gY2hlY2sg YgorICAgICAgICBwcm9wZXJseSB3aGljaCBsZWFkcyB0byBhbiBhc3NlcnRpb24gZmFpbHVyZSBp biB0aGUgQUkuCisKKyAgICAgICAgKiBkZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwOgor ICAgICAgICAoSlNDOjpERkc6OkNvbnN0YW50Rm9sZGluZ1BoYXNlOjpmb2xkQ29uc3RhbnRzKToK KwogMjAxNy0wNy0yNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IGJ1Z3MgaW4gcHJvYmUgY29kZSB0byBjaGFuZ2Ugc3Agb24geDg2LCB4ODZfNjQgYW5kIDMy LWJpdCBBUk0uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0 YW50Rm9sZGluZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3Rh bnRGb2xkaW5nUGhhc2UuY3BwCmluZGV4IDhmNGE0NTVjODg3NGY1NThhN2JhYzAwMGU4MTJjMTlh YmE4Y2NiYzMuLjVmMWQ2ODQ1ZWM1ODI5OTNiMmM1NzFiZjViZTJhMWNmMjBlODVhYmUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2Uu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhh c2UuY3BwCkBAIC0xMzUsMTEgKzEzNSw4IEBAIHByaXZhdGU6CiAgICAgICAgICAgICB9CiAKICAg ICAgICAgICAgIGNhc2UgQ29tcGFyZUVxOiB7Ci0gICAgICAgICAgICAgICAgaWYgKCFtX2ludGVy cHJldGVyLm5lZWRzVHlwZUNoZWNrKG5vZGUtPmNoaWxkMSgpLCBTcGVjT3RoZXIpKQotICAgICAg ICAgICAgICAgICAgICBub2RlLT5jaGlsZDEoKS5zZXRVc2VLaW5kKE90aGVyVXNlKTsKLSAgICAg ICAgICAgICAgICBpZiAoIW1faW50ZXJwcmV0ZXIubmVlZHNUeXBlQ2hlY2sobm9kZS0+Y2hpbGQy KCksIFNwZWNPdGhlcikpCi0gICAgICAgICAgICAgICAgICAgIG5vZGUtPmNoaWxkMigpLnNldFVz ZUtpbmQoT3RoZXJVc2UpOwotICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg IC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIGJhY2sgdGhlIGJyb2tlbiBmb2xkaW5nIHBoYXNlIGhl cmUgZm9yIGNvbXBhcmlzaW9ucyB3aXRoIHRoaW5nIHdlIHByb3ZlIG9uZSBzaWRlIGhhcyB0eXBl IFNwZWNPdGhlci4gCisgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICAKICAgICAgICAgICAgIGNhc2UgQ2hlY2tTdHJ1Y3R1cmU6Cg== 316411 2017-07-25 17:20:41 -0700 2017-07-25 17:34:31 -0700 Patch bug-174846-20170725172040.patch text/plain 2441 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YmI1YTZiOGZkNThhZWIyNzUwYzgwOTM2MDg5ODc0YmQ3ZDg1MWYxLi5lNWJiM2FmNmNhNzBkMmRh ZjIyNTc0MzY1YTQ1YjIyOWE2NmU1NDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNSBAQAorMjAxNy0wNy0yNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgQnJva2VuIENvbXBhcmVFcSBjb25zdGFudCBmb2xkaW5n IHBoYXNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc0ODQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjk3ODgwOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJ1ZyBoYXBwZW5lZCB3aGVu IHdlIHdvdWxkIGdldCBjb2RlIGxpa2UgdGhlIGZvbGxvd2luZzoKKworICAgICAgICBhOiBKU0Nv bnN0KFVuZGVmaW5lZCkKKyAgICAgICAgYjogR2V0TG9jYWwoU29tZU9iamVjdE9yVW5kZWZpbmVk KQorICAgICAgICAuLi4KKyAgICAgICAgYzogQ29tcGFyZUVxKENoZWNrOk9iamVjdE9yT3RoZXI6 YiwgQ2hlY2s6T2JqZWN0T3JPdGhlcjphKQorCisgICAgICAgIGNvbnN0YW50IGZvbGRpbmcgd2ls bCB0dXJuIHRoaXMgaW50bzoKKworICAgICAgICBhOiBKU0NvbnN0KFVuZGVmaW5lZCkKKyAgICAg ICAgYjogR2V0TG9jYWwoU29tZU9iamVjdE9yVW5kZWZpbmVkKQorICAgICAgICAuLi4KKyAgICAg ICAgYzogQ29tcGFyZUVxKENoZWNrOk9iamVjdE9yT3RoZXI6YiwgT3RoZXI6YSkKKworICAgICAg ICBCdXQgdGhlIFNwZWN1bGF0aXZlSklUL0ZUTCBsb3dlcmluZyB3aWxsIGZhaWwgdG8gY2hlY2sg YgorICAgICAgICBwcm9wZXJseSB3aGljaCBsZWFkcyB0byBhbiBhc3NlcnRpb24gZmFpbHVyZSBp biB0aGUgQUkuCisKKyAgICAgICAgSSdsbCBmb2xsb3cgdXAgd2l0aCBhIG1vcmUgcm9idXN0IGZp eCBsYXRlci4gRm9yIG5vdywgSSdsbCByZW1vdmUgdGhlCisgICAgICAgIGNhc2UgdGhhdCBnZW5l cmF0ZXMgdGhlIGNvZGUuIFJlbW92aW5nIHRoZSBjb2RlIGFwcGVhcnMgdG8gYmUgcGVyZgorICAg ICAgICBuZXV0cmFsLgorCisgICAgICAgICogZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpDb25zdGFudEZvbGRpbmdQaGFzZTo6Zm9sZENvbnN0YW50 cyk6CisKIDIwMTctMDctMjUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCBidWdzIGluIHByb2JlIGNvZGUgdG8gY2hhbmdlIHNwIG9uIHg4NiwgeDg2XzY0IGFu ZCAzMi1iaXQgQVJNLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdD b25zdGFudEZvbGRpbmdQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nv bnN0YW50Rm9sZGluZ1BoYXNlLmNwcAppbmRleCA4ZjRhNDU1Yzg4NzRmNTU4YTdiYWMwMDBlODEy YzE5YWJhOGNjYmMzLi41ZjFkNjg0NWVjNTgyOTkzYjJjNTcxYmY1YmUyYTFjZjIwZTg1YWJlIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1Bo YXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGlu Z1BoYXNlLmNwcApAQCAtMTM1LDExICsxMzUsOCBAQCBwcml2YXRlOgogICAgICAgICAgICAgfQog CiAgICAgICAgICAgICBjYXNlIENvbXBhcmVFcTogewotICAgICAgICAgICAgICAgIGlmICghbV9p bnRlcnByZXRlci5uZWVkc1R5cGVDaGVjayhub2RlLT5jaGlsZDEoKSwgU3BlY090aGVyKSkKLSAg ICAgICAgICAgICAgICAgICAgbm9kZS0+Y2hpbGQxKCkuc2V0VXNlS2luZChPdGhlclVzZSk7Ci0g ICAgICAgICAgICAgICAgaWYgKCFtX2ludGVycHJldGVyLm5lZWRzVHlwZUNoZWNrKG5vZGUtPmNo aWxkMigpLCBTcGVjT3RoZXIpKQotICAgICAgICAgICAgICAgICAgICBub2RlLT5jaGlsZDIoKS5z ZXRVc2VLaW5kKE90aGVyVXNlKTsKLSAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAg ICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFkZCBiYWNrIHRoZSBicm9rZW4gZm9sZGluZyBwaGFz ZSBoZXJlIGZvciBjb21wYXJpc2lvbnMgd2l0aCB0aGluZyB3ZSBwcm92ZSBvbmUgc2lkZSBoYXMg dHlwZSBTcGVjT3RoZXIuIAorICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICBjYXNlIENoZWNrU3RydWN0dXJlOgo=