174840 2017-07-25 15:59:02 -0700 Web Inspector: Fix warnings about console.assert lines without semicolons 2017-07-25 17:45:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1332129 0 joepeck 2017-07-25 15:59:02 -0700 Fix warnings about console.assert lines without semicolons' $ ./Scripts/copy-user-interface-resources-dryrun.rb $d/foo WARNING: console.assert missing trailing semicolon on line 50001: console.assert(navigationItem, "Missing navigation item for settings view.", settingsView) WARNING: console.assert missing trailing semicolon on line 50046: console.assert(index !== -1, "SettingsView not found.", settingsView) 1332131 1 316400 joepeck 2017-07-25 16:01:38 -0700 Created attachment 316400 [PATCH] Proposed Fix 1332181 2 316400 bburg 2017-07-25 17:17:27 -0700 Comment on attachment 316400 [PATCH] Proposed Fix rs=me 1332191 3 316400 commit-queue 2017-07-25 17:45:08 -0700 Comment on attachment 316400 [PATCH] Proposed Fix Clearing flags on attachment: 316400 Committed r219894: <http://trac.webkit.org/changeset/219894> 1332192 4 commit-queue 2017-07-25 17:45:10 -0700 All reviewed patches have been landed. Closing bug. 316400 2017-07-25 16:01:38 -0700 2017-07-25 17:45:08 -0700 [PATCH] Proposed Fix assert-1.patch text/plain 2118 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRjMDBkYzdkYzE1Li5kNThiNzliNTc5NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDctMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBGaXggd2FybmluZ3MgYWJvdXQgY29uc29sZS5hc3NlcnQgbGluZXMgd2l0aG91dCBzZW1pY29s b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ4 NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zZXQgc2VsZWN0ZWRT ZXR0aW5nc1ZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRpbmdzVGFiQ29udGVudFZp ZXcucHJvdG90eXBlLnNldFNldHRpbmdzVmlld1Zpc2libGUpOgorICAgICAgICBBZGQgc2VtaWNv bG9uIHRvIGFzc2VydCBsaW5lcyBzbyB0aGV5IGNhbiBiZSBzdHJpcHBlZCBpbiBvcHRpbWl6ZWQg YnVpbGRzLgorCiAyMDE3LTA3LTIxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5saW5lIG11bHRpcGxlIGNvbnNvbGUgbG9n IHZhbHVlcyBpZiB0aGV5IGFyZSBzaW1wbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRW aWV3LmpzCmluZGV4IGI0MDExMTcwZGUzLi5jMGUwMGZiYTNmNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0 aW5nc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC04MCw3ICs4MCw3IEBAIFdlYkluc3BlY3Rvci5TZXR0 aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRz IFdlYkluCiAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2V0dGluZ3NWaWV3LnVwZGF0ZUxheW91dCgp OwogCiAgICAgICAgIGxldCBuYXZpZ2F0aW9uSXRlbSA9IHRoaXMuX25hdmlnYXRpb25CYXIuZmlu ZE5hdmlnYXRpb25JdGVtKHNldHRpbmdzVmlldy5pZGVudGlmaWVyKTsKLSAgICAgICAgY29uc29s ZS5hc3NlcnQobmF2aWdhdGlvbkl0ZW0sICJNaXNzaW5nIG5hdmlnYXRpb24gaXRlbSBmb3Igc2V0 dGluZ3Mgdmlldy4iLCBzZXR0aW5nc1ZpZXcpCisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KG5hdmln YXRpb25JdGVtLCAiTWlzc2luZyBuYXZpZ2F0aW9uIGl0ZW0gZm9yIHNldHRpbmdzIHZpZXcuIiwg c2V0dGluZ3NWaWV3KTsKICAgICAgICAgaWYgKCFuYXZpZ2F0aW9uSXRlbSkKICAgICAgICAgICAg IHJldHVybjsKIApAQCAtMTI1LDcgKzEyNSw3IEBAIFdlYkluc3BlY3Rvci5TZXR0aW5nc1RhYkNv bnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAg ICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgbGV0IGluZGV4ID0gdGhpcy5fc2V0dGluZ3NW aWV3cy5pbmRleE9mKHNldHRpbmdzVmlldyk7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KGluZGV4 ICE9PSAtMSwgIlNldHRpbmdzVmlldyBub3QgZm91bmQuIiwgc2V0dGluZ3NWaWV3KQorICAgICAg ICBjb25zb2xlLmFzc2VydChpbmRleCAhPT0gLTEsICJTZXR0aW5nc1ZpZXcgbm90IGZvdW5kLiIs IHNldHRpbmdzVmlldyk7CiAgICAgICAgIGlmIChpbmRleCA9PT0gLTEpCiAgICAgICAgICAgICBy ZXR1cm47CiAK