174836 2017-07-25 14:25:56 -0700 bisect-builds: add --list option 2018-01-15 12:51:26 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174596 1 lforschler lforschler aakash_jain annulen lforschler mcatanzaro sam slewis webkit-bug-importer oldest_to_newest 1332098 0 lforschler 2017-07-25 14:25:56 -0700 We should add a --list option to get a list of revisions. We should also print out a list of platform and configurations. 1332099 1 webkit-bug-importer 2017-07-25 14:26:43 -0700 <rdar://problem/33521944> 1346999 2 320315 lforschler 2017-09-08 16:43:41 -0700 Created attachment 320315 v1 patch for review 1347017 3 320315 sam 2017-09-08 17:46:17 -0700 Comment on attachment 320315 v1 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review > Tools/Scripts/bisect-builds:225 > + print 'Supported minified platforms: {}'.format(minified_platforms()) > + print 'Supported unminified platforms: {}'.format(unminified_platforms()) What does minified/unminified mean in this context? 1347021 4 320315 lforschler 2017-09-08 17:52:26 -0700 Comment on attachment 320315 v1 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review >> Tools/Scripts/bisect-builds:225 >> + print 'Supported unminified platforms: {}'.format(unminified_platforms()) > > What does minified/unminified mean in this context? Minified archives are those with dSYMs and a few other non-essential bits stripped out. They are approximately 90% smaller than full archives (unminified) We keep full archives for 14 days. Minified Archives for 2.5 years. 1347025 5 320322 lforschler 2017-09-08 17:57:08 -0700 Created attachment 320322 v2 patch from feedback 1347030 6 320322 annulen 2017-09-08 18:15:01 -0700 Comment on attachment 320322 v2 patch from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review > Tools/Scripts/bisect-builds:228 > + exit(1) I think it should be exit(0), as it is not exit because of error 1347041 7 sam 2017-09-08 20:07:28 -0700 Does the help text document the minified term anywhere? If not, I think it probably needs to say something clearer, or explain what that means in some way. 1347050 8 320322 lforschler 2017-09-08 21:49:41 -0700 Comment on attachment 320322 v2 patch from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review >> Tools/Scripts/bisect-builds:228 >> + exit(1) > > I think it should be exit(0), as it is not exit because of error good catch, will fix. 1347051 9 lforschler 2017-09-08 21:53:04 -0700 (In reply to Sam Weinig from comment #7) > Does the help text document the minified term anywhere? If not, I think it > probably needs to say something clearer, or explain what that means in some > way. I will investigate working this into the help text. 1347058 10 320333 lforschler 2017-09-08 22:20:23 -0700 Created attachment 320333 v3. 1347059 11 320334 lforschler 2017-09-08 22:21:44 -0700 Created attachment 320334 v3 1347730 12 320334 aakash_jain 2017-09-11 16:48:39 -0700 Comment on attachment 320334 v3 View in context: https://bugs.webkit.org/attachment.cgi?id=320334&action=review > Tools/Scripts/bisect-builds:225 > + print('Supported minified platforms: {}'.format(minified_platforms())) It might be a good idea to make this a function, instead of having all these print statements in main. 1347744 13 lforschler 2017-09-11 17:10:32 -0700 Committed revision 221895. 320315 2017-09-08 16:43:41 -0700 2017-09-08 17:57:08 -0700 v1 patch for review 174836.patch text/plain 2489 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTgwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzOiBhZGQgLS1saXN0IG9wdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Jpc2Vj dC1idWlsZHM6CisgICAgICAgIChwYXJzZV9hcmdzKTogYWRkIC0tbGlzdCBvcHRpb24KKyAgICAg ICAgKG1pbmlmaWVkX3BsYXRmb3Jtcyk6IHVwZGF0ZSBwbGF0Zm9ybSB0byBpbmNsdWRlIGlvcy0x MC1zaW11bGF0b3IKKyAgICAgICAgKG1haW4pOgorCiAyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hs ZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBiaXNlY3QtYnVpbGRzIGRvZXNu J3Qgd29yayBkdWUgdG8gbWlzc2luZyByZXF1ZXN0cyBtb2R1bGUKSW5kZXg6IFRvb2xzL1Njcmlw dHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2Jpc2VjdC1idWls ZHMJKHJldmlzaW9uIDIyMTgwMSkKKysrIFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwkod29y a2luZyBjb3B5KQpAQCAtMTM5LDYgKzEzOSw3IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3MpOgogICAg IHBhcnNlci5hZGRfYXJndW1lbnQoJy1mJywgJy0tZnVsbCcsIGFjdGlvbj0nc3RvcmVfdHJ1ZScs IGRlZmF1bHQ9RmFsc2UsIGhlbHA9J1VzZSBmdWxsIGFyY2hpdmVzIGNvbnRhaW5pbmcgZGVidWcg c3ltYm9scy4gVGhlc2UgYXJlIHNpZ25pZmljYW50bHkgbGFyZ2VyIGZpbGVzIScpCiAgICAgcGFy c2VyLmFkZF9hcmd1bWVudCgnLXMnLCAnLS1zdGFydCcsIGRlZmF1bHQ9Tm9uZSwgdHlwZT1pbnQs IGhlbHA9J1RoZSBzdGFydGluZyByZXZpc2lvbiB0byBiaXNlY3QuJykKICAgICBwYXJzZXIuYWRk X2FyZ3VtZW50KCctZScsICctLWVuZCcsIGRlZmF1bHQ9Tm9uZSwgdHlwZT1pbnQsIGhlbHA9J1Ro ZSBlbmRpbmcgcmV2aXNpb24gdG8gYmlzZWN0JykKKyAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCct bCcsICctLWxpc3QnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBkZWZhdWx0PUZhbHNlLCBoZWxwPSdE aXNwbGF5IGEgbGlzdCBvZiBwbGF0Zm9ybXMgYW5kIHJldmlzaW9ucycpCiAgICAgcmV0dXJuIHBh cnNlci5wYXJzZV9hcmdzKGFyZ3MpCiAKIApAQCAtMTg3LDcgKzE4OCw3IEBAIGRlZiB0ZXN0X2Fy Y2hpdmUob3B0aW9ucywgcmV2aXNpb24pOgogCiBkZWYgbWluaWZpZWRfcGxhdGZvcm1zKCk6CiAg ICAgIyBGSVhNRTogcXVlcnkgdGhpcyBkeW5hbWljYWxseSBmcm9tIEFQSQotICAgIHJldHVybiAg WydtYWMtZWxjYXBpdGFuJywgJ21hYy1zaWVycmEnXQorICAgIHJldHVybiAgWydtYWMtZWxjYXBp dGFuJywgJ21hYy1zaWVycmEnLCAnaW9zLXNpbXVsYXRvci0xMCddCiAKIAogZGVmIHVubWluaWZp ZWRfcGxhdGZvcm1zKCk6CkBAIC0yMTgsNyArMjE5LDE0IEBAIGRlZiBtYWluKG9wdGlvbnMpOgog ICAgIHVybCA9IGdldF9hcGlfdXJsKG9wdGlvbnMpCiAgICAgciA9IHJlcXVlc3RzLmdldCh1cmwp CiAgICAgcmV2aXNpb25fbGlzdCA9IGdldF9zb3J0ZWRfcmV2aXNpb25zKHIuanNvbigpKQotICAg IAorCisgICAgaWYgb3B0aW9ucy5saXN0OgorICAgICAgICBwcmludCAnU3VwcG9ydGVkIG1pbmlm aWVkIHBsYXRmb3Jtczoge30nLmZvcm1hdChtaW5pZmllZF9wbGF0Zm9ybXMoKSkKKyAgICAgICAg cHJpbnQgJ1N1cHBvcnRlZCB1bm1pbmlmaWVkIHBsYXRmb3Jtczoge30nLmZvcm1hdCh1bm1pbmlm aWVkX3BsYXRmb3JtcygpKQorICAgICAgICBwcmludCAne30gcmV2aXNpb25zIGF2YWlsYWJsZSBm b3Igc3VwcGxpZWQgcGxhdGZvcm06IHt9LXt9LXt9OicuZm9ybWF0KGxlbihyZXZpc2lvbl9saXN0 KSwgb3B0aW9ucy5wbGF0Zm9ybSwgb3B0aW9ucy5hcmNoaXRlY3R1cmUsIG9wdGlvbnMuY29uZmln dXJhdGlvbikKKyAgICAgICAgcHJpbnQgcmV2aXNpb25fbGlzdAorICAgICAgICBleGl0KDEpCisK ICAgICBzdGFydF9pbmRleCwgZW5kX2luZGV4ID0gZ2V0X2luZGljZXNfZnJvbV9yZXZpc2lvbnMo cmV2aXNpb25fbGlzdCwgb3B0aW9ucy5zdGFydCwgb3B0aW9ucy5lbmQpCiAgICAgcHJpbnQoJ0Jp c2VjdGluZyBiZXR3ZWVuIHt9IGFuZCB7fScuZm9ybWF0KHJldmlzaW9uX2xpc3Rbc3RhcnRfaW5k ZXhdLCByZXZpc2lvbl9saXN0W2VuZF9pbmRleF0pKQogICAgIAo= 320322 2017-09-08 17:57:08 -0700 2018-01-15 12:51:26 -0800 v2 patch from feedback 174836.patch text/plain 2493 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTgwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzOiBhZGQgLS1saXN0IG9wdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Jpc2Vj dC1idWlsZHM6CisgICAgICAgIChwYXJzZV9hcmdzKTogYWRkIC0tbGlzdCBvcHRpb24KKyAgICAg ICAgKG1pbmlmaWVkX3BsYXRmb3Jtcyk6IHVwZGF0ZSBwbGF0Zm9ybSB0byBpbmNsdWRlIGlvcy0x MC1zaW11bGF0b3IKKyAgICAgICAgKG1haW4pOgorCiAyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hs ZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBiaXNlY3QtYnVpbGRzIGRvZXNu J3Qgd29yayBkdWUgdG8gbWlzc2luZyByZXF1ZXN0cyBtb2R1bGUKSW5kZXg6IFRvb2xzL1Njcmlw dHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2Jpc2VjdC1idWls ZHMJKHJldmlzaW9uIDIyMTgwMSkKKysrIFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwkod29y a2luZyBjb3B5KQpAQCAtMTM5LDYgKzEzOSw3IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3MpOgogICAg IHBhcnNlci5hZGRfYXJndW1lbnQoJy1mJywgJy0tZnVsbCcsIGFjdGlvbj0nc3RvcmVfdHJ1ZScs IGRlZmF1bHQ9RmFsc2UsIGhlbHA9J1VzZSBmdWxsIGFyY2hpdmVzIGNvbnRhaW5pbmcgZGVidWcg c3ltYm9scy4gVGhlc2UgYXJlIHNpZ25pZmljYW50bHkgbGFyZ2VyIGZpbGVzIScpCiAgICAgcGFy c2VyLmFkZF9hcmd1bWVudCgnLXMnLCAnLS1zdGFydCcsIGRlZmF1bHQ9Tm9uZSwgdHlwZT1pbnQs IGhlbHA9J1RoZSBzdGFydGluZyByZXZpc2lvbiB0byBiaXNlY3QuJykKICAgICBwYXJzZXIuYWRk X2FyZ3VtZW50KCctZScsICctLWVuZCcsIGRlZmF1bHQ9Tm9uZSwgdHlwZT1pbnQsIGhlbHA9J1Ro ZSBlbmRpbmcgcmV2aXNpb24gdG8gYmlzZWN0JykKKyAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCct bCcsICctLWxpc3QnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBkZWZhdWx0PUZhbHNlLCBoZWxwPSdE aXNwbGF5IGEgbGlzdCBvZiBwbGF0Zm9ybXMgYW5kIHJldmlzaW9ucycpCiAgICAgcmV0dXJuIHBh cnNlci5wYXJzZV9hcmdzKGFyZ3MpCiAKIApAQCAtMTg3LDcgKzE4OCw3IEBAIGRlZiB0ZXN0X2Fy Y2hpdmUob3B0aW9ucywgcmV2aXNpb24pOgogCiBkZWYgbWluaWZpZWRfcGxhdGZvcm1zKCk6CiAg ICAgIyBGSVhNRTogcXVlcnkgdGhpcyBkeW5hbWljYWxseSBmcm9tIEFQSQotICAgIHJldHVybiAg WydtYWMtZWxjYXBpdGFuJywgJ21hYy1zaWVycmEnXQorICAgIHJldHVybiAgWydtYWMtZWxjYXBp dGFuJywgJ21hYy1zaWVycmEnLCAnaW9zLXNpbXVsYXRvci0xMCddCiAKIAogZGVmIHVubWluaWZp ZWRfcGxhdGZvcm1zKCk6CkBAIC0yMTgsNyArMjE5LDE0IEBAIGRlZiBtYWluKG9wdGlvbnMpOgog ICAgIHVybCA9IGdldF9hcGlfdXJsKG9wdGlvbnMpCiAgICAgciA9IHJlcXVlc3RzLmdldCh1cmwp CiAgICAgcmV2aXNpb25fbGlzdCA9IGdldF9zb3J0ZWRfcmV2aXNpb25zKHIuanNvbigpKQotICAg IAorCisgICAgaWYgb3B0aW9ucy5saXN0OgorICAgICAgICBwcmludCgnU3VwcG9ydGVkIG1pbmlm aWVkIHBsYXRmb3Jtczoge30nLmZvcm1hdChtaW5pZmllZF9wbGF0Zm9ybXMoKSkpCisgICAgICAg IHByaW50KCdTdXBwb3J0ZWQgdW5taW5pZmllZCBwbGF0Zm9ybXM6IHt9Jy5mb3JtYXQodW5taW5p ZmllZF9wbGF0Zm9ybXMoKSkpCisgICAgICAgIHByaW50KCd7fSByZXZpc2lvbnMgYXZhaWxhYmxl IGZvciBzdXBwbGllZCBwbGF0Zm9ybToge30te30te306Jy5mb3JtYXQobGVuKHJldmlzaW9uX2xp c3QpLCBvcHRpb25zLnBsYXRmb3JtLCBvcHRpb25zLmFyY2hpdGVjdHVyZSwgb3B0aW9ucy5jb25m aWd1cmF0aW9uKSkKKyAgICAgICAgcHJpbnQocmV2aXNpb25fbGlzdCkKKyAgICAgICAgZXhpdCgx KQorCiAgICAgc3RhcnRfaW5kZXgsIGVuZF9pbmRleCA9IGdldF9pbmRpY2VzX2Zyb21fcmV2aXNp b25zKHJldmlzaW9uX2xpc3QsIG9wdGlvbnMuc3RhcnQsIG9wdGlvbnMuZW5kKQogICAgIHByaW50 KCdCaXNlY3RpbmcgYmV0d2VlbiB7fSBhbmQge30nLmZvcm1hdChyZXZpc2lvbl9saXN0W3N0YXJ0 X2luZGV4XSwgcmV2aXNpb25fbGlzdFtlbmRfaW5kZXhdKSkKICAgICAK 320333 2017-09-08 22:20:23 -0700 2017-09-08 22:21:44 -0700 v3. 174836.patch text/plain 3430 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTgwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzOiBhZGQgLS1saXN0IG9wdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Jpc2Vj dC1idWlsZHM6CisgICAgICAgIChwYXJzZV9hcmdzKTogYWRkIC0tbGlzdCBvcHRpb24KKyAgICAg ICAgKG1pbmlmaWVkX3BsYXRmb3Jtcyk6IHVwZGF0ZSBwbGF0Zm9ybSB0byBpbmNsdWRlIGlvcy0x MC1zaW11bGF0b3IKKyAgICAgICAgKG1haW4pOgorCiAyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hs ZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBiaXNlY3QtYnVpbGRzIGRvZXNu J3Qgd29yayBkdWUgdG8gbWlzc2luZyByZXF1ZXN0cyBtb2R1bGUKSW5kZXg6IFRvb2xzL1Njcmlw dHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2Jpc2VjdC1idWls ZHMJKHJldmlzaW9uIDIyMTgwMSkKKysrIFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwkod29y a2luZyBjb3B5KQpAQCAtMTMyLDEzICsxMzIsMTUgQEAgZGVmIGdldF9zM19sb2NhdGlvbl9mb3Jf cmV2aXNpb24odXJsLCByZQogCiAKIGRlZiBwYXJzZV9hcmdzKGFyZ3MpOgotICAgIHBhcnNlciA9 IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdQZXJmb3JtIGEgYmlzZWN0aW9u IGFnYWluc3QgZXhpc3RpbmcgV2ViS2l0IGFyY2hpdmVzLicpCisgICAgaGVscHRleHQgPSAnYmlz ZWN0LWJ1aWxkcyBpcyBkZXNpZ25lZCB0byBoZWxwIHBpbnBvaW50IHJlZ3Jlc3Npb25zIHRvIHNw ZWNpZmljIGNvZGUgY2hhbmdlcy4gSXQgZG9lcyB0aGlzIGJ5IGJpc2VjdGluZyBhY3Jvc3MgYXJj aGl2ZXMgcHJvZHVjZWQgYnkgYnVpbGQud2Via2l0Lm9yZy4gXG5GdWxsIGFuZCAibWluaWZpZWQi IGFyY2hpdmVzIGFyZSBhdmFpbGFibGUuIE1pbmlmaWVkIGFyY2hpdmVzIGFyZSBzaWduaWZpY2Fu dGx5IHNtYWxsZXIsIGFzIHRoZXkgaGF2ZSBiZWVuIHN0cmlwcGVkIG9mIGRTWU1zIGFuZCBvdGhl ciBub24tZXNzZW50aWFsIGNvbXBvbmVudHMuXG4nCisgICAgcGFyc2VyID0gYXJncGFyc2UuQXJn dW1lbnRQYXJzZXIoZGVzY3JpcHRpb249aGVscHRleHQpCiAgICAgcGFyc2VyLmFkZF9hcmd1bWVu dCgnLWMnLCAnLS1jb25maWd1cmF0aW9uJywgZGVmYXVsdD0ncmVsZWFzZScsIGhlbHA9J1RoZSBj b25maWd1cmF0aW9uIHRvIHF1ZXJ5IFtyZWxlYXNlIHwgZGVidWddJykKICAgICBwYXJzZXIuYWRk X2FyZ3VtZW50KCctYScsICctLWFyY2hpdGVjdHVyZScsIGRlZmF1bHQ9J3g4Nl82NCcsIGhlbHA9 J1RoZSBhcmNoaXRlY3R1cmUgdG8gcXVlcnkgW3g4Nl82NCB8IGkzODZdJykKICAgICBwYXJzZXIu YWRkX2FyZ3VtZW50KCctcCcsICctLXBsYXRmb3JtJywgZGVmYXVsdD0nTm9uZScsIHJlcXVpcmVk PVRydWUsIGhlbHA9J1RoZSBwbGF0Zm9ybSB0byBxdWVyeSBbbWFjLXNpZXJyYSB8IGd0ayB8IGlv cy1zaW11bGF0b3IgfCB3aW5dJykKICAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCctZicsICctLWZ1 bGwnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBkZWZhdWx0PUZhbHNlLCBoZWxwPSdVc2UgZnVsbCBh cmNoaXZlcyBjb250YWluaW5nIGRlYnVnIHN5bWJvbHMuIFRoZXNlIGFyZSBzaWduaWZpY2FudGx5 IGxhcmdlciBmaWxlcyEnKQogICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy1zJywgJy0tc3RhcnQn LCBkZWZhdWx0PU5vbmUsIHR5cGU9aW50LCBoZWxwPSdUaGUgc3RhcnRpbmcgcmV2aXNpb24gdG8g YmlzZWN0LicpCiAgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLWUnLCAnLS1lbmQnLCBkZWZhdWx0 PU5vbmUsIHR5cGU9aW50LCBoZWxwPSdUaGUgZW5kaW5nIHJldmlzaW9uIHRvIGJpc2VjdCcpCisg ICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLWwnLCAnLS1saXN0JywgYWN0aW9uPSdzdG9yZV90cnVl JywgZGVmYXVsdD1GYWxzZSwgaGVscD0nRGlzcGxheSBhIGxpc3Qgb2YgcGxhdGZvcm1zIGFuZCBy ZXZpc2lvbnMnKQogICAgIHJldHVybiBwYXJzZXIucGFyc2VfYXJncyhhcmdzKQogCiAKQEAgLTE4 Nyw3ICsxODksNyBAQCBkZWYgdGVzdF9hcmNoaXZlKG9wdGlvbnMsIHJldmlzaW9uKToKIAogZGVm IG1pbmlmaWVkX3BsYXRmb3JtcygpOgogICAgICMgRklYTUU6IHF1ZXJ5IHRoaXMgZHluYW1pY2Fs bHkgZnJvbSBBUEkKLSAgICByZXR1cm4gIFsnbWFjLWVsY2FwaXRhbicsICdtYWMtc2llcnJhJ10K KyAgICByZXR1cm4gIFsnbWFjLWVsY2FwaXRhbicsICdtYWMtc2llcnJhJywgJ2lvcy1zaW11bGF0 b3ItMTAnXQogCiAKIGRlZiB1bm1pbmlmaWVkX3BsYXRmb3JtcygpOgpAQCAtMjE4LDcgKzIyMCwx NCBAQCBkZWYgbWFpbihvcHRpb25zKToKICAgICB1cmwgPSBnZXRfYXBpX3VybChvcHRpb25zKQog ICAgIHIgPSByZXF1ZXN0cy5nZXQodXJsKQogICAgIHJldmlzaW9uX2xpc3QgPSBnZXRfc29ydGVk X3JldmlzaW9ucyhyLmpzb24oKSkKLSAgICAKKworICAgIGlmIG9wdGlvbnMubGlzdDoKKyAgICAg ICAgcHJpbnQoJ1N1cHBvcnRlZCBtaW5pZmllZCBwbGF0Zm9ybXM6IHt9Jy5mb3JtYXQobWluaWZp ZWRfcGxhdGZvcm1zKCkpKQorICAgICAgICBwcmludCgnU3VwcG9ydGVkIHVubWluaWZpZWQgcGxh dGZvcm1zOiB7fScuZm9ybWF0KHVubWluaWZpZWRfcGxhdGZvcm1zKCkpKQorICAgICAgICBwcmlu dCgne30gcmV2aXNpb25zIGF2YWlsYWJsZSBmb3Igc3VwcGxpZWQgcGxhdGZvcm06IHt9LXt9LXt9 OicuZm9ybWF0KGxlbihyZXZpc2lvbl9saXN0KSwgb3B0aW9ucy5wbGF0Zm9ybSwgb3B0aW9ucy5h cmNoaXRlY3R1cmUsIG9wdGlvbnMuY29uZmlndXJhdGlvbikpCisgICAgICAgIHByaW50KHJldmlz aW9uX2xpc3QpCisgICAgICAgIGV4aXQoMCkKKwogICAgIHN0YXJ0X2luZGV4LCBlbmRfaW5kZXgg PSBnZXRfaW5kaWNlc19mcm9tX3JldmlzaW9ucyhyZXZpc2lvbl9saXN0LCBvcHRpb25zLnN0YXJ0 LCBvcHRpb25zLmVuZCkKICAgICBwcmludCgnQmlzZWN0aW5nIGJldHdlZW4ge30gYW5kIHt9Jy5m b3JtYXQocmV2aXNpb25fbGlzdFtzdGFydF9pbmRleF0sIHJldmlzaW9uX2xpc3RbZW5kX2luZGV4 XSkpCiAgICAgCg== 320334 2017-09-08 22:21:44 -0700 2017-09-11 16:27:11 -0700 v3 174836.patch text/plain 3426 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTgwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzOiBhZGQgLS1saXN0IG9wdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0ODM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Jpc2Vj dC1idWlsZHM6CisgICAgICAgIChwYXJzZV9hcmdzKTogYWRkIC0tbGlzdCBvcHRpb24KKyAgICAg ICAgKG1pbmlmaWVkX3BsYXRmb3Jtcyk6IHVwZGF0ZSBwbGF0Zm9ybSB0byBpbmNsdWRlIGlvcy0x MC1zaW11bGF0b3IKKyAgICAgICAgKG1haW4pOgorCiAyMDE3LTA5LTA4ICBMdWNhcyBGb3JzY2hs ZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBiaXNlY3QtYnVpbGRzIGRvZXNu J3Qgd29yayBkdWUgdG8gbWlzc2luZyByZXF1ZXN0cyBtb2R1bGUKSW5kZXg6IFRvb2xzL1Njcmlw dHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2Jpc2VjdC1idWls ZHMJKHJldmlzaW9uIDIyMTgwMSkKKysrIFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwkod29y a2luZyBjb3B5KQpAQCAtMTMyLDEzICsxMzIsMTUgQEAgZGVmIGdldF9zM19sb2NhdGlvbl9mb3Jf cmV2aXNpb24odXJsLCByZQogCiAKIGRlZiBwYXJzZV9hcmdzKGFyZ3MpOgotICAgIHBhcnNlciA9 IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdQZXJmb3JtIGEgYmlzZWN0aW9u IGFnYWluc3QgZXhpc3RpbmcgV2ViS2l0IGFyY2hpdmVzLicpCisgICAgaGVscHRleHQgPSAnYmlz ZWN0LWJ1aWxkcyBpcyBkZXNpZ25lZCB0byBoZWxwIHBpbnBvaW50IHJlZ3Jlc3Npb25zIHRvIHNw ZWNpZmljIGNvZGUgY2hhbmdlcy4gSXQgZG9lcyB0aGlzIGJ5IGJpc2VjdGluZyBhY3Jvc3MgYXJj aGl2ZXMgcHJvZHVjZWQgYnkgYnVpbGQud2Via2l0Lm9yZy4gRnVsbCBhbmQgIm1pbmlmaWVkIiBh cmNoaXZlcyBhcmUgYXZhaWxhYmxlLiBNaW5pZmllZCBhcmNoaXZlcyBhcmUgc2lnbmlmaWNhbnRs eSBzbWFsbGVyLCBhcyB0aGV5IGhhdmUgYmVlbiBzdHJpcHBlZCBvZiBkU1lNcyBhbmQgb3RoZXIg bm9uLWVzc2VudGlhbCBjb21wb25lbnRzLicKKyAgICBwYXJzZXIgPSBhcmdwYXJzZS5Bcmd1bWVu dFBhcnNlcihkZXNjcmlwdGlvbj1oZWxwdGV4dCkKICAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCct YycsICctLWNvbmZpZ3VyYXRpb24nLCBkZWZhdWx0PSdyZWxlYXNlJywgaGVscD0nVGhlIGNvbmZp Z3VyYXRpb24gdG8gcXVlcnkgW3JlbGVhc2UgfCBkZWJ1Z10nKQogICAgIHBhcnNlci5hZGRfYXJn dW1lbnQoJy1hJywgJy0tYXJjaGl0ZWN0dXJlJywgZGVmYXVsdD0neDg2XzY0JywgaGVscD0nVGhl IGFyY2hpdGVjdHVyZSB0byBxdWVyeSBbeDg2XzY0IHwgaTM4Nl0nKQogICAgIHBhcnNlci5hZGRf YXJndW1lbnQoJy1wJywgJy0tcGxhdGZvcm0nLCBkZWZhdWx0PSdOb25lJywgcmVxdWlyZWQ9VHJ1 ZSwgaGVscD0nVGhlIHBsYXRmb3JtIHRvIHF1ZXJ5IFttYWMtc2llcnJhIHwgZ3RrIHwgaW9zLXNp bXVsYXRvciB8IHdpbl0nKQogICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy1mJywgJy0tZnVsbCcs IGFjdGlvbj0nc3RvcmVfdHJ1ZScsIGRlZmF1bHQ9RmFsc2UsIGhlbHA9J1VzZSBmdWxsIGFyY2hp dmVzIGNvbnRhaW5pbmcgZGVidWcgc3ltYm9scy4gVGhlc2UgYXJlIHNpZ25pZmljYW50bHkgbGFy Z2VyIGZpbGVzIScpCiAgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLXMnLCAnLS1zdGFydCcsIGRl ZmF1bHQ9Tm9uZSwgdHlwZT1pbnQsIGhlbHA9J1RoZSBzdGFydGluZyByZXZpc2lvbiB0byBiaXNl Y3QuJykKICAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCctZScsICctLWVuZCcsIGRlZmF1bHQ9Tm9u ZSwgdHlwZT1pbnQsIGhlbHA9J1RoZSBlbmRpbmcgcmV2aXNpb24gdG8gYmlzZWN0JykKKyAgICBw YXJzZXIuYWRkX2FyZ3VtZW50KCctbCcsICctLWxpc3QnLCBhY3Rpb249J3N0b3JlX3RydWUnLCBk ZWZhdWx0PUZhbHNlLCBoZWxwPSdEaXNwbGF5IGEgbGlzdCBvZiBwbGF0Zm9ybXMgYW5kIHJldmlz aW9ucycpCiAgICAgcmV0dXJuIHBhcnNlci5wYXJzZV9hcmdzKGFyZ3MpCiAKIApAQCAtMTg3LDcg KzE4OSw3IEBAIGRlZiB0ZXN0X2FyY2hpdmUob3B0aW9ucywgcmV2aXNpb24pOgogCiBkZWYgbWlu aWZpZWRfcGxhdGZvcm1zKCk6CiAgICAgIyBGSVhNRTogcXVlcnkgdGhpcyBkeW5hbWljYWxseSBm cm9tIEFQSQotICAgIHJldHVybiAgWydtYWMtZWxjYXBpdGFuJywgJ21hYy1zaWVycmEnXQorICAg IHJldHVybiAgWydtYWMtZWxjYXBpdGFuJywgJ21hYy1zaWVycmEnLCAnaW9zLXNpbXVsYXRvci0x MCddCiAKIAogZGVmIHVubWluaWZpZWRfcGxhdGZvcm1zKCk6CkBAIC0yMTgsNyArMjIwLDE0IEBA IGRlZiBtYWluKG9wdGlvbnMpOgogICAgIHVybCA9IGdldF9hcGlfdXJsKG9wdGlvbnMpCiAgICAg ciA9IHJlcXVlc3RzLmdldCh1cmwpCiAgICAgcmV2aXNpb25fbGlzdCA9IGdldF9zb3J0ZWRfcmV2 aXNpb25zKHIuanNvbigpKQotICAgIAorCisgICAgaWYgb3B0aW9ucy5saXN0OgorICAgICAgICBw cmludCgnU3VwcG9ydGVkIG1pbmlmaWVkIHBsYXRmb3Jtczoge30nLmZvcm1hdChtaW5pZmllZF9w bGF0Zm9ybXMoKSkpCisgICAgICAgIHByaW50KCdTdXBwb3J0ZWQgdW5taW5pZmllZCBwbGF0Zm9y bXM6IHt9Jy5mb3JtYXQodW5taW5pZmllZF9wbGF0Zm9ybXMoKSkpCisgICAgICAgIHByaW50KCd7 fSByZXZpc2lvbnMgYXZhaWxhYmxlIGZvciBzdXBwbGllZCBwbGF0Zm9ybToge30te30te306Jy5m b3JtYXQobGVuKHJldmlzaW9uX2xpc3QpLCBvcHRpb25zLnBsYXRmb3JtLCBvcHRpb25zLmFyY2hp dGVjdHVyZSwgb3B0aW9ucy5jb25maWd1cmF0aW9uKSkKKyAgICAgICAgcHJpbnQocmV2aXNpb25f bGlzdCkKKyAgICAgICAgZXhpdCgwKQorCiAgICAgc3RhcnRfaW5kZXgsIGVuZF9pbmRleCA9IGdl dF9pbmRpY2VzX2Zyb21fcmV2aXNpb25zKHJldmlzaW9uX2xpc3QsIG9wdGlvbnMuc3RhcnQsIG9w dGlvbnMuZW5kKQogICAgIHByaW50KCdCaXNlY3RpbmcgYmV0d2VlbiB7fSBhbmQge30nLmZvcm1h dChyZXZpc2lvbl9saXN0W3N0YXJ0X2luZGV4XSwgcmV2aXNpb25fbGlzdFtlbmRfaW5kZXhdKSkK ICAgICAK