174831 2017-07-25 13:33:54 -0700 Dragged links are blurry on 1x displays. 2017-07-25 15:49:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1332059 0 pvollan 2017-07-25 13:33:54 -0700 When I drag a link from a 2x display to a 1x display, the text in the drag image is blurry. 1332060 1 pvollan 2017-07-25 13:34:20 -0700 <rdar://problem/33519698> 1332065 2 316388 pvollan 2017-07-25 13:41:38 -0700 Created attachment 316388 Patch 1332071 3 316388 simon.fraser 2017-07-25 13:47:31 -0700 Comment on attachment 316388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316388&action=review > Source/WebCore/platform/mac/DragImageMac.mm:293 > + // To work around blurry drag images on 1x displays, make the width and height a multiple of 2. > + // FIXME: remove this workaround when <rdar://problem/33059739> is fixed. > + boundingRect.setWidth((static_cast<int>(boundingRect.width()) / 2) * 2); > + boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2)); Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer? 1332084 4 pvollan 2017-07-25 14:06:07 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 316388 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316388&action=review > > > Source/WebCore/platform/mac/DragImageMac.mm:293 > > + // To work around blurry drag images on 1x displays, make the width and height a multiple of 2. > > + // FIXME: remove this workaround when <rdar://problem/33059739> is fixed. > > + boundingRect.setWidth((static_cast<int>(boundingRect.width()) / 2) * 2); > > + boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2)); > > Is this a user-visible change, or does it just add transparent pixels? Does > it affect alignment of the image with the pointer? Do you mean if this changes the alignment of the memory address of the image data? Thanks for reviewing! 1332085 5 316388 simon.fraser 2017-07-25 14:07:39 -0700 Comment on attachment 316388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316388&action=review >>> Source/WebCore/platform/mac/DragImageMac.mm:293 >>> + boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2)); >> >> Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer? > > Do you mean if this changes the alignment of the memory address of the image data? > > Thanks for reviewing! No, i mean the position of the drag image relative to the mouse pointer. 1332101 6 pvollan 2017-07-25 14:28:38 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 316388 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316388&action=review > > >>> Source/WebCore/platform/mac/DragImageMac.mm:293 > >>> + boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2)); > >> > >> Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer? > > > > Do you mean if this changes the alignment of the memory address of the image data? > > > > Thanks for reviewing! > > No, i mean the position of the drag image relative to the mouse pointer. Ah, yes, I believe it does affect the alignment with the pointer, since the image size is used in this calculation. 1332109 7 simon.fraser 2017-07-25 14:58:32 -0700 That's bad, then. 1332117 8 pvollan 2017-07-25 15:21:07 -0700 Thanks for reviewing! 1332126 9 316388 commit-queue 2017-07-25 15:49:00 -0700 Comment on attachment 316388 Patch Clearing flags on attachment: 316388 Committed r219891: <http://trac.webkit.org/changeset/219891> 1332127 10 commit-queue 2017-07-25 15:49:01 -0700 All reviewed patches have been landed. Closing bug. 316388 2017-07-25 13:41:38 -0700 2017-07-25 15:49:00 -0700 Patch bug-174831-20170725134147.patch text/plain 1923 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTg3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA3LTI1ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEcmFnZ2VkIGxpbmtzIGFy ZSBibHVycnkgb24gMXggZGlzcGxheXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzQ4MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMzNTE5Njk4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g dGhlIHdpZHRoIGFuZCBoZWlnaHQgb2YgdGhlIGRyYWcgaW1hZ2UgaXMgYSBtdWx0aXBsZSBvZiAy LCB0aGUgZHJhZyBpbWFnZSBpcyBub3QgYmx1cnJ5CisgICAgICAgIG9uIGEgMXggZGlzcGxheS4g VGhpcyBpcyBhIHdvcmthcm91bmQgd2hpY2ggc2hvdWxkIGJlIHJlbW92ZWQgd2hlbiA8cmRhcjov L3Byb2JsZW0vMzMwNTk3Mzk+CisgICAgICAgIGlzIGZpeGVkLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgc2luY2UgdGhpcyBpcyBub3Qgc3RyYWlnaHRmb3J3YXJkIHRvIHRlc3Qgd2l0aCBhIGxh eW91dCB0ZXN0LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0RyYWdJbWFnZU1hYy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OkxpbmtJbWFnZUxheW91dDo6TGlua0ltYWdlTGF5b3V0KToKKwogMjAx Ny0wNy0yNSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAg ICAgICAgIEFzeW5jIGltYWdlIGRlY29kaW5nIGZvciBsYXJnZSBpbWFnZXMgc2hvdWxkIGJlIGRp c2FibGVkIGFmdGVyIHRoZSBmaXJzdCB0aW1lIGEgdGlsZSBpcyBwYWludGVkCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJhZ0ltYWdlTWFjLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW0JKHJldmlzaW9uIDIxOTgz MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTI4Niw2ICsyODYsMTEgQEAgTGlua0ltYWdlTGF5b3V0OjpMaW5rSW1hZ2VM YXlvdXQoVVJMJiB1cgogICAgIGN1cnJlbnRZICs9IGxpbmtJbWFnZVBhZGRpbmc7CiAKICAgICBi b3VuZGluZ1JlY3QgPSBGbG9hdFJlY3QoMCwgMCwgbWF4aW11bVVzZWRUZXh0V2lkdGggKyBsaW5r SW1hZ2VQYWRkaW5nICogMiwgY3VycmVudFkpOworCisgICAgLy8gVG8gd29yayBhcm91bmQgYmx1 cnJ5IGRyYWcgaW1hZ2VzIG9uIDF4IGRpc3BsYXlzLCBtYWtlIHRoZSB3aWR0aCBhbmQgaGVpZ2h0 IGEgbXVsdGlwbGUgb2YgMi4KKyAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgd29ya2Fyb3VuZCB3 aGVuIDxyZGFyOi8vcHJvYmxlbS8zMzA1OTczOT4gaXMgZml4ZWQuCisgICAgYm91bmRpbmdSZWN0 LnNldFdpZHRoKChzdGF0aWNfY2FzdDxpbnQ+KGJvdW5kaW5nUmVjdC53aWR0aCgpKSAvIDIpICog Mik7CisgICAgYm91bmRpbmdSZWN0LnNldEhlaWdodCgoc3RhdGljX2Nhc3Q8aW50Pihib3VuZGlu Z1JlY3QuaGVpZ2h0KCkgLyAyKSAqIDIpKTsKIH0KIAogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJ bWFnZUZvckxpbmsoRWxlbWVudCYsIFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBUZXh0 SW5kaWNhdG9yRGF0YSYsIEZvbnRSZW5kZXJpbmdNb2RlLCBmbG9hdCkK