174827 2017-07-25 12:03:49 -0700 Make StyleResolver::isValid{Cue, Region}StyleProperty() static, inline, non-member functions 2017-07-25 16:06:35 -0700 1 1 1 Unclassified WebKit CSS WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates hyatt simon.fraser zalan oldest_to_newest 1332034 0 dbates 2017-07-25 12:03:49 -0700 StyleResolver::isValid{Cue, Region}StyleProperty() are private member functions. They access neither instance nor class data. It is sufficient to make them static, inline, non-member functions. 1332035 1 316382 dbates 2017-07-25 12:05:47 -0700 Created attachment 316382 Patch 1332136 2 316382 dbates 2017-07-25 16:06:33 -0700 Comment on attachment 316382 Patch Clearing flags on attachment: 316382 Committed r219892: <http://trac.webkit.org/changeset/219892> 1332137 3 dbates 2017-07-25 16:06:35 -0700 All reviewed patches have been landed. Closing bug. 316382 2017-07-25 12:05:47 -0700 2017-07-25 16:06:33 -0700 Patch bug-174827-20170725120657.patch text/plain 4070 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZhZGYwMWJlNWUxNWQx ZjZmMWMxMjIxNGY3NjFkNjBiYmU5YmQ1Mi4uZDM0YmUxOWNkMGNkNDA4ZWM5MWIwZWMzZDRkMjEw OTNjMjJlNjE5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA3LTI1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFN0eWxlUmVzb2x2 ZXI6OmlzVmFsaWR7Q3VlLCBSZWdpb259U3R5bGVQcm9wZXJ0eSgpIHN0YXRpYywgaW5saW5lLCBu b24tbWVtYmVyIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0ODI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU3R5bGVSZXNvbHZlcjo6aXNWYWxpZHtDdWUsIFJlZ2lvbn1TdHlsZVByb3Bl cnR5KCkgYWNjZXNzIG5laXRoZXIgaW5zdGFuY2Ugbm9yCisgICAgICAgIGNsYXNzIGRhdGEuIE1v cmVvdmVyLCB0aGV5IGFyZSBwcml2YXRlIG1lbWJlciBmdW5jdGlvbnMgYW5kIGhlbmNlIGNhbm5v dCBiZQorICAgICAgICB1c2VkIG91dHNpZGUgb2YgU3R5bGVSZXNvbHZlcidzIGltcGxlbWVudGF0 aW9uLiBTbywgbWFrZSB0aGVzZSBzdGF0aWMsIGlubGluZSwKKyAgICAgICAgbm9uLW1lbWJlciBm dW5jdGlvbnMuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppc1ZhbGlkUmVnaW9uU3R5bGVQcm9wZXJ0eSk6CisgICAgICAgIChXZWJDb3JlOjpp c1ZhbGlkQ3VlU3R5bGVQcm9wZXJ0eSk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVy OjpDYXNjYWRlZFByb3BlcnRpZXM6OmFkZE1hdGNoKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxl UmVzb2x2ZXI6OmlzVmFsaWRSZWdpb25TdHlsZVByb3BlcnR5KTogRGVsZXRlZC4KKyAgICAgICAg KFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmlzVmFsaWRDdWVTdHlsZVByb3BlcnR5KTogRGVsZXRl ZC4KKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5oOgorCiAyMDE3LTA3LTI1ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgQXN5bmMgaW1h Z2UgZGVjb2RpbmcgZm9yIGxhcmdlIGltYWdlcyBzaG91bGQgYmUgZGlzYWJsZWQgYWZ0ZXIgdGhl IGZpcnN0IHRpbWUgYSB0aWxlIGlzIHBhaW50ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmNwcAppbmRleCAzMjNhMjUyMDIyMWQyNjRlNmE1NDA1ODhjMDI0Y2UzZTczMDQwNTg4Li42ZWFi Y2IxNTY3YTNiMzFjODViNzA0NThhMjFiYjI5ZGZjNDc4NTExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwCkBAIC0xNDc0LDggKzE0NzQsOCBAQCBpbmxpbmUgYm9vbCBpc1ZhbGlk VmlzaXRlZExpbmtQcm9wZXJ0eShDU1NQcm9wZXJ0eUlEIGlkKQogfQogCiAvLyBodHRwOi8vZGV2 LnczLm9yZy9jc3N3Zy9jc3MzLXJlZ2lvbnMvI3RoZS1hdC1yZWdpb24tc3R5bGUtcnVsZQotLy8g RklYTUU6IGFkZCBpbmNyZW1lbnRhbCBzdXBwb3J0IGZvciBvdGhlciByZWdpb24gc3R5bGluZyBw cm9wZXJ0aWVzLgotaW5saW5lIGJvb2wgU3R5bGVSZXNvbHZlcjo6aXNWYWxpZFJlZ2lvblN0eWxl UHJvcGVydHkoQ1NTUHJvcGVydHlJRCBpZCkKKy8vIEZJWE1FOiBBZGQgaW5jcmVtZW50YWwgc3Vw cG9ydCBmb3Igb3RoZXIgcmVnaW9uIHN0eWxpbmcgcHJvcGVydGllcy4KK3N0YXRpYyBpbmxpbmUg Ym9vbCBpc1ZhbGlkUmVnaW9uU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eUlEIGlkKQogewogICAg IHN3aXRjaCAoaWQpIHsKICAgICBjYXNlIENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yOgpAQCAt MTQ4OSw3ICsxNDg5LDcgQEAgaW5saW5lIGJvb2wgU3R5bGVSZXNvbHZlcjo6aXNWYWxpZFJlZ2lv blN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlJRCBpZCkKIH0KIAogI2lmIEVOQUJMRShWSURFT19U UkFDSykKLWlubGluZSBib29sIFN0eWxlUmVzb2x2ZXI6OmlzVmFsaWRDdWVTdHlsZVByb3BlcnR5 KENTU1Byb3BlcnR5SUQgaWQpCitzdGF0aWMgaW5saW5lIGJvb2wgaXNWYWxpZEN1ZVN0eWxlUHJv cGVydHkoQ1NTUHJvcGVydHlJRCBpZCkKIHsKICAgICBzd2l0Y2ggKGlkKSB7CiAgICAgY2FzZSBD U1NQcm9wZXJ0eUJhY2tncm91bmQ6CkBAIC0yMTQ2LDEwICsyMTQ2LDEwIEBAIHZvaWQgU3R5bGVS ZXNvbHZlcjo6Q2FzY2FkZWRQcm9wZXJ0aWVzOjphZGRNYXRjaChjb25zdCBNYXRjaFJlc3VsdCYg bWF0Y2hSZXN1bHQsCiAgICAgICAgIH0KICAgICAgICAgQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlE ID0gY3VycmVudC5pZCgpOwogCi0gICAgICAgIGlmIChwcm9wZXJ0eVdoaXRlbGlzdFR5cGUgPT0g UHJvcGVydHlXaGl0ZWxpc3RSZWdpb24gJiYgIVN0eWxlUmVzb2x2ZXI6OmlzVmFsaWRSZWdpb25T dHlsZVByb3BlcnR5KHByb3BlcnR5SUQpKQorICAgICAgICBpZiAocHJvcGVydHlXaGl0ZWxpc3RU eXBlID09IFByb3BlcnR5V2hpdGVsaXN0UmVnaW9uICYmICFpc1ZhbGlkUmVnaW9uU3R5bGVQcm9w ZXJ0eShwcm9wZXJ0eUlEKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogI2lmIEVOQUJMRShWSURF T19UUkFDSykKLSAgICAgICAgaWYgKHByb3BlcnR5V2hpdGVsaXN0VHlwZSA9PSBQcm9wZXJ0eVdo aXRlbGlzdEN1ZSAmJiAhU3R5bGVSZXNvbHZlcjo6aXNWYWxpZEN1ZVN0eWxlUHJvcGVydHkocHJv cGVydHlJRCkpCisgICAgICAgIGlmIChwcm9wZXJ0eVdoaXRlbGlzdFR5cGUgPT0gUHJvcGVydHlX aGl0ZWxpc3RDdWUgJiYgIWlzVmFsaWRDdWVTdHlsZVByb3BlcnR5KHByb3BlcnR5SUQpKQogICAg ICAgICAgICAgY29udGludWU7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUmVzb2x2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmgK aW5kZXggNTljODU2MDc3NjI0Yjc5MjE0ZjRhZGMzYjE1MjMyNWY5Yzg1MWIzZC4uN2Q2MDZhNzcz OWNhOGY4ODM4MjY0M2ZjM2FmMDZhMWVhNTc2NGIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUmVzb2x2ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNv bHZlci5oCkBAIC0zMjcsMTAgKzMyNyw2IEBAIHByaXZhdGU6CiAgICAgdm9pZCBhcHBseUNhc2Nh ZGVkUHJvcGVydGllcyhDYXNjYWRlZFByb3BlcnRpZXMmLCBpbnQgZmlyc3RQcm9wZXJ0eSwgaW50 IGxhc3RQcm9wZXJ0eSwgY29uc3QgTWF0Y2hSZXN1bHQqKTsKICAgICB2b2lkIGNhc2NhZGVNYXRj aGVzKENhc2NhZGVkUHJvcGVydGllcyYsIGNvbnN0IE1hdGNoUmVzdWx0JiwgYm9vbCBpbXBvcnRh bnQsIGludCBzdGFydEluZGV4LCBpbnQgZW5kSW5kZXgsIGJvb2wgaW5oZXJpdGVkT25seSk7CiAK LSAgICBzdGF0aWMgYm9vbCBpc1ZhbGlkUmVnaW9uU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eUlE KTsKLSNpZiBFTkFCTEUoVklERU9fVFJBQ0spCi0gICAgc3RhdGljIGJvb2wgaXNWYWxpZEN1ZVN0 eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlJRCk7Ci0jZW5kaWYKICAgICB2b2lkIG1hdGNoUGFnZVJ1 bGVzKE1hdGNoUmVzdWx0JiwgUnVsZVNldCosIGJvb2wgaXNMZWZ0UGFnZSwgYm9vbCBpc0ZpcnN0 UGFnZSwgY29uc3QgU3RyaW5nJiBwYWdlTmFtZSk7CiAgICAgdm9pZCBtYXRjaFBhZ2VSdWxlc0Zv ckxpc3QoVmVjdG9yPFN0eWxlUnVsZVBhZ2UqPiYgbWF0Y2hlZFJ1bGVzLCBjb25zdCBWZWN0b3I8 U3R5bGVSdWxlUGFnZSo+JiwgYm9vbCBpc0xlZnRQYWdlLCBib29sIGlzRmlyc3RQYWdlLCBjb25z dCBTdHJpbmcmIHBhZ2VOYW1lKTsKIAo=