174806 2017-07-24 18:12:51 -0700 [iOS WK2] Crash under PageOverlayController::uninstallPageOverlay when doing multiple finds 2017-07-24 18:18:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton oldest_to_newest 1331818 0 simon.fraser 2017-07-24 18:12:51 -0700 [iOS WK2] Crash under PageOverlayController::uninstallPageOverlay when doing multiple finds 1331819 1 316337 simon.fraser 2017-07-24 18:16:11 -0700 Created attachment 316337 Patch 1331820 2 316337 thorton 2017-07-24 18:16:30 -0700 Comment on attachment 316337 Patch V. silly :( 1331821 3 simon.fraser 2017-07-24 18:18:22 -0700 https://trac.webkit.org/changeset/219852/webkit 316337 2017-07-24 18:16:11 -0700 2017-07-24 18:16:30 -0700 Patch bug-174806-20170724181611.patch text/plain 3050 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NzgwOTBlYjNhNjZlOWIx YWViYWQzYWEwZDFlMWUzYjkyMTY3ZTEuLjRjMmQ1MzFmOGEzMjI3MDdhZjNkZmJkZTMzOGM4MDgw MmU4OWUwY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTctMDctMjQgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXSzJdIENyYXNo IHVuZGVyIFBhZ2VPdmVybGF5Q29udHJvbGxlcjo6dW5pbnN0YWxsUGFnZU92ZXJsYXkgd2hlbiBk b2luZyBtdWx0aXBsZSBmaW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0ODA2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzMzNTAxNjY0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBDYWxs aW5nIFRleHRJbmRpY2F0b3I6OmNyZWF0ZVdpdGhTZWxlY3Rpb25JbkZyYW1lIGNhbiB0cmlnZ2Vy IGxheW91dCB2aWEgVmlzaWJsZVNlbGVjdGlvbiBjb2RlLAorICAgICAgICB3aGljaCBjYW4gcmUt ZW50ZXIgRmluZENvbnRyb2xsZXI6OnVwZGF0ZUZpbmRJbmRpY2F0b3Igd2hpY2ggaGFzIGJ5IG5v dyByZW1vdmVkIG1fZmluZEluZGljYXRvck92ZXJsYXkKKyAgICAgICAgZnJvbSBwYWdlT3Zlcmxh eUNvbnRyb2xsZXIncyBtYXAsIGJ1dCBub3QgZGVsZXRlZCBpdC4gVGhlIHNlY29uZCBjYWxsIHRv IHVuaW5zdGFsbFBhZ2VPdmVybGF5KCkKKyAgICAgICAgdGh1cyBjcmFzaGVzIGF0IG1fb3Zlcmxh eUdyYXBoaWNzTGF5ZXJzLnRha2UoJm92ZXJsYXkpLT5yZW1vdmVGcm9tUGFyZW50KCkuCisgICAg ICAgIAorICAgICAgICBGaXggYnkgbnVsbGluZyBvdXQgbV9maW5kSW5kaWNhdG9yT3ZlcmxheSBh cyBzb29uIGFzIHdlIHVuaW5zdGFsbCBpdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvRmluZENvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9s bGVyOjp1cGRhdGVGaW5kSW5kaWNhdG9yKToKKwogMjAxNy0wNy0yNCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMTk4 MjguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvRmlu ZENvbnRyb2xsZXJJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3Mv RmluZENvbnRyb2xsZXJJT1MubW0KaW5kZXggOTUxOTM5OGM5MmI4ZjNiODM3YWMwMjhlNWY1Mjcw MzcyMzg0MzlmMi4uZDk0OWExY2NkMWQxOTIwYTQwMDFmMDAzYjgzZWM1Y2ZmNGVhMjQ4ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL0ZpbmRDb250cm9s bGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9GaW5k Q29udHJvbGxlcklPUy5tbQpAQCAtODksMTYgKzg5LDE2IEBAIHZvaWQgRmluZEluZGljYXRvck92 ZXJsYXlDbGllbnRJT1M6OmRyYXdSZWN0KFBhZ2VPdmVybGF5JiBvdmVybGF5LCBHcmFwaGljc0Nv bnRlCiAKIGJvb2wgRmluZENvbnRyb2xsZXI6OnVwZGF0ZUZpbmRJbmRpY2F0b3IoRnJhbWUmIHNl bGVjdGVkRnJhbWUsIGJvb2wgaXNTaG93aW5nT3ZlcmxheSwgYm9vbCBzaG91bGRBbmltYXRlKQog ewotICAgIGlmIChtX2ZpbmRJbmRpY2F0b3JPdmVybGF5KQorICAgIGlmIChtX2ZpbmRJbmRpY2F0 b3JPdmVybGF5KSB7CiAgICAgICAgIG1fd2ViUGFnZS0+bWFpbkZyYW1lKCktPnBhZ2VPdmVybGF5 Q29udHJvbGxlcigpLnVuaW5zdGFsbFBhZ2VPdmVybGF5KCptX2ZpbmRJbmRpY2F0b3JPdmVybGF5 LCBQYWdlT3ZlcmxheTo6RmFkZU1vZGU6OkRvTm90RmFkZSk7Ci0KLSAgICBSZWZQdHI8VGV4dElu ZGljYXRvcj4gdGV4dEluZGljYXRvciA9IFRleHRJbmRpY2F0b3I6OmNyZWF0ZVdpdGhTZWxlY3Rp b25JbkZyYW1lKHNlbGVjdGVkRnJhbWUsIGZpbmRUZXh0SW5kaWNhdG9yT3B0aW9ucywgVGV4dElu ZGljYXRvclByZXNlbnRhdGlvblRyYW5zaXRpb246Ok5vbmUsIEZsb2F0U2l6ZSh0b3RhbEhvcml6 b250YWxNYXJnaW4sIHRvdGFsVmVydGljYWxNYXJnaW4pKTsKLSAgICBpZiAoIXRleHRJbmRpY2F0 b3IpIHsKICAgICAgICAgbV9maW5kSW5kaWNhdG9yT3ZlcmxheSA9IG51bGxwdHI7CiAgICAgICAg IG1faXNTaG93aW5nRmluZEluZGljYXRvciA9IGZhbHNlOwotICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgfQogCisgICAgUmVmUHRyPFRleHRJbmRpY2F0b3I+IHRleHRJbmRpY2F0b3IgPSBUZXh0 SW5kaWNhdG9yOjpjcmVhdGVXaXRoU2VsZWN0aW9uSW5GcmFtZShzZWxlY3RlZEZyYW1lLCBmaW5k VGV4dEluZGljYXRvck9wdGlvbnMsIFRleHRJbmRpY2F0b3JQcmVzZW50YXRpb25UcmFuc2l0aW9u OjpOb25lLCBGbG9hdFNpemUodG90YWxIb3Jpem9udGFsTWFyZ2luLCB0b3RhbFZlcnRpY2FsTWFy Z2luKSk7CisgICAgaWYgKCF0ZXh0SW5kaWNhdG9yKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK ICAgICBtX2ZpbmRJbmRpY2F0b3JPdmVybGF5Q2xpZW50ID0gc3RkOjptYWtlX3VuaXF1ZTxGaW5k SW5kaWNhdG9yT3ZlcmxheUNsaWVudElPUz4oc2VsZWN0ZWRGcmFtZSwgdGV4dEluZGljYXRvci5n ZXQoKSk7CiAgICAgbV9maW5kSW5kaWNhdG9yT3ZlcmxheSA9IFBhZ2VPdmVybGF5OjpjcmVhdGUo Km1fZmluZEluZGljYXRvck92ZXJsYXlDbGllbnQsIFBhZ2VPdmVybGF5OjpPdmVybGF5VHlwZTo6 RG9jdW1lbnQpOwogICAgIG1fd2ViUGFnZS0+bWFpbkZyYW1lKCktPnBhZ2VPdmVybGF5Q29udHJv bGxlcigpLmluc3RhbGxQYWdlT3ZlcmxheSgqbV9maW5kSW5kaWNhdG9yT3ZlcmxheSwgUGFnZU92 ZXJsYXk6OkZhZGVNb2RlOjpEb05vdEZhZGUpOwo=