174785 2017-07-24 08:20:59 -0700 [CMake] libtasn1 should not be required when not enabling subtle_crypto 2017-07-24 09:01:43 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez achristensen bugs-noreply jiewen_tan mmaxfield zan oldest_to_newest 1331609 0 clopez 2017-07-24 08:20:59 -0700 After r218626 <https://trac.webkit.org/r218626> libtasn1 is required for building WebKitGTK or WPE even when not enabling subtle_crypto. In file included from /home/clopez/webkit/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.cpp:28:0: /home/clopez/webkit/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.h:29:22: fatal error: libtasn1.h: No such file or directory #include <libtasn1.h> ^ compilation terminated. Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/build.make:89: recipe for target 'Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/crypto/tasn1/Utilities.cpp.o' failed make[2]: *** [Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/crypto/tasn1/Utilities.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... The only source files including pal/crypto/tasn1/Utilities.h are CryptoKeyECGCrypt.cpp and CryptoKeyRSAGCrypt.cpp which are only included if ENABLE_SUBTLE_CRYPTO=ON 1331611 1 316290 clopez 2017-07-24 08:24:45 -0700 Created attachment 316290 Patch 1331619 2 316290 clopez 2017-07-24 09:01:39 -0700 Comment on attachment 316290 Patch Clearing flags on attachment: 316290 Committed r219823: <http://trac.webkit.org/changeset/219823> 1331620 3 clopez 2017-07-24 09:01:43 -0700 All reviewed patches have been landed. Closing bug. 316290 2017-07-24 08:24:45 -0700 2017-07-24 09:01:39 -0700 Patch bug-174785-20170724172444.patch text/plain 1926 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA2M2JjNzgx ZjliZmQ1ZjRjYzA4Y2I0NjUwZDAwMWEzZDI4MTljODBhLi41NDkyZjlmYTU0ZDA5YzU3NDVlMDI1 ZDhiYzM4ZjQzM2FmNDMxZDQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0wNy0yNCAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNv bT4KKworICAgICAgICBbQ01ha2VdIGxpYnRhc24xIHNob3VsZCBub3QgYmUgcmVxdWlyZWQgd2hl biBub3QgZW5hYmxpbmcgc3VidGxlX2NyeXB0bworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0Nzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvUGxhdGZvcm1HVEsuY21ha2U6CisgICAgICAgICog cGFsL1BsYXRmb3JtV1BFLmNtYWtlOgorCiAyMDE3LTA3LTE4ICBBbmR5IEVzdGVzICA8YWVzdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBbWGNvZGVdIEVuYWJsZSBDTEFOR19XQVJOX1JBTkdFX0xP T1BfQU5BTFlTSVMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4 IDFjZGQ3NDVkYWM2ZmUxMjUyMDU1ZmZmYjYwNmE3ZDM5NjBlZjk1MmIuLmYxZGNjMTdmOGQ3MTkw N2ExN2E1NThhZmE1ZTRkZTI1YjhmMjE3MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BB TC9wYWwvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9QbGF0 Zm9ybUdUSy5jbWFrZQpAQCAtMSwxMyArMSwxNyBAQAogbGlzdChBUFBFTkQgUEFMX1NPVVJDRVMK ICAgICBjcnlwdG8vZ2NyeXB0L0NyeXB0b0RpZ2VzdEdDcnlwdC5jcHAKIAotICAgIGNyeXB0by90 YXNuMS9VdGlsaXRpZXMuY3BwCi0KICAgICBzeXN0ZW0vZ3RrL1NvdW5kR3RrLmNwcAogCiAgICAg dGV4dC9LaWxsUmluZ05vbmUuY3BwCiApCiAKK2lmIChFTkFCTEVfU1VCVExFX0NSWVBUTykKKyAg ICBsaXN0KEFQUEVORCBQQUxfU09VUkNFUworICAgICAgICBjcnlwdG8vdGFzbjEvVXRpbGl0aWVz LmNwcAorICAgICkKK2VuZGlmICgpCisKIGxpc3QoQVBQRU5EIFBBTF9TWVNURU1fSU5DTFVERV9E SVJFQ1RPUklFUwogICAgICR7R0RLX0lOQ0xVREVfRElSU30KICkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1XUEUuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QQUwv cGFsL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGEyY2QyZmUzNTg0NTQ4M2RhMjhmODI5YTIxODU1 MDRjMDRjMWM2ZDUuLjIzNzdjMzQ3MWI5MmViYTI3MWQ4ZjExNzhiZDY4ZTVlMmZlNTFmYzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIv U291cmNlL1dlYkNvcmUvUEFML3BhbC9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMSw5ICsxLDEzIEBA CiBsaXN0KEFQUEVORCBQQUxfU09VUkNFUwogICAgIGNyeXB0by9nY3J5cHQvQ3J5cHRvRGlnZXN0 R0NyeXB0LmNwcAogCi0gICAgY3J5cHRvL3Rhc24xL1V0aWxpdGllcy5jcHAKLQogICAgIHN5c3Rl bS9Tb3VuZE5vbmUuY3BwCiAKICAgICB0ZXh0L0tpbGxSaW5nTm9uZS5jcHAKICkKKworaWYgKEVO QUJMRV9TVUJUTEVfQ1JZUFRPKQorICAgIGxpc3QoQVBQRU5EIFBBTF9TT1VSQ0VTCisgICAgICAg IGNyeXB0by90YXNuMS9VdGlsaXRpZXMuY3BwCisgICAgKQorZW5kaWYgKCkK