174767 2017-07-23 19:23:37 -0700 [GTK] A typo in the reference manual of WebKitWebInspector 2017-07-23 20:20:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 ashie webkit-unassigned berto bugs-noreply buildbot cgarcia commit-queue gustavo mcatanzaro oldest_to_newest 1331500 0 ashie 2017-07-23 19:23:37 -0700 There is a typo in an example code in the reference manual of WebKitWebInspector. https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebInspector.html https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp?rev=218332#L53 - webkit_web_load_uri (WEBKIT_WEB_VIEW(my_webview), "http://www.gnome.org"); + webkit_web_view_load_uri (WEBKIT_WEB_VIEW(my_webview), "http://www.gnome.org"); "view" is missing in the function name. 1331507 1 316252 ashie 2017-07-23 19:39:28 -0700 Created attachment 316252 Patch 1331508 2 buildbot 2017-07-23 19:41:53 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1331509 3 316252 mcatanzaro 2017-07-23 19:42:24 -0700 Comment on attachment 316252 Patch Thank you for submitting this fix! I'm impressed you noticed. 1331514 4 316252 commit-queue 2017-07-23 20:20:32 -0700 Comment on attachment 316252 Patch Clearing flags on attachment: 316252 Committed r219793: <http://trac.webkit.org/changeset/219793> 1331515 5 commit-queue 2017-07-23 20:20:34 -0700 All reviewed patches have been landed. Closing bug. 316252 2017-07-23 19:39:28 -0700 2017-07-23 20:20:32 -0700 Patch bug-174767-20170724113927.patch text/plain 1574 ashie U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3YmMxMzdlNzlhM2Y3Yzcw MjRiNGM4ZjRjOWJlMDNiYTFlNTE2ZWMuLjJlMjE1YzUyNzU0NTUxOTNkYmY4NWYzZDI3YmUxMmVj ZGI5MGFmODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDctMjMgIFRha3VybyBB c2hpZSAgPGFzaGllQGNsZWFyLWNvZGUuY29tPgorCisgICAgICAgIFtHVEtdIENvcnJlY3QgYSB0 eXBvIGluIHRoZSByZWZlcmVuY2UgbWFudWFsIG9mIFdlYktpdFdlYkluc3BlY3RvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NzY3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJJbnNwZWN0b3IuY3BwOgorCiAyMDE3LTA3LTIyICBXZW5zb24gSHNpZWgg IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgV0syXSBSZW1vdmUgX1dL RHJhZ2dhYmxlRWxlbWVudEluZm8gYW5kIGZvbGQgUG9zaXRpb25JbmZvcm1hdGlvblRlc3RzIGlu dG8gV0tSZXF1ZXN0QWN0aXZhdGVkRWxlbWVudEluZm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViSW5zcGVjdG9yLmNwcAppbmRleCA2MGIyMDZj NDI5YTk3ZDQ0NjQzNWJkOTUxNjBhYzYyOWZhZDU5NTJjLi4wZjAxNzExZTc5NjFlOGIwMGM1ZTU3 NGQyODg1MGQwNWIyNDFmNmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYkluc3BlY3Rvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJJbnNwZWN0b3IuY3BwCkBAIC01MCw3ICs1MCw3IEBAIHVzaW5n IG5hbWVzcGFjZSBXZWJLaXQ7CiAgKiBnX29iamVjdF9zZXQgKEdfT0JKRUNUKHNldHRpbmdzKSwg ImVuYWJsZS1kZXZlbG9wZXItZXh0cmFzIiwgVFJVRSwgTlVMTCk7CiAgKgogICogLzwhLS0gLS0+ KiBMb2FkIHNvbWUgZGF0YSBvciByZWxvYWQgdG8gYmUgYWJsZSB0byBpbnNwZWN0IHRoZSBwYWdl KjwhLS0gLS0+LwotICogd2Via2l0X3dlYl9sb2FkX3VyaSAoV0VCS0lUX1dFQl9WSUVXKG15X3dl YnZpZXcpLCAiaHR0cDovL3d3dy5nbm9tZS5vcmciKTsKKyAqIHdlYmtpdF93ZWJfdmlld19sb2Fk X3VyaSAoV0VCS0lUX1dFQl9WSUVXKG15X3dlYnZpZXcpLCAiaHR0cDovL3d3dy5nbm9tZS5vcmci KTsKICAqCiAgKiAvPCEtLSAtLT4qIFNob3cgdGhlIGluc3BlY3RvciAqPCEtLSAtLT4vCiAgKiBX ZWJLaXRXZWJJbnNwZWN0b3IgKmluc3BlY3RvciA9IHdlYmtpdF93ZWJfdmlld19nZXRfaW5zcGVj dG9yIChXRUJLSVRfV0VCX1ZJRVcobXlfd2VidmlldykpOwo=