174765 2017-07-23 16:50:28 -0700 Web Inspector: should only show Canvases in resource type filter if debug setting enabled 2017-07-24 10:13:32 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1331480 0 mattbaker 2017-07-23 16:50:28 -0700 Summary: Should only show Canvases in resource type filter if debug setting enabled. It's very surprising when the option appears in a release build, for which this setting will never be enabled. 1331481 1 webkit-bug-importer 2017-07-23 16:50:46 -0700 <rdar://problem/33479009> 1331482 2 316243 mattbaker 2017-07-23 16:52:54 -0700 Created attachment 316243 Patch 1331547 3 316243 hi 2017-07-23 23:20:39 -0700 Comment on attachment 316243 Patch Oops. Good catch =D 1331652 4 316243 bburg 2017-07-24 09:44:44 -0700 Comment on attachment 316243 Patch r=me too 1331658 5 316243 commit-queue 2017-07-24 10:13:30 -0700 Comment on attachment 316243 Patch Clearing flags on attachment: 316243 Committed r219826: <http://trac.webkit.org/changeset/219826> 1331659 6 commit-queue 2017-07-24 10:13:32 -0700 All reviewed patches have been landed. Closing bug. 316243 2017-07-23 16:52:54 -0700 2017-07-24 10:13:30 -0700 Patch bug-174765-20170723165253.patch text/plain 2489 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm MWY1MjY5NjBiOWQxYWFkN2YzMGQ3MWY5ZjIzYjcxNjkzYTk2MjY4Li41ZjJlNGRkZjEyYThkYjk3 MzU4ZDg5NjMwOWZkMzE2MmM2Mzg2MWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wNy0yMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc2hvdWxkIG9ubHkgc2hvdyBDYW52YXNlcyBpbiBy ZXNvdXJjZSB0eXBlIGZpbHRlciBpZiBkZWJ1ZyBzZXR0aW5nIGVuYWJsZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDc2NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzM0NzkwMDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsKToKKwogMjAx Ny0wNy0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGluc3BlY3QoYUZ1bmN0aW9uKSBzaG91bGQganVtcCB0byBmdW5jdGlv biBkZWZpbml0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9SZXNvdXJjZVNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCmluZGV4IGM1ODli ZTUyNGY0MzEwZGViMTU5ZjhiM2RkNzdlMGZiNDhlOGMxNjkuLmIzNGIxMWIwNzA3M2M0ZTNkYWQ5 MzVlZTUyYzYwYWQxMjExNTMxZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpz CkBAIC01MCw5ICs1MCwxMSBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFuZWwgPSBj bGFzcyBSZXNvdXJjZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICAgICAg c2NvcGVCYXJJdGVtcy5wdXNoKHNjb3BlQmFySXRlbSk7CiAgICAgICAgIH0KIAotICAgICAgICBs ZXQgY2FudmFzZXNTY29wZUJhckl0ZW0gPSBuZXcgV2ViSW5zcGVjdG9yLlNjb3BlQmFySXRlbShz Y29wZUl0ZW1QcmVmaXggKyBXZWJJbnNwZWN0b3IuQ2FudmFzLlJlc291cmNlU2lkZWJhclR5cGUs IFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2FudmFzZXMiKSk7Ci0gICAgICAgIGNhbnZhc2VzU2Nv cGVCYXJJdGVtW1dlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQYW5lbC5SZXNvdXJjZVR5cGVT eW1ib2xdID0gV2ViSW5zcGVjdG9yLkNhbnZhcy5SZXNvdXJjZVNpZGViYXJUeXBlOwotICAgICAg ICBzY29wZUJhckl0ZW1zLmluc2VydEF0SW5kZXgoY2FudmFzZXNTY29wZUJhckl0ZW0sIHNjb3Bl QmFySXRlbXMubGVuZ3RoIC0gMSk7CisgICAgICAgIGlmICh3aW5kb3cuQ2FudmFzQWdlbnQgJiYg V2ViSW5zcGVjdG9yLnNldHRpbmdzLmV4cGVyaW1lbnRhbFNob3dDYW52YXNDb250ZXh0c0luUmVz b3VyY2VzLnZhbHVlKSB7CisgICAgICAgICAgICBsZXQgY2FudmFzZXNTY29wZUJhckl0ZW0gPSBu ZXcgV2ViSW5zcGVjdG9yLlNjb3BlQmFySXRlbShzY29wZUl0ZW1QcmVmaXggKyBXZWJJbnNwZWN0 b3IuQ2FudmFzLlJlc291cmNlU2lkZWJhclR5cGUsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2Fu dmFzZXMiKSk7CisgICAgICAgICAgICBjYW52YXNlc1Njb3BlQmFySXRlbVtXZWJJbnNwZWN0b3Iu UmVzb3VyY2VTaWRlYmFyUGFuZWwuUmVzb3VyY2VUeXBlU3ltYm9sXSA9IFdlYkluc3BlY3Rvci5D YW52YXMuUmVzb3VyY2VTaWRlYmFyVHlwZTsKKyAgICAgICAgICAgIHNjb3BlQmFySXRlbXMuaW5z ZXJ0QXRJbmRleChjYW52YXNlc1Njb3BlQmFySXRlbSwgc2NvcGVCYXJJdGVtcy5sZW5ndGggLSAx KTsKKyAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX3Njb3BlQmFyID0gbmV3IFdlYkluc3BlY3Rv ci5TY29wZUJhcigicmVzb3VyY2Utc2lkZWJhci1zY29wZS1iYXIiLCBzY29wZUJhckl0ZW1zLCBz Y29wZUJhckl0ZW1zWzBdLCB0cnVlKTsKICAgICAgICAgdGhpcy5fc2NvcGVCYXIuYWRkRXZlbnRM aXN0ZW5lcihXZWJJbnNwZWN0b3IuU2NvcGVCYXIuRXZlbnQuU2VsZWN0aW9uQ2hhbmdlZCwgdGhp cy5fc2NvcGVCYXJTZWxlY3Rpb25EaWRDaGFuZ2UsIHRoaXMpOwo=