174740 2017-07-21 18:59:20 -0700 [WebIDL] Simplify XMLHttpRequest bindings by removing built-ins 2018-07-20 15:35:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187411 P2 Normal --- 187411 1 sam sam cdumez commit-queue joepeck oldest_to_newest 1331240 0 sam 2017-07-21 18:59:20 -0700 [WebIDL] Simplify XMLHttpRequest bindings by removing built-ins 1331243 1 316158 sam 2017-07-21 19:03:02 -0700 Created attachment 316158 Patch 1331265 2 316158 cdumez 2017-07-21 20:26:26 -0700 Comment on attachment 316158 Patch LOVE IT 1331267 3 316158 commit-queue 2017-07-21 20:54:19 -0700 Comment on attachment 316158 Patch Clearing flags on attachment: 316158 Committed r219757: <http://trac.webkit.org/changeset/219757> 1331268 4 commit-queue 2017-07-21 20:54:20 -0700 All reviewed patches have been landed. Closing bug. 1331273 5 316158 joepeck 2017-07-21 21:16:39 -0700 Comment on attachment 316158 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316158&action=review > Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:60 > + > + Style: Extra newline 316158 2017-07-21 19:03:02 -0700 2017-07-21 20:54:19 -0700 Patch bug-174740-20170721190508.patch text/plain 7194 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTc1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE3LTA3LTIxICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dlYklETF0gU2ltcGxpZnkgWE1MSHR0 cFJlcXVlc3QgYmluZGluZ3MgYnkgcmVtb3ZpbmcgYnVpbHQtaW5zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ3NDAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYmVoYXZpb3Igd2Ugd2VyZSBnZXR0 aW5nIGZyb20gWE1MSHR0cFJlcXVlc3QuanMgY2FuIGJlIGltcGxlbWVudGVkCisgICAgICAgIHdp dGggdGhlIFtDYWNoZWRBdHRyaWJ1dGVdIGV4dGVuZGVkIGF0dHJpYnV0ZS4gVGhpcyByZWR1Y2Vz IHRoZSBudW1iZXIKKyAgICAgICAgb2YgSlMgLT4gQysrIGp1bXBzIHJlcXVpcmVkIGFuZCBtYWtl cyB0aGUgY29kZSBtb3JlIHNpbWlsYXIgdG8gb3RoZXIKKyAgICAgICAgYmluZGluZ3MgdGhhdCBu ZWVkIGNhY2hpbmcgb2YgYW4gSURMIGFueSB2YWx1ZS4KKworICAgICAgICAqIENNYWtlTGlzdHMu dHh0OgorICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6CisgICAgICAgICogeG1sL1hNTEh0 dHBSZXF1ZXN0LmpzOiBSZW1vdmVkLgorICAgICAgICBSZW1vdmUgWE1MSHR0cFJlcXVlc3QuanMu CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkpTWE1MSHR0cFJlcXVlc3Q6OnJlc3BvbnNlKToKKyAgICAgICAgKFdl YkNvcmU6OkpTWE1MSHR0cFJlcXVlc3Q6OnJldHJpZXZlUmVzcG9uc2UpOiBEZWxldGVkLgorICAg ICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5pZGw6CisgICAgICAgIFJlcGxhY2UgYnVpbHRpbiB3 aXRoIGEgW0NhY2hlZEF0dHJpYnV0ZV0gYW5kIFtDdXN0b21HZXR0ZXJdCisgICAgICAgIGZvciB0 aGUgcmVzcG9uc2UgcHJvcGVydHkuCisKIDIwMTctMDctMjEgIFBlciBBcm5lIFZvbGxhbiAgPHB2 b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJvdW5kLXRyaXBwaW5nIHN0cm9rZS13aWR0aCBz dHlsZXMgdGhyb3VnaCBnZXRDb21wdXRlZFN0eWxlIGNhdXNlIHRoZSB0ZXh0IHRvIGdhaW4gYSBz dHJva2UuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAkocmV2aXNpb24gMjE5NzUwKQorKysgU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTM4NDMsNyArMzg0 Myw2IEBAIHNldChXZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMKICAgICAke1dFQkNPUkVfRElSfS9N b2R1bGVzL3N0cmVhbXMvV3JpdGFibGVTdHJlYW0uanMKICAgICAke1dFQkNPUkVfRElSfS9Nb2R1 bGVzL3N0cmVhbXMvV3JpdGFibGVTdHJlYW1JbnRlcm5hbHMuanMKICAgICAke1dFQkNPUkVfRElS fS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmdJbnRlcm5hbHMuanMKLSAgICAke1dFQkNPUkVfRElS fS94bWwvWE1MSHR0cFJlcXVlc3QuanMKICkKIAogc2V0KEJVSUxUSU5TX0dFTkVSQVRPUl9TQ1JJ UFRTCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UJKHJldmlzaW9uIDIxOTc1MCkK KysrIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UJKHdvcmtpbmcgY29weSkKQEAg LTEzOTgsNyArMTM5OCw2IEBAIFdlYkNvcmVfQlVJTFRJTlNfU09VUkNFUyA9IFwKICAgICAkKFdl YkNvcmUpL01vZHVsZXMvc3RyZWFtcy9Xcml0YWJsZVN0cmVhbS5qcyBcCiAgICAgJChXZWJDb3Jl KS9Nb2R1bGVzL3N0cmVhbXMvV3JpdGFibGVTdHJlYW1JbnRlcm5hbHMuanMgXAogICAgICQoV2Vi Q29yZSkvYmluZGluZ3MvanMvSlNET01CaW5kaW5nSW50ZXJuYWxzLmpzIFwKLSAgICAkKFdlYkNv cmUpL3htbC9YTUxIdHRwUmVxdWVzdC5qcyBcCiAjCiAKIEJVSUxUSU5TX0dFTkVSQVRPUl9TQ1JJ UFRTID0gXApJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRwUmVxdWVz dEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNY TUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAJKHJldmlzaW9uIDIxOTc1MCkKKysrIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01MCwyMiArNTAsMzEgQEAgdm9pZCBKU1hNTEh0dHBSZXF1ZXN0Ojp2aXNpdEFkZGl0aW9u YWxDaAogICAgICAgICB2aXNpdG9yLmFkZE9wYXF1ZVJvb3QocmVzcG9uc2VEb2N1bWVudCk7CiB9 CiAKLUpTVmFsdWUgSlNYTUxIdHRwUmVxdWVzdDo6cmV0cmlldmVSZXNwb25zZShFeGVjU3RhdGUm IHN0YXRlKQorSlNWYWx1ZSBKU1hNTEh0dHBSZXF1ZXN0OjpyZXNwb25zZShFeGVjU3RhdGUmIHN0 YXRlKSBjb25zdAogeworICAgIGF1dG8gY2FjaGVSZXN1bHQgPSBbJl0gKEpTVmFsdWUgdmFsdWUp IC0+IEpTVmFsdWUgeworICAgICAgICBtX3Jlc3BvbnNlLnNldChzdGF0ZS52bSgpLCB0aGlzLCB2 YWx1ZSk7CisgICAgICAgIHJldHVybiB2YWx1ZTsKKyAgICB9OworCisKKyAgICBpZiAod3JhcHBl ZCgpLnJlc3BvbnNlQ2FjaGVJc1ZhbGlkKCkpCisgICAgICAgIHJldHVybiBtX3Jlc3BvbnNlLmdl dCgpOworCiAgICAgYXV0byB0eXBlID0gd3JhcHBlZCgpLnJlc3BvbnNlVHlwZSgpOwogCiAgICAg c3dpdGNoICh0eXBlKSB7CiAgICAgY2FzZSBYTUxIdHRwUmVxdWVzdDo6UmVzcG9uc2VUeXBlOjpF bXB0eVN0cmluZzoKICAgICBjYXNlIFhNTEh0dHBSZXF1ZXN0OjpSZXNwb25zZVR5cGU6OlRleHQ6 IHsKICAgICAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUoc3RhdGUudm0oKSk7 Ci0gICAgICAgIHJldHVybiB0b0pTPElETE51bGxhYmxlPElETFVTVlN0cmluZz4+KHN0YXRlLCBz Y29wZSwgd3JhcHBlZCgpLnJlc3BvbnNlVGV4dCgpKTsKKyAgICAgICAgcmV0dXJuIGNhY2hlUmVz dWx0KHRvSlM8SURMTnVsbGFibGU8SURMVVNWU3RyaW5nPj4oc3RhdGUsIHNjb3BlLCB3cmFwcGVk KCkucmVzcG9uc2VUZXh0KCkpKTsKICAgICB9CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7 CiAgICAgfQogCiAgICAgaWYgKCF3cmFwcGVkKCkuZG9uZVdpdGhvdXRFcnJvcnMoKSkKLSAgICAg ICAgcmV0dXJuIGpzTnVsbCgpOworICAgICAgICByZXR1cm4gY2FjaGVSZXN1bHQoanNOdWxsKCkp OwogCiAgICAgSlNWYWx1ZSB2YWx1ZTsKICAgICBzd2l0Y2ggKHR5cGUpIHsKQEAgLTk3LDcgKzEw Niw3IEBAIEpTVmFsdWUgSlNYTUxIdHRwUmVxdWVzdDo6cmV0cmlldmVSZXNwb24KICAgICB9CiAK ICAgICB3cmFwcGVkKCkuZGlkQ2FjaGVSZXNwb25zZSgpOwotICAgIHJldHVybiB2YWx1ZTsKKyAg ICByZXR1cm4gY2FjaGVSZXN1bHQodmFsdWUpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CkluZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwJKHJldmlzaW9uIDIxOTc1 MCkKKysrIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwJKHdvcmtpbmcgY29w eSkKQEAgLTQ3LDggKzQ3LDYgQEAgZW51bSBYTUxIdHRwUmVxdWVzdFJlc3BvbnNlVHlwZSB7CiAg ICAgSlNDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgSlNHZW5lcmF0ZVRvSlNPYmplY3QsCiAgICAg SlNHZW5lcmF0ZVRvTmF0aXZlT2JqZWN0LAotICAgIFByaXZhdGVJZGVudGlmaWVyLAotICAgIFB1 YmxpY0lkZW50aWZpZXIsCiBdIGludGVyZmFjZSBYTUxIdHRwUmVxdWVzdCA6IFhNTEh0dHBSZXF1 ZXN0RXZlbnRUYXJnZXQgewogICAgIC8vIGV2ZW50IGhhbmRsZXIKICAgICBhdHRyaWJ1dGUgRXZl bnRIYW5kbGVyIG9ucmVhZHlzdGF0ZWNoYW5nZTsKQEAgLTc5LDEzICs3Nyw4IEBAIGVudW0gWE1M SHR0cFJlcXVlc3RSZXNwb25zZVR5cGUgewogICAgIEJ5dGVTdHJpbmcgZ2V0QWxsUmVzcG9uc2VI ZWFkZXJzKCk7CiAgICAgW01heVRocm93RXhjZXB0aW9uXSB2b2lkIG92ZXJyaWRlTWltZVR5cGUo RE9NU3RyaW5nIG1pbWUpOwogICAgIFtTZXR0ZXJNYXlUaHJvd0V4Y2VwdGlvbl0gYXR0cmlidXRl IFhNTEh0dHBSZXF1ZXN0UmVzcG9uc2VUeXBlIHJlc3BvbnNlVHlwZTsKLSAgICBbSlNCdWlsdGlu XSByZWFkb25seSBhdHRyaWJ1dGUgYW55IHJlc3BvbnNlOworICAgIFtDYWNoZWRBdHRyaWJ1dGUs IEN1c3RvbUdldHRlcl0gcmVhZG9ubHkgYXR0cmlidXRlIGFueSByZXNwb25zZTsKICAgICBbR2V0 dGVyTWF5VGhyb3dFeGNlcHRpb25dIHJlYWRvbmx5IGF0dHJpYnV0ZSBVU1ZTdHJpbmcgcmVzcG9u c2VUZXh0OwogICAgIC8vIEZJWE1FOiByZXNwb25zZVhNTCBzaG91bGQgYmUgYW5ub3RhdGVkIHdp dGggW0V4cG9zZWQ9V2luZG93XS4KICAgICBbR2V0dGVyTWF5VGhyb3dFeGNlcHRpb25dIHJlYWRv bmx5IGF0dHJpYnV0ZSBEb2N1bWVudD8gcmVzcG9uc2VYTUw7Ci0KLSAgICAvLyBpbnRlcm5hbHMK LSAgICBbUHJpdmF0ZUlkZW50aWZpZXJdIGJvb2xlYW4gcmVzcG9uc2VDYWNoZUlzVmFsaWQoKTsK LSAgICBbUHJpdmF0ZUlkZW50aWZpZXIsIEN1c3RvbV0gYW55IHJldHJpZXZlUmVzcG9uc2UoKTsK LQogfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuanMJKHJldmlzaW9uIDIx OTc1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5qcwkobm9uZXhpc3Rl bnQpCkBAIC0xLDM5ICswLDAgQEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYgQXBwbGUgSW5j LgotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICogMS4gUmVk aXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmln aHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlz dHJpYnV0aW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5D LiBgYEFTIElTJycgQU5EIEFOWQotICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKLSAqIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgotICogUFVSUE9T RSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IKLSAqIENP TlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFM LCBTUEVDSUFMLAotICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xV RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAotICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCi0gKiBQUk9GSVRTOyBPUiBC VVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCi0g KiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9S IFRPUlQKLSAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4g QU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KLSAqLwotCi1mdW5jdGlvbiBy ZXNwb25zZSgpCi17Ci0gICAgInVzZSBzdHJpY3QiOwotCi0gICAgLy8gRklYTUU6IEFkZCBhIGhl bHBlciByb3V0aW5lIGZvciB0aGF0IGtpbmQgb2YgY2hlY2tzLgotICAgIGlmICghKHRoaXMgaW5z dGFuY2VvZiBAWE1MSHR0cFJlcXVlc3QpKQotICAgICAgICBAdGhyb3dUeXBlRXJyb3IoIlRoZSBY TUxIdHRwUmVxdWVzdC5yZXNwb25zZSBnZXR0ZXIgY2FuIG9ubHkgYmUgdXNlZCBvbiBpbnN0YW5j ZXMgb2YgWE1MSHR0cFJlcXVlc3QiKTsKLQotICAgIGlmIChAWE1MSHR0cFJlcXVlc3QucHJvdG90 eXBlLkByZXNwb25zZUNhY2hlSXNWYWxpZC5AY2FsbCh0aGlzKSkKLSAgICAgICAgcmV0dXJuIHRo aXMuQHJlc3BvbnNlOwotCi0gICAgdGhpcy5AcmVzcG9uc2UgPSBAWE1MSHR0cFJlcXVlc3QucHJv dG90eXBlLkByZXRyaWV2ZVJlc3BvbnNlLkBjYWxsKHRoaXMpOwotICAgIHJldHVybiB0aGlzLkBy ZXNwb25zZTsKLX0K